Re: [Maria-developers] Review request for a fix for MDEV-5506

2014-01-27 Thread Alexander Barkov
Hi Sergei, On 01/26/2014 11:23 PM, Sergei Golubchik wrote: Hi, Alexander! Few questions, see below. === modified file 'mysql-test/t/timezone2.test' --- mysql-test/t/timezone2.test 2013-08-08 08:58:28 + +++ mysql-test/t/timezone2.test 2014-01-23 10:34:46 + @@ -298,5 +298,11 @@

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-27 Thread Sergey Vojtovich
Hi Sergei, I will submit updated patch soon. Comments inline. On Sun, Jan 26, 2014 at 09:40:33PM +0100, Sergei Golubchik wrote: Hi, Sergey! On Jan 22, Sergey Vojtovich wrote: + +# Prepare test +delimiter |; +CREATE PROCEDURE p_install(x INT) +BEGIN + DECLARE CONTINUE

Re: [Maria-developers] Next steps in improving single-threaded performance

2014-01-27 Thread Sergey Vojtovich
Hi Kristian, just out of curiosity: is it possible to find out which functions cause highest amount of icache misses? Can it have anything to do with branch misprediction? Regards, Sergey On Fri, Jan 24, 2014 at 03:51:25PM +0100, Kristian Nielsen wrote: I have been analysing CPU bottlenecks in

Re: [Maria-developers] Next steps in improving single-threaded performance

2014-01-27 Thread Kristian Nielsen
Sergey Vojtovich s...@mariadb.org writes: just out of curiosity: is it possible to find out which functions cause highest amount of icache misses? Yes, see the second post, the profiles marked Icache misses (ICACHE.MISSES), before PGO and Icache misses (ICACHE.MISSES), after PGO. These are

Re: [Maria-developers] MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-27 Thread Sergey Vojtovich
Sergei, On Mon, Jan 27, 2014 at 12:32:19PM +0400, Sergey Vojtovich wrote: ...skip... I'd suggest to remove plugin_mem_root at all. We can store plugin structures on dynamic arrays instead (instead of storing just pointers). Hmm. Interesting. In a separate changeset then. Can you

Re: [Maria-developers] Review request for a fix for MDEV-5506

2014-01-27 Thread Sergei Golubchik
Hi, Alexander! On Jan 27, Alexander Barkov wrote: On 01/26/2014 11:23 PM, Sergei Golubchik wrote: Okay, I understand what you did. But I don't understand why. What was the problem? Why there was a crash? - Item_func_make_set::val_str() returns my_empty_string ... After the fix

Re: [Maria-developers] Rev 4009: MDEV-5345 - Deadlock between mysql_change_user(), SHOW VARIABLES

2014-01-27 Thread Sergei Golubchik
Hi, Sergey! Ok to push. A couple of comments below: On Jan 27, Sergey Vojtovich wrote: revno: 4009 revision-id: s...@mariadb.org-20140127090430-g63lt751yxw9ddud parent: ser...@pisem.net-20131217162654-dw2zlm3td1p12bxl committer: Sergey Vojtovich s...@mariadb.org branch nick: 5.5-mdev5345

Re: [Maria-developers] 5.5.35 Release ?

2014-01-27 Thread Sergei Golubchik
Hi, ImperialNetwork! On Jan 27, ImperialNetwork wrote: Hi, I was wondering if MariaDB 5.5.35 is going to be released today as stated on jira page. I plan some maintenance and i will do it as soon as 5.5.35 will be released. Thank you in advance Alexandru Yes and no. Unless something

Re: [Maria-developers] The Monty Program AB vendor check (rpm)

2014-01-27 Thread Colin Charles
On 25 Jan 2014, at 16:26, Sergei Golubchik s...@mariadb.org wrote: Hi, Oden! On Dec 03, Oden Eriksson wrote: I got assigned to look at the rpm packaging and fixed some stuff there, but got stuck at the Monty Program AB vendor check in support-files/rpm/server- prein.sh when I wanted to

[Maria-developers] MariaDB 5.5.35 Release Prep

2014-01-27 Thread Daniel Bartholomew
All, I've begun the prep work for the MariaDB 5.5.35 release. The draft changelog and release notes are here: - https://mariadb.com/kb/en/mariadb-5535-changelog/ - https://mariadb.com/kb/en/mariadb-5535-release-notes/ Please let me know ASAP if there's anything that needs to be

Re: [Maria-developers] Review request for a fix for MDEV-5506

2014-01-27 Thread Alexander Barkov
Hi Sergei, On 01/27/2014 05:52 PM, Sergei Golubchik wrote: Hi, Alexander! On Jan 27, Alexander Barkov wrote: On 01/26/2014 11:23 PM, Sergei Golubchik wrote: Okay, I understand what you did. But I don't understand why. What was the problem? Why there was a crash? -