[Maria-developers] Unsubscribe

2016-03-30 Thread Abdul Hakeem
___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Re: [Maria-developers] Please review MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring

2016-03-30 Thread Sergei Golubchik
Hi, Alexander! On Mar 30, Alexander Barkov wrote: > commit 4ab28aca964fa646aa55676db813dbed66b83093 > Author: Alexander Barkov > Date: Mon Mar 28 11:05:51 2016 +0400 > > MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring, part 1. > Fixing the debug_sync and

Re: [Maria-developers] MDEV-7773, Aggregate Stored Functions

2016-03-30 Thread Soham Mankad
Thank you Oleksandr Byelkin sir for letting me know that I was working in wrong direction and yes I will pay more attention towards what is written in knowledge base and comments of MDEV-7773 Regards, Soham Mankad ___ Mailing list:

[Maria-developers] Please review MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring

2016-03-30 Thread Alexander Barkov
Hi Sergei, Please review a partial patch for MDEV-6353. It removes my_mbcharlen() in all remaining pieces of the code, except LOAD DATA and SELECT INTO OUTFILE. I'll do LOAD DATA and SELECT INTO OUTFILE in a separate patch. Thanks. commit 4ab28aca964fa646aa55676db813dbed66b83093 Author:

Re: [Maria-developers] MDEV-8360 Clean-up CHARSET_INFO: strnncollsp: diff_if_only_endspace_difference

2016-03-30 Thread Sergei Golubchik
Hi, Alexander! On Mar 25, Alexander Barkov wrote: > Hi Sergei, > > please review a patch for MDEV-8360. Looks good! Ok to push. > Btw, shouldn't we remove: > > #define HA_END_SPACE_ARE_EQUAL 512 > > in ./include/my_base.h ? > > It's not really needed. Yes, please do. > commit

Re: [Maria-developers] MDEV-7773, Aggregate Stored Functions

2016-03-30 Thread Oleksandr Byelkin
Hi, Soham! On 30.03.2016 16:28, Soham Mankad wrote: [skip] Please let me know whether I am working in right direction or not and whether the methods I have mentioned can be used or not to implement the project. Sorry, but you e-mail makes me think that you have not read comments to the

Re: [Maria-developers] MDEV-7773, Aggregate Stored Functions

2016-03-30 Thread Soham Mankad
Respected Sir, I have found some of ways to implement this project using C++, SQL, java, or C. As I had mentioned earlier, I was searching for some of database systems that have this facility or in some way can implement it. The database system that I discovered while learning for this topic is

Re: [Maria-developers] 1e883e9: MDEV-5535: Cannot reopen temporary table

2016-03-30 Thread Sergei Golubchik
Hi, Nirbhay! Here's a review of MDEV-5535. Sorry, it took a while - this was a big patch. The approach is fine, my comments are mostly about details. On Mar 07, Nirbhay Choubey wrote: > diff --git a/mysql-test/r/temp_table.result b/mysql-test/r/temp_table.result > index ee0b3ab..94b02a6 100644

Re: [Maria-developers] [Commits] d40d68f: Convert percent_rank to work with cursors

2016-03-30 Thread Sergey Petrunia
On Mon, Mar 28, 2016 at 10:58:55PM +0300, Vicentiu Ciorbaru wrote: > revision-id: d40d68f23602be9886c1b502fdad9d23bdc9a0fb > (mariadb-10.1.8-187-gd40d68f) > parent(s): bf18dac08fe0ae18975158e786fee097883949d4 > author: Vicențiu Ciorbaru > committer: Vicențiu Ciorbaru > timestamp: 2016-03-28