Re: [Maria-developers] [Merge] lp:~mydb08/maria/maria-5.1 into lp:maria

2010-03-04 Thread Kristian Nielsen
Venu Anuganti myd...@gmail.com writes: Venu Anuganti has proposed merging lp:~mydb08/maria/maria-5.1 into lp:maria. Requested reviews: Maria-captains (maria-captains) Initial SHOW [GLOBAL] TEMPORARY TABLES [FROM/IN db] implementation along with associated Information Schema

[Maria-developers] Help with memory leak in optimiser code

2010-03-09 Thread Kristian Nielsen
Hi Sergey, Thanks for offering to help with the memory leak. Here are the details. Tree is here: lp:~maria-captains/maria/mariadb-5.1-knielsen This tree is the merge with MySQL-5.1.44, including your fix for the uninitialised variable in table elimination. The test case is the following,

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2825)

2010-03-10 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: === modified file 'storage/maria/ma_search.c' --- a/storage/maria/ma_search.c 2009-05-06 12:03:24 + +++ b/storage/maria/ma_search.c 2010-03-09 19:22:24 + + info-int_keypos= info-keyread_buff + (ulonglong) info-int_keypos;

[Maria-developers] Need help with packaging for MariaDB 5.2

2010-03-10 Thread Kristian Nielsen
Hi Arjen, We are starting to think about MariaDB 5.2, in particular of start making (alpha) releases with packages. The current ourdelta packaging scripts for MariaDB 5.1 fail to build 5.2 (seen in Buildbot). I took a look at it, unfortunately it is more complicated than what I can easily fix

Re: [Maria-developers] [Fwd: WorkLog sends out too many mail-copies to maria-developers]

2010-03-13 Thread Kristian Nielsen
Bryan Alsdorf br...@askmonty.org writes: Here is a message from Arjen regarding worklog. I haven't messed with it and I believe you are currently maintaining it. Thoughts? I agree that Worklog mail sending is annoying/broken as it is now. Unfortunately I don't know how to fix it, and I

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-15 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: On Mon, 25 Jan 2010 13:55:44 +0100, Kristian Nielsen kniel...@knielsen-hq.org wrote: I think it would be useful if you explained what the problems are with that interface, in your opinion. This interface does not seem to improve

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-15 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: The global transaction ID is a cornerstone concept of a any replication system which aspires to be pluggable, extensible and go beyond basic master-slave. It is hardly possible to even start designing the rest of the API without first

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-16 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: On Mon, 15 Mar 2010 10:57:41 +0100, Kristian Nielsen kniel...@knielsen-hq.org wrote: What I am wondering at the moment is if the concept of global transaction ID should be a part of the new API, or if it is really an implemtation

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-17 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: On Mon, 15 Mar 2010 12:29:14 +0100, Kristian Nielsen kniel...@knielsen-hq.org wrote: One possible implementation for that can be (UUID, long long) pair. How is this different from (server_id, group_id)? (I'd like to understand

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-18 Thread Kristian Nielsen
Alex, I think this discussion is getting really interesting, and I understand your points much better now, thanks for your many comments! Alex Yurchenko alexey.yurche...@codership.com writes: On Wed, 17 Mar 2010 10:48:50 +0100, Kristian Nielsen kniel...@knielsen-hq.org wrote: So what

Re: [Maria-developers] Creating an external branch of sql-bench

2010-03-18 Thread Kristian Nielsen
Hakan Kuecuekyilmaz ha...@askmonty.org writes: we had some emails from Mark Callaghan, Patrick Galbraith, and Brian Aker asking for an external branch of our sql-bench directory. They want to extend and enhance the sql-bench benchmark suite. After a short phone call with Monty, he told me

Re: [Maria-developers] Creating an external branch of sql-bench

2010-03-23 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: I know how to take an external project and merge it into MariaDB. This uses the merge-into bzr plugin. However, I do not know how to go in the opposite direction, that is take a part od the MariaDB tree and split it out in a separate project

Re: [Maria-developers] MariaDB Release Numbering

2010-03-25 Thread Kristian Nielsen
Colin Charles co...@askmonty.org writes: On 25 Mar 2010, at 02:09, Daniel Bartholomew wrote: If so, my thinking is that the first 5.2 release will be called 5.2.1 and then go up from there. This is the only logical way forward We can then say 5.2.1 branched from MySQL 5.x (for example)

Re: [Maria-developers] MariaDB Release Numbering

2010-03-25 Thread Kristian Nielsen
Adam M. Dutko dutko.a...@gmail.com writes: If we're always pulling from a mysql stable release and porting their features/patches why not always be a minor number above them? Say they release 5.2 ... we've added their patches from 5.2 but also added Ah, but the thing is, MySQL will never (as

Re: [Maria-developers] [Bug 544173] [NEW] Server crash for multi-engine transaction with binlog disabled

2010-03-25 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.com writes: On Mar 25, 2010, at 8:39 AM, Kristian Nielsen wrote: Yes. This is simple enough to do with DBUG. Just insert code that makes each engine fail in their prepare() when the appropriate DBUG flag is set. Another test we need is to have

Re: [Maria-developers] OQGraph?

2010-03-30 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: I wanted to see if there was something I could do to help getting oqgraph-in-mariadb moving again. Ok, I got some progress on this. But I have problems with the packaging, need help to proceed. The OQGraph engine seems to be built as a module

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-03-30 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: On Mon, 29 Mar 2010 00:02:09 +0200, Kristian Nielsen kniel...@knielsen-hq.org wrote: The way I understood the above is that global mutex is taken in InnoDB prepare() solely to synchronize binlog and InnoDB commits. Is that so? If Yes

Re: [Maria-developers] oqgraph in mariadb - integration work

2010-03-31 Thread Kristian Nielsen
Arjen Lentz ar...@openquery.com writes: On 31 Mar 2010, at 05:14, Arjen Lentz wrote: I think we need something like %attr(644, root, root) %{_libdir}/mysql/plugin Ok, I got it sorted out (it wasn't quite like this, but should be ok now). So my preference would be to make it a

Re: [Maria-developers] WL#47: please, review

2010-04-06 Thread Kristian Nielsen
Alexi1952 alexi1...@yandex.ru writes: Hi Sergey, Send you for review: 1. WL#47 branch published on: https://code.launchpad.net/~alexi1952/maria/maria-5.2-wl47 2. Diff file attached. 3. Commit message attached. Hi Alexi, Thanks for sending the patch. I did the code review as Sergey

Re: [Maria-developers] Fix windows compiler errors

2010-04-08 Thread Kristian Nielsen
Bo Thorsen b...@askmonty.org writes: Den 07-04-2010 16:24, Bo Thorsen skrev: When compiling lp:maria on windows, there are a couple of errors. The attached patch fixes those. Part of this patch fixes https://bugs.launchpad.net/maria/+bug/550974, and it's done the way Sanja suggested. Can

[Maria-developers] Getting a stable Windows host into Buildbot

2010-04-15 Thread Kristian Nielsen
[Cc:ing maria-developers@, in case anyone can help with suggestions or is just generally interested. For background see http://askmonty.org/wiki/BuildBot::package] Hi Bo, Just a quick summary of our discussions about setting up a Windows Buildbot host in Buildbot using KVM to get things running

Re: [Maria-developers] --with-embedded-privilege-control

2010-04-19 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: I added --with-embedded-privilege-control to the -fulltest builds to avoid new occurences of MBug#563187 in the future. Hm, now we get lots of crashes in Buildbot. Any ideas? - Kristian. https://buildbot.askmonty.org/buildbot/builders

Re: [Maria-developers] Review request: Remove a bunch of Windows warnings

2010-04-20 Thread Kristian Nielsen
Bo Thorsen b...@askmonty.org writes: This patch removes most of the Windows build warnings on Windows Vista 32 bit with Visual Studio 2005. I have only built with debug info using the configuration in win\configure-mariadb.sh. Ok to push. Somehow your patch got into my email in UCS2

[Maria-developers] ORDER BY bug for TEXT in federatedx

2010-04-28 Thread Kristian Nielsen
Hi Patrick Please check this mysql bug: http://bugs.mysql.com/bug.php?id=32426 This bug is also in FederatedX (I noticed when I merged the test case from MySQL 5.1.46 :-) I created a MariaDB bug: https://bugs.launchpad.net/maria/+bug/571200 Can you look into this? For now I commented

[Maria-developers] PBXT test failure in MySQL 5.1.46 merge

2010-04-28 Thread Kristian Nielsen
Hi Paul, I'm merging MySQL 5.1.46 into MariaDB. But I hit a test failure in PBXT, see below. It is wrong result from a SELECT. Interestingly, the same SELECT in the main test suite seems to work correctly. The code is in lp:~maria-captains/maria/5.1-release Can you maybe take a look, in

Re: [Maria-developers] PBXT test failure in MySQL 5.1.46 merge

2010-04-30 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.org writes: I ran the test below using both InnoDB and PBXT, using MariaDB (lp:~maria-captains/maria/5.1-release) and MySQL 5.1.46. I get the same result from both engines (and both servers). The select select t1.id,t2.id from t2 left join t1 on

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-04-30 Thread Kristian Nielsen
MARK CALLAGHAN mdcal...@gmail.com writes: As a further optimization, I want a callback that is called after the binlog entries are written for a transaction and before the wait for group commit on the fsync is done. That callback will be used to release row locks (optionally) held by the

Re: [Maria-developers] PBXT test failure in MySQL 5.1.46 merge

2010-04-30 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: Paul McCullagh paul.mccull...@primebase.org writes: I ran the test below using both InnoDB and PBXT, using MariaDB (lp:~maria-captains/maria/5.1-release) and MySQL 5.1.46. I get the same result from both engines (and both servers

[Maria-developers] Please check optimiser regression in MySQL 5.1.46

2010-04-30 Thread Kristian Nielsen
Hi Igor, Timour, Sergey, Can one of you please check this patch from MySQL 5.1.46? It is a commit to fix http://bugs.mysql.com/bug.php?id=51494 This patch introduces a regression: http://bugs.mysql.com/bug.php?id=53334 If I revert the patch, the regression disappears. And interestingly,

Re: [Maria-developers] Please check optimiser regression in MySQL 5.1.46

2010-05-03 Thread Kristian Nielsen
Igor Babaev i...@askmonty.org writes: Below you'll find a patch for bug #53334 (against mysql-5.1.46). Thanks! I pushed it into 5.1-release (to be included in upcoming MariaDB 5.1.46). I investigated other latest fixes pushed by Sergey Glukhov. The fix for bugs ##51242/52336 looked

Re: [Maria-developers] comm...@mariadb.org list

2010-05-05 Thread Kristian Nielsen
Daniel Bartholomew db...@askmonty.org writes: Maria Captains: After subscribing, please change the destination email address you have configured for the bzr email plugin in ~/.bazaar/bazaar.conf (or ~/.bazaar/locations.conf) to comm...@mariadb.org. I changed the address in our main

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/pbxt-1.0.11 into lp:maria

2010-05-10 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.org writes: All tests in the PBXT suite run through on Mac and Linux, except for one error under Linux, which is a bit weird (see below). -- pbxt.select_safe [ fail ] Test ended at 2010-05-06 17:19:13

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/pbxt-1.0.11 into lp:maria

2010-05-14 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.org writes: Thanks for clearing this up. The problem is certainly as you say: it depends on the speed of a background thread. From this point of view the test does not make all that much sense for PBXT which returns inconsistent row count estimates.

Re: [Maria-developers] Creating .bzr tree for download

2010-05-17 Thread Kristian Nielsen
Michael Widenius michael.widen...@gmail.com writes: Daniel, can you create a 'initial' repository of MariaDB 5.2 and make a .tar.gz file of it available on our download page. We need this ASAP because we get complains from developers that they can't use bzr to create download MariaDB source

Re: [Maria-developers] MySQL 5.1.46 diff of sql/sql_select.cc for review

2010-05-19 Thread Kristian Nielsen
Igor Babaev i...@askmonty.org writes: Here's my review. Thanks a lot for your help! I checked through all your points (few detailed comments below), all your proposed solutions seem reasonable to me. In summary, we should as you suggest: - Rework patches for bugs 39022, 48483, and 49324 as

Re: [Maria-developers] Question about License...

2010-06-08 Thread Kristian Nielsen
Mateusz Matan mateuszma...@gmail.com writes: We designed a custom Storage Engine (CLDB) for MySQL/MariaDB which now pass all premature tests. I wonder, how can we solve license problem... We would not share our sources, but we will just use shared library (*.so)... Which licenses

[Maria-developers] Fixes for an issue with my_atomic

2010-06-09 Thread Kristian Nielsen
Hi, I had a problem with my group commit patch, and tracked it down to a problem in my_atomic. The issue is that my_atomic_cas*(val, cmp, new) accesses *cmp after successful CAS operation (in one place reading it, in another place writing it). Here is the fix: Index:

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-06-21 Thread Kristian Nielsen
Alex Yurchenko alexey.yurche...@codership.com writes: On Wed, 19 May 2010 15:05:55 +0200, Sergei Golubchik s...@askmonty.org wrote: Yes, it only describes how the data get to the redundancy service, but not what happens there. I intentionally kept the details of redundancy out, to be able

[Maria-developers] SphinxSE pushed into 5.2

2010-07-09 Thread Kristian Nielsen
Hi, I have pushed SphinxSE into MariaDB 5.2. It should be available in the upcoming MariaDB 5.2.2, which is currently planned within a few weeks. For now, only the code for the storage engine is pushed, not for the mysql-test-run.pl stuff. Sergei Golubchik wanted to modify mysql-test-run.pl

Re: [Maria-developers] Repeated Error in accept: Bad file descriptor

2010-07-14 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: Time == Time Less timelessn...@gmail.com writes: Time Just thought I'd try out PBXT. I created a database instance with 10 Time databases, inside each 100 tables. They were MyISAM tables. Then I did an Time alter table name engine=pbxt across all

Re: [Maria-developers] Repeated Error in accept: Bad file descriptor

2010-07-14 Thread Kristian Nielsen
Time Less timelessn...@gmail.com writes: The problem is that MySQL/MariaDB is using select() to accept new connections. But select() has a hard-coded limit of 1024 on the max number of open files it can support. It seems PBXT uses an open file descriptor per table, Not two per table? It

Re: [Maria-developers] Repeated Error in accept: Bad file descriptor

2010-07-15 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: I didn't know that PBXT would open up all files at startup. If that's InnoDB actually does something similar during recovery (that is how the Bug#48929 was originally reported by Peter). Paul, can you verify the above is the case for PBXT (ie, that

Re: [Maria-developers] wl#127 - changes to mtr for sphinx

2010-08-03 Thread Kristian Nielsen
Sergei Golubchik ser...@pisem.net writes: Kristian, I've done the changes - would you mind to review the patch ? Sure! I will review after finishing with XtraDB merge. the first one fixes ndb. as ndb is hacked in mtr and is all over the place, I could not change mtr without touching ndb

Re: [Maria-developers] [Commits] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2877)

2010-08-04 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: + find_innodb_plugin; +if (find_innodb_plugin) Why use such wierd syntax for calling a function? Why not the normal find_innodb_plugin() ? - Kristian. ___ Mailing list:

Re: [Maria-developers] [Commits] Rev 2835: added a sphinxse test suite in http://bazaar.launchpad.net/~maria-captains/maria/5.2/

2010-08-06 Thread Kristian Nielsen
s...@askmonty.org writes: === added file 'mysql-test/suite/sphinx/sphinx.test' --- a/mysql-test/suite/sphinx/sphinx.test 1970-01-01 00:00:00 + +++ b/mysql-test/suite/sphinx/sphinx.test 2010-08-06 13:11:37 + @@ -0,0 +1,30 @@ +if (`SELECT $HAVE_SPHINX .0009.0009`) { +

[Maria-developers] Federated vs. FederatedX in Windows

2010-08-09 Thread Kristian Nielsen
Hi Bo, I noticed some test failures in Federated in our Windows Build, which made me realise that we are building Federated[X] incorrectly: http://buildbot.askmonty.org/buildbot/builders/kvm-zip-winxp-x86/builds/104/steps/compile/logs/stdio build FEDERATED as static library build

Re: [Maria-developers] [Commits] Rev 2898: generalization of mtr to support suite.pm extensions: in http://bazaar.launchpad.net/~maria-captains/maria/5.1/

2010-08-11 Thread Kristian Nielsen
s...@askmonty.org writes: Hi, Kristian Would you like to look once again at the mtr patch ? Sure! I've removed auto-creation of my.cnf options by mere mentioning, as you found that confusing. Instead I added explicit group OPT, so now sphinx my.cnf would do [searchd]

Re: [Maria-developers] Architecture review of MWL#116 Efficient group commit for binary log

2010-09-03 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: Hi, Kristian! Let's start from the WL description: Thanks for your detailed comments! While currently there is no server guarantee to get same commit order in engines an binlog (except for the InnoDB prepare_commit_mutex hack), there are several

Re: [Maria-developers] Architecture review of MWL#116 Efficient group commit for binary log

2010-09-06 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: Hi, Kristian! Hot and cool, yes, I've used (and coded) them myself :) But I only use them where I believe they actually improve concurrency, and I think this one is not the case. Very true. So let us forget about the lock-free stuff. I'll remove

Re: [Maria-developers] Architecture review of MWL#116 Efficient group commit for binary log

2010-09-08 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: So now the algorithm is something like this: Where in this algorithm you call ht-commit_ordered() ? Oops, I forgot, sorry! It should be at the start of for thd2 in queue (before the wakeup). thd-ready= false lock(LOCK_prepare_ordered)

Re: [Maria-developers] ./configure report

2010-09-15 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: For a while, I had a small personal gripe that it is not easy to see what plugins are configured to be built and how. That is, I know where Yes, agree! I've extended it from [...] to include all plugins in alphabetical order (and moved

Re: [Maria-developers] Live Schema Changes

2010-09-23 Thread Kristian Nielsen
Zardosht Kasheff zardo...@gmail.com writes: I have spent some of my spare time looking into this. It turns out that MySQL Cluster already has this ability. They have the following handler functions listed below. I spent a weekend trying to port MySQL Cluster's alter table function

Re: [Maria-developers] Live Schema Changes

2010-09-24 Thread Kristian Nielsen
Zardosht Kasheff zardo...@gmail.com writes: My main interest is getting a feature that many think is very useful properly implemented and integrated into 5.1. This is a feature that was enthusiastically brought up during the 2010 storage engine summit. Also, I think Mark's online schema

[Maria-developers] Implementing new group commit API in PBXT?

2010-09-29 Thread Kristian Nielsen
Hi Paul! I want to ask your opinion about implementing in PBXT an extension to the storage engine API that I am working on. There are lots of details in http://askmonty.org/worklog/Server-BackLog/?tid=116 (and even more details in other places), but I thought you would appreciate the short

Re: [Maria-developers] request for feedback on live schema changes patch

2010-10-01 Thread Kristian Nielsen
Zardosht Kasheff zardo...@gmail.com writes: That being said, I would love to hear feedback on this patch, and would also like to understand what (if anything) can be done to get this into MariaDB 5.1. I realize that may not be possible, but if it is, I would like to try. I didn't look at the

Re: [Maria-developers] Implementing new group commit API in PBXT?

2010-10-04 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.org writes: Hi Kristian, Hi Paul, thanks for your detailed answer! I was a bit difficult to explain, so please ask if anything is not clear. It seems pretty clear from your explanation. I will take a look into the sources, and will let you know if I

Re: [Maria-developers] [Commits] Rev 2851: MWL#132: Transaction coordinator plugin. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2010-10-04 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: knielsen +++ b/sql/log.cc2010-10-04 10:48:08 + knielsen @@ -6531,6 +6531,39 @@ err1: knielsen--tc-heuristic-recover={commit|rollback}); knielsenreturn 1; knielsen } knielsen + knielsen +static TC_LOG * knielsen

Re: [Maria-developers] Implementing new group commit API in PBXT?

2010-10-05 Thread Kristian Nielsen
Paul McCullagh paul.mccull...@primebase.org writes: The easiest way to do this would be to add a parameter to xn_end_xact() that indicates that the log should not be written or flushed. Ok, I gave it a shot, but I had some problems due to not knowing the PBXT code sufficiently ... In

[Maria-developers] Transactional INFORMATION_SCHEMA / status variables?

2010-10-06 Thread Kristian Nielsen
Would it make sense to have transactional behaviour for status variables, and/or information_schema tables? Or does this break the code and/or user expectations too much? The motivation is to follow up on MWL#116, group commit, which introduces consistent commit order between storage engines and

[Maria-developers] Why do we need fsync() in commit() in internal two-phase commit?

2010-10-26 Thread Kristian Nielsen
Currently, when an InnoDB/XtraDB transaction is committed with the binlog enabled, we do three fsync()'s: 1. Inside prepare() in InnoDB 2. When writing to the binlog 3. Inside commit() in InnoDB The fsync()s are done when --innodb-flush-log-at-trx-commit=1 and sync_binlog=1; these settings are

Re: [Maria-developers] gcc -Wframe-larger-than

2010-11-01 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: Just noticed that gcc has a warning option -Wframe-larger-than=LEN that makes gcc to warn about functions with stack frames larger than LEN. Considering a recent issue when we had a 130K structure on the stack (which did overflow the stack in some

[Maria-developers] MWL#116: Efficient group commit, ready for code review

2010-11-01 Thread Kristian Nielsen
Hi Serg, Please find attached the patch for code review of MWL#116: Efficient group commit. I went through all your comments in the architecture review and updated the worklog description and the code accordingly. I hope I got everything, otherwise I hope you have the patience to point out any

[Maria-developers] MWL#132: TC plugin, patch for (possible) code review

2010-11-01 Thread Kristian Nielsen
Hi Serg, And here is the patch for MWL#132, TC plugin. The patch is fairly short, as most of the real code changes are included in MWL#116. This patch is mainly about introducing a new plugin interface for transaction coordinators, and making the three existing TCs in log.cc into built-in

Re: [Maria-developers] [Commits] Rev 2971: MBug#643463: Slow XtraDB shutdown: Fix more sleeps delaying shutdown. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2010-11-10 Thread Kristian Nielsen
Hi Codership, Can you do a review of this patch for InnoDB (XtraDB)? It is https://bugs.launchpad.net/percona-server/+bug/643463, it fixes a problem that a number of threads in the InnoDB code used sleep() for several seconds, which unnecessarily delays shutdown (this is especially annoying when

Re: [Maria-developers] [Commits] Rev 89: MBug#674413: better fix following review: clear sql_mode rather than add every column explicitly. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2010-11-21 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: Hi, knielsen! On Nov 20, kniel...@knielsen-hq.org wrote: At http://bazaar.launchpad.net/~maria-captains/maria/5.1 revno: 89 revision-id:

[Maria-developers] Ready to release MariaDB 5.1.53

2010-12-06 Thread Kristian Nielsen
Daniel, We are now ready to release MariaDB 5.1.53 and MariaDB 5.2.4. For 5.1.53, the tag is mariadb-5.1.53 and the tree is: lp:~maria-captains/maria/5.1-release Packages should be downloaded from here: http://knielsen-hq.org/archive/pack/5.1-release/build-660/ For 5.2.4, the tag is

Re: [Maria-developers] a mysql-test-run problem

2010-12-07 Thread Kristian Nielsen
Vladimir Kolesnikov vladi...@primebase.org writes: I'm trying to reproduce this bug in PBXT: https://bugs.launchpad.net/pbxt/+bug/668491 Great! I use sources from mariadb-5.1.42.tar.gz That's quite an old version, you should use the latest. I got some problems trying to run maria's test

Re: [Maria-developers] problem with partitioning and our storage engine in 5.2

2010-12-09 Thread Kristian Nielsen
Philip Stoev pst...@askmonty.org writes: This code was added as a fix for MySQL bug #38005 and then removed as a fix for bug #46639 Yes. Turns out that the removal part of Bug#46639 was lost in MariaDB in this merge: revno: 2732 [merge] revision-id:

Re: [Maria-developers] Volunteer my machine for buildbot and database with test results

2010-12-10 Thread Kristian Nielsen
Haidong Ji haidong...@gmail.com writes: I am back from my trip now. I can offer my Fedora 13 32-bit and Windows 7 Enterprise 32-bit up for build purposes. Like mentioned before, I've got Python buildbot installed on Fedora. I can install and setup buildbot on my Windows machine as well.

Re: [Maria-developers] [Commits] Rev 2999: Speed up `mtr --parallel=lots` by scheduling some slow tests earlier. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2011-01-03 Thread Kristian Nielsen
Sergei Golubchik s...@askmonty.org writes: Hm. Why do you prefer to add a dummy include file to every long test, instead of using a separate file, like disabled.def ? I thought it was simpler to re-use an existing mechanism. The mtr_cases.pm already parses out lots of info about test cases in

Re: [Maria-developers] Restarting cooperation of Percona and Monty Programming AB

2011-01-04 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: Kristian == Kristian Nielsen kniel...@knielsen-hq.org writes: cut Kristian Anyway, I fixed the patch, added test cases, and merged into MariaDB. It is Kristian pushed here: Kristian lp:~knielsen/maria/5.2-percona

Re: [Maria-developers] Restarting cooperation of Percona and Monty Programming AB

2011-01-06 Thread Kristian Nielsen
. Best regards, Oleg 2011/1/4 Kristian Nielsen kniel...@knielsen-hq.org: Michael Widenius mo...@askmonty.org writes: Kristian == Kristian Nielsen kniel...@knielsen-hq.org writes: cut Kristian Anyway, I fixed the patch, added test cases, and merged into MariaDB. It is Kristian pushed here

Re: [Maria-developers] [Commits] Rev 2905: Merge Percona patch MWL#47 into mariadb 5.2-percona. in http://bazaar.launchpad.net/~maria-captains/maria/5.2

2011-01-12 Thread Kristian Nielsen
kniel...@knielsen-hq.org writes: message: Merge Percona patch MWL#47 into mariadb 5.2-percona. This patch adds options to annotate the binlog (and the mysqlbinlog output) with the original SQL query for queries that are logged using row-based replication. Serg raised the very

[Maria-developers] Buildbot will be down start of next week due to upgrade

2011-01-21 Thread Kristian Nielsen
Next week, on Monday, I plan to take down Buildbot and start the upgrade process to version 0.8.x. This is a somewhat major upgrade, as Buildbot 0.8 switches to storing all its state and history in a MySQL (well MariaDB probably ;-) database rather than gazilions of Python-encoded files.

Re: [Maria-developers] Buildbot will be down start of next week due to upgrade

2011-01-21 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: Next week, on Monday, I plan to take down Buildbot and start the upgrade process to version 0.8.x. BTW, there should be no actions needed for the build slaves, the can remain on whatever version they were before, and they should re-connect

Re: [Maria-developers] Buildbot will be down start of next week due to upgrade

2011-01-24 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: Next week, on Monday, I plan to take down Buildbot and start the upgrade process to version 0.8.x. I finished the upgrade, and Buildbot should be back up on 0.8.3! There were a number of issues during the install, but I managed to fix

Re: [Maria-developers] replication improvements going on here and there

2011-01-28 Thread Kristian Nielsen
Rasmus Johansson ras...@montyprogram.com writes: I would need your help to understand the different replication topics that are very active now: - The replication work that you have been doing As far as implementation goes, it is these four worklogs, which are in code review and available

Re: [Maria-developers] Using tilde in the version for debs?

2011-02-20 Thread Kristian Nielsen
Henrik Ingo henrik.i...@avoinelama.fi writes: Hi Kristian Hi Henrik, nice to hear from you again! But just as a quickie, I noticed you are changing the versioning of debs to include the distribution codename (lucid, maverick, etc..): Right. I basically copied this from the bzr packages on

Re: [Maria-developers] Fwd: [Commits] Rev 2921: Added build script which works with ICC v12.0 in file:///home/hakan/work/monty_program/maria-5.2/

2011-02-24 Thread Kristian Nielsen
Hakan Kuecuekyilmaz ha...@askmonty.org writes: Kristian, can you please review the new build script, so that I can push it into our 5.2 tree. After we cleared the license details with Ok to push. - Kristian. Begin forwarded message: From: Hakan Kuecuekyilmaz

Re: [Maria-developers] Buildbot Update

2011-03-01 Thread Kristian Nielsen
Adam M. Dutko dutko.a...@gmail.com writes: All of the buildbots I run should be back online. Thanks! Unfortunately, it looks like the buildslave 'adutko-centos5-amd64' is out of space: File /usr/lib/python2.4/site-packages/buildbot/slave/commands.py, line 1159, in _writeData

Re: [Maria-developers] Release of MariaDB 5.1.55

2011-03-01 Thread Kristian Nielsen
Daniel Bartholomew db...@montyprogram.com writes: All: If you have a moment, please check over the above pages to see if there are any mistakes or omissions and let me know (or jump in and fix if you have editing rights). Looks fine to me. I added a link to the release notes for Percona

[Maria-developers] dgcov.pl

2011-03-02 Thread Kristian Nielsen
Hi Serg, I pushed to lp:mariadb-tools a fix for the negative numbers output by gcov which causes dgcov.pl to break. (Sergey Petrunya needed it). It just strips the leading '-' from negative numbers, so it does not help to understand what the problem is, I would still like to figure that out...

[Maria-developers] MariaDB 5.2.5 packages ready for release

2011-03-02 Thread Kristian Nielsen
From: Kristian Nielsen kniel...@knielsen-hq.org Subject: Release of MariaDB 5.1.55 To: Daniel Bartholomew db...@askmonty.org Cc: Internal Dev List d...@askmonty.org Date: Mon, 28 Feb 2011 12:40:13 +0100 Hi Daniel, The packages for release of MariaDB 5.2.5 are ready. The main changes I know

Re: [Maria-developers] RedHat Buildslaves

2011-03-07 Thread Kristian Nielsen
Daniel Bartholomew db...@montyprogram.com writes: Daniel I'm creating the build-slaves based on the KVM setup Daniel instructions you have here: Daniel Daniel http://askmonty.org/wiki/BuildBot:vm-setup#Centos_5_i386 I now have a rhel6-amd64 vm setup on terrier with base, serial, build, and

[Maria-developers] Report from OpenSourceDays2011

2011-03-08 Thread Kristian Nielsen
Hi, On Saturday, March 5, I gave a talk at the OpenSourceDays 2011 conference in Copenhagen, Denmark: http://opensourcedays.org/ My talk was titled Latest news from the MariaDB (and MySQL) community. I put the slides from the talk up on my web server here:

[Maria-developers] Testing group commit with XtraBackup

2011-03-09 Thread Kristian Nielsen
Hi Philip, I thought of another test of group commit that ought to be done (not sure why I didn't think to mention this earlier, sorry about that). It's not urgent, just something for the list. The test is basically the same you already did for non-blocking `mysqldump --master-data

Re: [Maria-developers] request for feedback on live schema changes patch

2011-03-18 Thread Kristian Nielsen
Zardosht Kasheff zardo...@gmail.com writes: I am hoping to resurrect this discussion. Has there been any discussion on implementing the feature of allowing handlers to do fast schema changes in MariaDB (on any version)? I have put this patch on MySQL 5.1, and I think I have it working. I

Re: [Maria-developers] [All] How are we going to handle incompatible changes in MariaDB?

2011-03-18 Thread Kristian Nielsen
Philip Stoev pst...@askmonty.org writes: We should discuss how do we handle new developments in MariaDB that cause our behavior to diverge from the one in MySQL. Since we claim to be a Yes, agree. Thank you for bringing it up! Note that this is a general MariaDB discussion, not a Monty

[Maria-developers] mysql_upgrade issue for libmysqld and amarok

2011-03-18 Thread Kristian Nielsen
This is a follow up on a discussion I had with eean on Freenode IRC #maria. The issue is how to upgrade libmysqd from MySQL version 5.1 to version 5.5 (or more generally any major version upgrade), in particular as relates to Amarok's use of libmysqld. The procedure for upgrading a normal MySQL

Re: [Maria-developers] mysql_upgrade issue for libmysqld and amarok

2011-03-18 Thread Kristian Nielsen
Ian Monroe i...@monroe.nu writes: On Fri, Mar 18, 2011 at 05:44, Kristian Nielsen kniel...@knielsen-hq.org wrote: The issue is how to upgrade libmysqd from MySQL version 5.1 to version 5.5 (or more generally any major version upgrade), in particular as relates to Amarok's use of libmysqld

[Maria-developers] Writeup of how to run my group commit benchmark

2011-03-28 Thread Kristian Nielsen
Hi, For anyone interested in trying to redo my group commit benchmarks on more interesting hardware than what I have available, here is a writeup of the steps needed to run it. The benchmarks are described here: http://kristiannielsen.livejournal.com/15739.html

Re: [Maria-developers] MWL#116: Efficient group commit, ready for code review

2011-04-04 Thread Kristian Nielsen
Hi Monty, Thanks for your review! I generally followed your suggestions, except for this: + if (entry-begin_event-write(log_file)) +return ER_ERROR_ON_WRITE; + + DBUG_EXECUTE_IF(crash_before_writing_xid, + { +if ((write_cache(cache))) +

Re: [Maria-developers] [Commits] Rev 2864: MWL#136: Cross-engine consistency for START TRANSACTION WITH CONSISTENT SNAPSHOT in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2011-04-04 Thread Kristian Nielsen
Hi Monty! Thanks for review of MWL#136. I fixed the patch according to all your suggestions! - Kristian. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe :

[Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Kristian Nielsen
Hi Serg, As promised, here is a summary of the changes to the storage engine API that I made as part of group commit. Two new handlerton methods are added: void (*prepare_ordered)(handlerton *hton, THD *thd, bool all); void (*commit_ordered)(handlerton *hton, THD *thd, bool all);

Re: [Maria-developers] dist-hook in top-level Makefile.am

2011-04-06 Thread Kristian Nielsen
Vladislav Vaintroub w...@montyprogram.com writes: Kristian, now that Windows builds in 5.2+ are self-sufficient and can produce different packages from bzr, do you see any reason to keep this hook in the top-level Makefile.am? If not, I can remove, or you can remove it if you prefer. Will

Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Kristian Nielsen
MARK CALLAGHAN mdcal...@gmail.com writes: Is commit_ordered called before or after the transaction's XID event has been written to the binlog? after it has been forced (fsync) to the binlog? It is called just after XID event has been written (and fsync()ed in case of sync_binlog=1) to

Re: [Maria-developers] [Maria-discuss] MariaDB 5.6

2011-04-09 Thread Kristian Nielsen
Peter Laursen peter_laur...@webyog.com writes: I noticed this on planet.mysql: http://kb.askmonty.org/v/plans-for-56 I *again* strongly want to discourage a major version number identical with a MySQL/Oracle release. MySQL plans a 5.6 too and I believe that there is already a source-tree

[Maria-developers] PBXT test failures after your patch for lp:732124

2011-04-12 Thread Kristian Nielsen
Hi Monty, After you pushed the patch for lp:732124, test failures appeared in Buildbot for test case pbxt.union. Most were just that the pbxt union.result file needed same update as for main.union. But there was one more issue: create table t1 (a int); insert into t1 values (1),(2),(3);

Re: [Maria-developers] [Maria-discuss] MariaDB 5.6

2011-04-12 Thread Kristian Nielsen
Adam M. Dutko dutko.a...@gmail.com writes: Does the following item under the Performance section indicate optimizations for AMD chips are not being added? Better multi CPU performance above 16 cores (Work with Intel) No (very unlikely). The AMD and Intel x86_64 chips are quite similar,

[Maria-developers] MariaDB/MySQL error code issue

2011-04-18 Thread Kristian Nielsen
Hi, For merging MySQL into MariaDB, we need to work out what to do about error code. The problem occurs as (different) new error messages are added in both MySQL and MariaDB. When we then merge from MySQL, we get conflicts between the error numbers. If we do not handle this somehow, it means

<    1   2   3   4   5   6   7   8   >