Re: [matplotlib-devel] picking bug in SVN with old masked array

2008-02-19 Thread Eric Firing
John Hunter wrote: > On Feb 19, 2008 5:45 PM, Paul Kienzle <[EMAIL PROTECTED]> wrote: > >> I didn't provide any masked array checks in any of the contains methods >> that I wrote. Do any of these need to be fixed? > > They do need to be fixed, but this is not a high priority item. Let's > wait

Re: [matplotlib-devel] picking bug in SVN with old masked array

2008-02-19 Thread John Hunter
On Feb 19, 2008 5:45 PM, Paul Kienzle <[EMAIL PROTECTED]> wrote: > I didn't provide any masked array checks in any of the contains methods > that I wrote. Do any of these need to be fixed? They do need to be fixed, but this is not a high priority item. Let's wait until the new maskedarray code

Re: [matplotlib-devel] picking bug in SVN with old masked array

2008-02-19 Thread Paul Kienzle
On Tue, Feb 19, 2008 at 10:55:14AM -0500, Michael Droettboom wrote: > 2) The picking code for a line assumes non-masked arrays. Since the > Line class already keeps around a "compressed" version of the data for > drawing, it is easy enough to use that instead of the raw data. I didn't provide a

Re: [matplotlib-devel] picking bug in SVN with old masked array

2008-02-19 Thread Michael Droettboom
Thanks for finding this. I just committed a slightly less band-aid-like fix in SVN r4979. There were really two bugs here: 1) A masked array is created for a line plot whenever only y values are provided, even if there are no masked values in the data. That would only be a performance bug if