Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-14 Thread Eric Firing
On 08/13/2010 12:30 PM, Benjamin Root wrote: > [...] > > Notice that both stroke and fill are checking for alpha != 0.0. > > > Yeah, well, try out my attached script. Then view the two files. > Something is wrong... I think I have that fixed now, along with a temporary fix for the original "

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-13 Thread Eric Firing
On 08/13/2010 12:30 PM, Benjamin Root wrote: > > > On Fri, Aug 13, 2010 at 4:43 PM, Eric Firing > wrote: > > On 08/13/2010 10:35 AM, Benjamin Root wrote: > > On Thu, Aug 12, 2010 at 4:46 PM, Eric Firing > >

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-13 Thread Benjamin Root
On Fri, Aug 13, 2010 at 4:43 PM, Eric Firing wrote: > On 08/13/2010 10:35 AM, Benjamin Root wrote: > > On Thu, Aug 12, 2010 at 4:46 PM, Eric Firing > > wrote: > > > > On 08/12/2010 10:40 AM, Benjamin Root wrote: > > [...] > > > > > > > > >>> mcolor.co

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-13 Thread Eric Firing
On 08/13/2010 10:35 AM, Benjamin Root wrote: > On Thu, Aug 12, 2010 at 4:46 PM, Eric Firing > wrote: > > On 08/12/2010 10:40 AM, Benjamin Root wrote: > [...] > > > > > > >>> mcolor.colorConvertor.to_rgba_array('none') > > > array([], shape=(0, 4),

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-13 Thread Benjamin Root
On Thu, Aug 12, 2010 at 4:46 PM, Eric Firing wrote: > On 08/12/2010 10:40 AM, Benjamin Root wrote: > [...] > > > > > > >>> mcolor.colorConvertor.to_rgba_array('none') > > > array([], shape=(0, 4), dtype=float64) > > > > > > >>> mcolor.colorConvertor.to_rgba_array(['none']

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Eric Firing
On 08/12/2010 10:40 AM, Benjamin Root wrote: [...] > > > > >>> mcolor.colorConvertor.to_rgba_array('none') > > array([], shape=(0, 4), dtype=float64) > > > > >>> mcolor.colorConvertor.to_rgba_array(['none']) > > array([[ 0., 0., 0., 0.]]) > > > > >>> mcolo

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Benjamin Root
On Thu, Aug 12, 2010 at 12:37 PM, Eric Firing wrote: > On 08/12/2010 06:09 AM, Benjamin Root wrote: > > On Thu, Aug 12, 2010 at 10:13 AM, Ben North > > wrote: > > > > Ben Root: > > >Ben North: > > >> Same kind of thing with > > >> the kwarg 'color

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Eric Firing
On 08/12/2010 06:09 AM, Benjamin Root wrote: > On Thu, Aug 12, 2010 at 10:13 AM, Ben North > wrote: > > Ben Root: > >Ben North: > >> Same kind of thing with > >> the kwarg 'color' instead of 'edgecolor', which is also fixed in my > >> second re

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Benjamin Root
On Thu, Aug 12, 2010 at 10:13 AM, Ben North wrote: > Ben Root: > >Ben North: > >> Same kind of thing with > >> the kwarg 'color' instead of 'edgecolor', which is also fixed in my > >> second recent email. > > > > Looking through the code for bar(), I see the same thing occurs for the > > 'color'

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Ben North
Ben Root: >Ben North: >> Same kind of thing with >> the kwarg 'color' instead of 'edgecolor', which is also fixed in my >> second recent email. > > Looking through the code for bar(), I see the same thing occurs for the > 'color' keyword argument. So I guess we should fix that as well. Yes, the s

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-12 Thread Benjamin Root
On Mon, Aug 9, 2010 at 10:02 AM, Ben North wrote: > >> I tried to use "edgecolor = 'none'" in a call to bar(), hoping to get no > >> border to the bars, but instead got no bars at all. > > > > Just to note, the documentation does specify a difference between None > and > > 'none'. None means to

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-09 Thread Ben North
>> I tried to use "edgecolor = 'none'" in a call to bar(), hoping to get no >> border to the bars, but instead got no bars at all. > > Just to note, the documentation does specify a difference between None and > 'none'. None means to use the rcdefaults and 'none' means no color at all. > Is bar()

Re: [matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-09 Thread Benjamin Root
On Mon, Aug 9, 2010 at 3:28 AM, Ben North wrote: > Hi, > > I tried to use "edgecolor = 'none'" in a call to bar(), hoping to get no > border to the bars, but instead got no bars at all. The patch below > (against 1.0.0) seems to fix this; it adds a check for 'none' to the > existing check for No

[matplotlib-devel] Handle 'none' as edgecolor for bar()

2010-08-09 Thread Ben North
Hi, I tried to use "edgecolor = 'none'" in a call to bar(), hoping to get no border to the bars, but instead got no bars at all. The patch below (against 1.0.0) seems to fix this; it adds a check for 'none' to the existing check for None as a special case of the edgecolor argument. Thanks, Ben.