Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-04 Thread Jouni K . Seppänen
"John Hunter" <[EMAIL PROTECTED]> writes: > The call signature in the docstring should certainly be changed to > match the new signature. Ok. I synced the docstrings of bar and barh. > Also, take a look at the kwdocd stuff we have to see if you can make > that work for the keyword args. It wa

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread John Hunter
On 3/3/07, Jouni K. Seppänen <[EMAIL PROTECTED]> wrote: > Done. Should the function signature in the docstring of barh be > changed as well? I think listing the possible keyword arguments and > their defaults is valuable in the help text, but the signature could > make people think they can use po

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread Jouni K . Seppänen
"John Hunter" <[EMAIL PROTECTED]> writes: >> I replaced most of the kwargs by a **kwargs dict in svn revision 3037. > > Since this changes the API, albeit minimally, make sure these changes > are documented in the API_CHANGES file. Thanks for working on this. Done. Should the function signature

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-03 Thread John Hunter
On 3/3/07, Jouni K. Seppänen <[EMAIL PROTECTED]> wrote: > I replaced most of the kwargs by a **kwargs dict in svn revision 3037. > This does change the behavior for people who were giving positional > arguments to barh, but they do get an error message. Since this changes the API, albeit minimall

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-02 Thread Jouni K . Seppänen
Eric Firing <[EMAIL PROTECTED]> writes: > Looks like barh just needs to take a **kwargs (which could replace most > of the present listed kwargs; or add a log kwarg to the list) and pass > it along to bar. You are taking care of this? I replaced most of the kwargs by a **kwargs dict in svn rev

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-02 Thread John Hunter
On 3/2/07, Eric Firing <[EMAIL PROTECTED]> wrote: > I didn't do it--but it looks like the reason is that having barh as a > separate method permits a more natural order of arguments without > introducing more complexity in the argument handling. barh was originally added for compatibility with m

Re: [matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-02 Thread Eric Firing
Jouni K. Seppänen wrote: > Hi, > > What is the reason for having both barh and bar, when the latter > accepts the orientation='horizontal' argument? I am asking because of > sf bug #1669506, which is about hist(orientation='horizontal') not > working because it passes a log kwarg to barh. > I di

[matplotlib-devel] barh vs. bar(orientation='horizontal')

2007-03-02 Thread Jouni K . Seppänen
Hi, What is the reason for having both barh and bar, when the latter accepts the orientation='horizontal' argument? I am asking because of sf bug #1669506, which is about hist(orientation='horizontal') not working because it passes a log kwarg to barh. -- Jouni K. Seppänen http://www.iki.fi/jks