Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-22 Thread Ariel Rokem
Hi - following up on this patch, as suggested, I have added a use-case of mlab.cohere_pairs to examples/pylab_examples/mri_with_eeg.py. Cheers, Ariel On Sat, Aug 22, 2009 at 4:27 PM, John Hunter wrote: > On Sat, Aug 22, 2009 at 6:00 PM, Ariel Rokem wrote: > >> so - now, almost two weeks later

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-22 Thread John Hunter
On Sat, Aug 22, 2009 at 6:00 PM, Ariel Rokem wrote: > so - now, almost two weeks later, I can finally install MPL from > source. On to submitting that patch. Thanks for following up -- applied to the release branch, merged to trunk

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-22 Thread Ariel Rokem
Hi - so - now, almost two weeks later, I can finally install MPL from source. On to submitting that patch. Here's what I get with mlab.cohere_pairs, as it is currently: In [1]: a=np.array([[1,2,3,4],[1,2,3,4]]) In [2]: b=([1,1],[0,0]) In [3]: mlab.cohere_pairs(a,b)

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-12 Thread Ariel Rokem
Hi - scratch that. Only *seems* to be working. Actually it hangs when I run scripts that open figures. I am going to undo all this and forget I ever started down this path. Cheers, Ariel On Wed, Aug 12, 2009 at 11:10 AM, Ariel Rokem wrote: > Hi again - a string of strange things just happened.

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-12 Thread Ariel Rokem
Hi again - a string of strange things just happened. After this recent chain of failures, I decided to try to do some random attempts at making this work. First, I ran 'sudo python setup.py install' in the directory into which I had checked out the mpl source. After going through all of the above,

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-12 Thread Ariel Rokem
Hi Fernando and John, regardless of the clunky way in which I was trying to introduce our patch, I still want to be able to build MPL from source on my machine. It is a distraction, but, hey, it's a distraction on top of a distraction on top of a distraction, so at this point, I might as well be d

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-12 Thread John Hunter
On Wed, Aug 12, 2009 at 2:26 AM, Fernando Perez wrote: > By the way John, in this particular case, I don't think the change > warrants a before/after example, because the before case is "it > doesn't run" :)  The code today makes calls to Numeric routines like > typecode() that simply don't exist

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-12 Thread Fernando Perez
On Tue, Aug 11, 2009 at 7:29 PM, Ariel Rokem wrote: > ASR:matplotlib arokem$ make build_os105 > make: *** No rule to make target `build_os105'.  Stop. Typo: John said: make build_osx105 Note the extra 'x'. By the way John, in this particular case, I don't think the change warrants a before/a

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-11 Thread Ariel Rokem
Resending, with CC to list. Thanks for the help! Nightmare of the living crash-test dummy... I tried following your instructions. Here's what that looks like: ASR:matplotlib arokem$ make build_os105 make: *** No rule to make target `build_os105'. Stop. ASR:matplotlib arokem$ cd release/osx ASR:

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-11 Thread John Hunter
On Tue, Aug 11, 2009 at 8:29 PM, Ariel Rokem wrote: > Am I doing something wrong? I promise to follow your instructions, if I can > make it work :-) No worries -- OSX is a nightmare. First try this: make build_osx105 and if that works, you can python setup.py install If that doesn't work

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-11 Thread Ariel Rokem
Hi - I would like to do that, but now, after I grabbed the most recent svn from main source and tried to build it (so that I can replicate the broken-ness of the code) I get this: ASR:matplotlib arokem$ python setup.py install =

Re: [matplotlib-devel] mlab cohere_pairs patch

2009-08-11 Thread John Hunter
On Tue, Aug 11, 2009 at 5:02 PM, Ariel Rokem wrote: > here is a suggested patch for mlab's cohere_pairs function. The old version > was broken, due to some outdated code. Thanks Ariel for the patch. Could you explain your patch in words -- what was broken before and how you fixed it. Also, whil

[matplotlib-devel] mlab cohere_pairs patch

2009-08-11 Thread Ariel Rokem
Hi, here is a suggested patch for mlab's cohere_pairs function. The old version was broken, due to some outdated code. Cheers, Ariel -- Ariel Rokem Helen Wills Neuroscience Institute University of California, Berkeley http://argentum.ucbso.berkeley.edu/ariel mlab_cohere_pairs_patch.py Descri