Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-05 Thread Benjamin Root
On Wed, Jan 5, 2011 at 9:51 AM, John Hunter wrote: > > > On Wed, Jan 5, 2011 at 9:45 AM, Benjamin Root wrote: > >> >> Ah, I see... that makes much more sense then. >> >> Thanks for clearing that up. >> > > > Ben do you want to handle this submission? Since it is a bug, it can go > into the bran

Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-05 Thread John Hunter
On Wed, Jan 5, 2011 at 9:45 AM, Benjamin Root wrote: > > Ah, I see... that makes much more sense then. > > Thanks for clearing that up. > Ben do you want to handle this submission? Since it is a bug, it can go into the branch. Paul, would you like to have commit access? If so, please send me

Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-05 Thread Jae-Joon Lee
Thanks for the patches. I just committed the getitem patch to the trunk with slight modifications. As I think this is not a serious bug, I didn't push it to the maintenance branch. I'll review the doc patch and commit it later this week. On the other hand, I don't think it is a good idea to have t

Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-05 Thread Benjamin Root
On Wed, Jan 5, 2011 at 12:11 AM, Paul Ivanov wrote: > Benjamin Root, on 2011-01-04 19:48, wrote: > > 2011/1/4 Paul Ivanov > > > > > Hi matplotlib developers, > > > > > > I was answering a question on the -users list and came across a > > > gridspec __getitem__ bug which causes an infinite loop

Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-04 Thread Paul Ivanov
Benjamin Root, on 2011-01-04 19:48, wrote: > 2011/1/4 Paul Ivanov > > > Hi matplotlib developers, > > > > I was answering a question on the -users list and came across a > > gridspec __getitem__ bug which causes an infinite loop if the > > user tries to iterate over it, because getitem never did

Re: [matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-04 Thread Benjamin Root
2011/1/4 Paul Ivanov > Hi matplotlib developers, > > I was answering a question on the -users list and came across a > gridspec __getitem__ bug which causes an infinite loop if the > user tries to iterate over it, because getitem never did a > sanity-check when given an integer key. > > from mat

[matplotlib-devel] two gridspec patches (fix getitem bug and docs)

2011-01-04 Thread Paul Ivanov
Hi matplotlib developers, I was answering a question on the -users list and came across a gridspec __getitem__ bug which causes an infinite loop if the user tries to iterate over it, because getitem never did a sanity-check when given an integer key. from matplotlib import gridspec gs = grids