Re: AMC merge patch #2

2003-02-11 Thread Pavel Roskin
Hello! The saga continues, this time with EXTfs and Syntax files updates: Changes included in patch: (all merged in from AMC version mc-4.1.35-A12pre) - EXTFS Support for the ESP archiver ('uesp' added where needed) I have never heard of ESP. Icon=compressed.xpm is wrong. There is no

Re: AMC merge patch #2

2003-02-11 Thread Arpi
Hi, The saga continues, this time with EXTfs and Syntax files updates: Changes included in patch: (all merged in from AMC version mc-4.1.35-A12pre) - EXTFS Support for the ESP archiver ('uesp' added where needed) I have never heard of ESP. Is it enough reason to refuse the patch?

Usability issue - error dialog

2003-02-11 Thread Adam Byrtek / alpha
Error dialogs (for example 'File exists' dialog) are displayed in red, and the hotkeys are NOT highlighted, so the user don't know which key to use. One could easily confuse 'Append' (P hotkey) with 'Abort' (A hotkey). Maybe we should display corresponging hotkeys in yellow? Regards --

[patch] avoid invoking commands with empty argument

2003-02-11 Thread Adam Byrtek / alpha
mc passes an empty argument () to the EDITOR when creating new file (with F14). It makes vim to list the current dircetory. The nvi doesn't create temporary file, so write command won't work, however if you call nvi without any argument it creates a temp file to save the data in. The same problem

Re: [patch] avoid invoking commands with empty argument

2003-02-11 Thread Pavel Roskin
Hello, Adam! On Tue, 11 Feb 2003, Adam Byrtek / alpha wrote: mc passes an empty argument () to the EDITOR when creating new file (with F14). It makes vim to list the current dircetory. The nvi doesn't create temporary file, so write command won't work, however if you call nvi without any

Re: [patch] avoid invoking commands with empty argument

2003-02-11 Thread Adam Byrtek / alpha
On Tue, Feb 11, 2003 at 12:07:50PM -0500, Pavel Roskin wrote: P.S. Empty string comes from edit_cmd_new(). It should be fine to use NULL if we take care not to run vfs_file_is_local() on NULL in execute_with_vfs_arg(). Your patch is better, it sorts things on higher level. I wanted to be sure

hotlist: hotkey duplicates control; patch submitted

2003-02-11 Thread bulia byak
A new version of the hotlist patch with hotkey duplicates control is uploaded: http://savannah.gnu.org/patch/index.php?func=detailpatchpatch_id=1042group_id=3521 * in new/edit entry/group, an error message is displayed, and the dialog is redisplayed so that the user can change the hotkey *

Re: AMC merge patch #2

2003-02-11 Thread Adam Byrtek / alpha
On Tue, Feb 11, 2003 at 03:00:14PM -0500, bulia byak wrote: Why not apply the same approach here? Especially given that such additions are very unlikely to break anything else in mc. On the other side nearly every programmer has written some tools for his own use, to learn something new, just

Re: Usability issue - error dialog

2003-02-11 Thread Pavel Roskin
Hello! Error dialogs (for example 'File exists' dialog) are displayed in red, and the hotkeys are NOT highlighted, so the user don't know which key to use. One could easily confuse 'Append' (P hotkey) with 'Abort' (A hotkey). Maybe we should display corresponding hotkeys in yellow? Yes,