Re: mcedit file locking

2003-03-26 Thread Pavel Roskin
> > that's a) not exactly a downside, if you ask me and b) usually not true, > > as the locks are only advisory, not mandatory, so "the other" > > application has to use locking itself to notice what we do. OK, it seems that write lock using fcntl for the period when the file is being edited would

Re: mcedit file locking

2003-03-26 Thread Pavel Tsekov
On Tue, 25 Mar 2003, Oswald Buddenhagen wrote: > On Tue, Mar 25, 2003 at 01:59:12AM -0500, Pavel Roskin wrote: > > 3) System-wide locks using fcntl() or (if not supported) flock(). > > > i'd go with that one. > > > Pro: No stale locks. Works in non-writable directories. Locking between > > user

Data corruption on file copying/moving fixed

2003-03-26 Thread Andrew V. Samoilov
Hello! There was a data corruption possibility in the file.c:copy_file_file() for a years. If mc_write() fails to write n_read bytes at once for some reason then n_read is fixed, but buf is not, so there are some pieces from beginning of buf instead of trailing part. Possible scenario: copy/mo