Re: Is anyone reviewing patches ?

2005-04-14 Thread Pavel Tsekov
Hello, On Thu, 14 Apr 2005, Marco Ciampa wrote: On Thu, Apr 14, 2005 at 10:25:02AM +0300, Pavel Tsekov wrote: Hello, Does anyone care ? which patches? http://mail.gnome.org/archives/mc-devel/2005-April/msg5.html http://mail.gnome.org/archives/mc-devel/2005-April/msg00021.html

Re: Is anyone reviewing patches ?

2005-04-14 Thread Marco Ciampa
Please forgive me if I'm off topic but I'm only trying to give a hand. On Thu, Apr 14, 2005 at 10:47:03AM +0300, Pavel Tsekov wrote: Hello, On Thu, 14 Apr 2005, Marco Ciampa wrote: On Thu, Apr 14, 2005 at 10:25:02AM +0300, Pavel Tsekov wrote: Hello, Does anyone care ? which

Re: [patch] new menu generation code simplifies translator's work

2005-04-14 Thread Roland Illig
Roland Illig wrote: Hi all, I rewrote the create_menu() function in src/menu.c to make the work of the translators easier. Until now, they have to count spaces to correctly align the menu items. Now the code inserts these spaces automatically. This patch is not ready for production use. It

Re: [patch] const_cast to be replaced by str_unconst

2005-04-14 Thread Oswald Buddenhagen
On Tue, Apr 12, 2005 at 08:28:50PM +0200, Roland Illig wrote: Pavel Tsekov wrote: For those of you that are concerned about the performance loss of an extra function call: It is much more important for the code to be readable and checkable by the compiler than to be 1 millisecond faster at

Re: [patch] const_cast to be replaced by str_unconst

2005-04-14 Thread Roland Illig
Oswald Buddenhagen wrote: whoops, this is exactly what you're talking about. :} anyway, i don't think this extra warning would matter, given that it would be in the same location in every file. and, fwiw, isn't it possible to use a #pragma or some __attribute__ to get rid of the warning? There's a

Re: Little syntax fixes - makefile

2005-04-14 Thread Leonard den Ottolander
Hi Ian, On Thu, 2005-04-14 at 07:45, Ian Zagorskih wrote: file (.\*[Mm]akefile[\\\.a-zA-Z0-9]\*|..\*\\.mk)$ Makefile include makefile.syntax So for example Makefile.Release is catched too. PS: Makefile.Release and Makefile.Debug names are used now in Qt4 package :) Committed to both HEAD