Re: [PATCH] Overriding automatic syntax detection

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: It is not hard to fix these but please do you homework next time. You are as inspirational as ever. Please give it a try against PRE first. Yeah, yeah. Why should I test against PRE and then test it one more time against HEAD. IMHO,

Re: code improvements for the viewer

2005-07-08 Thread Pavel Tsekov
Hello, On Thu, 7 Jul 2005, Roland Illig wrote: The at all is not correct. Indeed, I have left out the case where mcview is shown in the right panel. I have fixed it. Thanks for testing and the quick note. Ok, it works fine now. Another problem that I see here (though this might be related

cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, While investigating the recent bug report posted by Thomas Zajic regarding cons.saver I came across the following code: winsz.ws_col = winsz.ws_row = 0; if (ioctl (console_fd, TIOCGWINSZ, winsz) 0 || winsz.ws_col = 0 || winsz.ws_row = 0 || winsz.ws_col = 256 ||

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: Hello Pavel, On Fri, 2005-07-08 at 11:31, Pavel Tsekov wrote: winsz.ws_col = winsz.ws_row = 0; if (ioctl (console_fd, TIOCGWINSZ, winsz) 0 || winsz.ws_col = 0 || winsz.ws_row = 0 || winsz.ws_col = 256 ||

CVS commit wrong version

2005-07-08 Thread Leonard den Ottolander
Hi, For some reason the revision for NEWS in my local PRE tree got replaced with the version for HEAD in CVS/Entries. Hence I've now wrongly updated NEWS in HEAD with a version ment for PRE. How do I correct this last commit? Can I revert the version or do I just recommit the previous version?

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hi Pavel, On Fri, 2005-07-08 at 15:20, Pavel Tsekov wrote: Well, currently the limit has been raised so it should be reflected here too. I think the limit used in mc is to restrict memory consumption and does not indicate a slang limit. Screens that can represent more than 512 x 512 characters

Re: CVS commit wrong version

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: Hi, For some reason the revision for NEWS in my local PRE tree got replaced with the version for HEAD in CVS/Entries. Hence I've now wrongly updated NEWS in HEAD with a version ment for PRE. How do I correct this last commit? Can I

Re: getgrouplist segfault?

2005-07-08 Thread Andrew V. Samoilov
Hello, we can add and use new variable like use_getgrouplist in mc.lib. Let system admins or users who defined MC_DATADIR approve this setting for their systems. I think run-time detection of this glibc misfeature is not trivial. On other hand it's not right to has two MC for both cases. --

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: On Fri, 2005-07-08 at 15:20, Pavel Tsekov wrote: Well, currently the limit has been raised so it should be reflected here too. I think the limit used in mc is to restrict memory consumption and does not indicate a slang limit.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hello Pavel, On Fri, 2005-07-08 at 16:28, Pavel Tsekov wrote: The problem is this check does not happen when the screen (say xterm) is being resized so we need it here as well. I don't understand what you are talking about. cons.saver is used only in linux console and FreeBSD console.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: Hello Pavel, On Fri, 2005-07-08 at 16:28, Pavel Tsekov wrote: The problem is this check does not happen when the screen (say xterm) is being resized so we need it here as well. I don't understand what you are talking about.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: On Fri, 2005-07-08 at 17:01, Pavel Tsekov wrote: It will crash (eventually) because of the slang limitation. Even with the check in console handler. As long as it doesn't write into unallocated memory mc will not crash. I Well, MC

Re: getgrouplist segfault?

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Andrew V. Samoilov wrote: I think run-time detection of this glibc misfeature is not trivial. How about gnu_get_libc_version() ? Does this method has any drawbacks ? Well, I bet a lot of distros will provide patched glibc without patched VERSION. Yes, indeed

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hello Pavel, On Fri, 2005-07-08 at 20:06, Pavel Tsekov wrote: Indeed this limit should be increased to 512, but as I've pointed out before that is sadly not a one place fix. Are you sure ? The limit should be set according to the slang version, not to a fixed 512. We should probably set