[patch #1042] hotkeys and other improvements in hotlist

2006-02-02 Thread bulia byak
Follow-up Comment #14, patch #1042 (project mc): Sure, please feel free to use a different dotdot patch. I'm not saying mine is the best. I just want this functionality to be in. As for my patch, I wasn't such an experienced programmer back then (three years ago!). I just reworked that entire

Re: syntax switching

2006-02-02 Thread Leonard den Ottolander
Hi Pavel, On Thu, 2006-02-02 at 17:55 +0200, Pavel Tsekov wrote: The patch isn't working quite as I'd expect it. If syntax highlighting is off when opening a file - it is not possible to switch it on (i.e. see the file coloured after Ctrl + S) because the syntax rules are not loaded yet. If

Segfault on loading of non existent syntax file

2006-02-02 Thread Leonard den Ottolander
Hi, Ran mc from a temporary build dir and copied Syntax to ~/.mc/cedit/ . Tried editing a file and saw a segfault when the non existent syntax file is attempted to be loaded. #0 edit_get_rule (edit=0x92e8dc0, byte_index=-1) at syntax.c:285 #1 0x080a4161 in edit_free_syntax_rules

[bug #13500] Feature request: .. entry in directory hotlist subgroups

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #4, bug #13500 (project mc): Sorry, the previous patch was bad: 1) I forgot to add `..' entry when adding a new group from the hotlist dialog 2) The label and the destionation of the `..' entries were not g_strdup()-ed which caused MC to crash Please, give the update patch a

[patch #1042] hotkeys and other improvements in hotlist

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #13, patch #1042 (project mc): Hello Bulia, Please, take a look here: https://savannah.gnu.org/bugs/?func=detailitemitem_id=13500 I've created a patch which adds .. to the hotlist. I think the approach used there is cleaner than the one you have used in your own patch. What

Re: Crash on hexediting empty file

2006-02-02 Thread Pavel Tsekov
On Wed, 1 Feb 2006, Leonard den Ottolander wrote: Hi, Try F3 - F4 - F2 on an empty file. Boom, ouch. (Might be that if you still are in edit mode you need to try after getting back in view mode.) Patch is attached. I'll not commit this before Roland comments . There are multiple ways to fix

Re: [patch?] recent ftpfs ERRNOR fix broke uploading

2006-02-02 Thread Jindrich Makovicka
Pavel Tsekov wrote: On Thu, 2 Feb 2006, Pavel Tsekov wrote: On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return

Re: current CVS mc isn't compilable

2006-02-02 Thread Roland Illig
Pavel Tsekov wrote: Fixed. Oops and thanks. :) Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [patch?] recent ftpfs ERRNOR fix broke uploading

2006-02-02 Thread Pavel Tsekov
On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I've just

[patch #1042] hotkeys and other improvements in hotlist

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #15, patch #1042 (project mc): There is a good chance that your patches will be reviewed if you submit them. In fact I'd ask you to do so if you have patches that are of general interest. ___ Reply to this item at:

[bug #13500] Feature request: .. entry in directory hotlist subgroups

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #3, bug #13500 (project mc): Patch attached. ___ Additional Item Attachment: File name: mc-hotlist-dotdot.patchSize:3 KB Add .. entry to hotlist subgroups

Re: syntax switching

2006-02-02 Thread Leonard den Ottolander
Hi Pavel, On Thu, 2006-02-02 at 17:55 +0200, Pavel Tsekov wrote: The patch isn't working quite as I'd expect it. If syntax highlighting is off when opening a file - it is not possible to switch it on (i.e. see the file coloured after Ctrl + S) because the syntax rules are not loaded yet. If

Re: syntax switching

2006-02-02 Thread Pavel Tsekov
On Wed, 1 Feb 2006, Leonard den Ottolander wrote: On Mon, 2006-01-30 at 13:55 +0200, Andy Shevchenko wrote: Arny (one of developers of MPlayer) made patch for mc old version. I catch the syntax highlighting toggle feature from it and adopt to a last FC package. I hope, the switcher of

[bug #13731] confirm deleting from directory hotlist

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #9, bug #13731 (project mc): Please, close. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=13731 ___ Message sent via/by Savannah

[bug #15412] gpmsupport on console doesn't work

2006-02-02 Thread Pavel Tsekov
Follow-up Comment #2, bug #15412 (project mc): Please, close. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=15412 ___ Message sent via/by Savannah

Re: [patch?] recent ftpfs ERRNOR fix broke uploading

2006-02-02 Thread Pavel Tsekov
On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to 0 seems to fix the problem. I'll

Re: [patch?] recent ftpfs ERRNOR fix broke uploading

2006-02-02 Thread Pavel Tsekov
On Thu, 2 Feb 2006, Pavel Tsekov wrote: On Wed, 1 Feb 2006, Jindrich Makovicka wrote: after a fix of wrong ERRNOR usage in ftpfs.c (2006-01-24 ftpfs.c (ftpfs_dir_load): Fix a bad ERRNOR call), mc segfaults when I try uploading directories recursively. Changing the return value from -1 to

Re: Crash on hexediting empty file

2006-02-02 Thread Roland Illig
Pavel Tsekov wrote: Index: src/view.c === RCS file: /cvsroot/mc/mc/src/view.c,v retrieving revision 1.353 diff -u -p -r1.353 view.c --- src/view.c 1 Feb 2006 15:59:21 - 1.353 +++ src/view.c 2 Feb 2006 08:49:45 - @@