Re: [PATCH] Help Viewer - mouse issues

2007-01-20 Thread Pavel Tsekov
Hello, On Wed, 2007-01-03 at 23:03, Pavel Tsekov wrote: Hmm. I don't really understand why the '\n' is necessary - and since the code is quite old perhaps noone remebers anymore. I'll play with the code a bit and see if I be able to determine whether the newline is of any importance. I'll

Re: [PATCH] Help Viewer - mouse issues

2007-01-10 Thread Pavel Tsekov
On Tue, 2007-01-09 at 19:08, Grigory Trenin wrote: Pavel Tsekov wrote: Well, we can go with the simple solution for now - but it should be documented somewhere to prevent further confusion. As to whether it is worth the effort - think about this: Me and you together spent a

Re: [PATCH] Help Viewer - mouse issues

2007-01-10 Thread Grigory Trenin
Pavel Tsekov wrote: On Tue, 2007-01-09 at 19:08, Grigory Trenin wrote: Pavel Tsekov wrote: I am not quite satisfied with that simple solution too. What do you think if I convert xnc.hlp to mandoc format and patch man2hlp respectively? I think it will be sufficient to add to man2hlp

Re: [PATCH] Help Viewer - mouse issues

2007-01-09 Thread Grigory Trenin
Pavel Tsekov wrote: Well, we can go with the simple solution for now - but it should be documented somewhere to prevent further confusion. As to whether it is worth the effort - think about this: Me and you together spent a considerable amount of time on a simple issue - was it worth it ?

Re: [PATCH] Help Viewer - mouse issues

2007-01-06 Thread Pavel Tsekov
On Sat, 6 Jan 2007, Grigory Trenin wrote: Pavel Tsekov wrote: Implementing either solution would not remove the necessity of this: [...] need to revise the help files for all languages, to check if they fit in the window, and fix them if necessary. [...] To fix this there should be no

Re: [PATCH] Help Viewer - mouse issues

2007-01-06 Thread Pavel Tsekov
On Wed, 2007-01-03 at 23:03, Pavel Tsekov wrote: On Wed, 2007-01-03 at 22:43, Grigory Trenin wrote: Pavel Tsekov wrote: How about fixing help_follow_link() instead ? IMO, this would be a proper fix if we agree that the leading '\n' is not desired. Good point! Certainly,

Re: [PATCH] Help Viewer - mouse issues

2007-01-05 Thread Pavel Tsekov
On Fri, 2007-01-05 at 02:32, Grigory Trenin wrote: Pavel Tsekov wrote: On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: This is patch is OK, but there are still problems. See this: create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4,

Re: [PATCH] Help Viewer - mouse issues

2007-01-05 Thread Grigory Trenin
Pavel Tsekov wrote: Implementing either solution would not remove the necessity of this: [...] need to revise the help files for all languages, to check if they fit in the window, and fix them if necessary. [...] To fix this there should be no preformatted pages involved, IMO. But I may be

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Pavel Tsekov
On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: 1) mouse-rightbutton.patch Returning to a previous node by pressing right mouse button doesn't work in xterm. It works only in Linux console with GPM. The problem is that help_event() catches only GPM_UP event, and it seems that xterm

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Grigory Trenin
Pavel Tsekov wrote: I had this idea now. How about fixing the code that captures mouse events from xterm instead ? I.e. when it receives a mouse down event it will record which key was pressed and it will copy this information to the mouse up event ? This will be not always reliable. Suppose

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Pavel Tsekov
On Thu, 2007-01-04 at 22:33, Grigory Trenin wrote: Pavel Tsekov wrote: I had this idea now. How about fixing the code that captures mouse events from xterm instead ? I.e. when it receives a mouse down event it will record which key was pressed and it will copy this information to the mouse

Re: [PATCH] Help Viewer - mouse issues

2007-01-04 Thread Grigory Trenin
Pavel Tsekov wrote: On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: This is patch is OK, but there are still problems. See this: create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4, ^^ HELP_WINDOW_WIDTH already is large enough to

[PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Hello, Here are 3 patches to the mouse issues in the Help Viewer. 1) mouse-rightbutton.patch Returning to a previous node by pressing right mouse button doesn't work in xterm. It works only in Linux console with GPM. The problem is that help_event() catches only GPM_UP event, and it seems that

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Pavel Tsekov
Hello Grigory, On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: Here are 3 patches to the mouse issues in the Help Viewer. [...] 3) mouse-linkfollow.patch When following a link with a mouse, an extra '\n' is insterted at the top of the window (just follow any link with a keyboard, then

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Pavel Tsekov
On Wed, 2007-01-03 at 19:19, Grigory Trenin wrote: 2) mouse-offbytwo.patch Last two lines of the help window (the bottom line and a frame) are not mouse-clickable. So the user will not be able to follow a link with a mouse, if it is situated at the bottom line. And the frame needs to be

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: How about fixing help_follow_link() instead ? IMO, this would be a proper fix if we agree that the leading '\n' is not desired. Good point! Certainly, this would be better. The help format documentation says: The hypertext file is a file that may have one or more

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Pavel Tsekov
On Wed, 2007-01-03 at 22:43, Grigory Trenin wrote: Pavel Tsekov wrote: How about fixing help_follow_link() instead ? IMO, this would be a proper fix if we agree that the leading '\n' is not desired. Good point! Certainly, this would be better. The help format documentation says:

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: This is patch is OK, but there are still problems. See this: create_dlg (0, 0, help_lines + 4, HELP_WINDOW_WIDTH + 4, ^^ HELP_WINDOW_WIDTH already is large enough to hold the dialog frame. As a resylt if you try to

Re: [PATCH] Help Viewer - mouse issues

2007-01-03 Thread Grigory Trenin
Pavel Tsekov wrote: It seems like man2hlp is producing output with line lengths larget than HELP_TEXT_WIDTH which is incorrect IMO. In some nodes (eg, Menu File Edit) preformatted text is used (it is marked by .nf tag). In that case man2hlp will output the text as is, without trying to wrap