Hello, there!
This patch makes the handling of the 'type/' directive much better. It
also improve the quality of the code.
o It checks if the data in 'content_string' is valid and doesn't
preform any further checks, whether it matches a regex.
o There was such check in the original, code
Hello, Pavel! :)
Wednesday, August 21, 2002, 6:55:51 PM, you wrote:
PR Hello, Pavel!
This patch makes the handling of the 'type/' directive much better. It
also improve the quality of the code.
PR I appreciate your goals, but your patch is too hard for me to understand.
The original code
Hello again!
P.S. I just realized that spliting regex_check_type() breaks caching of
the file output, and I don't have time to fix it today, so your help
will be appreciated.
Never mind. It's fixed now. I think I also fixed all the issues you were
trying to fix.
--
Regards,
Pavel Roskin
Hello!
I feel bad that I broke the code ask asked your for help and then fixed it
myself. I hope you didn't lose much time on it.
PR By the way, if I hacked this function, I would first try to split
PR processing of type/ into a separate function. regex_command() is too
PR large. It even
Hello, Pavel! :)
Wednesday, August 21, 2002, 9:52:39 PM, you wrote:
PR Hello!
PR I feel bad that I broke the code ask asked your for help and then fixed it
PR myself. I hope you didn't lose much time on it.
The important thing is that the right code is now in CVS :)
PR Reorganization of the
