Follow-up Comment #6, patch #4492 (project mc):
Unfortunately i can't see how
https://savannah.gnu.org/patch/?func=detailitemitem_id=4492#comment5 can
help me to solve problem of using same variable for flags and port in
vfs_split_url.
anyway i've considered other comments, so sending new patch.
Follow-up Comment #7, patch #4492 (project mc):
Problem is that one can't specify both a port and a compressed connection.
But that problem is not in your code but the way vfs_split_url() parses the
options.
Best thing would be to fix the parsing of the options in vfs_split_url().
Follow-up Comment #3, patch #4492 (project mc):
There's more:
Please do not use the FISH_FLAGS to pass the port. It interferes with the
other flags. Just use it to indicate a port has been specified and pass that
port in a *separate* variable.
FISH_DEFAULT_PORT is different for ssh (22) and
Follow-up Comment #4, patch #4492 (project mc):
Now I see the fact that you use port and flags is because this is the way
vfs_split_url handles it. Ugh. So the ugly hack is in utilvfs.c.
___
Reply to this item at:
Follow-up Comment #5, patch #4492 (project mc):
http://savannah.gnu.org/cgi-bin/viewcvs/mc/mc/vfs/utilvfs.c.diff?r1=1.2r2=1.3
___
Reply to this item at:
http://savannah.gnu.org/patch/?func=detailitemitem_id=4492
Follow-up Comment #2, patch #4492 (project mc):
Thanks for fast response.
Hope this patch mets all requirements.
___
Additional Item Attachment:
File name: mc-fish_port.patch Size:3 KB
Patch, allowing to set port to connect
URL:
http://savannah.gnu.org/patch/?func=detailitemitem_id=4492
Summary: Patch, allowing to set port to connect for FIle
transfer over SHell filesystem
Project: GNU Midnight Commander
Submitted by: boda
Submitted on: Чтв 06.10.2005 at
Follow-up Comment #1, patch #4492 (project mc):
A couple of general comments:
- Please use the -p switch for diffs. This way it's obvious which function is
affected.
- Do not remove empty lines (at least not as integral part of a functional
patch). They increase readability.
- Do not use C99
