Re: Big patch for mcview

2005-04-08 Thread Roland Illig
Pavel Tsekov wrote: Droping a short note that you've done the commit wouldn't hurt so much, would it ? Sorry, I forgot it. :( Committed. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Big patch for mcview

2005-04-08 Thread Pavel Tsekov
Hello, On Wed, 6 Apr 2005, Roland Illig wrote: > Roland Illig wrote: > > Hi all, > > > > I must have had too much time, as I have partly rewritten mcview. The > > patch is quite large and changes many things. However, I have tested it > > with all available types of data sources (see the code for

Re: Big patch for mcview

2005-04-07 Thread Pavel Tsekov
Hello, On Wed, 6 Apr 2005, Roland Illig wrote: > Roland Illig wrote: > > Hi all, > > > > I must have had too much time, as I have partly rewritten mcview. The > > patch is quite large and changes many things. However, I have tested it > > with all available types of data sources (see the code for

Re: Big patch for mcview

2005-04-06 Thread Roland Illig
Roland Illig wrote: Hi all, I must have had too much time, as I have partly rewritten mcview. The patch is quite large and changes many things. However, I have tested it with all available types of data sources (see the code for explanation), and it seems to work. Here is my second try for the view

Re: Big patch for mcview (fwd)

2005-04-05 Thread Pavel Tsekov
On Tue, 5 Apr 2005, Jindrich Makovicka wrote: > Pavel Tsekov wrote: > > Hello, > > > > I'm forwarding this to the list (again) just to make sure that it won't be > > missed because of the wrong settings of my clock. > > I have already resolved the issue with Roland - the patch accidentally > remov

Re: Big patch for mcview (fwd)

2005-04-05 Thread Jindrich Makovicka
Pavel Tsekov wrote: > Hello, > > I'm forwarding this to the list (again) just to make sure that it won't be > missed because of the wrong settings of my clock. I have already resolved the issue with Roland - the patch accidentally removed the line view->view_active = 1; which then caused the cr

Re: Big patch for mcview (fwd)

2005-04-05 Thread Pavel Tsekov
TECTED]> Cc: MC dev Subject: Re: Big patch for mcview Hello, On Fri, 1 Apr 2005, Roland Illig wrote: > Jindrich Makovicka wrote: > > Crashes when switching between viewer modes. To reproduce, use F3 on a > > jpg/mp3/whatever (assuming you have mpg123, ImageMagick or other &

Re: Big patch for mcview

2005-04-04 Thread Pavel Tsekov
Hello, On Fri, 1 Apr 2005, Roland Illig wrote: > Jindrich Makovicka wrote: > > Crashes when switching between viewer modes. To reproduce, use F3 on a > > jpg/mp3/whatever (assuming you have mpg123, ImageMagick or other > > corresponding viewer), press F8 to display raw, then press F4 => sig11. >

Re: Big patch for mcview

2005-04-01 Thread Roland Illig
Jindrich Makovicka wrote: Crashes when switching between viewer modes. To reproduce, use F3 on a jpg/mp3/whatever (assuming you have mpg123, ImageMagick or other corresponding viewer), press F8 to display raw, then press F4 => sig11. I cannot reproduce this. Can you be more specific where mc cras

Re: Big patch for mcview

2005-03-24 Thread Jindrich Makovicka
Roland Illig wrote: Pavel Tsekov wrote: First of all - this patch could have been much smaller and thus easier to review/understand. 25 % (line 666 to the end) of the patch are hunks which do the following: get_byte => view->get_byte Well, simply keeping get_byte () and calling view->get_byte f

Re: Big patch for mcview

2005-03-08 Thread Roland Illig
Pavel Tsekov wrote: First of all - this patch could have been much smaller and thus easier to review/understand. 25 % (line 666 to the end) of the patch are hunks which do the following: get_byte => view->get_byte Well, simply keeping get_byte () and calling view->get_byte from within would have

Re: Big patch for mcview

2005-03-07 Thread Pavel Tsekov
Hello, On Wed, 2 Mar 2005, Roland Illig wrote: > Hi all, > > I must have had too much time, as I have partly rewritten mcview. The > patch is quite large and changes many things. However, I have tested it > with all available types of data sources (see the code for explanation), > and it seems to

Re: Big patch for mcview

2005-03-03 Thread Dmitry Alexeyev
On Wednesday 02 March 2005 21:40, Roland Illig wrote: > Hi all, > > I must have had too much time, as I have partly rewritten mcview. The > patch is quite large and changes many things. However, I have tested > it with all available types of data sources (see the code for > explanation), and it see

Big patch for mcview

2005-03-02 Thread Roland Illig
Hi all, I must have had too much time, as I have partly rewritten mcview. The patch is quite large and changes many things. However, I have tested it with all available types of data sources (see the code for explanation), and it seems to work. http://www.roland-illig.de/tmp/viewer.patch Here are t