Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-26 Thread Igor Russkih
Hello, This command line option defaults to /usr/local. This patch is just a proof of concept thing. I am posting it so that you can test it and then we can discuss it. For me this patch looks fine, its good idea for MC to detect colorer's library presence in runtime. However the

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-26 Thread Pavel Tsekov
Hello, On Mon, 26 Jun 2006, Igor Russkih wrote: For me this patch looks fine, its good idea for MC to detect colorer's library presence in runtime. However the implementation is not rather straightforward because of that separate glue library. Yes, it adds another level, but at the moment

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-25 Thread Pavel Tsekov
Hello, Find attached the patch. In order to build MC you have to run libtoolize in the MC source tree. I've added the ability to tell configure where you colorer is installed. You can pass the colorer directory via the --with-colorer configure option - for example:

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-25 Thread Pavel Tsekov
I forgot to attach the patch :( colorer-dynload.patch.gz Description: Binary data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-23 Thread Pavel Tsekov
Hello Igor, On Thu, 22 Jun 2006, Igor Russkih wrote: Here attached the patch over mc-2006-06-17-02 (snapshot from ibiblio.org). Please don't make direct diffs between mc-colorer and cvs snapshot since they are different versions. Use this patch for reviewing. I've separated the patch for

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-23 Thread Pavel Tsekov
Hello Igor, On Thu, 22 Jun 2006, Igor Russkih wrote: Here attached the patch over mc-2006-06-17-02 (snapshot from ibiblio.org). Please don't make direct diffs between mc-colorer and cvs snapshot since they are different versions. Use this patch for reviewing. I've separated the patch for

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Igor Russkih
Leonard, all, Here attached the patch over mc-2006-06-17-02 (snapshot from ibiblio.org). Please don't make direct diffs between mc-colorer and cvs snapshot since they are different versions. Use this patch for reviewing. I've separated the patch for easier understanding: build.diff -

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Leonard den Ottolander
Hello Igor, On Thu, 2006-06-22 at 14:17 +0400, Igor Russkih wrote: either during compilation time or in runtime - I meant this is already implemented. I should look for that switch then :) . No, just clean mc snapshot from ibiblio.org. Can you make it available to me? I am quite curious

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Pavel Tsekov
On Thu, 22 Jun 2006, Leonard den Ottolander wrote: Is it technically possible to reimplement that c++ code in c? (This is just theoretical question, I don't ask you to do it.) It is possible to move this code to libcolorer side and implement plain C API from library side - however this'll

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Igor Russkih
already implemented. I should look for that switch then :) . It's a runtime option in editor's settings dialog. You'll find it easily ;) No, just clean mc snapshot from ibiblio.org. Can you make it available to me? I am quite curious where the changes I The latest one I've got from

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Igor Russkih
The previous I've used (mc-2006-05-30-15.tar.gz) I cannot find that version anymore. Can you make it available to me somewhere so I can have a look? I've placed it at http://colorer.sourceforge.net/files/mc-2006-05-30-15.tar.gz -- Igor ___

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Leonard den Ottolander
Hello Igor, On Thu, 2006-06-22 at 17:55 +0400, Igor Russkih wrote: I've placed it at http://colorer.sourceforge.net/files/mc-2006-05-30-15.tar.gz Thanks. Well, that clears things up for me :-) . It turns out all the changes I observed are caused by the autogen step used to create the

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Leonard den Ottolander
Hi Igor, On Thu, 2006-06-22 at 17:30 +0400, Igor Russkih wrote: It's a runtime option in editor's settings dialog. You'll find it easily ;) Yes, got it. But you've introduced a duplicate hotkey C. Please choose another one. Leonard. -- mount -t life -o ro /dev/dna /genetic/research

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-22 Thread Oswald Buddenhagen
On Thu, Jun 22, 2006 at 05:30:38PM +0400, Igor Russkih wrote: already implemented. I should look for that switch then :) . It's a runtime option in editor's settings dialog. You'll find it easily ;) fwiw, i think this is silly. typical example of over-configurability. if it has to be

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Igor Russkih
Hi Pavel, Hi All,I'll be really glad to help to improve MC in this area, I've downloaded MC-Colorer's source tarball today and I tooka look at the code. Though I haven't studied the code in depthI can say that it seems pretty high quality. After all it iswritten by the colorer's author himself -

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Leonard den Ottolander
Hello Igor, On Wed, 2006-06-21 at 16:50 +0400, Igor Russkih wrote: I'll be really glad to help to improve MC in this area, This looks really nice. I'm very exited. With just minor patching to the xml (introduction of ControlKeyword, eg if, else etc.) and a custom colour scheme I've already got

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Pavel Tsekov
On Wed, 21 Jun 2006, Leonard den Ottolander wrote: There are also some questions which I believe should be discussed. At first there is one C++ file in this mod (to link with c++ colorer code). As far as I understand MC uses C only. Is this a problem? Yes, it might. The overall approach

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Leonard den Ottolander
Hello Pavel, On Wed, 2006-06-21 at 17:26 +0300, Pavel Tsekov wrote: Yes it will take a lot of work - colorer is written entirely in C++ . Thus there is a thin wrapper to translate from C to C++ and vice versa. In my opinion this is not a big deal and a necessary sacrifice. I'm not sure what

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Pavel Tsekov
On Wed, 21 Jun 2006, Leonard den Ottolander wrote: Hello Pavel, On Wed, 2006-06-21 at 17:26 +0300, Pavel Tsekov wrote: Yes it will take a lot of work - colorer is written entirely in C++ . Thus there is a thin wrapper to translate from C to C++ and vice versa. In my opinion this is not a

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Igor Russkih
On 6/21/06, Leonard den Ottolander [EMAIL PROTECTED] wrote: Hello Igor, original in mc (where can I send patches? Is there a mailing list for colorer?). Only have to look at the String type as we normally Sure, you can use [EMAIL PROTECTED]

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-21 Thread Leonard den Ottolander
Hello Igor, On Wed, 2006-06-21 at 23:26 +0400, Igor Russkih wrote: On 6/21/06, Leonard den Ottolander [EMAIL PROTECTED] wrote: Colorer library can be disabled either during compilation time Switching at run time would be nice. At least as a startup option. Just a single ru.po file with a few

Re: Midnight Commander mod with Colorer-take5 syntax engine

2006-06-20 Thread Pavel Tsekov
Hello Stan, On Tue, 20 Jun 2006, Stan. S. Krupoderov wrote: This Midnight Commander build is modified to use Colorer-take5 as a syntax highlighting engine in standard mc editor. http://colorer.sourceforge.net/mc.html That's just great! Maybe it can be useful for someone. Any opinions?