Re: [RFE][PATCH] Display free space on device in panels

2006-05-31 Thread Pavel Tsekov
On Wed, 31 May 2006, Oswald Buddenhagen wrote: On Wed, May 31, 2006 at 05:13:29PM +0300, Pavel Tsekov wrote: There is no need to profile MC. It is not speedup in terms of CPU cycles but in reduced screen update i.e. why paint the frame each time if it really doesn't change at all. it should b

Re: [RFE][PATCH] Display free space on device in panels

2006-05-31 Thread Oswald Buddenhagen
On Wed, May 31, 2006 at 05:13:29PM +0300, Pavel Tsekov wrote: > There is no need to profile MC. It is not speedup in terms of CPU > cycles but in reduced screen update i.e. why paint the frame each time > if it really doesn't change at all. > it should be pointed out that the screen libs (ncurses

Re: [RFE][PATCH] Display free space on device in panels

2006-05-31 Thread Pavel Tsekov
On Wed, 31 May 2006, Jindrich Novy wrote: On Tue, 2006-05-30 at 14:56 +0300, Pavel Tsekov wrote: On Mon, 29 May 2006, Jindrich Novy wrote: On Fri, 2006-05-19 at 14:29 -0400, Pavel Roskin wrote: Can we avoid any highlighting? I think Far Manager does it right: http://red-bean.com/proski/mc/f

Re: [RFE][PATCH] Display free space on device in panels

2006-05-31 Thread Leonard den Ottolander
Hello Jindrich, On Wed, 2006-05-31 at 15:56 +0200, Jindrich Novy wrote: > On Tue, 2006-05-30 at 14:56 +0300, Pavel Tsekov wrote: > > Now, after I reviewed the patch for a second time I am pretty convinced > > that the free space info should be displayed in the mini status area > > and not on its

Re: [RFE][PATCH] Display free space on device in panels

2006-05-31 Thread Jindrich Novy
Hi Pavel, On Tue, 2006-05-30 at 14:56 +0300, Pavel Tsekov wrote: > On Mon, 29 May 2006, Jindrich Novy wrote: > > > On Fri, 2006-05-19 at 14:29 -0400, Pavel Roskin wrote: > >> Can we avoid any highlighting? I think Far Manager does it right: > >> http://red-bean.com/proski/mc/far.png > > > > Att

Re: [RFE][PATCH] Display free space on device in panels

2006-05-30 Thread Pavel Tsekov
On Mon, 29 May 2006, Jindrich Novy wrote: On Fri, 2006-05-19 at 14:29 -0400, Pavel Roskin wrote: Can we avoid any highlighting? I think Far Manager does it right: http://red-bean.com/proski/mc/far.png Attaching the patch without highlighting. The main changes are that I moved the show_free_s

Re: [RFE][PATCH] Display free space on device in panels

2006-05-30 Thread Jindrich Novy
On Tue, 2006-05-30 at 11:36 +0300, Pavel Tsekov wrote: > Please, do not send patches generated against UTF8-ized version of MC. Ah, done that again. Attaching the cleanly applicable variant then. Jindrich -- Jindrich Novy <[EMAIL PROTECTED]> --- mc/src/screen.c.orig 2006-02-08 11:10:37.

Re: [RFE][PATCH] Display free space on device in panels

2006-05-30 Thread Pavel Tsekov
On Mon, 29 May 2006, Jindrich Novy wrote: Hi Pavel and Pavel, On Fri, 2006-05-19 at 14:29 -0400, Pavel Roskin wrote: Can we avoid any highlighting? I think Far Manager does it right: http://red-bean.com/proski/mc/far.png Attaching the patch without highlighting. The main changes are that I

Re: [RFE][PATCH] Display free space on device in panels

2006-05-29 Thread Jindrich Novy
Hi Pavel and Pavel, On Fri, 2006-05-19 at 14:29 -0400, Pavel Roskin wrote: > Can we avoid any highlighting? I think Far Manager does it right: > http://red-bean.com/proski/mc/far.png Attaching the patch without highlighting. The main changes are that I moved the show_free_space() into main.c sin

Re: [RFE][PATCH] Display free space on device in panels

2006-05-24 Thread Leonard den Ottolander
Hi, On Fri, 2006-05-19 at 21:08 +0200, Oswald Buddenhagen wrote: > yes, but i definitely prefer the totals above the mini-status. i think > that's what they had in earlier times, too. Maybe the free space could be an option *in* the mini status. To make people aware of this new option we could de

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Oswald Buddenhagen
On Fri, May 19, 2006 at 02:29:49PM -0400, Pavel Roskin wrote: > Hello! > > > I was originally inspired by the old czech m602 file manager: > > http://oldgame.legalne.net/big/images/Manazer-M602.00.120.jpg > > > > A bit more talky design was used in the DOS Navigator: > > http://www.dev0.de/pix/dn

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Pavel Roskin
Hello! > I was originally inspired by the old czech m602 file manager: > http://oldgame.legalne.net/big/images/Manazer-M602.00.120.jpg > > A bit more talky design was used in the DOS Navigator: > http://www.dev0.de/pix/dn151lfnbeta3.png Can we avoid any highlighting? I think Far Manager does it

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Leonard den Ottolander
Hi Jindrich, On Fri, 2006-05-19 at 17:16 +0200, Jindrich Novy wrote: > > > When it wouldn't be highlighted, you need > > > to look up at the panel title to be sure whether it's active since > > > the the highlighted widgets are on top of the panel. This may save > > > you one eye movement

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Jindrich Novy
Hi Pavel, On Fri, 2006-05-19 at 16:07 +0300, Pavel Tsekov wrote: > > 2) You are sure that you are looking at the correct free space in the > > panel you are working in. When it wouldn't be highlighted, you need > > to look up at the panel title to be sure whether it's active since > > the th

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Pavel Tsekov
On Fri, 19 May 2006, Jindrich Novy wrote: On Thu, 2006-05-18 at 23:42 +0200, Leonard den Ottolander wrote: On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: Btw if anyone on this list wants to share his thoughts on this patch - now is the time. Personally I don't like the highlighting o

Re: [RFE][PATCH] Display free space on device in panels

2006-05-19 Thread Jindrich Novy
Hi Leonard, On Thu, 2006-05-18 at 23:42 +0200, Leonard den Ottolander wrote: > On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: > > Btw if anyone on this list wants to share his thoughts on this patch - now > > is the time. > > Personally I don't like the highlighting of the free space ind

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Leonard den Ottolander
Hi Pavel, On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: > Btw if anyone on this list wants to share his thoughts on this patch - now > is the time. Personally I don't like the highlighting of the free space indicator. I find it rather distracting. It suffices that the top of the panel i

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Jindrich Novy
Hi Pavel, On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: > On Thu, 18 May 2006, Jindrich Novy wrote: > > > Yes, the patch can still be improved. I posted it here just to discuss > > the feature and whether upstream likes it. It's still not a commit > > candidate yet. > > Well, it seems t

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Pavel Tsekov
On Thu, 18 May 2006, Jindrich Novy wrote: Yes, the patch can still be improved. I posted it here just to discuss the feature and whether upstream likes it. It's still not a commit candidate yet. Well, it seems that this is a much desired feature... I've seen people requesting it at several dif

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Jindrich Novy
Hi Pavel, On Thu, 2006-05-18 at 12:11 +0300, Pavel Tsekov wrote: > Hello Jindrich, > > On Wed, 1 Feb 2006, Jindrich Novy wrote: > > > On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote: > >> thanks for your comments, attaching the patch better matching the mc > >> coding style. > > > > I mod

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Pavel Tsekov
On Wed, 1 Feb 2006, Jindrich Novy wrote: Hello, On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote: thanks for your comments, attaching the patch better matching the mc coding style. I modified the patch so that it can be switched on/off in the Options/Layout dialog to display free space

Re: [RFE][PATCH] Display free space on device in panels

2006-05-18 Thread Pavel Tsekov
Hello Jindrich, On Wed, 1 Feb 2006, Jindrich Novy wrote: On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote: thanks for your comments, attaching the patch better matching the mc coding style. I modified the patch so that it can be switched on/off in the Options/Layout dialog to display f

Re: [RFE][PATCH] Display free space on device in panels

2006-02-01 Thread Jindrich Novy
Hello, On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote: > thanks for your comments, attaching the patch better matching the mc > coding style. I modified the patch so that it can be switched on/off in the Options/Layout dialog to display free space on device. termshot(TM) is attached: ┌<─

Re: [RFE][PATCH] Display free space on device in panels

2006-01-02 Thread Jindrich Novy
Hello Roland, thanks for your comments, attaching the patch better matching the mc coding style. Jindrich -- Jindrich Novy <[EMAIL PROTECTED]>, http://people.redhat.com/jnovy/ (o_ _o) //\ The worst evil in the world is refusal to thi

Re: [RFE][PATCH] Display free space on device in panels

2005-12-31 Thread Roland Illig
Jindrich Novy wrote: > --- mc-4.6.1a/src/screen.c.showfree 2005-12-28 16:49:52.0 +0100 > +++ mc-4.6.1a/src/screen.c2005-12-28 17:14:45.0 +0100 > @@ -106,6 +107,12 @@ int filetype_mode = 1; > /* The hook list for the select file function */ > Hook *select_file_hook = 0; > >