cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, While investigating the recent bug report posted by Thomas Zajic regarding cons.saver I came across the following code: winsz.ws_col = winsz.ws_row = 0; if (ioctl (console_fd, TIOCGWINSZ, winsz) 0 || winsz.ws_col = 0 || winsz.ws_row = 0 || winsz.ws_col = 256 ||

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: Hello Pavel, On Fri, 2005-07-08 at 11:31, Pavel Tsekov wrote: winsz.ws_col = winsz.ws_row = 0; if (ioctl (console_fd, TIOCGWINSZ, winsz) 0 || winsz.ws_col = 0 || winsz.ws_row = 0 || winsz.ws_col = 256 ||

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hi Pavel, On Fri, 2005-07-08 at 15:20, Pavel Tsekov wrote: Well, currently the limit has been raised so it should be reflected here too. I think the limit used in mc is to restrict memory consumption and does not indicate a slang limit. Screens that can represent more than 512 x 512 characters

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: On Fri, 2005-07-08 at 15:20, Pavel Tsekov wrote: Well, currently the limit has been raised so it should be reflected here too. I think the limit used in mc is to restrict memory consumption and does not indicate a slang limit.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hello Pavel, On Fri, 2005-07-08 at 16:28, Pavel Tsekov wrote: The problem is this check does not happen when the screen (say xterm) is being resized so we need it here as well. I don't understand what you are talking about. cons.saver is used only in linux console and FreeBSD console.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: Hello Pavel, On Fri, 2005-07-08 at 16:28, Pavel Tsekov wrote: The problem is this check does not happen when the screen (say xterm) is being resized so we need it here as well. I don't understand what you are talking about.

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Pavel Tsekov
Hello, On Fri, 8 Jul 2005, Leonard den Ottolander wrote: On Fri, 2005-07-08 at 17:01, Pavel Tsekov wrote: It will crash (eventually) because of the slang limitation. Even with the check in console handler. As long as it doesn't write into unallocated memory mc will not crash. I Well, MC

Re: cons.saver limit on the maximum number of lines/columns

2005-07-08 Thread Leonard den Ottolander
Hello Pavel, On Fri, 2005-07-08 at 20:06, Pavel Tsekov wrote: Indeed this limit should be increased to 512, but as I've pointed out before that is sadly not a one place fix. Are you sure ? The limit should be set according to the slang version, not to a fixed 512. We should probably set