Hello Pavel,
On Mon, 2005-06-13 at 15:29, Pavel Tsekov wrote:
> I am posting a patch for review, comments, etc. This is a candidate for mc
> 4.6.1. I have another patch which is more intrusive and needs much more
> attention. I'll post later when I am sure it is clean enough - it
> will be candida
Hi Pavel,
On Wed, 2005-06-22 at 19:44, Leonard den Ottolander wrote:
> What I am concerned about is whether tests for panel->something can
> occur when running mcedit. Have you checked the code paths to make sure
> this will never happen?
Never mind this ;) . I was under the impression panel is a
On Wed, 2005-06-22 at 15:16, Pavel Tsekov wrote:
> No. The condition `edit_one_file != NULL' is valid only when you invoke
> the editor as mcedit (directly from the command line) and not from within
> the file manager i.e. pressing F4 on a file. I use `edit_one_file' to
> recognize the difference.
Hi Pavel,
On Wed, 2005-06-22 at 15:24, Pavel Tsekov wrote:
> Currently MC always has panels. I have a patch which changes this i.e.
> panels are instantiated only when they are needed i.e. MC is invoked as
> file manager. But this is something which should be discussed after the
> release.
What I
Hello,
On Wed, 22 Jun 2005, Leonard den Ottolander wrote:
> On Wed, 2005-06-22 at 13:51, Leonard den Ottolander wrote:
> > As an addendum to this, is there any code that tests !panel->something
> > that can be reached in case panel has not been assigned?
> >
> > $ grep -lr \!panel\-\> *
>
> Duh!
Hello,
On Wed, 22 Jun 2005, Leonard den Ottolander wrote:
> :) ). I haven't quite grasped the code path. If I understand your
> explanation correctly the first free takes place in clean_dir() and the
> second in mc_maybe_editor_or_viewer(). But after the free in clean_dir()
> fname gets assigned
On Wed, 2005-06-22 at 13:51, Leonard den Ottolander wrote:
> As an addendum to this, is there any code that tests !panel->something
> that can be reached in case panel has not been assigned?
>
> $ grep -lr \!panel\-\> *
Duh! The "!" is of course totally irrelevant. Any test for
panel->something f
On Wed, 2005-06-22 at 13:41, Leonard den Ottolander wrote:
> - Is the test in the fifth hunk of src/user.c correct? Not totally
> grasping that code, but as you test for (!panel) in the 6th hunk (fall
> through) I was wondering if the test there shouldn't read (panel &&
> !panel->marked).
As an ad
Hello Pavel,
I might need to get enlightened on how the double free actually takes
place. I can't reproduce the warning or crash you describe (FC1, still
:) ). I haven't quite grasped the code path. If I understand your
explanation correctly the first free takes place in clean_dir() and the
second
--- [ Leonard den Ottolander ] ===---
> Hi Pavel,
>> Why testing if the bugs are not fixed ?
> Now this is the kind of tone that I can't appreciate. It suggests that
> nobody is interested in mc but you. This of course is totally untrue.
> You confuse the fact that I haven't (taken) time to re
Hi Pavel,
On Wed, 2005-06-15 at 14:28, Pavel Tsekov wrote:
> If it is the "oh, boy" thing
> that upset you - I used that as expression of exclamation and I don't see
> anything personal in doing so. Certainly I don't call you names - this was
> not my intention at least.
Neither did I feel it as
Hello,
On Wed, 15 Jun 2005, Leonard den Ottolander wrote:
> On Tue, 2005-06-14 at 22:20, Pavel Tsekov wrote:
> > You are calling for security review but you are denying a patch
>
> Now *you* are assuming too much. I haven't denied your patch. I'm just
> inquiring if adding a single g_strdup() wou
Hi Pavel,
On Tue, 2005-06-14 at 22:20, Pavel Tsekov wrote:
> You are calling for security review but you are denying a patch
Now *you* are assuming too much. I haven't denied your patch. I'm just
inquiring if adding a single g_strdup() would fix the issue "for now".
And I wasn't calling for a se
Hello,
On Tue, 14 Jun 2005, Leonard den Ottolander wrote:
> Hi Pavel,
>
> On Tue, 2005-06-14 at 21:36, Pavel Tsekov wrote:
> > But let's not hold the patch for another couple of
> > days/weeks/months until someone finds out if it is exploitable or not.
>
> I've briefly glanced at it. Can't we jus
Hi Pavel,
On Tue, 2005-06-14 at 21:36, Pavel Tsekov wrote:
> But let's not hold the patch for another couple of
> days/weeks/months until someone finds out if it is exploitable or not.
I've briefly glanced at it. Can't we just add a g_strdup() for 4.6.1 and
work on your improved patch for post 4.
Hello,
On Tue, 14 Jun 2005, Leonard den Ottolander wrote:
> Hi Pavel,
>
> On Tue, 2005-06-14 at 16:51, Pavel Tsekov wrote:
> > > As you stated this was a serious issue I assumed you meant it to be
> > > exploitable.
> >
> > You've assumed too much. I never said that I think that this issue is
> >
Hi Pavel,
On Tue, 2005-06-14 at 16:51, Pavel Tsekov wrote:
> > As you stated this was a serious issue I assumed you meant it to be
> > exploitable.
>
> You've assumed too much. I never said that I think that this issue is
> exploitable.
Yes and no. But since you're remark left some room for inte
Hello,
On Tue, 14 Jun 2005, Leonard den Ottolander wrote:
> Hi Pavel,
>
> On Tue, 2005-06-14 at 07:09, Pavel Tsekov wrote:
> > > Have you reported this issue to mitre.org or bugtraq?
> >
> > Nope. I didn't knew that I should do. Can you do that ?
>
> As you stated this was a serious issue I assum
Hi Pavel,
On Tue, 2005-06-14 at 07:09, Pavel Tsekov wrote:
> > Have you reported this issue to mitre.org or bugtraq?
>
> Nope. I didn't knew that I should do. Can you do that ?
As you stated this was a serious issue I assumed you meant it to be
exploitable.
I have never reported such issues to
Hello,
On Mon, 13 Jun 2005, Leonard den Ottolander wrote:
> Hi Pavel,
>
> On Mon, 2005-06-13 at 08:42, Pavel Tsekov wrote:
> > > > current_panel->dir.list[0].fname = (char *) file;
> > > > ^
> > >
> > > Will a g_strdup() suffice?
> >
> > Yes
Hi Pavel,
On Mon, 2005-06-13 at 08:42, Pavel Tsekov wrote:
> > > current_panel->dir.list[0].fname = (char *) file;
> > > ^
> >
> > Will a g_strdup() suffice?
>
> Yes, but it is not a long term solution.
Have you reported this issue to mitre
Hello,
On Mon, 13 Jun 2005, Pavel Tsekov wrote:
> Hello,
>
> On Sun, 12 Jun 2005, Leonard den Ottolander wrote:
>
> > Hi Pavel,
> >
> > On Sun, 2005-06-12 at 19:49, Pavel Tsekov wrote:
> > > current_panel->dir.list[0].fname = (char *) file;
> > > ^^
Hello,
On Sun, 12 Jun 2005, Leonard den Ottolander wrote:
> Hi Pavel,
>
> On Sun, 2005-06-12 at 19:49, Pavel Tsekov wrote:
> > current_panel->dir.list[0].fname = (char *) file;
> > ^
>
> Will a g_strdup() suffice?
Yes, but it is not a long
Hi Pavel,
On Sun, 2005-06-12 at 19:49, Pavel Tsekov wrote:
> current_panel->dir.list[0].fname = (char *) file;
> ^
Will a g_strdup() suffice?
Leonard.
--
mount -t life -o ro /dev/dna /genetic/research
___
Hello,
On Fri, 10 Jun 2005, Pavel Tsekov wrote:
> Hello,
>
> On Fri, 10 Jun 2005, [iso-8859-2] Krzysztof Dulęba wrote:
>
> > Hi
> >
> > For a few months now I've been suffering from mcedit internal error. Every
> > once in a while, without any reason, mcedit stackdumps during exit
> > procedure (
25 matches
Mail list logo
