Re: New patchfs script

2002-12-11 Thread Andrew V. Samoilov
Adam Byrtek 'alpha' wrote: On Wed, Dec 11, 2002 at 04:42:35PM +0200, Andrew V. Samoilov wrote: I applied little patch for your patchfs to quote metacharacters in Agreed. . . . >>-copyout ($ARGV[2], $ARGV[3]); >>+copyout ($ARGV[2], quotemeta ($ARGV[3])); > > > The second chunk i

Re: New patchfs script

2002-12-11 Thread Adam Byrtek 'alpha'
On Wed, Dec 11, 2002 at 03:59:47PM +0100, Adam Byrtek 'alpha' wrote: > > And it is reasonable to search and substitute perl in patchfs, a and > > uzip scripts, but this is another story. > > Could be quite hard... i see no popular alternatives. Sorry, I didn't understand you right. I was thinkin

Re: New patchfs script

2002-12-11 Thread Andrew V. Samoilov
Hi, Adam! Adam Byrtek 'alpha' wrote: On Wed, Dec 11, 2002 at 12:03:18PM -0500, Pavel Roskin wrote: I suggest that we select the shorter filename unless it's /dev/null. Usually the longer filename has ".orig" or ".new" is it. Also it would be nice to add ".diff" to all filenames. It would forc

Re: New patchfs script

2002-12-11 Thread Adam Byrtek 'alpha'
On Wed, Dec 11, 2002 at 12:03:18PM -0500, Pavel Roskin wrote: > I suggest that we select the shorter filename unless it's /dev/null. > Usually the longer filename has ".orig" or ".new" is it. > > Also it would be nice to add ".diff" to all filenames. It would force > correct syntax highlighting i

Re: New patchfs script

2002-12-11 Thread Pavel Roskin
Hello! > I applied little patch for your patchfs to quote metacharacters in > filename before giving it to shell. Also I want to eliminate temporary > file in copyout() and teach patchfs to understand context diffs (diff > -c). Another good change should be to use +++ filename for newly created >

Re: New patchfs script

2002-12-11 Thread Adam Byrtek 'alpha'
On Wed, Dec 11, 2002 at 04:42:35PM +0200, Andrew V. Samoilov wrote: > -copyout ($ARGV[2], $ARGV[3]); > +copyout ($ARGV[2], quotemeta ($ARGV[3])); The second chunk is invalid. $ARGV[3] is used only for 'open', and it doesn't need quoting: bash-2.05b$ perl -we 'open TMP, ">". quotemeta("Q|Q

Re: New patchfs script

2002-12-11 Thread Adam Byrtek 'alpha'
On Wed, Dec 11, 2002 at 04:42:35PM +0200, Andrew V. Samoilov wrote: > I applied little patch for your patchfs to quote metacharacters in Agreed. > Also I want to eliminate temporary file in copyout() It's necessary with this algorithm - you can't do 'seek' on a pipe. The temporary file is creat

Re: New patchfs script

2002-12-11 Thread Andrew V. Samoilov
Hi, Adam! Adam Byrtek 'alpha' wrote: On Mon, Dec 09, 2002 at 12:16:42PM -0500, Pavel Roskin wrote: I hope to put your script on CVS today and I'm ready to make fixes myself, but I just want to give you are chance to do it right. Updated version attached. It works in reasonable time, even with

Re: New patchfs script

2002-12-10 Thread Pavel Roskin
Hello! > On Mon, Dec 09, 2002 at 03:42:52PM -0500, Pavel Roskin wrote: > > Yes, I think some of the VFSs need to be given more visibility, possibly > > in the menu or maybe in some predefined hotlist. > > Menu with 'subcategories' (like hotlist now) would be nice. This is supported in the hotlist

Re: New patchfs script

2002-12-10 Thread Adam Byrtek 'alpha'
On Mon, Dec 09, 2002 at 03:42:52PM -0500, Pavel Roskin wrote: > Yes, I think some of the VFSs need to be given more visibility, possibly > in the menu or maybe in some predefined hotlist. Menu with 'subcategories' (like hotlist now) would be nice. > That would be mc-4.6.0-pre2. I don't have any

Re: New patchfs script

2002-12-09 Thread Pavel Roskin
Hello! > Updated version attached. It works in reasonable time, even with kernel > patches. It supports file size and date parsing. All warnings fixed. Applied! Thank you! By the way, you are showing a good example to somebody else in this mailing list :-) > I considered some 'run' virtual met

Re: New patchfs script

2002-12-09 Thread Adam Byrtek 'alpha'
On Mon, Dec 09, 2002 at 12:16:42PM -0500, Pavel Roskin wrote: > I hope to put your script on CVS today and I'm ready to make fixes myself, > but I just want to give you are chance to do it right. Updated version attached. It works in reasonable time, even with kernel patches. It supports file size

Re: New patchfs script

2002-12-09 Thread Adam Byrtek 'alpha'
On Mon, Dec 09, 2002 at 12:16:42PM -0500, Pavel Roskin wrote: > Please use "-w" (see the first line in uzip). There are some warnings > with copyout. Ok. This warning wasn't important at all, but I'll fix it. > Also, the size of the files is still 0: Yes, I have to rewrite whole code to make 's

Re: New patchfs script

2002-12-09 Thread Pavel Roskin
Hello! > Hi. I've rewiten patchfs in Perl - now it can properly handle all > patches in unified diff format (the most common format for patches). Thank you! > Methods supported: list, copyout Please use "-w" (see the first line in uzip). There are some warnings with copyout. Also, the size of

New patchfs script

2002-12-09 Thread Adam Byrtek 'alpha'
Hi. I've rewiten patchfs in Perl - now it can properly handle all patches in unified diff format (the most common format for patches). Methods supported: list, copyout The algorithm isn't too fast (yet), but I think it's quite usable, especialy for smaller patches. When I've tested it on 27MB ker

Re: [PATCH] new patchfs

2002-10-26 Thread Pavel Roskin
Quoting Padraig Brady <[EMAIL PROTECTED]>: > I checked that the replacement was OK. Anyway the patch is attached. Why did you remove "paths to used programs"? Just because you replace the file on CVS and use "cvs diff" it doesn't make your patch safe. You should make sure that it only contains th

[PATCH] new patchfs

2002-10-26 Thread Padraig Brady
On Fri, 25 Oct 2002, Pavel Roskin wrote: > > On Fri, 25 Oct 2002, Padraig Brady wrote: > > > > Personally I think the attached is much better than the origonal > > (details in comments at top) > > Please send a patch against the CVS version, which can be found here: > http://cvs.gnome.org/lxr/sour

Re: new patchfs

2002-10-25 Thread Pavel Roskin
Hello! On Fri, 25 Oct 2002, Padraig Brady wrote: > Personally I think the attached is much better than the origonal > (details in comments at top) Please send a patch against the CVS version, which can be found here: http://cvs.gnome.org/lxr/source/mc/vfs/extfs/patchfs?raw=1 It seems from your

new patchfs

2002-10-25 Thread Padraig Brady
Personally I think the attached is much better than the origonal (details in comments at top) Also it would be nice to add: regex/\.(patch|diff)\.*(gz|bz2)*$ Open=%cd %p#patchfs in the default bindings file (just above ### Archives ###) Also s/lynx/links/ seems appropriate in the defaul