Re: patchfs, audio update

2002-12-19 Thread Andrew V. Samoilov
Pavel Roskin wrote: Hello! Well, but some quoting (and security) issues fixed in the CVS just now. Patch attached. BTW, new incarnation reports wrong patch sizes for gzipped patches. Just for your information. Size is not very critical after I disabled fast loading on non-local VFS in the

Re: patchfs, audio update

2002-12-19 Thread Adam Byrtek 'alpha'
On Thu, Dec 19, 2002 at 05:40:08PM +0200, Andrew V. Samoilov wrote: We trust you, but sometimes you misunderstand us. Sorry, maybe I used the wrong word once more. I apologize if it sounded that way. But the main problem was that everything works fine for me, so I was confused and did not know

Re: patchfs, audio update

2002-12-18 Thread Andrew V. Samoilov
Adam Byrtek 'alpha' wrote: On Fri, Dec 13, 2002 at 07:09:27PM +0200, Andrew V. Samoilov wrote: Perfect and very impressive! Power perl skills! Thank you very much :) I do not enforce you to implement context format. But it will be some regressive and on other hand some projects (Samba as

Re: patchfs, audio update

2002-12-18 Thread Adam Byrtek 'alpha'
On Wed, Dec 18, 2002 at 07:45:29PM +0200, Andrew V. Samoilov wrote: Well, but some quoting (and security) issues fixed in the CVS just now. Patch attached. Looks good, thanks. I need to be more careful when it comes to quoting... looks like I forget about this too often. BTW, new incarnation

Re: patchfs, audio update

2002-12-18 Thread Pavel Roskin
Hello! Well, but some quoting (and security) issues fixed in the CVS just now. Patch attached. BTW, new incarnation reports wrong patch sizes for gzipped patches. Just for your information. Size is not very critical after I disabled fast loading on non-local VFS in the editor. You can open

Re: patchfs, audio update

2002-12-18 Thread Andrew V. Samoilov
BTW, new incarnation reports wrong patch sizes for gzipped patches. I'll examine this when I have more time. Regards You can use ideas from attached file. I eliminated all tell() call and calculate position itself by adding current line length to some variable. Patched patchfs list

Re: patchfs, audio update

2002-12-18 Thread Adam Byrtek 'alpha'
On Wed, Dec 18, 2002 at 09:26:05PM +0200, Andrew V. Samoilov wrote: You can use ideas from attached file. I eliminated all tell() call and calculate position itself by adding current line length to some This wasn't necessary at all. The problem was somewhere else: patchfs treated empty

Re: patchfs, audio update

2002-12-18 Thread Pavel Roskin
Hello! This wasn't necessary at all. The problem was somewhere else: patchfs treated empty line as the diff boundary, so the size was broken. The fix was really simple. Sorry, I don't understand why an empty line is not a diff boundary. It's not valid in diff, as far as I know. Pavel,

Re: patchfs, audio update

2002-12-18 Thread Adam Byrtek 'alpha'
On Wed, Dec 18, 2002 at 06:45:42PM -0500, Pavel Roskin wrote: Sorry, I don't understand why an empty line is not a diff boundary. It's not valid in diff, as far as I know. Yes, it is not a valid diff. Valid diff puts: ' \n' (space and a newline) But Andrew gave me a link to a www mailing list

Re: patchfs, audio update

2002-12-13 Thread Adam Byrtek 'alpha'
On Fri, Dec 13, 2002 at 12:21:57AM -0500, Pavel Roskin wrote: My fault for not reading your patch :-( My fault for not reading MY patch carefuly :) I suggest that you use cvs diff to generate diffs. I used cvs, but I didn't notice this small change. Regards -- _.|._ |_ _.: Adam

Re: patchfs, audio update

2002-12-13 Thread Andrew V. Samoilov
Adam Byrtek 'alpha' wrote: 2002-12-13 Adam Byrtek [EMAIL PROTECTED] * extfs/patchfs.in: Copyin method added (with compressed files support). Files inside archive now have '.diff' extension. Temporary file not needed any more. Proper handling of /dev/null

Re: patchfs, audio update

2002-12-12 Thread Adam Byrtek 'alpha'
Forgotten about perl year issue. Sorry, sorry. Attached. -- _.|._ |_ _.: Adam Byrtek, alpha@(irc.pl|debian.org) (_|||_)| |(_|: gg 1802819, pgp 0xB25952C0 |: jid alpha.jabberpl.org --- extfs.orig/patchfs.in 2002-12-13 03:13:30.0 +0100 +++

Re: patchfs, audio update

2002-12-12 Thread Pavel Roskin
Hello! Changelog entry attached in patch as Pavel requested. Excellent! Applied. Pavel: I suggest that we select the shorter filename unless it's /dev/null. Usually the longer filename has .orig or .new is it. Had some problems with this solution, so I've looked up official

Re: patchfs, audio update

2002-12-12 Thread Pavel Roskin
On Fri, 13 Dec 2002, Adam Byrtek 'alpha' wrote: Forgotten about perl year issue. Sorry, sorry. Attached. OK. Not only that, but I also missed that you reverted another useful change (set current date, not year 1970, on patches if the date cannot be parsed): -return timef(time); +