[MediaWiki-commits] [Gerrit] Don't use sudo -u apache for dumpwikidatajson.sh - change (operations/puppet)

2014-07-21 Thread ArielGlenn (Code Review)
ArielGlenn has submitted this change and it was merged. Change subject: Don't use sudo -u apache for dumpwikidatajson.sh .. Don't use sudo -u apache for dumpwikidatajson.sh I can't really test this, but I guess datasets can't s

[MediaWiki-commits] [Gerrit] Turn stubthreshold back into a combo box - change (mediawiki/core)

2014-07-21 Thread TTO (Code Review)
TTO has uploaded a new change for review. https://gerrit.wikimedia.org/r/148022 Change subject: Turn stubthreshold back into a combo box .. Turn stubthreshold back into a combo box Currrently it's an insanely tall list box. A

[MediaWiki-commits] [Gerrit] Restored compatiblity to mw 1.22 - change (mediawiki...BlueSpiceFoundation)

2014-07-21 Thread Swidmann (Code Review)
Swidmann has uploaded a new change for review. https://gerrit.wikimedia.org/r/148023 Change subject: Restored compatiblity to mw 1.22 .. Restored compatiblity to mw 1.22 commented out getAfterPortlet to provide compatibility

[MediaWiki-commits] [Gerrit] Track loading time for MediaViewer and the file page - change (analytics...config)

2014-07-21 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/148024 Change subject: Track loading time for MediaViewer and the file page .. Track loading time for MediaViewer and the file page Change-Id: I

[MediaWiki-commits] [Gerrit] Correct reference to userCan hook - change (mediawiki...BlueSpiceFoundation)

2014-07-21 Thread Smuggli (Code Review)
Smuggli has submitted this change and it was merged. Change subject: Correct reference to userCan hook .. Correct reference to userCan hook That hook has been moved to Title::checkPermissionHooks() and Title::userCanRead() is n

[MediaWiki-commits] [Gerrit] Add ability to add pages to spamlist view - change (mediawiki...MassMessage)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add ability to add pages to spamlist view .. Add ability to add pages to spamlist view Also change some Html::rawElement to Html::element and mw.msg to mw

[MediaWiki-commits] [Gerrit] Rename rawActionViewBeforeOutput hook to rawPageViewBeforeOu... - change (mediawiki...XMLContentExtension)

2014-07-21 Thread Withoutaname (Code Review)
Withoutaname has uploaded a new change for review. https://gerrit.wikimedia.org/r/148025 Change subject: Rename rawActionViewBeforeOutput hook to rawPageViewBeforeOutput .. Rename rawActionViewBeforeOutput hook to rawPageViewB

[MediaWiki-commits] [Gerrit] Remove deprecated Title::userCanRead() - change (mediawiki/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove deprecated Title::userCanRead() .. Remove deprecated Title::userCanRead() Change-Id: I574babf4534c849d1e1491724ea537d53ea1d1d5 --- M RELEASE-NOTES-

[MediaWiki-commits] [Gerrit] Revert "Generalize Installer::showStatusMessage()" - change (mediawiki/core)

2014-07-21 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/148026 Change subject: Revert "Generalize Installer::showStatusMessage()" .. Revert "Generalize Installer::showStatusMessage()" We probably want to

[MediaWiki-commits] [Gerrit] Don't try to pass non Title objects into RequestContext::set... - change (mediawiki...AbuseFilter)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Don't try to pass non Title objects into RequestContext::setTitle .. Don't try to pass non Title objects into RequestContext::setTitle That will cause a

[MediaWiki-commits] [Gerrit] Don't try to pass non Title objects into RequestContext::set... - change (mediawiki...AbuseFilter)

2014-07-21 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/148027 Change subject: Don't try to pass non Title objects into RequestContext::setTitle .. Don't try to pass non Title objects into RequestContext:

[MediaWiki-commits] [Gerrit] Add base interface for setters in RequestContext and Derivat... - change (mediawiki/core)

2014-07-21 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/148028 Change subject: Add base interface for setters in RequestContext and DerivativeContext .. Add base interface for setters in RequestContext an

[MediaWiki-commits] [Gerrit] Enable FlaggedRevs on Module namespace on ukwiki - change (operations/mediawiki-config)

2014-07-21 Thread Odder (Code Review)
Odder has uploaded a new change for review. https://gerrit.wikimedia.org/r/148029 Change subject: Enable FlaggedRevs on Module namespace on ukwiki .. Enable FlaggedRevs on Module namespace on ukwiki Doing just that. See bug f

[MediaWiki-commits] [Gerrit] Add 1 more runner per job runner server - change (operations/puppet)

2014-07-21 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has submitted this change and it was merged. Change subject: Add 1 more runner per job runner server .. Add 1 more runner per job runner server * This adds a little more headroom Change-Id: I9ca67f446d4fb32d4

[MediaWiki-commits] [Gerrit] Set $wgUploadNavigationUrl for plwikisource - change (operations/mediawiki-config)

2014-07-21 Thread Odder (Code Review)
Odder has uploaded a new change for review. https://gerrit.wikimedia.org/r/148030 Change subject: Set $wgUploadNavigationUrl for plwikisource .. Set $wgUploadNavigationUrl for plwikisource So as to direct future uploads to Co

[MediaWiki-commits] [Gerrit] Always return bool in BackupReader::handleUpload - change (mediawiki/core)

2014-07-21 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/148031 Change subject: Always return bool in BackupReader::handleUpload .. Always return bool in BackupReader::handleUpload Change-Id: I476a16

[MediaWiki-commits] [Gerrit] Set $wgForceUIMsgAsContentMsg for zhwikivoyage - change (operations/mediawiki-config)

2014-07-21 Thread Odder (Code Review)
Odder has uploaded a new change for review. https://gerrit.wikimedia.org/r/148032 Change subject: Set $wgForceUIMsgAsContentMsg for zhwikivoyage .. Set $wgForceUIMsgAsContentMsg for zhwikivoyage So as to allow translation of

[MediaWiki-commits] [Gerrit] Use dfs.blocksize instead of deprecated dfs.block.size - change (operations...cdh)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148033 to review the following change. Change subject: Use dfs.blocksize instead of deprecated dfs.block.size .. Use dfs.blocks

[MediaWiki-commits] [Gerrit] Remove mixed void/non-void returns in MysqlUpdater - change (mediawiki/core)

2014-07-21 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/148034 Change subject: Remove mixed void/non-void returns in MysqlUpdater .. Remove mixed void/non-void returns in MysqlUpdater Change-Id: Iee

[MediaWiki-commits] [Gerrit] Increase the number of parsoid job runners - change (operations/puppet)

2014-07-21 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has submitted this change and it was merged. Change subject: Increase the number of parsoid job runners .. Increase the number of parsoid job runners Change-Id: I454f9ae8780e20f0db45dc8bbec03af6ce1b9d47 --- M

[MediaWiki-commits] [Gerrit] ldap: qualify vars - change (operations/puppet)

2014-07-21 Thread Matanya (Code Review)
Matanya has uploaded a new change for review. https://gerrit.wikimedia.org/r/148035 Change subject: ldap: qualify vars .. ldap: qualify vars Change-Id: Ic90146c2cd86a1fb25750f19199dbb73019b4f7b --- M modules/ldap/templates/ba

[MediaWiki-commits] [Gerrit] beta: rename memcached object cache - change (operations/mediawiki-config)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148036 Change subject: beta: rename memcached object cache .. beta: rename memcached object cache In production 'memcached-pecl' is referenced from C

[MediaWiki-commits] [Gerrit] beta: rename memcached object cache - change (operations/mediawiki-config)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: beta: rename memcached object cache .. beta: rename memcached object cache In production 'memcached-pecl' is referenced from CommonSettings.php for the 'm

[MediaWiki-commits] [Gerrit] Remove return from MaintenanceFixup::outputChanneled - change (mediawiki/core)

2014-07-21 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/148037 Change subject: Remove return from MaintenanceFixup::outputChanneled .. Remove return from MaintenanceFixup::outputChanneled Parent Mai

[MediaWiki-commits] [Gerrit] Fix typo with scalac/scala in b918cc9e2 - change (operations...kafka)

2014-07-21 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/148038 Change subject: Fix typo with scalac/scala in b918cc9e2 .. Fix typo with scalac/scala in b918cc9e2 scalac is the dependent binary

[MediaWiki-commits] [Gerrit] beta: fix sessions memcache - change (operations/mediawiki-config)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148039 Change subject: beta: fix sessions memcache .. beta: fix sessions memcache Previous patch ended up sessions being pointed to an invalid object

[MediaWiki-commits] [Gerrit] beta: fix sessions memcache - change (operations/mediawiki-config)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: beta: fix sessions memcache .. beta: fix sessions memcache Previous patch ended up sessions being pointed to an invalid objectcache. Just use memcached-p

[MediaWiki-commits] [Gerrit] mediawiki: extract nutcracker to its own manifest - change (operations/puppet)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148041 Change subject: mediawiki: extract nutcracker to its own manifest .. mediawiki: extract nutcracker to its own manifest On beta, we need to be

[MediaWiki-commits] [Gerrit] beta: configure nutcracker on bastion - change (operations/puppet)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148042 Change subject: beta: configure nutcracker on bastion .. beta: configure nutcracker on bastion Change-Id: Ia71a41439989e9ea35eaa08f6a52f48b996

[MediaWiki-commits] [Gerrit] nutcracker: set service dependency - change (operations/puppet)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148043 Change subject: nutcracker: set service dependency .. nutcracker: set service dependency When install nutcracker on a new server, puppet attem

[MediaWiki-commits] [Gerrit] nutcracker: set service dependency - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: nutcracker: set service dependency .. nutcracker: set service dependency When install nutcracker on a new server, puppet attempted to start the ser

[MediaWiki-commits] [Gerrit] Uses multiple templates, fixed inheritance - change (mediawiki...Citoid)

2014-07-21 Thread Mvolz (Code Review)
Mvolz has submitted this change and it was merged. Change subject: Uses multiple templates, fixed inheritance .. Uses multiple templates, fixed inheritance *Now uses multiple citation templates (hard-coded in for wikipedia) *A

[MediaWiki-commits] [Gerrit] Now uses action instead of button to insert - change (mediawiki...Citoid)

2014-07-21 Thread Mvolz (Code Review)
Mvolz has uploaded a new change for review. https://gerrit.wikimedia.org/r/148044 Change subject: Now uses action instead of button to insert .. Now uses action instead of button to insert *Uses "insert citation" action to in

[MediaWiki-commits] [Gerrit] Remove unneeded CSS rule - change (mediawiki...Translate)

2014-07-21 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/148045 Change subject: Remove unneeded CSS rule .. Remove unneeded CSS rule Change-Id: Ieb6acf127e3827c43454c12bf90680a6d0a1bc57 --- M resources/css

[MediaWiki-commits] [Gerrit] Get rid of deprecated HHVM module - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: Get rid of deprecated HHVM module .. Get rid of deprecated HHVM module This module set up a test environment with Facebook's HHVM packages and the

[MediaWiki-commits] [Gerrit] Remove unneded prefixed CSS rules - change (mediawiki...Wikibase)

2014-07-21 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/148046 Change subject: Remove unneded prefixed CSS rules .. Remove unneded prefixed CSS rules o-isolate and ms-isolate are not actually used anywher

[MediaWiki-commits] [Gerrit] Remove inline colors from within tables - change (apps...wikipedia)

2014-07-21 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/148047 Change subject: Remove inline colors from within tables .. Remove inline colors from within tables Change-Id: Ie14ea00b01bb8d9ef48f03e897f2

[MediaWiki-commits] [Gerrit] reprepro: stop importing Facebook's HHVM packages - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: reprepro: stop importing Facebook's HHVM packages .. reprepro: stop importing Facebook's HHVM packages We don't use them; we have our own. This was

[MediaWiki-commits] [Gerrit] Another user-agent related fixup - change (pywikibot/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Another user-agent related fixup .. Another user-agent related fixup config2 was previously able to be run under python3. This fixes a recent commit which

[MediaWiki-commits] [Gerrit] [BrowserTest] Added @login tag to language screenshot feature - change (mediawiki...VisualEditor)

2014-07-21 Thread Vikassy (Code Review)
Vikassy has uploaded a new change for review. https://gerrit.wikimedia.org/r/148048 Change subject: [BrowserTest] Added @login tag to language screenshot feature .. [BrowserTest] Added @login tag to language screenshot feature

[MediaWiki-commits] [Gerrit] Move the section alignment code to a jquery plugin - change (mediawiki...ContentTranslation)

2014-07-21 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/148049 Change subject: Move the section alignment code to a jquery plugin .. Move the section alignment code to a jquery plugin ...and to a differe

[MediaWiki-commits] [Gerrit] Add an integration test for UpdateRepoOnMoveJob - change (mediawiki...Wikibase)

2014-07-21 Thread Hoo man (Code Review)
Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/148050 Change subject: Add an integration test for UpdateRepoOnMoveJob .. Add an integration test for UpdateRepoOnMoveJob Change-Id: I2bb856f383662d

[MediaWiki-commits] [Gerrit] Compatibility for custom articlepath - change (mediawiki...GoogleLogin)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Compatibility for custom articlepath .. Compatibility for custom articlepath If a custom articlepath is set (e.g. $wgScript?title=$1) subpages won't work,

[MediaWiki-commits] [Gerrit] Fixed fatal undefined SpecialGoogleLogin::getHost - change (mediawiki...GoogleLogin)

2014-07-21 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/148051 Change subject: Fixed fatal undefined SpecialGoogleLogin::getHost .. Fixed fatal undefined SpecialGoogleLogin::getHost getHost m

[MediaWiki-commits] [Gerrit] Remove the old section id clean up code - change (mediawiki...ContentTranslation)

2014-07-21 Thread Santhosh (Code Review)
Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/148052 Change subject: Remove the old section id clean up code .. Remove the old section id clean up code Now that we have new segmenter in place a

[MediaWiki-commits] [Gerrit] Added COPYING file to clearly state GPL2 for the extension. - change (mediawiki...MwEmbedSupport)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Added COPYING file to clearly state GPL2 for the extension. .. Added COPYING file to clearly state GPL2 for the extension. Change-Id: Idda2894e1681272dd4d

[MediaWiki-commits] [Gerrit] Updated README - change (mediawiki...GoogleLogin)

2014-07-21 Thread Florianschmidtwelzow (Code Review)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/148054 Change subject: Updated README .. Updated README Change-Id: Idfbae56cc7534df570a2175ef02de264a9aeda7c --- M README.md 1 file cha

[MediaWiki-commits] [Gerrit] Add documentation for config.password_file - change (pywikibot/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add documentation for config.password_file .. Add documentation for config.password_file The documentation in config2.py in password_file referred the use

[MediaWiki-commits] [Gerrit] PEP257 fixes - change (pywikibot/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: PEP257 fixes .. PEP257 fixes Change-Id: I37852eb6d9010051dfaeee99eb064417c26e4832 --- M pywikibot/config2.py 1 file changed, 17 insertions(+), 1 deletion(

[MediaWiki-commits] [Gerrit] Implementes changes for translatewiki - change (mediawiki...BlueSpiceExtensions)

2014-07-21 Thread Smuggli (Code Review)
Smuggli has uploaded a new change for review. https://gerrit.wikimedia.org/r/148055 Change subject: Implementes changes for translatewiki .. Implementes changes for translatewiki Moved php i18n file into languages folder Move

[MediaWiki-commits] [Gerrit] Remove unneeded prefixed CSS rules - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unneeded prefixed CSS rules .. Remove unneeded prefixed CSS rules o-isolate and ms-isolate are not actually used anywhere on the web, so there's no

[MediaWiki-commits] [Gerrit] Use native focus - change (VisualEditor/VisualEditor)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148056 Change subject: Use native focus .. Use native focus It's faster. Change-Id: I633ee7d2de49ed60ceb00cf11d27c5481fadc4c3 --- M modules/ve/ce/

[MediaWiki-commits] [Gerrit] Use native focus - change (mediawiki...VisualEditor)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148057 Change subject: Use native focus .. Use native focus It's faster. Change-Id: I0a8a2452aa987e2b93c5c8ba3c6efa2bcafbaa86 --- M modules/ve-mw/

[MediaWiki-commits] [Gerrit] For xcf files, compose layers before scaling - change (mediawiki/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: For xcf files, compose layers before scaling .. For xcf files, compose layers before scaling Otherwise if some layers are a different size than the overal

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: aa5c6e9..365453f - change (mediawiki/extensions)

2014-07-21 Thread Jenkins-mwext-sync (Code Review)
Jenkins-mwext-sync has uploaded a new change for review. https://gerrit.wikimedia.org/r/148058 Change subject: Syncronize VisualEditor: aa5c6e9..365453f .. Syncronize VisualEditor: aa5c6e9..365453f Change-Id: Ifc049bea63143aa

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: aa5c6e9..365453f - change (mediawiki/extensions)

2014-07-21 Thread Jenkins-mwext-sync (Code Review)
Jenkins-mwext-sync has submitted this change and it was merged. Change subject: Syncronize VisualEditor: aa5c6e9..365453f .. Syncronize VisualEditor: aa5c6e9..365453f Change-Id: Ifc049bea63143aa8f0dd9f660133b42002a9504f --- M V

[MediaWiki-commits] [Gerrit] Pass jshint - change (mediawiki...OATHAuth)

2014-07-21 Thread Hashar (Code Review)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/148059 Change subject: Pass jshint .. Pass jshint Ignore third party file modules/qrcode.js Fix the few other errors: modules/jquery.qrcode.js: lin

[MediaWiki-commits] [Gerrit] [BrowserTest] Added @login tag to language screenshot feature - change (mediawiki...VisualEditor)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Added @login tag to language screenshot feature .. [BrowserTest] Added @login tag to language screenshot feature Change-Id: I31f58d4321d8dd2

[MediaWiki-commits] [Gerrit] Added @embed statement for resourceloader - change (mediawiki...BlueSpiceExtensions)

2014-07-21 Thread Smuggli (Code Review)
Smuggli has uploaded a new change for review. https://gerrit.wikimedia.org/r/148060 Change subject: Added @embed statement for resourceloader .. Added @embed statement for resourceloader embed statement was missing for one im

[MediaWiki-commits] [Gerrit] Use native focus - change (oojs/ui)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148061 Change subject: Use native focus .. Use native focus It's faster Change-Id: I27a7926a21dd81fec8bd398e6f4afbe05e06dd6d --- M demos/demo.js M

[MediaWiki-commits] [Gerrit] Fixed spacing - change (mediawiki/core)

2014-07-21 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/148062 Change subject: Fixed spacing .. Fixed spacing - Removed spaces after not operator (!) - Removed spaces inside array index - use tab as

[MediaWiki-commits] [Gerrit] Fix reference dialog focus - change (mediawiki...VisualEditor)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148063 Change subject: Fix reference dialog focus .. Fix reference dialog focus Wasn't migrated to processes. Change-Id: Idb5f614c172378aad5d37bf8

[MediaWiki-commits] [Gerrit] Add an integration test for UpdateRepoOnMoveJob - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add an integration test for UpdateRepoOnMoveJob .. Add an integration test for UpdateRepoOnMoveJob Change-Id: I2bb856f383662d352865ff5b391a1e6de469dbb4 --

[MediaWiki-commits] [Gerrit] Rename and move PropertyParserFunction code to own namespace - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Rename and move PropertyParserFunction code to own namespace .. Rename and move PropertyParserFunction code to own namespace Change-Id: Ia662448641bfe5c42

[MediaWiki-commits] [Gerrit] Move more parser function rendering code to Renderer - change (mediawiki...Wikibase)

2014-07-21 Thread Aude (Code Review)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/148064 Change subject: Move more parser function rendering code to Renderer .. Move more parser function rendering code to Renderer Change-Id: I7d86cce

[MediaWiki-commits] [Gerrit] beta: Add mediawiki/core/vendor to beta - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: beta: Add mediawiki/core/vendor to beta .. beta: Add mediawiki/core/vendor to beta Ensure that the initial clone of mediawiki/core/vendor is presen

[MediaWiki-commits] [Gerrit] mediawiki::multimedia: on trusty, install libvips37 rather t... - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: mediawiki::multimedia: on trusty, install libvips37 rather than libvips15 .. mediawiki::multimedia: on trusty, install libvips37 rather than libvip

[MediaWiki-commits] [Gerrit] Refactor ChangeNotifiers and weird "channel" concept - change (mediawiki...Wikibase)

2014-07-21 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/148065 Change subject: Refactor ChangeNotifiers and weird "channel" concept .. Refactor ChangeNotifiers and weird "channel" concept Thi

[MediaWiki-commits] [Gerrit] Remove unused constructor params from parser function Runner - change (mediawiki...Wikibase)

2014-07-21 Thread Aude (Code Review)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/148066 Change subject: Remove unused constructor params from parser function Runner .. Remove unused constructor params from parser function Runner Cha

[MediaWiki-commits] [Gerrit] Do not run `navigator.getUserMedia()` when not supported - change (mediawiki...PronunciationRecording)

2014-07-21 Thread Rillke (Code Review)
Rillke has uploaded a new change for review. https://gerrit.wikimedia.org/r/148067 Change subject: Do not run `navigator.getUserMedia()` when not supported .. Do not run `navigator.getUserMedia()` when not supported The old c

[MediaWiki-commits] [Gerrit] Move parser function code for site link lookup out of static... - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move parser function code for site link lookup out of static method .. Move parser function code for site link lookup out of static method Change-Id: I91

[MediaWiki-commits] [Gerrit] Pass pep257 on some of the files - change (pywikibot/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Pass pep257 on some of the files .. Pass pep257 on some of the files Using flake8-docstrings. The files are not 100% compliant. Change-Id: I03f9cf80cea0

[MediaWiki-commits] [Gerrit] Fix installing PHPUnit 3.7 via composer (on travis) - change (mediawiki...Wikibase)

2014-07-21 Thread Hoo man (Code Review)
Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/148068 Change subject: Fix installing PHPUnit 3.7 via composer (on travis) .. Fix installing PHPUnit 3.7 via composer (on travis) Change-Id: Idbc85d

[MediaWiki-commits] [Gerrit] Fix installing PHPUnit 3.7 via composer (on travis) - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix installing PHPUnit 3.7 via composer (on travis) .. Fix installing PHPUnit 3.7 via composer (on travis) Change-Id: Idbc85de8e933497c0657254250b205ca1f9

[MediaWiki-commits] [Gerrit] PEP8 fixes - change (pywikibot/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: PEP8 fixes .. PEP8 fixes - Specify the type of exception expected from winreg. - Fix E128 continuation line under-indented for visual indent by removing

[MediaWiki-commits] [Gerrit] wmflib: add ensure_directory() and ensure_link() - change (operations/puppet)

2014-07-21 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: wmflib: add ensure_directory() and ensure_link() .. wmflib: add ensure_directory() and ensure_link() It's a common pattern to want to map a generic

[MediaWiki-commits] [Gerrit] Defer building of MWReferenceSearchWidget index - change (mediawiki...VisualEditor)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148070 Change subject: Defer building of MWReferenceSearchWidget index .. Defer building of MWReferenceSearchWidget index It can be very slow on pa

[MediaWiki-commits] [Gerrit] MWReferenceSearchWidget buildIndex optimisations - change (mediawiki...VisualEditor)

2014-07-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/148069 Change subject: MWReferenceSearchWidget buildIndex optimisations .. MWReferenceSearchWidget buildIndex optimisations * Each item builds an M

[MediaWiki-commits] [Gerrit] Stop zero-padding partition specifications - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148075 to review the following change. Change subject: Stop zero-padding partition specifications .. Stop zero-padding partitio

[MediaWiki-commits] [Gerrit] Drop noop time adding from partition specification - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148076 to review the following change. Change subject: Drop noop time adding from partition specification .. Drop noop time add

[MediaWiki-commits] [Gerrit] Drop explicitly passing SerDe - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148074 to review the following change. Change subject: Drop explicitly passing SerDe .. Drop explicitly passing SerDe The pass

[MediaWiki-commits] [Gerrit] Get rid of camelCase - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148078 to review the following change. Change subject: Get rid of camelCase .. Get rid of camelCase Since coding conventions s

[MediaWiki-commits] [Gerrit] Fix hdfs data path 'external' to 'raw' - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148073 to review the following change. Change subject: Fix hdfs data path 'external' to 'raw' .. Fix hdfs data path 'external'

[MediaWiki-commits] [Gerrit] Fix obsolete 'kraken' references to 'refinery' - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148071 to review the following change. Change subject: Fix obsolete 'kraken' references to 'refinery' .. Fix obsolete 'kraken'

[MediaWiki-commits] [Gerrit] Stop using potentially uninitialized variables in oozie help... - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148077 to review the following change. Change subject: Stop using potentially uninitialized variables in oozie helper workflows ...

[MediaWiki-commits] [Gerrit] Add proper xml header to xml files - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148079 to review the following change. Change subject: Add proper xml header to xml files .. Add proper xml header to xml files

[MediaWiki-commits] [Gerrit] Switch from 'wmf' to 'wmf_raw' as hive database for raw data - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148072 to review the following change. Change subject: Switch from 'wmf' to 'wmf_raw' as hive database for raw data .. Switch f

[MediaWiki-commits] [Gerrit] Stop feeding the Oozie's site libpath twice into Oozie - change (analytics/refinery)

2014-07-21 Thread QChris (Code Review)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/148080 to review the following change. Change subject: Stop feeding the Oozie's site libpath twice into Oozie .. Stop feeding t

[MediaWiki-commits] [Gerrit] [BlueSpice] Register csyntaxhighlight+Readers modules - change (translatewiki)

2014-07-21 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/148081 Change subject: [BlueSpice] Register csyntaxhighlight+Readers modules .. [BlueSpice] Register csyntaxhighlight+Readers modules Chang

[MediaWiki-commits] [Gerrit] [BlueSpice] Register csyntaxhighlight+Readers modules - change (translatewiki)

2014-07-21 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. Change subject: [BlueSpice] Register csyntaxhighlight+Readers modules .. [BlueSpice] Register csyntaxhighlight+Readers modules Change-Id: I86d01a2b8c71c950f1bc43e861

[MediaWiki-commits] [Gerrit] preserve sortKey exactly when (de)serializing category links - change (pywikibot/core)

2014-07-21 Thread Ricordisamoa (Code Review)
Ricordisamoa has uploaded a new change for review. https://gerrit.wikimedia.org/r/148082 Change subject: preserve sortKey exactly when (de)serializing category links .. preserve sortKey exactly when (de)serializing category li

[MediaWiki-commits] [Gerrit] Use "let" keyword to define local variables - change (mediawiki...api)

2014-07-21 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/148083 Change subject: Use "let" keyword to define local variables .. Use "let" keyword to define local variables Instead of including a module. C

[MediaWiki-commits] [Gerrit] Don't end JSON snippets with new lines - change (mediawiki...Wikibase)

2014-07-21 Thread Hoo man (Code Review)
Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/148084 Change subject: Don't end JSON snippets with new lines .. Don't end JSON snippets with new lines Also moved the phpunit tests to a location w

[MediaWiki-commits] [Gerrit] json gem is not used in tests - change (mediawiki...api)

2014-07-21 Thread Zfilipin (Code Review)
Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/148085 Change subject: json gem is not used in tests .. json gem is not used in tests Change-Id: I73d5de79760d722e786759a51b85be2f2dc147db --- M sp

[MediaWiki-commits] [Gerrit] Remove check for wikimedia-mode file, which no longer exists - change (mediawiki/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove check for wikimedia-mode file, which no longer exists .. Remove check for wikimedia-mode file, which no longer exists Change-Id: Ib463e7687b7b35147

[MediaWiki-commits] [Gerrit] Move constructor code out of parser function static method - change (mediawiki...Wikibase)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move constructor code out of parser function static method .. Move constructor code out of parser function static method Change-Id: I896d52210ce828cf37af4

[MediaWiki-commits] [Gerrit] Document '.hql' filename ending for HiveQL files - change (analytics/refinery)

2014-07-21 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. Change subject: Document '.hql' filename ending for HiveQL files .. Document '.hql' filename ending for HiveQL files Change-Id: Ic41c1fb487db1303136db97eefebd44a23598fc5 ---

[MediaWiki-commits] [Gerrit] Always return bool in BackupReader::handleUpload - change (mediawiki/core)

2014-07-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Always return bool in BackupReader::handleUpload .. Always return bool in BackupReader::handleUpload Change-Id: I476a1668b3a1ff9148ff335c9d7c9aa0c8ca3d11

[MediaWiki-commits] [Gerrit] Use %(version)s in gbp.conf for debian branch - change (operations...kafka)

2014-07-21 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. Change subject: Use %(version)s in gbp.conf for debian branch .. Use %(version)s in gbp.conf for debian branch This way gbp.conf needs zero modifications on every new versio

[MediaWiki-commits] [Gerrit] Remove outdated camus jar - change (analytics/refinery)

2014-07-21 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. Change subject: Remove outdated camus jar .. Remove outdated camus jar Since we've switched to camus-wmf-0.1.0-wmf5.jar, the -wmf4 variant is no longer needed. Change-Id: I

  1   2   3   4   5   >