[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce problems caused by $wgRunJobsAsync

2016-08-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/306154 Change subject: Reduce problems caused by $wgRunJobsAsync .. Reduce problems caused by $wgRunJobsAsync * Use getCanonicalURL() to avoid

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: objectcache: Add missing @covers to unit tests

2016-08-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/306153 Change subject: objectcache: Add missing @covers to unit tests .. objectcache: Add missing @covers to unit tests * HashBagOStuff: 100% * Cach

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Article header tweaks

2016-08-22 Thread Mholloway (Code Review)
Mholloway has uploaded a new change for review. https://gerrit.wikimedia.org/r/306152 Change subject: Article header tweaks .. Article header tweaks -Reduce height of divider view to 1dp and use color resource -Make article d

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Earlier evaluation of suggestions in the sidebar

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Earlier evaluation of suggestions in the sidebar .. Earlier evaluation of suggestions in the sidebar Bug: T136463 Depends-On: Ib36ef6a2b9955189acfbe06bd6b

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: modules: Remove use of deprecated getModifiedTime()

2016-08-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/306151 Change subject: modules: Remove use of deprecated getModifiedTime() .. modules: Remove use of deprecated getModifiedTime() Since last year, R

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Use getDefinitionSummary() in ResourceLoaderULSJsonMessageMo...

2016-08-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/306150 Change subject: Use getDefinitionSummary() in ResourceLoaderULSJsonMessageModule .. Use getDefinitionSummary() in ResourceLoaderULSJsonMessage

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Simplify ResourceLoaderULSModule with content-based versioning

2016-08-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/306149 Change subject: Simplify ResourceLoaderULSModule with content-based versioning .. Simplify ResourceLoaderULSModule with content-based versioni

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove commit() calls from JobQueueDB

2016-08-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/306148 Change subject: Remove commit() calls from JobQueueDB .. Remove commit() calls from JobQueueDB Change-Id: Ic24a05c18bf31e49bf7e9a3c058de

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Frame and caption with existing .thumb/.thumbinner CSS

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Frame and caption with existing .thumb/.thumbinner CSS .. Frame and caption with existing .thumb/.thumbinner CSS Bug: T128913 Change-Id: Ifab05618ec895011

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Code cleanups to SqlBagOStuff

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Code cleanups to SqlBagOStuff .. Code cleanups to SqlBagOStuff * Refactor local DB usage check into usesMainDB() method. * Avoid using the db member of DB

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Pingback: Tweak docs a tiny bit to point to mw.org better

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Pingback: Tweak docs a tiny bit to point to mw.org better .. Pingback: Tweak docs a tiny bit to point to mw.org better Change-Id: Ia01380d6bb20cfb22b6cc37

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: A few more DBLockManager fixes and cleanups

2016-08-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/306147 Change subject: A few more DBLockManager fixes and cleanups .. A few more DBLockManager fixes and cleanups * Do not do the connection in

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: 1.27.1: release notes and bump version number

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: 1.27.1: release notes and bump version number .. 1.27.1: release notes and bump version number Change-Id: Ied2632ed0fa4bbb0bb2d290de11863ff0cb3dcec --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move EnqueueableDataUpdate to a separate file

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move EnqueueableDataUpdate to a separate file .. Move EnqueueableDataUpdate to a separate file Change-Id: Iabc291cd1f3c5390ca8bcc5da64a0ff01a082575 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_26]: [WIP] Use phpcs to forbid short array syntax

2016-08-22 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/306146 Change subject: [WIP] Use phpcs to forbid short array syntax .. [WIP] Use phpcs to forbid short array syntax Change-Id: If336a4091c11228d2a2f

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Release notes for all the previous security patches

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Release notes for all the previous security patches .. Release notes for all the previous security patches Change-Id: Ie93338b7d41a90f3ffdfa1b41891994935c

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_23]: SECURITY: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: SECURITY: Add -dSAFER to ghostscript as a hardening measure .. SECURITY: Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain scary feature

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: TranslateSandbox: also delete log entries for deleted users.

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: TranslateSandbox: also delete log entries for deleted users. .. TranslateSandbox: also delete log entries for deleted users. I could swear the log_user_te

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_27]: SECURITY: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Add -dSAFER to ghostscript as a hardening measure .. SECURITY: Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain scary

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_26]: SECURITY: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Add -dSAFER to ghostscript as a hardening measure .. SECURITY: Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain scary

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: SECURITY: Move 'UserGetRights' call before application of Se...

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() .. SECURITY: Move 'UserGetRights' call before application of Se

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Do not load schema.UniversalLanguageSelector explicitly

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Do not load schema.UniversalLanguageSelector explicitly .. Do not load schema.UniversalLanguageSelector explicitly Because ext.uls.eventlogger has it as a

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: SECURITY: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Add -dSAFER to ghostscript as a hardening measure .. SECURITY: Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain scary

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove redundant isLoggedIn() call

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove redundant isLoggedIn() call .. Remove redundant isLoggedIn() call Follows-up 3e7a50d5, 81c291f26. Change-Id: I76f71f92ed8f2f57b871fa359c469f83357d

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SECURITY: Move 'UserGetRights' call before application of Se...

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Move 'UserGetRights' call before application of Session::getAllowedUserRights() .. SECURITY: Move 'UserGetRights' call before application of Se

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Round coordinates based on zoom level

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Round coordinates based on zoom level .. Round coordinates based on zoom level Bug: T143179 Change-Id: I651e01308d43aa8eddb0e30dbb744eeab861d79f --- M mod

[MediaWiki-commits] [Gerrit] mediawiki...GeoData[master]: Use strict comparisons in equalsTo() and fullyEqualsTo()

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use strict comparisons in equalsTo() and fullyEqualsTo() .. Use strict comparisons in equalsTo() and fullyEqualsTo() This results in some updates not happ

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove commit() hack from User::addToDatabase()

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove commit() hack from User::addToDatabase() .. Remove commit() hack from User::addToDatabase() This is likely not needed anymore to avoid deadlocks an

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/306145 Change subject: Add -dSAFER to ghostscript as a hardening measure .. Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_27]: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/306144 Change subject: Add -dSAFER to ghostscript as a hardening measure .. Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_26]: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/306143 Change subject: Add -dSAFER to ghostscript as a hardening measure .. Add -dSAFER to ghostscript as a hardening measure -dSAFER disables certain

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[REL1_23]: SECURITY: Add -dSAFER to ghostscript as a hardening measure

2016-08-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/306142 Change subject: SECURITY: Add -dSAFER to ghostscript as a hardening measure .. SECURITY: Add -dSAFER to ghostscript as a hardening measure -dSAF

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Various database class cleanups

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Various database class cleanups .. Various database class cleanups * Refactor out some code duplication in query() into a separate private method. * Rem

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move EnqueueableDataUpdate to a separate file

2016-08-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/306141 Change subject: Move EnqueueableDataUpdate to a separate file .. Move EnqueueableDataUpdate to a separate file Change-Id: Iabc291cd1f3c5

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: SECURITY: API: Generate head items in the context of the giv...

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: API: Generate head items in the context of the given title .. SECURITY: API: Generate head items in the context of the given title $context->ge

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Use adaptive CDN TTLs for page views

2016-08-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/306140 Change subject: [WIP] Use adaptive CDN TTLs for page views .. [WIP] Use adaptive CDN TTLs for page views Change-Id: If621aca2fb68e9f87a5

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove redundant isLoggedIn() call

2016-08-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/306139 Change subject: Remove redundant isLoggedIn() call .. Remove redundant isLoggedIn() call Follows-up 3e7a50d5, 81c291f26. Change-Id: I76f71f9

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: SECURITY: XSS in unclosed internal links

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: XSS in unclosed internal links .. SECURITY: XSS in unclosed internal links rawurldecode was being run on unclosed internal links which could all

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: SECURITY: Escape '<' and ']]>' in inline

2016-08-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: SECURITY: Escape '<' and ']]>' in inline blocks .. SECURITY: Escape '<' and ']]>' in inline