[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update the zookeeper module's sha to the latest revision.

2016-09-04 Thread Elukey (Code Review)
Elukey has submitted this change and it was merged. Change subject: Update the zookeeper module's sha to the latest revision. .. Update the zookeeper module's sha to the latest revision. Correspondent code review: https://gerri

[MediaWiki-commits] [Gerrit] operations/puppet[production]: kibana: Restrict to domain networks

2016-09-04 Thread Muehlenhoff (Code Review)
Muehlenhoff has submitted this change and it was merged. Change subject: kibana: Restrict to domain networks .. kibana: Restrict to domain networks Stop using $INTERNAL, which is deprecated and unnecessarily broad. In productio

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update the zookeeper module's sha to the latest revision.

2016-09-04 Thread Elukey (Code Review)
Elukey has uploaded a new change for review. https://gerrit.wikimedia.org/r/308514 Change subject: Update the zookeeper module's sha to the latest revision. .. Update the zookeeper module's sha to the latest revision. Corresp

[MediaWiki-commits] [Gerrit] operations...zookeeper[master]: Allow a more custom set of arguments for the cleanup script

2016-09-04 Thread Elukey (Code Review)
Elukey has submitted this change and it was merged. Change subject: Allow a more custom set of arguments for the cleanup script .. Allow a more custom set of arguments for the cleanup script A bit of refactoring has been done:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: redis: manage our redis common config with puppet

2016-09-04 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: redis: manage our redis common config with puppet .. redis: manage our redis common config with puppet At the moment, the main redis.conf file is u

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::rcstream: move redis settings from legacy config file

2016-09-04 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: role::rcstream: move redis settings from legacy config file .. role::rcstream: move redis settings from legacy config file We have a series of sett

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Typo in a test: '+' instead of '.' to concatenate strings

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Typo in a test: '+' instead of '.' to concatenate strings .. Typo in a test: '+' instead of '.' to concatenate strings I found it by executing tests with

[MediaWiki-commits] [Gerrit] labs...deploy[master]: Bump striker submodule

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Bump striker submodule .. Bump striker submodule Change-Id: I59561045569fe9828216018dbaaac7ae19dfc988 --- M striker 1 file changed, 1 insertion(+), 1 dele

[MediaWiki-commits] [Gerrit] labs...deploy[master]: Bump striker submodule

2016-09-04 Thread BryanDavis (Code Review)
BryanDavis has uploaded a new change for review. https://gerrit.wikimedia.org/r/308504 Change subject: Bump striker submodule .. Bump striker submodule Change-Id: I59561045569fe9828216018dbaaac7ae19dfc988 --- M striker 1 file

[MediaWiki-commits] [Gerrit] mediawiki...SemanticForms[master]: Undefined JS variables in no-global-variables mode

2016-09-04 Thread Yaron Koren (Code Review)
Yaron Koren has submitted this change and it was merged. Change subject: Undefined JS variables in no-global-variables mode .. Undefined JS variables in no-global-variables mode I got a bug with sfgShowOnSelect specifically but

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clarify and update DeferredUpdates docs

2016-09-04 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/308503 Change subject: Clarify and update DeferredUpdates docs .. Clarify and update DeferredUpdates docs Change-Id: Ib70585d9d10f6f6493a625697

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Cache revision lookups done by Parser

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Cache revision lookups done by Parser .. Cache revision lookups done by Parser Inverse flame graphs shows revision lookups as one of the big three queries

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cgred: Fix indentation of =>

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: cgred: Fix indentation of => .. cgred: Fix indentation of => Bug: T93645 Change-Id: I8fbb3ab38f4eeca703be95928933adffa2c89c18 --- M modules/cgred/

[MediaWiki-commits] [Gerrit] operations/puppet[production]: striker: Add custom error pages to apache vhost

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: striker: Add custom error pages to apache vhost .. striker: Add custom error pages to apache vhost Bug: T144040 Change-Id: I844510b030c0487c34f084

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Fix trailing whitespace found

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmaster: Fix trailing whitespace found .. puppetmaster: Fix trailing whitespace found Bug: T93645 Change-Id: I387e75e3fe6b1ccc20d6e83e82d29b8

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmasters: Allow ssh puppet-merge from all frontends

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmasters: Allow ssh puppet-merge from all frontends .. puppetmasters: Allow ssh puppet-merge from all frontends All frontends should be able

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmasters: Allow ssh puppet-merge from all frontends

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308502 Change subject: puppetmasters: Allow ssh puppet-merge from all frontends .. puppetmasters: Allow ssh puppet-merge from all fronten

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet: CRL is now a file

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppet: CRL is now a file .. puppet: CRL is now a file Our CRL is now a file, convert the apache directory to the correct one Also add a comment a

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet: CRL is now a file

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308501 Change subject: puppet: CRL is now a file .. puppet: CRL is now a file Our CRL is now a file, convert the apache directory to the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "puppetmaster: Vary ssldir in frontend on masterness"

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: Revert "puppetmaster: Vary ssldir in frontend on masterness" .. Revert "puppetmaster: Vary ssldir in frontend on masterness" Turns out it is not n

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "puppetmaster: Vary ssldir in frontend on masterness"

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308500 Change subject: Revert "puppetmaster: Vary ssldir in frontend on masterness" .. Revert "puppetmaster: Vary ssldir in frontend on m

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clean array() syntax in docs, part V

2016-09-04 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/308499 Change subject: Clean array() syntax in docs, part V .. Clean array() syntax in docs, part V Change-Id: Ic65b7b2f1c2396246a3825c8d06d42bd6d

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role/cxserver: Fix role::cxserver not in autoload module layout

2016-09-04 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/308498 Change subject: role/cxserver: Fix role::cxserver not in autoload module layout .. role/cxserver: Fix role::cxserver not in autoload module la

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Special:CreateCollaborationHub: create members and announcem...

2016-09-04 Thread Harej (Code Review)
Harej has uploaded a new change for review. https://gerrit.wikimedia.org/r/308497 Change subject: Special:CreateCollaborationHub: create members and announcement features and sign up project creator as first member. .. Specia

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Wikimedia messages for new 'engineer' group for ruwiki

2016-09-04 Thread MarcoAurelio (Code Review)
MarcoAurelio has uploaded a new change for review. https://gerrit.wikimedia.org/r/308449 Change subject: Wikimedia messages for new 'engineer' group for ruwiki .. Wikimedia messages for new 'engineer' group for ruwiki Bug: T1

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: New 'engineer' group for ruwiki

2016-09-04 Thread MarcoAurelio (Code Review)
MarcoAurelio has uploaded a new change for review. https://gerrit.wikimedia.org/r/308448 Change subject: New 'engineer' group for ruwiki .. New 'engineer' group for ruwiki Bug: T144599 Change-Id: Ia2474a812a7b410d59472f8a1e4b

[MediaWiki-commits] [Gerrit] mediawiki...latex_renderer[master]: Treat divs as paragraphs for breaking

2016-09-04 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. https://gerrit.wikimedia.org/r/308447 Change subject: Treat divs as paragraphs for breaking .. Treat divs as paragraphs for breaking * Seeing a ton of "Underfull \hbox (badness"

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Rename 'autopatrol' to 'autopatrolled' on fawiki

2016-09-04 Thread MarcoAurelio (Code Review)
MarcoAurelio has uploaded a new change for review. https://gerrit.wikimedia.org/r/308446 Change subject: Rename 'autopatrol' to 'autopatrolled' on fawiki .. Rename 'autopatrol' to 'autopatrolled' on fawiki Bug: T144699 Bug: T

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Reset the LocalClusterObjectCache service in tests

2016-09-04 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/308445 Change subject: Reset the LocalClusterObjectCache service in tests .. Reset the LocalClusterObjectCache service in tests Change-Id: I23b

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Reset the LocalClusterObjectCache service in tests

2016-09-04 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/308444 Change subject: Reset the LocalClusterObjectCache service in tests .. Reset the LocalClusterObjectCache service in tests Change-Id: If5d

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[master]: Reset the LocalClusterObjectCache service in tests

2016-09-04 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/308443 Change subject: Reset the LocalClusterObjectCache service in tests .. Reset the LocalClusterObjectCache service in tests Change-Id: I088

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [L10N] update nowcommons templates for de wiki

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: [L10N] update nowcommons templates for de wiki .. [L10N] update nowcommons templates for de wiki Change-Id: I2af276ad7f373a1e0d3fb68550d7eb6e4d8e5a80 ---

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: replace.py: add get_inside_exception to ReplacementListEntry

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: replace.py: add get_inside_exception to ReplacementListEntry .. replace.py: add get_inside_exception to ReplacementListEntry ReplacementListEntry inherits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Vary ssldir in frontend on masterness

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmaster: Vary ssldir in frontend on masterness .. puppetmaster: Vary ssldir in frontend on masterness A frontend might or might not be a mast

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Pedantic whitespace fixes

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmaster: Pedantic whitespace fixes .. puppetmaster: Pedantic whitespace fixes Remove a couple of whitespace issues in our puppetmaster/role m

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Vary ssldir in frontend on masterness

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308442 Change subject: puppetmaster: Vary ssldir in frontend on masterness .. puppetmaster: Vary ssldir in frontend on masterness A fron

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role: Fix not in autoload module layout

2016-09-04 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/308441 Change subject: role: Fix not in autoload module layout .. role: Fix not in autoload module layout Bug: T93645 Change-Id: I9ccc29fe70cdebfe4d

[MediaWiki-commits] [Gerrit] operations/puppet[production]: manifests/role: Fix: class not documented

2016-09-04 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/308440 Change subject: manifests/role: Fix: class not documented .. manifests/role: Fix: class not documented Change-Id: If94ae1ae1830ac8b6cdb64450b

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: install korean locales

2016-09-04 Thread Merlijn van Deen (Code Review)
Merlijn van Deen has uploaded a new change for review. https://gerrit.wikimedia.org/r/308439 Change subject: toollabs: install korean locales .. toollabs: install korean locales Bug: T130532 Change-Id: I1e9e30edb99640a10407f1

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: replace.py: add get_inside_exception to ReplacementListEntry

2016-09-04 Thread Mpaa (Code Review)
Mpaa has uploaded a new change for review. https://gerrit.wikimedia.org/r/308438 Change subject: replace.py: add get_inside_exception to ReplacementListEntry .. replace.py: add get_inside_exception to ReplacementListEntry Rep

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Pedantic whitespace fixes

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308437 Change subject: puppetmaster: Pedantic whitespace fixes .. puppetmaster: Pedantic whitespace fixes Remove a couple of whitespace

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix wrong dependency in puppetmaster::gitclone

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: Fix wrong dependency in puppetmaster::gitclone .. Fix wrong dependency in puppetmaster::gitclone Fix wrong hook depedency, it should depend on the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix wrong dependency in puppetmaster::gitclone

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/308436 Change subject: Fix wrong dependency in puppetmaster::gitclone .. Fix wrong dependency in puppetmaster::gitclone Fix wrong hook d

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmasters: support multiple git masters

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmasters: support multiple git masters .. puppetmasters: support multiple git masters Given we will have multiple frontends, we want all of t

[MediaWiki-commits] [Gerrit] operations/puppet[production]: site.pp: Use role keyword as a function

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: site.pp: Use role keyword as a function .. site.pp: Use role keyword as a function Puppet 4 syntax requires to use parameters for fuctions. While

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toolserver: Redirect ~mzmcbride/yanker/ to tool labs

2016-09-04 Thread Merlijn van Deen (Code Review)
Merlijn van Deen has uploaded a new change for review. https://gerrit.wikimedia.org/r/308435 Change subject: toolserver: Redirect ~mzmcbride/yanker/ to tool labs .. toolserver: Redirect ~mzmcbride/yanker/ to tool labs Bug: T1

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add SRV records for puppet (all pointing to palladium.eqiad....

2016-09-04 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: Add SRV records for puppet (all pointing to palladium.eqiad.wmnet) .. Add SRV records for puppet (all pointing to palladium.eqiad.wmnet) Please n

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ssl_ciphersuite: remove DHE+chapoly

2016-09-04 Thread BBlack (Code Review)
BBlack has uploaded a new change for review. https://gerrit.wikimedia.org/r/308433 Change subject: ssl_ciphersuite: remove DHE+chapoly .. ssl_ciphersuite: remove DHE+chapoly Nothing has negotiated this to date, and it seems u

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ssl_ciphersuite: remove SHA256 "mid" options

2016-09-04 Thread BBlack (Code Review)
BBlack has uploaded a new change for review. https://gerrit.wikimedia.org/r/308434 Change subject: ssl_ciphersuite: remove SHA256 "mid" options .. ssl_ciphersuite: remove SHA256 "mid" options In our ciphersuite simulations an

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2016-09-04T10:00:01+0000

2016-09-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: New Wikidata Build - 2016-09-04T10:00:01+ .. New Wikidata Build - 2016-09-04T10:00:01+ Change-Id: Id4e00d67441bfe6e1cef1b801fb9e24e7f31113e --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::rcstream: move redis settings from legacy config file

2016-09-04 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/308432 Change subject: role::rcstream: move redis settings from legacy config file .. role::rcstream: move redis settings from legacy conf

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [L10M] update nowcommons templates for de wiki

2016-09-04 Thread Xqt (Code Review)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/308431 Change subject: [L10M] update nowcommons templates for de wiki .. [L10M] update nowcommons templates for de wiki Change-Id: I2af276ad7f373a1e0d3f

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Change $wgArticleCountMethod in Wikidata from default ('link...

2016-09-04 Thread Urbanecm (Code Review)
Urbanecm has uploaded a new change for review. https://gerrit.wikimedia.org/r/308430 Change subject: Change $wgArticleCountMethod in Wikidata from default ('link') to 'any' .. Change $wgArticleCountMethod in Wikidata from def

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add source wikis in import page in sawiki

2016-09-04 Thread Urbanecm (Code Review)
Urbanecm has uploaded a new change for review. https://gerrit.wikimedia.org/r/308429 Change subject: Add source wikis in import page in sawiki .. Add source wikis in import page in sawiki Bug: T133483 Change-Id: If6592900cd0c

[MediaWiki-commits] [Gerrit] mediawiki...FileAnnotations[master]: Prevent image click when adding annotations

2016-09-04 Thread Prtksxna (Code Review)
Prtksxna has uploaded a new change for review. https://gerrit.wikimedia.org/r/308428 Change subject: Prevent image click when adding annotations .. Prevent image click when adding annotations Change-Id: I3c4ce9f295c294004f326

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] remove -hash option from support

2016-09-04 Thread Xqt (Code Review)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/308427 Change subject: [bugfix] remove -hash option from support .. [bugfix] remove -hash option from support - webservice for -hash option is not avail

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] ncTemplates is a method not a property

2016-09-04 Thread Xqt (Code Review)
Xqt has uploaded a new change for review. https://gerrit.wikimedia.org/r/308426 Change subject: [bugfix] ncTemplates is a method not a property .. [bugfix] ncTemplates is a method not a property Bug: T144690 Change-Id: Iaf31f

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2016-09-04T10:00:01+0000

2016-09-04 Thread WikidataBuilder (Code Review)
WikidataBuilder has uploaded a new change for review. https://gerrit.wikimedia.org/r/308425 Change subject: New Wikidata Build - 2016-09-04T10:00:01+ .. New Wikidata Build - 2016-09-04T10:00:01+ Change-Id: Id4e00d6744