[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Don't use isset() to test for null

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309936 Change subject: Don't use isset() to test for null .. Don't use isset() to test for null Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Store babel languages in the database

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309937 Change subject: Store babel languages in the database .. Store babel languages in the database The current method of reading categories and

[MediaWiki-commits] [Gerrit] integration/config[master]: Update location of parserTests.php

2016-09-11 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. https://gerrit.wikimedia.org/r/309935 Change subject: Update location of parserTests.php .. Update location of parserTests.php Also remove fixme comment, since I don't agree

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Move the addModules to the hook of the trigger

2016-09-11 Thread Fomafix (Code Review)
Fomafix has uploaded a new change for review. https://gerrit.wikimedia.org/r/309934 Change subject: Move the addModules to the hook of the trigger .. Move the addModules to the hook of the trigger This change ensures that

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Add massmessage permission to highvolume grant

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add massmessage permission to highvolume grant .. Add massmessage permission to highvolume grant Bug: T145349 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid "No transaction is active" saveFileDependencies() test...

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid "No transaction is active" saveFileDependencies() tests errors .. Avoid "No transaction is active" saveFileDependencies() tests errors Unit tests

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid "No transaction is active" saveFileDependencies() test...

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309933 Change subject: Avoid "No transaction is active" saveFileDependencies() tests errors .. Avoid "No transaction is active"

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Reduce check_sslxNN alert thresholds to 30d/15d

2016-09-11 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged. Change subject: Reduce check_sslxNN alert thresholds to 30d/15d .. Reduce check_sslxNN alert thresholds to 30d/15d Revert to the check_ssl defaults of 30 days to WARNING and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid "Column md_module cannot be null" error in unit tests

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid "Column md_module cannot be null" error in unit tests .. Avoid "Column md_module cannot be null" error in unit tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Add massmessage permission to highvolume grant

2016-09-11 Thread MusikAnimal (Code Review)
MusikAnimal has uploaded a new change for review. https://gerrit.wikimedia.org/r/309932 Change subject: Add massmessage permission to highvolume grant .. Add massmessage permission to highvolume grant Bug: T145349 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DBAccessBase: Automatically reuse connections

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309931 Change subject: DBAccessBase: Automatically reuse connections .. DBAccessBase: Automatically reuse connections

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use memory job queue for unit tests

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use memory job queue for unit tests .. Use memory job queue for unit tests Change-Id: I13586b9873bf09acd4a458a7af75a25d9b980fca --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Upgrade upload esams to Varnish 4

2016-09-11 Thread Ema (Code Review)
Ema has submitted this change and it was merged. Change subject: Upgrade upload esams to Varnish 4 .. Upgrade upload esams to Varnish 4 Bug: T131502 Change-Id: Ic719c8dd2968eae5febc37bfec7b84cc7ffdced1 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Upgrade upload esams to Varnish 4

2016-09-11 Thread Ema (Code Review)
Ema has uploaded a new change for review. https://gerrit.wikimedia.org/r/309930 Change subject: Upgrade upload esams to Varnish 4 .. Upgrade upload esams to Varnish 4 Bug: T131502 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd::ssl: fix puppet ssldir path

2016-09-11 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309929 Change subject: etcd::ssl: fix puppet ssldir path .. etcd::ssl: fix puppet ssldir path Use the function that was already made for this

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache_upload esams: route to codfw

2016-09-11 Thread Ema (Code Review)
Ema has submitted this change and it was merged. Change subject: cache_upload esams: route to codfw .. cache_upload esams: route to codfw Bug: T131502 Change-Id: I6f94051ca6a4da5bcd2987c3cf192a822c74142f --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache_upload esams: route to codfw

2016-09-11 Thread Ema (Code Review)
Ema has uploaded a new change for review. https://gerrit.wikimedia.org/r/309928 Change subject: cache_upload esams: route to codfw .. cache_upload esams: route to codfw Bug: T131502 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use memory job queue for unit tests

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309927 Change subject: Use memory job queue for unit tests .. Use memory job queue for unit tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid "Column md_module cannot be null" error in unit tests

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309926 Change subject: Avoid "Column md_module cannot be null" error in unit tests .. Avoid "Column md_module cannot be null" error in unit

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.28.0-wmf.18]: Fix mw.Uri crushing bug

2016-09-11 Thread Yurik (Code Review)
Yurik has uploaded a new change for review. https://gerrit.wikimedia.org/r/309925 Change subject: Fix mw.Uri crushing bug .. Fix mw.Uri crushing bug I suspect this is the fix, but i have a hard time replicating it outside of

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: Replace HTMLForm info fields with definition lists on manage...

2016-09-11 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/309924 Change subject: Replace HTMLForm info fields with definition lists on management interface .. Replace HTMLForm info fields with

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Display an error message when the validataion of a radio inp...

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Display an error message when the validataion of a radio input fails because user did not provide any input. .. Display an error message when the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Reduce check_sslxNN alert thresholds to 30d/15d

2016-09-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. https://gerrit.wikimedia.org/r/309923 Change subject: Reduce check_sslxNN alert thresholds to 30d/15d .. Reduce check_sslxNN alert thresholds to 30d/15d Revert to the

[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Add categories to ParserOutput, don't embed in wikitext

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309922 Change subject: Add categories to ParserOutput, don't embed in wikitext .. Add categories to ParserOutput, don't embed in wikitext This adds

[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Fix casing of Language::getFallbackFor() call

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309921 Change subject: Fix casing of Language::getFallbackFor() call .. Fix casing of Language::getFallbackFor() call Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Display an error message when the validataion of a radio inp...

2016-09-11 Thread Huji (Code Review)
Huji has uploaded a new change for review. https://gerrit.wikimedia.org/r/309920 Change subject: Display an error message when the validataion of a radio input fails because user did not provide any input. .. Display an

[MediaWiki-commits] [Gerrit] mediawiki...GeoData[master]: Make doLinksUpdate() avoid creating DB replication lag

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309919 Change subject: Make doLinksUpdate() avoid creating DB replication lag .. Make doLinksUpdate() avoid creating DB replication lag Large

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove useless LoadBalancer::parentInfo() method and calls

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove useless LoadBalancer::parentInfo() method and calls .. Remove useless LoadBalancer::parentInfo() method and calls Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use ESTIMATE_DB_APPLY for total transaction time estimate

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use ESTIMATE_DB_APPLY for total transaction time estimate .. Use ESTIMATE_DB_APPLY for total transaction time estimate Individual write queries already

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make PurgeJobUtils avoid creating DB replication lag

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309918 Change subject: Make PurgeJobUtils avoid creating DB replication lag .. Make PurgeJobUtils avoid creating DB replication lag Large

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add LBFactory::getChronologyProtectorTouched() method

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add LBFactory::getChronologyProtectorTouched() method .. Add LBFactory::getChronologyProtectorTouched() method This lets callers check whether a user

[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Fix return documentation of mParseParameter()

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309916 Change subject: Fix return documentation of mParseParameter() .. Fix return documentation of mParseParameter() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Babel[master]: Remove unused mHtmlAttrib() function

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309917 Change subject: Remove unused mHtmlAttrib() function .. Remove unused mHtmlAttrib() function Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use ESTIMATE_DB_APPLY for total transaction time estimate

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309915 Change subject: Use ESTIMATE_DB_APPLY for total transaction time estimate .. Use ESTIMATE_DB_APPLY for total transaction time estimate

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Lower wgMaxUserDBWriteDuration to 4

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Lower wgMaxUserDBWriteDuration to 4 .. Lower wgMaxUserDBWriteDuration to 4 The error rate from this is now extremely low after the estimate adjustments

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove useless LoadBalancer::parentInfo() method and calls

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309914 Change subject: Remove useless LoadBalancer::parentInfo() method and calls .. Remove useless LoadBalancer::parentInfo() method and calls

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Various depedency injection cleanups to LoadBalancer

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309913 Change subject: Various depedency injection cleanups to LoadBalancer .. Various depedency injection cleanups to LoadBalancer * Inject

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Allow Commons 'crats to manage accountcreator group

2016-09-11 Thread Odder (Code Review)
Odder has uploaded a new change for review. https://gerrit.wikimedia.org/r/309912 Change subject: Allow Commons 'crats to manage accountcreator group .. Allow Commons 'crats to manage accountcreator group This patch allows

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add upload_by_url right to Commons bots

2016-09-11 Thread Odder (Code Review)
Odder has uploaded a new change for review. https://gerrit.wikimedia.org/r/309911 Change subject: Add upload_by_url right to Commons bots .. Add upload_by_url right to Commons bots This patch adds the upload_by_url right to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update Bugzilla references to Phabricator references

2016-09-11 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/309910 Change subject: Update Bugzilla references to Phabricator references .. Update Bugzilla references to Phabricator references Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Further improve handling of silly canvas #drawImage exceptions

2016-09-11 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/309909 Change subject: Further improve handling of silly canvas #drawImage exceptions .. Further improve handling of silly canvas

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Make CentralAuthUser::register() trigger importLocalNames()

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309877 Change subject: Make CentralAuthUser::register() trigger importLocalNames() .. Make CentralAuthUser::register() trigger

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: Avoid $wgUser in tagPage()

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid $wgUser in tagPage() .. Avoid $wgUser in tagPage() Not passing a User object in causes WikiPage::doEditContent() to use $wgUser. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Test

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309876 Change subject: Test .. Test Change-Id: I2079b04da664a459e8c5313ccdfcdf8d654ed12e --- M includes/PHPVersionCheck.php 1 file changed, 39

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: Avoid $wgUser in doMassUserBlockInternal()

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid $wgUser in doMassUserBlockInternal() .. Avoid $wgUser in doMassUserBlockInternal() Change-Id: Iee7829f987ed4e901d43250abf1ab6d05ee0d478 --- M

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: Avoid $wgUser in tagPage()

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309870 Change subject: Avoid $wgUser in tagPage() .. Avoid $wgUser in tagPage() Not passing a User object in causes WikiPage::doEditContent() to

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: Avoid $wgUser in doMassUserBlockInternal()

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309869 Change subject: Avoid $wgUser in doMassUserBlockInternal() .. Avoid $wgUser in doMassUserBlockInternal() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Simplify some LoadBalancer methods that do iteration

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Simplify some LoadBalancer methods that do iteration .. Simplify some LoadBalancer methods that do iteration Use foreachOpenConnection() and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make SessionBackend::save() update the user post-send

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309868 Change subject: Make SessionBackend::save() update the user post-send .. Make SessionBackend::save() update the user post-send

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Make PresentationModel::getPrimaryLinkWithMarkAsRead() final

2016-09-11 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/309867 Change subject: Make PresentationModel::getPrimaryLinkWithMarkAsRead() final .. Make PresentationModel::getPrimaryLinkWithMarkAsRead() final

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[master]: Add composer test entry point

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add composer test entry point .. Add composer test entry point This enables parallel-lint and mediawiki-codesniffer. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Testing.

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309866 Change subject: Testing. .. Testing. Change-Id: I93ddc89d48ebdd2583478f73bc43abbbe41ea38f --- 0 files changed, 0 insertions(+), 0

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[master]: Link to Special:GlobalBlock instead of Special:GlobalBlockLi...

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Link to Special:GlobalBlock instead of Special:GlobalBlockList on block success .. Link to Special:GlobalBlock instead of Special:GlobalBlockList on

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[master]: Cleanup SpecialGlobalBlockList code

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Cleanup SpecialGlobalBlockList code .. Cleanup SpecialGlobalBlockList code * Set explicit method visibility * Remove unused $mSearch and $mForm member

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Silence DBPerformance warnings during password migration

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309865 Change subject: Silence DBPerformance warnings during password migration .. Silence DBPerformance warnings during password migration

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Lower wgMaxUserDBWriteDuration to 4

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309864 Change subject: Lower wgMaxUserDBWriteDuration to 4 .. Lower wgMaxUserDBWriteDuration to 4 The error rate from this is now extremely

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Match vector

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Match vector .. Match vector Change-Id: Icb0d40dc2f08596ea79be446111c434704a11b39 --- M js/vector.js 1 file changed, 14 insertions(+), 4 deletions(-)

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Match vector

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309863 Change subject: Match vector .. Match vector Change-Id: Icb0d40dc2f08596ea79be446111c434704a11b39 --- M js/vector.js 1 file changed, 14

[MediaWiki-commits] [Gerrit] labs...heritage[master]: [NOT READY]Require lat, lon, image, monument_article and reg...

2016-09-11 Thread Lokal Profil (Code Review)
Lokal Profil has uploaded a new change for review. https://gerrit.wikimedia.org/r/309862 Change subject: [NOT READY]Require lat, lon, image, monument_article and registrant_url .. [NOT READY]Require lat, lon, image,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid page_touched update for HTTP GET action=purge requests

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309861 Change subject: Avoid page_touched update for HTTP GET action=purge requests .. Avoid page_touched update for HTTP GET action=purge

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make WikiPage::doPurge() clear the file cache too

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309860 Change subject: Make WikiPage::doPurge() clear the file cache too .. Make WikiPage::doPurge() clear the file cache too Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Enable composer-test on mediawiki/extensions/GlobalBlocking

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Enable composer-test on mediawiki/extensions/GlobalBlocking .. Enable composer-test on mediawiki/extensions/GlobalBlocking Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Simplify implementation of MassMessageListContent::hasInvali...

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Simplify implementation of MassMessageListContent::hasInvalidTargets() .. Simplify implementation of MassMessageListContent::hasInvalidTargets()

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Use extension data instead of (un)serialize hack in properties

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use extension data instead of (un)serialize hack in properties .. Use extension data instead of (un)serialize hack in properties

[MediaWiki-commits] [Gerrit] labs...heritage[master]: [Not READY] Require lat, lon, image, monument_article, regis...

2016-09-11 Thread Lokal Profil (Code Review)
Lokal Profil has uploaded a new change for review. https://gerrit.wikimedia.org/r/309859 Change subject: [Not READY] Require lat, lon, image, monument_article, registrant_url .. [Not READY] Require lat, lon, image,

[MediaWiki-commits] [Gerrit] labs...heritage[master]: [NOT READY] Store plain permalink instead of urlencoded one

2016-09-11 Thread Lokal Profil (Code Review)
Lokal Profil has uploaded a new change for review. https://gerrit.wikimedia.org/r/309858 Change subject: [NOT READY] Store plain permalink instead of urlencoded one .. [NOT READY] Store plain permalink instead of urlencoded

[MediaWiki-commits] [Gerrit] eventlogging[master]: Install ensure-kafka-topics-exist in virtualenv as well

2016-09-11 Thread Mobrovac (Code Review)
Mobrovac has uploaded a new change for review. https://gerrit.wikimedia.org/r/309857 Change subject: Install ensure-kafka-topics-exist in virtualenv as well .. Install ensure-kafka-topics-exist in virtualenv as well

[MediaWiki-commits] [Gerrit] mediawiki...Hovergallery[master]: Improve style

2016-09-11 Thread Sophivorus (Code Review)
Sophivorus has submitted this change and it was merged. Change subject: Improve style .. Improve style Change-Id: I2ee5b4e87fb5477687f01bac5e14f3066648eefa --- M HoverGallery.css 1 file changed, 3 insertions(+), 3 deletions(-)

[MediaWiki-commits] [Gerrit] mediawiki...Hovergallery[master]: Improve style

2016-09-11 Thread Sophivorus (Code Review)
Sophivorus has uploaded a new change for review. https://gerrit.wikimedia.org/r/309856 Change subject: Improve style .. Improve style Change-Id: I2ee5b4e87fb5477687f01bac5e14f3066648eefa --- M HoverGallery.css 1 file

[MediaWiki-commits] [Gerrit] labs...heritage[master]: Extract method get_categories_from_upper_categories

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Extract method get_categories_from_upper_categories .. Extract method get_categories_from_upper_categories With basic unit-test. Change-Id:

[MediaWiki-commits] [Gerrit] operations/dumps[master]: use max_allowed_packets for all mysql commands, not just mys...

2016-09-11 Thread ArielGlenn (Code Review)
ArielGlenn has submitted this change and it was merged. Change subject: use max_allowed_packets for all mysql commands, not just mysqldump .. use max_allowed_packets for all mysql commands, not just mysqldump Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_23]: Add missing global $wgUseXVO to RawAction.php

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309855 Change subject: Add missing global $wgUseXVO to RawAction.php .. Add missing global $wgUseXVO to RawAction.php Change-Id:

[MediaWiki-commits] [Gerrit] operations/dumps[master]: handle empty check for text, html, plain files

2016-09-11 Thread ArielGlenn (Code Review)
ArielGlenn has submitted this change and it was merged. Change subject: handle empty check for text, html, plain files .. handle empty check for text, html, plain files This will now check for empty abstract.xml files, for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove jquery.arrowSteps module

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309854 Change subject: Remove jquery.arrowSteps module .. Remove jquery.arrowSteps module It was unused by any other extension

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.special.movePage: Don't fail if no "Move associated talk ...

2016-09-11 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/309853 Change subject: mw.special.movePage: Don't fail if no "Move associated talk page" checkbox .. mw.special.movePage: Don't fail if

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Add jquery.arrowSteps from mw core

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309852 Change subject: Add jquery.arrowSteps from mw core .. Add jquery.arrowSteps from mw core No repo uses this js file except from UploadWizard

[MediaWiki-commits] [Gerrit] operations/dumps[master]: handle empty check for text, html, plain files

2016-09-11 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review. https://gerrit.wikimedia.org/r/309851 Change subject: handle empty check for text, html, plain files .. handle empty check for text, html, plain files This will now check for

[MediaWiki-commits] [Gerrit] operations/dumps[master]: use max_allowed_packets for all mysql commands, not just mys...

2016-09-11 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review. https://gerrit.wikimedia.org/r/309850 Change subject: use max_allowed_packets for all mysql commands, not just mysqldump .. use max_allowed_packets for all mysql commands, not

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Show up NewsletterEditPage for editing Newsletter contet

2016-09-11 Thread 01tonythomas (Code Review)
01tonythomas has uploaded a new change for review. https://gerrit.wikimedia.org/r/309849 Change subject: Show up NewsletterEditPage for editing Newsletter contet .. Show up NewsletterEditPage for editing Newsletter contet

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Test: Do not merge

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309845 Change subject: Test: Do not merge .. Test: Do not merge Change-Id: I1d1fee1affd457397466843fe877a2c3ba2d3185 --- M

[MediaWiki-commits] [Gerrit] labs...heritage[master]: Enable YAML linting via tox

2016-09-11 Thread Code Review
Jean-Frédéric has uploaded a new change for review. https://gerrit.wikimedia.org/r/309844 Change subject: Enable YAML linting via tox .. Enable YAML linting via tox In f439ac4 we introduced a tox target to lint YAML files.

[MediaWiki-commits] [Gerrit] mediawiki...MassEditRegex[master]: Fix undefined $htmlDiff

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309843 Change subject: Fix undefined $htmlDiff .. Fix undefined $htmlDiff Change-Id: Id775345955c480f0cb2e4d0eb695c303372e0ccb --- 0 files changed,

[MediaWiki-commits] [Gerrit] labs...heritage[master]: Extract CommonsCat templates data to JSON file

2016-09-11 Thread Code Review
Jean-Frédéric has uploaded a new change for review. https://gerrit.wikimedia.org/r/309842 Change subject: Extract CommonsCat templates data to JSON file .. Extract CommonsCat templates data to JSON file - Add new JSON file

[MediaWiki-commits] [Gerrit] labs...heritage[master]: Add unit tests for getCommonscatTemplates method

2016-09-11 Thread Code Review
Jean-Frédéric has uploaded a new change for review. https://gerrit.wikimedia.org/r/309841 Change subject: Add unit tests for getCommonscatTemplates method .. Add unit tests for getCommonscatTemplates method This paves the

[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: do not hardcode P_source_code_repository = "P1324"

2016-09-11 Thread Dachary (Code Review)
Dachary has uploaded a new change for review. https://gerrit.wikimedia.org/r/309840 Change subject: do not hardcode P_source_code_repository = "P1324" .. do not hardcode P_source_code_repository = "P1324" Because it won't be

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Changing MockObject limitation for getConfig from once to an...

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Changing MockObject limitation for getConfig from once to any in test .. Changing MockObject limitation for getConfig from once to any in test Having

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use DB_REPLICA in ContribsPager

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use DB_REPLICA in ContribsPager .. Use DB_REPLICA in ContribsPager Change-Id: Ic225b9c41d989722677caf323846783d7e0638a4 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Move BetaFeatures class check to isBetaFeatureAvailable

2016-09-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/309839 Change subject: Move BetaFeatures class check to isBetaFeatureAvailable .. Move BetaFeatures class check to isBetaFeatureAvailable

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Enable NoteDB in gerrit

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309838 Change subject: Enable NoteDB in gerrit .. Enable NoteDB in gerrit This is to allow us to use the hashtag feature in gerrit We will use

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2016-09-11T10:00:01+0000

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: New Wikidata Build - 2016-09-11T10:00:01+ .. New Wikidata Build - 2016-09-11T10:00:01+ Change-Id: I2c7969b6bd08c7cee1f6e2c40cd0050cb0a3d27c --- M

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Revert "Revert "Add UNIQUE indexes to ores_classification""

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Revert "Revert "Add UNIQUE indexes to ores_classification"" .. Revert "Revert "Add UNIQUE indexes to ores_classification"" This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Revert "Revert "Add UNIQUE indexes to ores_classification""

2016-09-11 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/309837 Change subject: Revert "Revert "Add UNIQUE indexes to ores_classification"" .. Revert "Revert "Add UNIQUE indexes to ores_classification""

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use DB_REPLICA in ContribsPager

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309836 Change subject: Use DB_REPLICA in ContribsPager .. Use DB_REPLICA in ContribsPager Change-Id: Ic225b9c41d989722677caf323846783d7e0638a4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce WikiPage::getContentModel() queries via caching

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309835 Change subject: Reduce WikiPage::getContentModel() queries via caching .. Reduce WikiPage::getContentModel() queries via caching

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Micro-optimisations and get rid of @-prefixed functions

2016-09-11 Thread Seb35 (Code Review)
Seb35 has submitted this change and it was merged. Change subject: Micro-optimisations and get rid of @-prefixed functions .. Micro-optimisations and get rid of @-prefixed functions Code: * Some micro-optimisations to avoid

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Micro-optimisations and get rid of @-prefixed functions

2016-09-11 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/309834 Change subject: Micro-optimisations and get rid of @-prefixed functions .. Micro-optimisations and get rid of @-prefixed functions Code: *

[MediaWiki-commits] [Gerrit] labs...heritage[master]: Replace TestFillTableMonumentsBase by CustomAssertions

2016-09-11 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Replace TestFillTableMonumentsBase by CustomAssertions .. Replace TestFillTableMonumentsBase by CustomAssertions Break out custom asssertions for reuse

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:UserRights: Trim value of $mTarget if it's a string

2016-09-11 Thread Glaisher (Code Review)
Glaisher has uploaded a new change for review. https://gerrit.wikimedia.org/r/309833 Change subject: Special:UserRights: Trim value of $mTarget if it's a string .. Special:UserRights: Trim value of $mTarget if it's a string

[MediaWiki-commits] [Gerrit] All-Projects[refs/meta/config]: Allows you to edit topic names even after merging a change

2016-09-11 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/309832 Change subject: Allows you to edit topic names even after merging a change .. Allows you to edit topic names even after merging a change See

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make DeferredUpdates::execute() protected

2016-09-11 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/309831 Change subject: Make DeferredUpdates::execute() protected .. Make DeferredUpdates::execute() protected Update the only caller, which is

  1   2   >