[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move LoadMonitorMySQL to LoadMonitor

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310733 Change subject: Move LoadMonitorMySQL to LoadMonitor .. Move LoadMonitorMySQL to LoadMonitor * The LoadMonitor interface is now

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused LBFactoryFake class

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unused LBFactoryFake class .. Remove unused LBFactoryFake class Change-Id: I88acf72fc32c7e3c9bead81d11c5adfd8dff6151 --- M autoload.php M

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Only store the full country code if it is on our valid list.

2016-09-14 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. https://gerrit.wikimedia.org/r/310732 Change subject: Only store the full country code if it is on our valid list. .. Only store the full country code if it is on our valid list.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused LBFactoryFake class

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310731 Change subject: Remove unused LBFactoryFake class .. Remove unused LBFactoryFake class Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Use a secure variable so that forks don't spam us

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use a secure variable so that forks don't spam us .. Use a secure variable so that forks don't spam us * This was generated with, travis encrypt

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Use a secure variable so that forks don't spam us

2016-09-14 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. https://gerrit.wikimedia.org/r/310730 Change subject: Use a secure variable so that forks don't spam us .. Use a secure variable so that forks don't spam us * This was generated

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310729 Change subject: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo .. puppet::self::gitclone: Get gitdir from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid MWException and wf* log methods in DatabaseBase

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid MWException and wf* log methods in DatabaseBase .. Avoid MWException and wf* log methods in DatabaseBase Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310728 Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Move 'site' and 'user' logic to makeModuleRe...

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310727 Change subject: resourceloader: Move 'site' and 'user' logic to makeModuleResponse .. resourceloader: Move 'site' and 'user' logic to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move various DB helper classes to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move various DB helper classes to /libs/rdbms .. Move various DB helper classes to /libs/rdbms Change-Id: I0724f1acce4f6c43b1f0983fa119e628e7c53ba5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310726 Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move LoadBalancer to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move LoadBalancer to /libs/rdbms .. Move LoadBalancer to /libs/rdbms Change-Id: Ic87f1cc84ba44be20f345944406e1d8a34be1c96 --- M autoload.php R

[MediaWiki-commits] [Gerrit] mediawiki...examples[master]: Change Commit

2016-09-14 Thread Himavarshini (Code Review)
Himavarshini has uploaded a new change for review. https://gerrit.wikimedia.org/r/310725 Change subject: Change Commit .. Change Commit Change-Id: I523ba3403adef25bf7ddeea2c8b9623faaa3d7e5 --- M Example/Example.php 1 file

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Fix: The topic name is revision-visibility-change

2016-09-14 Thread Mobrovac (Code Review)
Mobrovac has submitted this change and it was merged. Change subject: Fix: The topic name is revision-visibility-change .. Fix: The topic name is revision-visibility-change Change-Id: Iaec4f943add5eb6608edea2e684a0fb7f13bacac

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change DatabaseBase => IDatabase in /db where possible

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Change DatabaseBase => IDatabase in /db where possible .. Change DatabaseBase => IDatabase in /db where possible Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove handling for bad data (language = '_' as we are clean...

2016-09-14 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. https://gerrit.wikimedia.org/r/310724 Change subject: Remove handling for bad data (language = '_' as we are cleaning that up .. Remove handling for bad data (language = '_' as we

[MediaWiki-commits] [Gerrit] integration/config[master]: mediawiki: Merge parsertests job back into main phpunit job

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: mediawiki: Merge parsertests job back into main phpunit job .. mediawiki: Merge parsertests job back into main phpunit job This was originally separated

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change $wiki => $domain in LoadBalancer

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Change $wiki => $domain in LoadBalancer .. Change $wiki => $domain in LoadBalancer Change-Id: I97f96383c501e9b3262c11d143795b82ae36aca5 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Exception cleanups for LoadBalancer

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Exception cleanups for LoadBalancer .. Exception cleanups for LoadBalancer * Make the error message itself be dumb/raw. * Make the exception exposer show

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change $wiki => $domain in LoadBalancer

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310723 Change subject: Change $wiki => $domain in LoadBalancer .. Change $wiki => $domain in LoadBalancer Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Simplify mock object syntax in includes/db/ tests

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: phpunit: Simplify mock object syntax in includes/db/ tests .. phpunit: Simplify mock object syntax in includes/db/ tests * Omit redundant `expects(

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change DatabaseBase => IDatabase in /db where possible

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310722 Change subject: Change DatabaseBase => IDatabase in /db where possible .. Change DatabaseBase => IDatabase in /db where possible

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: Remove unneeded puppet-lint ignore rules

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: toollabs: Remove unneeded puppet-lint ignore rules .. toollabs: Remove unneeded puppet-lint ignore rules They are not needed since puppet lint does not fail

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga/phab: adjust checkcommand for phabricator http check

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: icinga/phab: adjust checkcommand for phabricator http check .. icinga/phab: adjust checkcommand for phabricator http check For unknown reasons this existing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga/phab: adjust checkcommand for phabricator http check

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310721 Change subject: icinga/phab: adjust checkcommand for phabricator http check .. icinga/phab: adjust checkcommand for phabricator http check For

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid MWException and wf* log methods in DatabaseBase

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310720 Change subject: Avoid MWException and wf* log methods in DatabaseBase .. Avoid MWException and wf* log methods in DatabaseBase

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] Beta: Clean puppetmaster cherry-picks

2016-09-14 Thread Thcipriani (Code Review)
Thcipriani has uploaded a new change for review. https://gerrit.wikimedia.org/r/310719 Change subject: [WIP] Beta: Clean puppetmaster cherry-picks .. [WIP] Beta: Clean puppetmaster cherry-picks This is an attempt to reduce

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet Panel: Actually populate the prefix panel with prefi...

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310718 Change subject: Puppet Panel: Actually populate the prefix panel with prefixes. .. Puppet Panel: Actually populate the prefix panel

[MediaWiki-commits] [Gerrit] operations/puppet[production]: apache: fix 42 x 'class not documented', add doc links

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310717 Change subject: apache: fix 42 x 'class not documented', add doc links .. apache: fix 42 x 'class not documented', add doc links Fixes 42 lint

[MediaWiki-commits] [Gerrit] oojs/ui[master]: ComboBoxInputWidget: Hide dropdown indicator when there is n...

2016-09-14 Thread VolkerE (Code Review)
VolkerE has uploaded a new change for review. https://gerrit.wikimedia.org/r/310716 Change subject: ComboBoxInputWidget: Hide dropdown indicator when there is no dropdown .. ComboBoxInputWidget: Hide dropdown indicator when

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move DBConnRef and ChronologyProtector to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move DBConnRef and ChronologyProtector to /libs/rdbms .. Move DBConnRef and ChronologyProtector to /libs/rdbms Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: Remove unneeded puppet-lint ignore rules

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310715 Change subject: toollabs: Remove unneeded puppet-lint ignore rules .. toollabs: Remove unneeded puppet-lint ignore rules They are not needed

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move TransactionProfiler to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move TransactionProfiler to /libs/rdbms .. Move TransactionProfiler to /libs/rdbms Change-Id: I13173facc9f101bca69e3bf3e85f292f8468e855 --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Clean up antifraud queue usage

2016-09-14 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Clean up antifraud queue usage .. Clean up antifraud queue usage No more KeyedOpaqueStorableObject or mirroring to ActiveMQ, just push an array straight to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make WikiPage::getRevision() make use of Revision::newKnownC...

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Make WikiPage::getRevision() make use of Revision::newKnownCurrent() .. Make WikiPage::getRevision() make use of Revision::newKnownCurrent() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix missing dependency of ext.visualEditor.mwwikitext upon e...

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310714 Change subject: Fix missing dependency of ext.visualEditor.mwwikitext upon ext.visualEditor.desktopArticleTarget .. Fix missing dependency

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Fix missing dependency of ext.proofreadpage.ve.pageTarget up...

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310713 Change subject: Fix missing dependency of ext.proofreadpage.ve.pageTarget upon ext.visualEditor.desktopArticleTarget .. Fix missing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mysql_wmf: Use require_package instead of package latest

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310712 Change subject: mysql_wmf: Use require_package instead of package latest .. mysql_wmf: Use require_package instead of package latest Bug:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: requesttracker: Use require_package instead of package latest

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310711 Change subject: requesttracker: Use require_package instead of package latest .. requesttracker: Use require_package instead of package

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add 'IF NOT EXISTS' to table creation

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add 'IF NOT EXISTS' to table creation .. Add 'IF NOT EXISTS' to table creation Because too lazy for proper schema migration Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Remove all traces of stomp pending queue

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove all traces of stomp pending queue .. Remove all traces of stomp pending queue DEPLOYMENT NOTE: Redis queue is now just called 'pending' Bug:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests .. Fix 'new ve.dm.Transaction.newFromInsertion' typos in tests They were harmless because the

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use correct switch type when opening welcome dialog on NWE

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310709 Change subject: Use correct switch type when opening welcome dialog on NWE .. Use correct switch type when opening welcome dialog on NWE

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gridengine: use present instead of latest in package

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310710 Change subject: gridengine: use present instead of latest in package .. gridengine: use present instead of latest in package Bug: T115348

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: More DB related class cleanups to prepare files for /libs

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: More DB related class cleanups to prepare files for /libs .. More DB related class cleanups to prepare files for /libs * Cleaned up some related logging

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: Use require_package instead of package latest

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310708 Change subject: contint: Use require_package instead of package latest .. contint: Use require_package instead of package latest Bug:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add 'IF NOT EXISTS' to table creation

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310707 Change subject: Add 'IF NOT EXISTS' to table creation .. Add 'IF NOT EXISTS' to table creation Because too lazy for proper schema migration

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Re-add parser tests to the ParserTests group

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Re-add parser tests to the ParserTests group .. Re-add parser tests to the ParserTests group It was omitted due to the new way in which parser test

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix broken select() call in rebuildFileCache.php

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix broken select() call in rebuildFileCache.php .. Fix broken select() call in rebuildFileCache.php A few other small cleanups Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ldap: Use require_package instead of package latest

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310706 Change subject: ldap: Use require_package instead of package latest .. ldap: Use require_package instead of package latest Bug: T115348

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make WikiPage::getRevision() make use of Revision::newKnownC...

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310705 Change subject: Make WikiPage::getRevision() make use of Revision::newKnownCurrent() .. Make WikiPage::getRevision() make use of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: contint: don't use ensure 'latest' with php packages

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310704 Change subject: contint: don't use ensure 'latest' with php packages .. contint: don't use ensure 'latest' with php packages As part of the

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move IDatabase/ILoadBalancer to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move IDatabase/ILoadBalancer to /libs/rdbms .. Move IDatabase/ILoadBalancer to /libs/rdbms Change-Id: I71f980b1024dc2fbca9cafbad2c9daebb6f28c9b --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Defaults for more queues

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Defaults for more queues .. Defaults for more queues Add Redis versions of donations, refunds, and recurring Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mediawiki_singlenode: Use require_package instead of package...

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310703 Change subject: mediawiki_singlenode: Use require_package instead of package latest .. mediawiki_singlenode: Use require_package instead of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Use require_package instead of package latest

2016-09-14 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310702 Change subject: mariadb: Use require_package instead of package latest .. mariadb: Use require_package instead of package latest Bug:

[MediaWiki-commits] [Gerrit] integration/config[master]: mediawiki: Merge parsertests job back into main phpunit job

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310701 Change subject: mediawiki: Merge parsertests job back into main phpunit job .. mediawiki: Merge parsertests job back into main phpunit job

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: How many times it explodes?

2016-09-14 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/310700 Change subject: How many times it explodes? .. How many times it explodes? Change-Id: I2e10d06d022b810563d46254ebae969336e462ce --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Upload.BookletLayout: Fix typo in comment

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.Upload.BookletLayout: Fix typo in comment .. mediawiki.Upload.BookletLayout: Fix typo in comment Follows-up 33041b752d. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Re-add parser tests to the ParserTests group

2016-09-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. https://gerrit.wikimedia.org/r/310699 Change subject: Re-add parser tests to the ParserTests group .. Re-add parser tests to the ParserTests group It was omitted due to the

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Reject isRequeue messages after expiry

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Reject isRequeue messages after expiry .. Reject isRequeue messages after expiry FIXME: configurable variables are kinda lying. Should replace max

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Update the badges' seen state when Special:Notifications is ...

2016-09-14 Thread Mooeypoo (Code Review)
Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/310698 Change subject: Update the badges' seen state when Special:Notifications is visited .. Update the badges' seen state when

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make SiteStatsUpdate implement MergeableUpdate

2016-09-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Make SiteStatsUpdate implement MergeableUpdate .. Make SiteStatsUpdate implement MergeableUpdate Change-Id: I53c9bf133f0707f2fa203ddd1a7fcb65be8b1329 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role: move mediawiki::install to autoloader layout

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: role: move mediawiki::install to autoloader layout .. role: move mediawiki::install to autoloader layout Bug: T93645 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix $wgFileCache DB outage fallback

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310696 Change subject: Fix $wgFileCache DB outage fallback .. Fix $wgFileCache DB outage fallback Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make rebuildFileCache cover ?action=history

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310697 Change subject: Make rebuildFileCache cover ?action=history .. Make rebuildFileCache cover ?action=history Also simplified the logic

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix broken select() call in rebuildFileCache.php

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310695 Change subject: Fix broken select() call in rebuildFileCache.php .. Fix broken select() call in rebuildFileCache.php A few other small

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet Panel: rename panel files

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Puppet Panel: rename panel files .. Puppet Panel: rename panel files Change-Id: Id72fe7c300a5641bfbb4ef8b6184a41b23dc202d --- M

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Hair-raising hack to pass dummy gateway response code to Don...

2016-09-14 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/310694 Change subject: Hair-raising hack to pass dummy gateway response code to DonationInterface .. Hair-raising hack to pass dummy gateway

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet Panel: rename panel files

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310693 Change subject: Puppet Panel: rename panel files .. Puppet Panel: rename panel files Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: repository: fix error verbosity

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: repository: fix error verbosity .. repository: fix error verbosity Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e Signed-off-by: Loic Dachary

[MediaWiki-commits] [Gerrit] operations/puppet[production]: delete ircyall module and role

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310692 Change subject: delete ircyall module and role .. delete ircyall module and role This module and role is apparently not used on any labs

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Expand "other" countries data

2016-09-14 Thread Bearloga (Code Review)
Bearloga has submitted this change and it was merged. Change subject: Expand "other" countries data .. Expand "other" countries data - Traffic, clickthrough rate, number of visits, ctr_visit (proportion of visits that have at

[MediaWiki-commits] [Gerrit] analytics/discovery-stats[production]: Ensure all metrics are logged with the same time

2016-09-14 Thread MaxSem (Code Review)
MaxSem has submitted this change and it was merged. Change subject: Ensure all metrics are logged with the same time .. Ensure all metrics are logged with the same time Bug: T144652 Change-Id:

[MediaWiki-commits] [Gerrit] analytics/discovery-stats[production]: Ensure all metrics are logged with the same time

2016-09-14 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/310691 Change subject: Ensure all metrics are logged with the same time .. Ensure all metrics are logged with the same time Bug: T144652 Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: repository: fix error verbosity

2016-09-14 Thread Dachary (Code Review)
Dachary has uploaded a new change for review. https://gerrit.wikimedia.org/r/310690 Change subject: repository: fix error verbosity .. repository: fix error verbosity Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.28.0-wmf.19]: Always serve all the data on preview

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Always serve all the data on preview .. Always serve all the data on preview Bug: T145615 Change-Id: I1a58a9e613a59a4259081fbb8dfb9a39aa813964 (cherry

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Reorder functions to reduce forward declarations

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Reorder functions to reduce forward declarations .. Reorder functions to reduce forward declarations Change-Id: I13cdf676cf7cb468966dd1a6ceca248c3e46d6ad

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ircyall: move role to module/role

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: ircyall: move role to module/role .. ircyall: move role to module/role Change-Id: I59eeb42bf6a486990aa2b4e939a6541f7cddd3af --- R

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add logging channel for NewUserMessage

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add logging channel for NewUserMessage .. Add logging channel for NewUserMessage I'll be adding logging for failures to leave a message, e.g. due to an

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: Use YAML.load instead of .parse for loading YAML

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has submitted this change and it was merged. Change subject: labs: Use YAML.load instead of .parse for loading YAML .. labs: Use YAML.load instead of .parse for loading YAML Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: snapshot: Fix variable contains an uppercase letter

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: snapshot: Fix variable contains an uppercase letter .. snapshot: Fix variable contains an uppercase letter Bug: T93645 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: Use YAML.load instead of .parse for loading YAML

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/310689 Change subject: labs: Use YAML.load instead of .parse for loading YAML .. labs: Use YAML.load instead of .parse for loading YAML

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache_upload: do not set do_stream=true on Varnish 4

2016-09-14 Thread Ema (Code Review)
Ema has uploaded a new change for review. https://gerrit.wikimedia.org/r/310551 Change subject: cache_upload: do not set do_stream=true on Varnish 4 .. cache_upload: do not set do_stream=true on Varnish 4 Varnish 4 already

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Fix whitespace error

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: puppetmaster: Fix whitespace error .. puppetmaster: Fix whitespace error Fixes ERROR: trailing whitespace found on line 11 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Upload.BookletLayout: Fix typo in comment

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310688 Change subject: mediawiki.Upload.BookletLayout: Fix typo in comment .. mediawiki.Upload.BookletLayout: Fix typo in comment Follows-up

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Force straight join for prop=linkshere|transcludedin|fi...

2016-09-14 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. https://gerrit.wikimedia.org/r/310552 Change subject: API: Force straight join for prop=linkshere|transcludedin|fileusage .. API: Force straight join for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tendril: fix 'optional before required parameter'

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: tendril: fix 'optional before required parameter' .. tendril: fix 'optional before required parameter' Change-Id: I09cf80df0f1421fad13f491a3d87e2f18aea3fdb ---

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: More fixups to httpyaml hiera backend

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has submitted this change and it was merged. Change subject: labs: More fixups to httpyaml hiera backend .. labs: More fixups to httpyaml hiera backend Change-Id: If7155d50b15bcb4af2ea367c894abbdae44837b5 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: More fixups to httpyaml hiera backend

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/310687 Change subject: labs: More fixups to httpyaml hiera backend .. labs: More fixups to httpyaml hiera backend Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Simplify mock object syntax in includes/db/ tests

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310686 Change subject: phpunit: Simplify mock object syntax in includes/db/ tests .. phpunit: Simplify mock object syntax in includes/db/ tests *

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tendril: fix 'optional before required parameter'

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310685 Change subject: tendril: fix 'optional before required parameter' .. tendril: fix 'optional before required parameter' Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add per-prefix config tabs

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Puppet panel: Add per-prefix config tabs .. Puppet panel: Add per-prefix config tabs This is a roughed-in design with a few placeholder tabs. Bug:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: remove an extra /div

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Puppet panel: remove an extra /div .. Puppet panel: remove an extra /div Change-Id: I3ed6d5014995192e217fadb70de71e108a622575 --- M

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceFoundation[master]: TaskApi permissions: Fixed fatal

2016-09-14 Thread Pwirth (Code Review)
Pwirth has submitted this change and it was merged. Change subject: TaskApi permissions: Fixed fatal .. TaskApi permissions: Fixed fatal A fatal error occured when a user has no 'read' permission. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Make sure tests fail on missing response file

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310684 Change subject: Make sure tests fail on missing response file .. Make sure tests fail on missing response file We were relying on something

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add a missing /div

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310682 Change subject: Puppet panel: Add a missing /div .. Puppet panel: Add a missing /div Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add per-prefix config tabs

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310683 Change subject: Puppet panel: Add per-prefix config tabs .. Puppet panel: Add per-prefix config tabs This is a roughed-in design

  1   2   3   4   >