[MediaWiki-commits] [Gerrit] @root.submitted may not exist in flow_reply_form - change (mediawiki...Flow)

2014-09-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/160115 Change subject: @root.submitted may not exist in flow_reply_form .. @root.submitted may not exist in flow_reply_form For no-js version of

[MediaWiki-commits] [Gerrit] Remove direct echo db access from mobilefrontend - change (mediawiki...MobileFrontend)

2014-09-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/160159 Change subject: Remove direct echo db access from mobilefrontend .. Remove direct echo db access from mobilefrontend This revives

[MediaWiki-commits] [Gerrit] wfDebugLog exception if thrown during formatting - change (mediawiki...Echo)

2014-09-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159801 Change subject: wfDebugLog exception if thrown during formatting .. wfDebugLog exception if thrown during formatting Some exception is not

[MediaWiki-commits] [Gerrit] Add emailsubject as a distribution type - change (mediawiki...Echo)

2014-09-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159840 Change subject: Add emailsubject as a distribution type .. Add emailsubject as a distribution type so that we could skip parameters escaping

[MediaWiki-commits] [Gerrit] Update flow reply subject - change (mediawiki...Flow)

2014-09-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159864 Change subject: Update flow reply subject .. Update flow reply subject This needs the Echo patch: https://gerrit.wikimedia.org/r/#/c/159840/

[MediaWiki-commits] [Gerrit] Add job to keep user echo notifications in reasonable volume - change (mediawiki...Echo)

2014-09-09 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159413 Change subject: Add job to keep user echo notifications in reasonable volume .. Add job to keep user echo notifications in reasonable volume

[MediaWiki-commits] [Gerrit] Move flow-mention back to flow-discussion category - change (mediawiki...Flow)

2014-09-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159194 Change subject: Move flow-mention back to flow-discussion category .. Move flow-mention back to flow-discussion category We want to disable

[MediaWiki-commits] [Gerrit] Both notifyNewTopic and notifyPostChange trigger mention notif - change (mediawiki...Flow)

2014-09-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159203 Change subject: Both notifyNewTopic and notifyPostChange trigger mention notif .. Both notifyNewTopic and notifyPostChange trigger mention

[MediaWiki-commits] [Gerrit] Colors are backwards for flyout section link - change (mediawiki...Echo)

2014-09-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159222 Change subject: Colors are backwards for flyout section link .. Colors are backwards for flyout section link Also make active section link not

[MediaWiki-commits] [Gerrit] Remove (X) next to Alerts/Messages if there is one section - change (mediawiki...Echo)

2014-09-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/159228 Change subject: Remove (X) next to Alerts/Messages if there is one section .. Remove (X) next to Alerts/Messages if there is one section

[MediaWiki-commits] [Gerrit] mw.echo.overlay.updateCount() not longer exists - change (mediawiki...Echo)

2014-09-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158790 Change subject: mw.echo.overlay.updateCount() not longer exists .. mw.echo.overlay.updateCount() not longer exists If you have an unread

[MediaWiki-commits] [Gerrit] Hide 'Cancel' button on preview screen - change (mediawiki...Flow)

2014-09-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158818 Change subject: Hide 'Cancel' button on preview screen .. Hide 'Cancel' button on preview screen Change-Id:

[MediaWiki-commits] [Gerrit] Remove redundant $template var from block renderAPI() method - change (mediawiki...Flow)

2014-09-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158825 Change subject: Remove redundant $template var from block renderAPI() method .. Remove redundant $template var from block renderAPI() method

[MediaWiki-commits] [Gerrit] Do not notify Topic creator on post edit/moderation - change (mediawiki...Flow)

2014-09-04 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158521 Change subject: Do not notify Topic creator on post edit/moderation .. Do not notify Topic creator on post edit/moderation Change-Id:

[MediaWiki-commits] [Gerrit] Decode data coming from URL - change (mediawiki...Flow)

2014-09-04 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158549 Change subject: Decode data coming from URL .. Decode data coming from URL Change-Id: I396c14578cc49c8cc10faf01ba83f46f2636cbf1 --- M

[MediaWiki-commits] [Gerrit] Implement post history - change (mediawiki...Flow)

2014-09-03 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158302 Change subject: Implement post history .. Implement post history Link like the following would throw exception:

[MediaWiki-commits] [Gerrit] Update text 'User Contributsions' to 'contribs' - change (mediawiki...Flow)

2014-09-03 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/158309 Change subject: Update text 'User Contributsions' to 'contribs' .. Update text 'User Contributsions' to 'contribs' Also remove the linking of

[MediaWiki-commits] [Gerrit] There is no welcome notification - change (mediawiki...Echo)

2014-08-28 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156961 Change subject: There is no welcome notification .. There is no welcome notification Bug: 70139 Change-Id:

[MediaWiki-commits] [Gerrit] template if / unless mismatch - change (mediawiki...Flow)

2014-08-28 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156983 Change subject: template if / unless mismatch .. template if / unless mismatch Change-Id: I80cdc0cb807f9c48135a18bccb799d516c4d2738 --- M

[MediaWiki-commits] [Gerrit] [WIP]Remove old notifications - change (mediawiki...Echo)

2014-08-28 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/157029 Change subject: [WIP]Remove old notifications .. [WIP]Remove old notifications Change-Id: Ibe3141f6b617bb3eec8a7486ceb371626ea65bd7 --- A

[MediaWiki-commits] [Gerrit] Specify which event type to use job queue - change (mediawiki...Echo)

2014-08-27 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156594 Change subject: Specify which event type to use job queue .. Specify which event type to use job queue This will allow us to specify which

[MediaWiki-commits] [Gerrit] Use job queue to process Flow notifications - change (mediawiki...Flow)

2014-08-27 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156598 Change subject: Use job queue to process Flow notifications .. Use job queue to process Flow notifications Depends on:

[MediaWiki-commits] [Gerrit] Revert this for now due to Echo not being stable, I don't wa... - change (mediawiki...MobileFrontend)

2014-08-27 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156696 Change subject: Revert this for now due to Echo not being stable, I don't want to break MobileFrontend, :), Re-apply this code back when the new Echo code is in both deployment branches

[MediaWiki-commits] [Gerrit] Turn on email bundling for post edit/reply + instructions - change (mediawiki...Flow)

2014-08-27 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156702 Change subject: Turn on email bundling for post edit/reply + instructions .. Turn on email bundling for post edit/reply + instructions To test

[MediaWiki-commits] [Gerrit] Add profiling to Echo notification API - change (mediawiki...Echo)

2014-08-27 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156737 Change subject: Add profiling to Echo notification API .. Add profiling to Echo notification API Change-Id:

[MediaWiki-commits] [Gerrit] Continue offset is missing in the read API - change (mediawiki...Echo)

2014-08-26 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156445 Change subject: Continue offset is missing in the read API .. Continue offset is missing in the read API When the notification is retrieved

[MediaWiki-commits] [Gerrit] Fallback to master lookup for title when lookup in slave fails - change (mediawiki...Echo)

2014-08-26 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156466 Change subject: Fallback to master lookup for title when lookup in slave fails .. Fallback to master lookup for title when lookup in slave

[MediaWiki-commits] [Gerrit] Redirect to Flow view action when url action is set to edit - change (mediawiki...Flow)

2014-08-25 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/156183 Change subject: Redirect to Flow view action when url action is set to edit .. Redirect to Flow view action when url action is set to edit

[MediaWiki-commits] [Gerrit] Revert Make timestamp in consistent format after loaded fro... - change (mediawiki...Echo)

2014-08-22 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155828 Change subject: Revert Make timestamp in consistent format after loaded from database .. Revert Make timestamp in consistent format after

[MediaWiki-commits] [Gerrit] Make timestamp in consistent format after loaded from database - change (mediawiki...Echo)

2014-08-22 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155842 Change subject: Make timestamp in consistent format after loaded from database .. Make timestamp in consistent format after loaded from

[MediaWiki-commits] [Gerrit] Message on diff page for post should use board title, not UUID - change (mediawiki...Flow)

2014-08-22 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155849 Change subject: Message on diff page for post should use board title, not UUID .. Message on diff page for post should use board title, not

[MediaWiki-commits] [Gerrit] Set UnitTestsList hook run against files inside tests/phpunit - change (mediawiki...Echo)

2014-08-22 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155858 Change subject: Set UnitTestsList hook run against files inside tests/phpunit .. Set UnitTestsList hook run against files inside tests/phpunit

[MediaWiki-commits] [Gerrit] Do not show board watch star in a topoic page - change (mediawiki...Flow)

2014-08-21 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155597 Change subject: Do not show board watch star in a topoic page .. Do not show board watch star in a topoic page bug: 69764 Change-Id:

[MediaWiki-commits] [Gerrit] Put created new topic notification in new notification style - change (mediawiki...Flow)

2014-08-21 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155651 Change subject: Put created new topic notification in new notification style .. Put created new topic notification in new notification style

[MediaWiki-commits] [Gerrit] Remove 'View Board' from all Flow notifications - change (mediawiki...Flow)

2014-08-21 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155653 Change subject: Remove 'View Board' from all Flow notifications .. Remove 'View Board' from all Flow notifications This actually introduces a

[MediaWiki-commits] [Gerrit] Remove direct echo db access from mobilefrontend - change (mediawiki...MobileFrontend)

2014-08-21 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155663 Change subject: Remove direct echo db access from mobilefrontend .. Remove direct echo db access from mobilefrontend * It should just use the

[MediaWiki-commits] [Gerrit] Make IE not cache ajax request - change (mediawiki...Flow)

2014-08-20 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155463 Change subject: Make IE not cache ajax request .. Make IE not cache ajax request Bug: 69160 Change-Id:

[MediaWiki-commits] [Gerrit] Missing 3rd argument in onAfterInsert() function call - change (mediawiki...Flow)

2014-08-20 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155470 Change subject: Missing 3rd argument in onAfterInsert() function call .. Missing 3rd argument in onAfterInsert() function call Bug: 69767

[MediaWiki-commits] [Gerrit] JS load of topic with garbled post breaks board interactivity - change (mediawiki...Flow)

2014-08-20 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155474 Change subject: JS load of topic with garbled post breaks board interactivity .. JS load of topic with garbled post breaks board interactivity

[MediaWiki-commits] [Gerrit] Add support for adding deferred update within a deferred update - change (mediawiki/core)

2014-08-19 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155151 Change subject: Add support for adding deferred update within a deferred update .. Add support for adding deferred update within a deferred

[MediaWiki-commits] [Gerrit] Defer Flow notification triggering till end of request - change (mediawiki...Flow)

2014-08-19 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155152 Change subject: Defer Flow notification triggering till end of request .. Defer Flow notification triggering till end of request This will

[MediaWiki-commits] [Gerrit] Enable job queue to process notification on mediawikiwiki - change (operations/mediawiki-config)

2014-08-19 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/155169 Change subject: Enable job queue to process notification on mediawikiwiki .. Enable job queue to process notification on mediawikiwiki See

[MediaWiki-commits] [Gerrit] Add waitForSlave() wrapper function to Echo Database wrapper - change (mediawiki...Echo)

2014-08-18 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154952 Change subject: Add waitForSlave() wrapper function to Echo Database wrapper .. Add waitForSlave() wrapper function to Echo Database wrapper

[MediaWiki-commits] [Gerrit] Make timestamp in consistent format after loaded from database - change (mediawiki...Echo)

2014-08-18 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154963 Change subject: Make timestamp in consistent format after loaded from database .. Make timestamp in consistent format after loaded from

[MediaWiki-commits] [Gerrit] [4] Code cleanup and miscellneous fix - change (mediawiki...Echo)

2014-08-16 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154386 Change subject: [4] Code cleanup and miscellneous fix .. [4] Code cleanup and miscellneous fix * cache function result in local variables *

[MediaWiki-commits] [Gerrit] [5] Add revision local cache holder object - change (mediawiki...Echo)

2014-08-16 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154387 Change subject: [5] Add revision local cache holder object .. [5] Add revision local cache holder object Change-Id:

[MediaWiki-commits] [Gerrit] [1] Make title lazy loaded in EchoEvent - change (mediawiki...Echo)

2014-08-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154380 Change subject: [1] Make title lazy loaded in EchoEvent .. [1] Make title lazy loaded in EchoEvent * We can batch load titles and load it when

[MediaWiki-commits] [Gerrit] [2] Add title local cache holder objects - change (mediawiki...Echo)

2014-08-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154381 Change subject: [2] Add title local cache holder objects .. [2] Add title local cache holder objects Change-Id:

[MediaWiki-commits] [Gerrit] [3] Use title local cache to cache title object - change (mediawiki...Echo)

2014-08-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154382 Change subject: [3] Use title local cache to cache title object .. [3] Use title local cache to cache title object Change-Id:

[MediaWiki-commits] [Gerrit] Revert Revert Merge remote-tracking branch 'gerrit/master'... - change (mediawiki...Echo)

2014-08-14 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/154110 Change subject: Revert Revert Merge remote-tracking branch 'gerrit/master' into two_tabs .. Revert Revert Merge remote-tracking branch

[MediaWiki-commits] [Gerrit] Add support to mark all as read for sections - change (mediawiki...Echo)

2014-08-13 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153960 Change subject: Add support to mark all as read for sections .. Add support to mark all as read for sections This also updates the way how

[MediaWiki-commits] [Gerrit] Add support to retrieve unread + read notifcations for section - change (mediawiki...Echo)

2014-08-13 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153994 Change subject: Add support to retrieve unread + read notifcations for section .. Add support to retrieve unread + read notifcations for

[MediaWiki-commits] [Gerrit] Add abstract model and mapper for notification - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153637 Change subject: Add abstract model and mapper for notification .. Add abstract model and mapper for notification Change-Id:

[MediaWiki-commits] [Gerrit] Add abstract model and mapper for notification - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153650 Change subject: Add abstract model and mapper for notification .. Add abstract model and mapper for notification Change-Id:

[MediaWiki-commits] [Gerrit] Add TargetPage model and mapper to notifications - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153651 Change subject: Add TargetPage model and mapper to notifications .. Add TargetPage model and mapper to notifications This will be used for

[MediaWiki-commits] [Gerrit] Move 'notification count refresh' logic out of mapper - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153702 Change subject: Move 'notification count refresh' logic out of mapper .. Move 'notification count refresh' logic out of mapper Change-Id:

[MediaWiki-commits] [Gerrit] use array_merge_resursive when merging based on array keys - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153725 Change subject: use array_merge_resursive when merging based on array keys .. use array_merge_resursive when merging based on array keys

[MediaWiki-commits] [Gerrit] Add method for fetching unread notifications - change (mediawiki...Echo)

2014-08-12 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153734 Change subject: Add method for fetching unread notifications .. Add method for fetching unread notifications Change-Id:

[MediaWiki-commits] [Gerrit] Add sub-directories to phpunit test - change (mediawiki...Echo)

2014-08-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153458 Change subject: Add sub-directories to phpunit test .. Add sub-directories to phpunit test Change-Id:

[MediaWiki-commits] [Gerrit] X on notification item to mark as read - change (mediawiki...Echo)

2014-08-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153529 Change subject: X on notification item to mark as read .. X on notification item to mark as read This will need the corresponding Flow patch:

[MediaWiki-commits] [Gerrit] [WIP]Delete invalid records from echo_target_page - change (mediawiki...Echo)

2014-08-10 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153372 Change subject: [WIP]Delete invalid records from echo_target_page .. [WIP]Delete invalid records from echo_target_page Purpose: * If a page

[MediaWiki-commits] [Gerrit] Add 'target-page' param to flow notifications - change (mediawiki...Flow)

2014-08-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152935 Change subject: Add 'target-page' param to flow notifications .. Add 'target-page' param to flow notifications This depends on echo patch:

[MediaWiki-commits] [Gerrit] Missing sectionId in flow_anon_warning.handlebars - change (mediawiki...Flow)

2014-08-08 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/153006 Change subject: Missing sectionId in flow_anon_warning.handlebars .. Missing sectionId in flow_anon_warning.handlebars Change-Id:

[MediaWiki-commits] [Gerrit] [WIP]Create TargetPage data if specified by EchoEvent - change (mediawiki...Echo)

2014-08-07 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152808 Change subject: [WIP]Create TargetPage data if specified by EchoEvent .. [WIP]Create TargetPage data if specified by EchoEvent @Todo - handle

[MediaWiki-commits] [Gerrit] [WIP]Mark notification as read upon visiting a page - change (mediawiki...Echo)

2014-08-06 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152198 Change subject: [WIP]Mark notification as read upon visiting a page .. [WIP]Mark notification as read upon visiting a page Change-Id:

[MediaWiki-commits] [Gerrit] Only auto mark notification read if it doesn't have targe page - change (mediawiki...Echo)

2014-08-06 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152203 Change subject: Only auto mark notification read if it doesn't have targe page .. Only auto mark notification read if it doesn't have targe

[MediaWiki-commits] [Gerrit] Echo/tests/ directory structure should mimic Echo/ directory's - change (mediawiki...Echo)

2014-08-06 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152204 Change subject: Echo/tests/ directory structure should mimic Echo/ directory's .. Echo/tests/ directory structure should mimic Echo/

[MediaWiki-commits] [Gerrit] Remove redundant global variable $wgEchoBackendName - change (mediawiki...Echo)

2014-08-06 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/152211 Change subject: Remove redundant global variable $wgEchoBackendName .. Remove redundant global variable $wgEchoBackendName @Todo * Need some

[MediaWiki-commits] [Gerrit] $checkmatrixOptions has an extra '-' in the key - change (mediawiki/core)

2014-08-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151972 Change subject: $checkmatrixOptions has an extra '-' in the key .. $checkmatrixOptions has an extra '-' in the key examples: 1. prefix:

[MediaWiki-commits] [Gerrit] Add support for splitting notifications into alert message - change (mediawiki...Echo)

2014-08-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151974 Change subject: Add support for splitting notifications into alert message .. Add support for splitting notifications into alert message

[MediaWiki-commits] [Gerrit] [WIP]Add TargetPage model and mapper to notifications - change (mediawiki...Echo)

2014-08-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151992 Change subject: [WIP]Add TargetPage model and mapper to notifications .. [WIP]Add TargetPage model and mapper to notifications This will be

[MediaWiki-commits] [Gerrit] [WIP]Add abastract model and mapper - change (mediawiki...Echo)

2014-08-05 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151999 Change subject: [WIP]Add abastract model and mapper .. [WIP]Add abastract model and mapper Change-Id:

[MediaWiki-commits] [Gerrit] Hygiene: Update method documentation add exception to a file - change (mediawiki...Echo)

2014-08-04 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151803 Change subject: Hygiene: Update method documentation add exception to a file .. Hygiene: Update method documentation add exception to a file

[MediaWiki-commits] [Gerrit] Add mw-ui-text-truncated to overlay and special page - change (mediawiki...Echo)

2014-08-04 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151805 Change subject: Add mw-ui-text-truncated to overlay and special page .. Add mw-ui-text-truncated to overlay and special page To support

[MediaWiki-commits] [Gerrit] Flow notification item new style - change (mediawiki...Flow)

2014-08-03 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/151537 Change subject: Flow notification item new style .. Flow notification item new style * Remove the snippet as requested * Truncate topic title

[MediaWiki-commits] [Gerrit] Fix a function param in API - change (mediawiki...Echo)

2014-07-31 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150876 Change subject: Fix a function param in API .. Fix a function param in API The distributionType is still passed to the function, it will be

[MediaWiki-commits] [Gerrit] static method should be declared with static - change (mediawiki...Echo)

2014-07-31 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150904 Change subject: static method should be declared with static .. static method should be declared with static Change-Id:

[MediaWiki-commits] [Gerrit] method signature has to match parent method - change (mediawiki...Flow)

2014-07-31 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150961 Change subject: method signature has to match parent method .. method signature has to match parent method Otherwise it produces a strict

[MediaWiki-commits] [Gerrit] Enable job queue to process notification on all wikis - change (operations/mediawiki-config)

2014-07-30 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150742 Change subject: Enable job queue to process notification on all wikis .. Enable job queue to process notification on all wikis See

[MediaWiki-commits] [Gerrit] Only trigger 'mark as read' API if unread notification is not 0 - change (mediawiki...MobileFrontend)

2014-07-29 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150394 Change subject: Only trigger 'mark as read' API if unread notification is not 0 .. Only trigger 'mark as read' API if unread notification is

[MediaWiki-commits] [Gerrit] Exception Caught: could not locate workflow for revision - change (mediawiki...Flow)

2014-07-29 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/150462 Change subject: Exception Caught: could not locate workflow for revision .. Exception Caught: could not locate workflow for revision Creating

[MediaWiki-commits] [Gerrit] Clicking on 'Edit title' leads to edit title page - change (mediawiki...Flow)

2014-07-25 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/149365 Change subject: Clicking on 'Edit title' leads to edit title page .. Clicking on 'Edit title' leads to edit title page overrides should have a

[MediaWiki-commits] [Gerrit] Fix incorrect varaible name - change (mediawiki...Echo)

2014-07-24 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/149208 Change subject: Fix incorrect varaible name .. Fix incorrect varaible name Change-Id: Iddf620954c3709e7c03c0b06e0bf8f3d08df366b --- M

[MediaWiki-commits] [Gerrit] Add Flow notification to 'message' notification section - change (mediawiki...Flow)

2014-07-22 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/148571 Change subject: Add Flow notification to 'message' notification section .. Add Flow notification to 'message' notification section Change-Id:

[MediaWiki-commits] [Gerrit] Formatter Fix for related Echo change - change (mediawiki...Flow)

2014-07-20 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/148011 Change subject: Formatter Fix for related Echo change .. Formatter Fix for related Echo change Related:

[MediaWiki-commits] [Gerrit] [WIP]Replace EchoBackend with mappers and gateway - change (mediawiki...Echo)

2014-07-17 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/147369 Change subject: [WIP]Replace EchoBackend with mappers and gateway .. [WIP]Replace EchoBackend with mappers and gateway * Get rid of

[MediaWiki-commits] [Gerrit] Enable job queue to process notification in test/test2 wiki - change (operations/mediawiki-config)

2014-07-16 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146849 Change subject: Enable job queue to process notification in test/test2 wiki .. Enable job queue to process notification in test/test2 wiki Job

[MediaWiki-commits] [Gerrit] Update TOC line height font size - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146357 Change subject: Update TOC line height font size .. Update TOC line height font size Change-Id: I20aabe642203f6483232dcd9590d86558d629686

[MediaWiki-commits] [Gerrit] Remove line after toggle modes - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146300 Change subject: Remove line after toggle modes .. Remove line after toggle modes Change-Id: Ic2573be48ada77fcb5e5bb97d6c26721048a8af0 --- M

[MediaWiki-commits] [Gerrit] Remove deprecated block-render() methods - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146299 Change subject: Remove deprecated block-render() methods .. Remove deprecated block-render() methods Change-Id:

[MediaWiki-commits] [Gerrit] Edit header form should not use parsed html for editing - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146330 Change subject: Edit header form should not use parsed html for editing .. Edit header form should not use parsed html for editing Change-Id:

[MediaWiki-commits] [Gerrit] Update wikifont icon in 'More option' menu - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146352 Change subject: Update wikifont icon in 'More option' menu .. Update wikifont icon in 'More option' menu @Todo - There is no matching icon in

[MediaWiki-commits] [Gerrit] Flow topic html page title is double escaped - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146349 Change subject: Flow topic html page title is double escaped .. Flow topic html page title is double escaped Change-Id:

[MediaWiki-commits] [Gerrit] Remove dotted line if summary doesn't exist - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146250 Change subject: Remove dotted line if summary doesn't exist .. Remove dotted line if summary doesn't exist @Todo - change dotted line color

[MediaWiki-commits] [Gerrit] A couple of fixes to CatchableFatalErrorException - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146508 Change subject: A couple of fixes to CatchableFatalErrorException .. A couple of fixes to CatchableFatalErrorException Followup to

[MediaWiki-commits] [Gerrit] Edited timestamp should link to diff - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146622 Change subject: Edited timestamp should link to diff .. Edited timestamp should link to diff Bug: 67607 Change-Id:

[MediaWiki-commits] [Gerrit] IP userpages should link to their Special:Contributions - change (mediawiki...Flow)

2014-07-15 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146645 Change subject: IP userpages should link to their Special:Contributions .. IP userpages should link to their Special:Contributions Bug: 67641

[MediaWiki-commits] [Gerrit] Add 'flow-header-empty' to RL messages - change (mediawiki...Flow)

2014-07-14 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/146141 Change subject: Add 'flow-header-empty' to RL messages .. Add 'flow-header-empty' to RL messages Change-Id:

[MediaWiki-commits] [Gerrit] Update topic sorting copy text - change (mediawiki...Flow)

2014-07-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/145709 Change subject: Update topic sorting copy text .. Update topic sorting copy text Recent active topics - Recently active topics Change-Id:

[MediaWiki-commits] [Gerrit] Special:Flow is not working - change (mediawiki...Flow)

2014-07-11 Thread Bsitu (Code Review)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/145715 Change subject: Special:Flow is not working .. Special:Flow is not working Change-Id: I8ce305c1f05275284ac56f74a360b8f026d24ab0 --- M

  1   2   3   4   5   6   7   8   9   10   >