[MediaWiki-commits] [Gerrit] fixes connect() avoiding ldap_connect() in case of empty ser... - change (mediawiki...LdapAuthentication)

[Bugsbunny (Code Review)]

Bugsbunny has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/135024

Change subject: fixes connect() avoiding ldap_connect() in case of empty 
servers list (causes undesired warning within generated page)
......................................................................

fixes connect() avoiding ldap_connect() in case of empty servers list
(causes undesired warning within generated page)

Change-Id: Id473aa09ab60e053dff3500e63e7dc66c80e3ab7
---
M LdapAuthentication.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LdapAuthentication 
refs/changes/24/135024/1

diff --git a/LdapAuthentication.php b/LdapAuthentication.php
index ae0d82a..ea33d22 100644
--- a/LdapAuthentication.php
+++ b/LdapAuthentication.php
@@ -598,6 +598,7 @@
                        $tok = strtok( " " );
                }
                $servers = rtrim( $servers );
+               if ( !$servers ) return false;
 
                $this->printDebug( "Using servers: $servers", SENSITIVE );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/135024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id473aa09ab60e053dff3500e63e7dc66c80e3ab7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Bugsbunny <harry.waschk...@googlemail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits