[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: Follow-up 6bb7939a79: use GenderCache

2018-01-23 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406014 ) Change subject: Follow-up 6bb7939a79: use GenderCache .. Follow-up 6bb7939a79: use GenderCache Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [WIP] Failing test case for losing annotations

2018-01-23 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405994 ) Change subject: [WIP] Failing test case for losing annotations .. [WIP] Failing test case for losing annotations Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SurfaceSynchronizer: Also translate selections that are not ...

2018-01-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405833 ) Change subject: SurfaceSynchronizer: Also translate selections that are not mentioned in the change .. SurfaceSynchronizer: Also translate

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Fix sequencing of server operations

2018-01-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405832 ) Change subject: rebaser: Fix sequencing of server operations .. rebaser: Fix sequencing of server operations pendingForDoc was not

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.31.0-wmf.17]: Revert "Improve error-handling for OptInController"

2018-01-22 Thread Catrope (Code Review)
Hello Mattflaschen, Sbisson, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/405754 to review the following change. Change subject: Revert "Improve error-handling for OptInController"

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SurfaceSynchronizer: Translate selections when unapplying

2018-01-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405549 ) Change subject: SurfaceSynchronizer: Translate selections when unapplying .. SurfaceSynchronizer: Translate selections when unapplying

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SurfaceSynchronizer: Clear author selections when unapplying

2018-01-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405546 ) Change subject: SurfaceSynchronizer: Clear author selections when unapplying .. SurfaceSynchronizer: Clear author selections when

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[wmf/1.31.0-wmf.17]: Follow-up dd0a0035e: make useve work together with prefix

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405390 ) Change subject: Follow-up dd0a0035e: make useve work together with prefix .. Follow-up dd0a0035e: make useve work together with prefix If

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[master]: Follow-up dd0a0035e: make useve work together with prefix

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405389 ) Change subject: Follow-up dd0a0035e: make useve work together with prefix .. Follow-up dd0a0035e: make useve work together with prefix If

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: revthank: Embed gender of thanks recipients in the page

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405380 ) Change subject: revthank: Embed gender of thanks recipients in the page .. revthank: Embed gender of thanks recipients in the page That

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: revthank: Clarify confirmation message and change yes/no mes...

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405381 ) Change subject: revthank: Clarify confirmation message and change yes/no messages .. revthank: Clarify confirmation message and change

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Piwik: Complement protocol-relative URL with `https://`

2018-01-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405378 ) Change subject: Piwik: Complement protocol-relative URL with `https://` .. Piwik: Complement protocol-relative URL with `https://`

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Uri: Don't double-escape fragments

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405377 ) Change subject: mediawiki.Uri: Don't double-escape fragments .. mediawiki.Uri: Don't double-escape fragments Fragments were ingested

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Hide hamburger button from assistive technologies

2018-01-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405251 ) Change subject: Hide hamburger button from assistive technologies .. Hide hamburger button from assistive technologies In current

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Replace 'http' with 'https'

2018-01-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405250 ) Change subject: Replace 'http' with 'https' .. Replace 'http' with 'https' Public Design Website is available in HTTPS too, so

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Change tag schema normalization

2018-01-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405375 ) Change subject: [WIP] Change tag schema normalization .. [WIP] Change tag schema normalization Sketch of how this would work. Doesn't deal

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: BoardDescriptionWidget: Fix init when no description created...

2018-01-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405051 ) Change subject: BoardDescriptionWidget: Fix init when no description created yet .. BoardDescriptionWidget: Fix init when no description

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Add copyright footer to all pages that need it

2018-01-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405046 ) Change subject: Add copyright footer to all pages that need it .. Add copyright footer to all pages that need it Bug: T184960 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: NewTopicWidget, BoardDescriptionWidget: Don't clear on error

2018-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404903 ) Change subject: NewTopicWidget, BoardDescriptionWidget: Don't clear on error .. NewTopicWidget, BoardDescriptionWidget: Don't clear on

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Update og:image and og:description on all 2017 pages

2018-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404901 ) Change subject: Update og:image and og:description on all 2017 pages .. Update og:image and og:description on all 2017 pages Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Add Piwik analytics to 2017 report (was already on 2016 and ...

2018-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404899 ) Change subject: Add Piwik analytics to 2017 report (was already on 2016 and 2015 reports) .. Add Piwik analytics to 2017 report (was

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Copy changes for 2017 annual report from Zack

2018-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404896 ) Change subject: Copy changes for 2017 annual report from Zack .. Copy changes for 2017 annual report from Zack Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Follow-up 79e29a401b: remove stray pipe

2018-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404895 ) Change subject: Follow-up 79e29a401b: remove stray pipe .. Follow-up 79e29a401b: remove stray pipe Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Bump ChangesListFilters schema revision

2018-01-16 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404528 ) Change subject: Bump ChangesListFilters schema revision .. Bump ChangesListFilters schema revision Bug: T184642 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.31.0-wmf.16]: Unbreak CSS selector for fallback input widget

2018-01-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403567 ) Change subject: Unbreak CSS selector for fallback input widget .. Unbreak CSS selector for fallback input widget Bug: T184631 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 6f07389ef2eb: fix variable name

2018-01-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402109 ) Change subject: Follow-up 6f07389ef2eb: fix variable name .. Follow-up 6f07389ef2eb: fix variable name Caused Notice: Undefined variable:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Make the tour module depend on ext.guidedTour

2018-01-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401739 ) Change subject: Make the tour module depend on ext.guidedTour .. Make the tour module depend on ext.guidedTour Otherwise, JS errors happen

[MediaWiki-commits] [Gerrit] integration/config[master]: Revert "Migrate VisualEditor 'npm doc' job to Docker"

2017-12-22 Thread Catrope (Code Review)
Hello Paladox, Hashar, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/399905 to review the following change. Change subject: Revert "Migrate VisualEditor 'npm doc' job to Docker"

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Unbreak tests after Chrome upgrade

2017-12-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399899 ) Change subject: Unbreak tests after Chrome upgrade .. Unbreak tests after Chrome upgrade Chrome appears to have changed how many newlines

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [WIP] Test commit

2017-12-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399894 ) Change subject: [WIP] Test commit .. [WIP] Test commit Change-Id: Ifae0d37a4fdb3bdc5fc42c1431e0af071b9d54db --- M README.md 1 file

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up c7ef30a30f6: append multi-element nodes in the rig...

2017-12-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399888 ) Change subject: Follow-up c7ef30a30f6: append multi-element nodes in the right order .. Follow-up c7ef30a30f6: append multi-element nodes

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: labs: Fix language code on deploymentwiki

2017-12-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399867 ) Change subject: labs: Fix language code on deploymentwiki .. labs: Fix language code on deploymentwiki Setting $wgLanguageCode =

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Follow-up fecdfacabd: unbreak creation of new summaries

2017-12-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399800 ) Change subject: Follow-up fecdfacabd: unbreak creation of new summaries .. Follow-up fecdfacabd: unbreak creation of new summaries I'd

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Follow-up fecdfaca: use "Structured Discussions" instead of ...

2017-12-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399666 ) Change subject: Follow-up fecdfaca: use "Structured Discussions" instead of "Flow" in i18n message .. Follow-up fecdfaca: use "Structured

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up e213462f7c61c: fix typo ("constriant" -> "constrai...

2017-12-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399610 ) Change subject: Follow-up e213462f7c61c: fix typo ("constriant" -> "constraint") .. Follow-up e213462f7c61c: fix typo ("constriant" ->

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Depool deployment-db04"

2017-12-20 Thread Catrope (Code Review)
Hello Urbanecm, jenkins-bot, Jcrespo, Zoranzoki21, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/399449 to review the following change. Change subject: Revert "Depool deployment-db04" ..

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 36f4daf32c: allow no-write database connections to...

2017-12-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399404 ) Change subject: Follow-up 36f4daf32c: allow no-write database connections to use transactions .. Follow-up 36f4daf32c: allow no-write

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: build: Update stylelint-config-wikimedia to 0.4.2

2017-12-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399247 ) Change subject: build: Update stylelint-config-wikimedia to 0.4.2 .. build: Update stylelint-config-wikimedia to 0.4.2 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove temporary read-only setting for beta labs

2017-12-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399207 ) Change subject: Remove temporary read-only setting for beta labs .. Remove temporary read-only setting for beta labs The database

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Depool deployment-db04

2017-12-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399182 ) Change subject: Depool deployment-db04 .. Depool deployment-db04 Its replication is broken, and its contents have diverged from the

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: [WIP] Bidi-embed user names

2017-12-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398919 ) Change subject: [WIP] Bidi-embed user names .. [WIP] Bidi-embed user names TODO: Embed all the other user names too TODO: Need a JS

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix various bugs with timestamps in mixed directionality

2017-12-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398891 ) Change subject: Fix various bugs with timestamps in mixed directionality .. Fix various bugs with timestamps in mixed directionality *

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DO NOT MERGE] Test change

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398686 ) Change subject: [DO NOT MERGE] Test change .. [DO NOT MERGE] Test change Change-Id: I0ecbef0a76f43e18938249b022b3910f00fe32e6 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Follow-up ca5587c2992: unbreak unit tests

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398685 ) Change subject: Follow-up ca5587c2992: unbreak unit tests .. Follow-up ca5587c2992: unbreak unit tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Don't ship unused templates to the client

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398684 ) Change subject: Don't ship unused templates to the client .. Don't ship unused templates to the client Rerendering the header

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Remove unused cancel buttons and some other things

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398683 ) Change subject: Remove unused cancel buttons and some other things .. Remove unused cancel buttons and some other things * Remove cancel

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Remove the old editor system

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398682 ) Change subject: Remove the old editor system .. Remove the old editor system It was no longer used anywhere. This is a relatively minimal

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Initializer: Simplify and deduplicate setupUndoPage()

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398681 ) Change subject: Initializer: Simplify and deduplicate setupUndoPage() .. Initializer: Simplify and deduplicate setupUndoPage() It used to

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Use new editor instead of old editor for undoing topic summa...

2017-12-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398680 ) Change subject: Use new editor instead of old editor for undoing topic summary edits .. Use new editor instead of old editor for undoing

[MediaWiki-commits] [Gerrit] mediawiki...ORES[wmf/1.31.0-wmf.12]: Follow-up 36748ca523: fix broken join conditions

2017-12-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398401 ) Change subject: Follow-up 36748ca523: fix broken join conditions .. Follow-up 36748ca523: fix broken join conditions Bug: T182936

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Follow-up 36748ca523: fix broken join conditions

2017-12-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398397 ) Change subject: Follow-up 36748ca523: fix broken join conditions .. Follow-up 36748ca523: fix broken join conditions Bug: T182936

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.11]: mw.rcfilters.ui.MenuSelectWidget: Always open this menu down...

2017-12-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398392 ) Change subject: mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards .. mw.rcfilters.ui.MenuSelectWidget: Always open this

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.12]: mw.rcfilters.ui.MenuSelectWidget: Always open this menu down...

2017-12-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398391 ) Change subject: mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards .. mw.rcfilters.ui.MenuSelectWidget: Always open this

[MediaWiki-commits] [Gerrit] oojs/ui[master]: ClippableElement: Fix JS error when Floatable is mixed in bu...

2017-12-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398207 ) Change subject: ClippableElement: Fix JS error when Floatable is mixed in but disabled .. ClippableElement: Fix JS error when Floatable is

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Don't load JS or redirect when transcluding

2017-12-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398206 ) Change subject: RCFilters: Don't load JS or redirect when transcluding .. RCFilters: Don't load JS or redirect when transcluding We were

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Disable RCFilters in mobile view

2017-12-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398202 ) Change subject: Disable RCFilters in mobile view .. Disable RCFilters in mobile view Bug: T181545 Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ChangesListSpecialPage: Add hook to disable structured filte...

2017-12-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398200 ) Change subject: ChangesListSpecialPage: Add hook to disable structured filters UI .. ChangesListSpecialPage: Add hook to disable

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up Ib933de3a3f: remove unnecessary override from Spec...

2017-12-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398110 ) Change subject: Follow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist .. Follow-up Ib933de3a3f: remove unnecessary

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Disable ORES in fawiki"

2017-12-09 Thread Catrope (Code Review)
Hello Ladsgroup, Legoktm, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/396806 to review the following change. Change subject: Revert "Disable ORES in fawiki" .. Revert

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Give rcOresDamagingPref the same default as oresDamagingPref

2017-12-09 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396805 ) Change subject: Give rcOresDamagingPref the same default as oresDamagingPref .. Give rcOresDamagingPref the same default as

[MediaWiki-commits] [Gerrit] analytics/limn-flow-data[master]: Fix definition of "active board", "active topic"

2017-12-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396566 ) Change subject: Fix definition of "active board", "active topic" .. Fix definition of "active board", "active topic" The queries for

[MediaWiki-commits] [Gerrit] analytics/limn-flow-data[master]: Correct SQL comments about moderation checks

2017-12-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396558 ) Change subject: Correct SQL comments about moderation checks .. Correct SQL comments about moderation checks unique-users and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Add class back on "show new changes" link

2017-12-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396457 ) Change subject: RCFilters: Add class back on "show new changes" link .. RCFilters: Add class back on "show new changes" link Removing this

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.11]: RCLFilters: Make 'target' and 'to/from' sticky

2017-12-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395899 ) Change subject: RCLFilters: Make 'target' and 'to/from' sticky .. RCLFilters: Make 'target' and 'to/from' sticky Make these parameters

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable ORES filters on simplewiki

2017-12-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395818 ) Change subject: Enable ORES filters on simplewiki .. Enable ORES filters on simplewiki Using the same thresholds as on enwiki. Bug:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MultilineTextInputWidget: Correct documentation for config.m...

2017-12-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395160 ) Change subject: MultilineTextInputWidget: Correct documentation for config.maxRows .. MultilineTextInputWidget: Correct documentation for

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Revert "Use ORES preference on Related Changes page"

2017-12-01 Thread Catrope (Code Review)
Hello Petar.petkovic, Sbisson, jenkins-bot, Mooeypoo, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/394630 to review the following change. Change subject: Revert "Use ORES preference on Related Changes page"

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Respect "Always use VE" and "Always use source editor" prefe...

2017-11-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394405 ) Change subject: Respect "Always use VE" and "Always use source editor" preferences .. Respect "Always use VE" and "Always use source

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.10]: RCFilters: Followup I75cfb2b56a: Fix function declaration

2017-11-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394382 ) Change subject: RCFilters: Followup I75cfb2b56a: Fix function declaration .. RCFilters: Followup I75cfb2b56a: Fix function declaration

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Graduate live update out of beta

2017-11-27 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393692 ) Change subject: Graduate live update out of beta .. Graduate live update out of beta Bug: T173614 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: PresentationModelSectionTrait: Use section anchor generation...

2017-11-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392992 ) Change subject: PresentationModelSectionTrait: Use section anchor generation from code .. PresentationModelSectionTrait: Use section

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Parser: Add guessSectionNameFromStrippedText() and refactor

2017-11-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392990 ) Change subject: Parser: Add guessSectionNameFromStrippedText() and refactor .. Parser: Add guessSectionNameFromStrippedText() and refactor

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Linker: Use Parser::guessSectionNameFromStrippedText()

2017-11-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392991 ) Change subject: Linker: Use Parser::guessSectionNameFromStrippedText() .. Linker: Use Parser::guessSectionNameFromStrippedText() Instead

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialListgrouprights: Fix "Namespace restrictions" header ID

2017-11-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392988 ) Change subject: SpecialListgrouprights: Fix "Namespace restrictions" header ID .. SpecialListgrouprights: Fix "Namespace restrictions"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiFeedWatchlist: Use guessSectionNameFromWikiText()

2017-11-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392989 ) Change subject: ApiFeedWatchlist: Use guessSectionNameFromWikiText() .. ApiFeedWatchlist: Use guessSectionNameFromWikiText() Instead of

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Flow Nuke: Include hidden comments in Nuke overview

2017-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392732 ) Change subject: Flow Nuke: Include hidden comments in Nuke overview .. Flow Nuke: Include hidden comments in Nuke overview Bug: T180607

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: [WIP] Remove editor switching infrastructure in favor of VE'...

2017-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392569 ) Change subject: [WIP] Remove editor switching infrastructure in favor of VE's source mode .. [WIP] Remove editor switching infrastructure

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: RCFilters: Followup I08db859c571: Fix typo in "namespaces"

2017-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392479 ) Change subject: RCFilters: Followup I08db859c571: Fix typo in "namespaces" .. RCFilters: Followup I08db859c571: Fix typo in "namespaces"

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move source mode newline hack down to ArticleTarget

2017-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392476 ) Change subject: Move source mode newline hack down to ArticleTarget .. Move source mode newline hack down to ArticleTarget We need this

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: RCFilters: Only apply excluded label to namespace items

2017-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392465 ) Change subject: RCFilters: Only apply excluded label to namespace items .. RCFilters: Only apply excluded label to namespace items Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move Sanitizer.php to includes/parser/

2017-11-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391718 ) Change subject: Move Sanitizer.php to includes/parser/ .. Move Sanitizer.php to includes/parser/ Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "RCFilters: Remove excluded params from URL"

2017-11-15 Thread Catrope (Code Review)
Hello Sbisson, jenkins-bot, Mooeypoo, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/391613 to review the following change. Change subject: Revert "RCFilters: Remove excluded params from URL"

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.8]: Revert "RCFilters: Remove excluded params from URL"

2017-11-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391614 ) Change subject: Revert "RCFilters: Remove excluded params from URL" .. Revert "RCFilters: Remove excluded params from URL" Breaks limit

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Use Remex in Sanitizer::stripAllTags()

2017-11-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391348 ) Change subject: [WIP] Use Remex in Sanitizer::stripAllTags() .. [WIP] Use Remex in Sanitizer::stripAllTags() Using a real HTML tokenizer

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SanitizerTest: Add tests for stripAllTags

2017-11-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391347 ) Change subject: SanitizerTest: Add tests for stripAllTags .. SanitizerTest: Add tests for stripAllTags Bug: T179978 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: PageTriageHooks: Use modifyExtensionTable() now that it exists

2017-11-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391153 ) Change subject: PageTriageHooks: Use modifyExtensionTable() now that it exists .. PageTriageHooks: Use modifyExtensionTable() now that it

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DatabaseUpdater: Add modifyExtensionTable()

2017-11-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391152 ) Change subject: DatabaseUpdater: Add modifyExtensionTable() .. DatabaseUpdater: Add modifyExtensionTable() We already had

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Add a filter for learners (newly autoconfirmed users)

2017-11-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391151 ) Change subject: Add a filter for learners (newly autoconfirmed users) .. Add a filter for learners (newly autoconfirmed users) Put the

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: PageTriageTags.sql: clean up trailing whitespace

2017-11-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391150 ) Change subject: PageTriageTags.sql: clean up trailing whitespace .. PageTriageTags.sql: clean up trailing whitespace Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Don't use $row->ores_damaging_threshold in Contributions whe...

2017-11-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390072 ) Change subject: Don't use $row->ores_damaging_threshold in Contributions where it isn't set .. Don't use $row->ores_damaging_threshold in

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: [WIP] Extract and expose categories in page API

2017-11-07 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389751 ) Change subject: [WIP] Extract and expose categories in page API .. [WIP] Extract and expose categories in page API Take all categories out

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Adaptation tests: Consistently assert href and title for all...

2017-11-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388443 ) Change subject: Adaptation tests: Consistently assert href and title for all links .. Adaptation tests: Consistently assert href and title

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: API: Make format parameters always default to 'fixed-html'

2017-11-01 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387810 ) Change subject: API: Make format parameters always default to 'fixed-html' .. API: Make format parameters always default to 'fixed-html'

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ui.Surface: Fix param documentation for getDom()

2017-10-27 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386782 ) Change subject: ve.ui.Surface: Fix param documentation for getDom() .. ve.ui.Surface: Fix param documentation for getDom() It expects a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Move label prefixes from dm.ItemModel to ui.TagIt...

2017-10-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386776 ) Change subject: RCFilters: Move label prefixes from dm.ItemModel to ui.TagItemWidget .. RCFilters: Move label prefixes from dm.ItemModel

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: HTML-escape tag names in filter capsules

2017-10-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386344 ) Change subject: RCFilters: HTML-escape tag names in filter capsules .. RCFilters: HTML-escape tag names in filter capsules Bug: T178975

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: [WIP] Category adaptation

2017-10-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386340 ) Change subject: [WIP] Category adaptation .. [WIP] Category adaptation Gather all the metadata from the source document, run it through

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.31.0-wmf.4]: mw.echo.ui.PageNotificationsOptionWidget: Fix CSS after chan...

2017-10-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385110 ) Change subject: mw.echo.ui.PageNotificationsOptionWidget: Fix CSS after changes in OOjs UI .. mw.echo.ui.PageNotificationsOptionWidget:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: ContainmentSet: Work around unhelpful behavior of lookupCent...

2017-10-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384300 ) Change subject: ContainmentSet: Work around unhelpful behavior of lookupCentralIds() .. ContainmentSet: Work around unhelpful behavior of

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: ContainmentSet: Use strict comparison for array_search()

2017-10-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384299 ) Change subject: ContainmentSet: Use strict comparison for array_search() .. ContainmentSet: Use strict comparison for array_search()

  1   2   3   4   5   6   7   8   9   10   >