[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: D'oh: fix creation/import of Default list.

2018-01-24 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406122 ) Change subject: D'oh: fix creation/import of Default list. .. D'oh: fix creation/import of Default list. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: POC: check whether reading lists are disabled server-side.

2018-01-23 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405939 ) Change subject: POC: check whether reading lists are disabled server-side. .. POC: check whether reading lists are disabled server-side.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make Default list sticky, regardless of sorting.

2018-01-23 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405917 ) Change subject: Make Default list sticky, regardless of sorting. .. Make Default list sticky, regardless of sorting. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Use python instead of python2.

2018-01-23 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405909 ) Change subject: Use python instead of python2. .. Use python instead of python2. Change-Id: I1b72343b05e9f249e0dd292761cbf7db0bc31d15 --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix hiding of thumbnails in reading list detail view.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405841 ) Change subject: Fix hiding of thumbnails in reading list detail view. .. Fix hiding of thumbnails in reading list detail view. Bug: T185541

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix background highlight of multi-select items.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405839 ) Change subject: Fix background highlight of multi-select items. .. Fix background highlight of multi-select items. Bug: T185536 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update red background color when swiping to delete.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405837 ) Change subject: Update red background color when swiping to delete. .. Update red background color when swiping to delete. Bug: T185539

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix undo of list deletion.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405836 ) Change subject: Fix undo of list deletion. .. Fix undo of list deletion. Bug: T185553 Change-Id: I6c9c3766591355a859325b5ebcf533511ed77afc

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix display of Default list title in numerous places.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405834 ) Change subject: Fix display of Default list title in numerous places. .. Fix display of Default list title in numerous places. The

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix searching of reading lists.

2018-01-22 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405831 ) Change subject: Fix searching of reading lists. .. Fix searching of reading lists. The previous implementation of reading lists had

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Actually fix UI quirk that leads to Default list being delet...

2018-01-19 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405345 ) Change subject: Actually fix UI quirk that leads to Default list being deletable. .. Actually fix UI quirk that leads to Default list being

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add more checks to protect and bullet-proof the Default list.

2018-01-19 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405339 ) Change subject: Add more checks to protect and bullet-proof the Default list. .. Add more checks to protect and bullet-proof the Default

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Improve failure behavior of FaceAndColorDetectImageView.

2018-01-19 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405319 ) Change subject: Improve failure behavior of FaceAndColorDetectImageView. .. Improve failure behavior of FaceAndColorDetectImageView. When

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-up: simplify some logic in RandomItemFragment.

2018-01-19 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405310 ) Change subject: Follow-up: simplify some logic in RandomItemFragment. .. Follow-up: simplify some logic in RandomItemFragment. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update design of About screen.

2018-01-19 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405306 ) Change subject: Update design of About screen. .. Update design of About screen. Bug: T181640 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update to wikimedia-page-library 4.8.0.

2018-01-18 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405211 ) Change subject: Update to wikimedia-page-library 4.8.0. .. Update to wikimedia-page-library 4.8.0. This also improves the logic of hiding

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Whoops: fix remote reading list NFC normalization.

2018-01-18 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405071 ) Change subject: Whoops: fix remote reading list NFC normalization. .. Whoops: fix remote reading list NFC normalization. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-up: simplify enabling/disabling of Randomizer save bu...

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404805 ) Change subject: Follow-up: simplify enabling/disabling of Randomizer save button. .. Follow-up: simplify enabling/disabling of Randomizer

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Enforce Unicode NFC when exchanging strings with Reading Lis...

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404800 ) Change subject: Enforce Unicode NFC when exchanging strings with Reading List service. .. Enforce Unicode NFC when exchanging strings with

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Remove unused resources.

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404765 ) Change subject: Remove unused resources. .. Remove unused resources. Change-Id: Ibabdf5e4e26edcc2d304414e0c8821be77a1a3ab --- D

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Remove unused strings.

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404766 ) Change subject: Remove unused strings. .. Remove unused strings. Change-Id: Idb3d24b2a91065ef9245263b69b4dc6049e079ad --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Remove unnecessary test abstraction.

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404759 ) Change subject: Remove unnecessary test abstraction. .. Remove unnecessary test abstraction. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update Robolectric to 3.6.1.

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404755 ) Change subject: Update Robolectric to 3.6.1. .. Update Robolectric to 3.6.1. Change-Id: I0b79bf1b587393953b8a8ccd985f230caadd134a --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update Gradle plugin to 3.0.1

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404750 ) Change subject: Update Gradle plugin to 3.0.1 .. Update Gradle plugin to 3.0.1

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-up: hygiene - make names more descriptive.

2018-01-17 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404676 ) Change subject: Follow-up: hygiene - make names more descriptive. .. Follow-up: hygiene - make names more descriptive. Please make names

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update verbiage of reading list download notification.

2018-01-16 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404586 ) Change subject: Update verbiage of reading list download notification. .. Update verbiage of reading list download notification. Bug:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add basic eventlogging to Offline Library screen.

2018-01-16 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404535 ) Change subject: Add basic eventlogging to Offline Library screen. .. Add basic eventlogging to Offline Library screen. - Also fix Sharing

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix usage of string resource for "OK".

2018-01-12 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403986 ) Change subject: Fix usage of string resource for "OK". .. Fix usage of string resource for "OK". The resource "R.string.OK" should not be

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix alignment of Edit pencil when description editing is dis...

2018-01-12 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403985 ) Change subject: Fix alignment of Edit pencil when description editing is disabled. .. Fix alignment of Edit pencil when description editing

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix Randomizer bookmark icon of first item upon screen rotat...

2018-01-12 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403958 ) Change subject: Fix Randomizer bookmark icon of first item upon screen rotation. .. Fix Randomizer bookmark icon of first item upon screen

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix persistence of on-this-day content on screen rotation.

2018-01-12 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403952 ) Change subject: Fix persistence of on-this-day content on screen rotation. .. Fix persistence of on-this-day content on screen rotation.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-up: Further simplify splitting of reading lists.

2018-01-11 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403764 ) Change subject: Follow-up: Further simplify splitting of reading lists. .. Follow-up: Further simplify splitting of reading lists. Nothing

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update Mapbox to 5.3.1.

2018-01-11 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403758 ) Change subject: Update Mapbox to 5.3.1. .. Update Mapbox to 5.3.1. https://github.com/mapbox/mapbox-gl-native/releases/tag/android-v5.3.1

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Lazily load the Nearby fragment.

2018-01-11 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403752 ) Change subject: Lazily load the Nearby fragment. .. Lazily load the Nearby fragment. When the user goes to the History tab, the Nearby tab

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Disable swipe refresh of reading lists for prod/beta.

2018-01-11 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403685 ) Change subject: Disable swipe refresh of reading lists for prod/beta. .. Disable swipe refresh of reading lists for prod/beta. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix a couple more button text center-alignments.

2018-01-10 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403414 ) Change subject: Fix a couple more button text center-alignments. .. Fix a couple more button text center-alignments. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-up: tiny tweaks to renaming lists with identical name...

2018-01-10 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403413 ) Change subject: Follow-up: tiny tweaks to renaming lists with identical name as Default. .. Follow-up: tiny tweaks to renaming lists with

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Improve/fix reading list importing logic from previous datab...

2018-01-09 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403218 ) Change subject: Improve/fix reading list importing logic from previous database version. .. Improve/fix reading list importing logic from

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Introduce blocking (sync) versions of login and csrf functions.

2018-01-09 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403191 ) Change subject: Introduce blocking (sync) versions of login and csrf functions. .. Introduce blocking (sync) versions of login and csrf

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Extend HttpStatusException to contain ServiceError information.

2018-01-09 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403190 ) Change subject: Extend HttpStatusException to contain ServiceError information. .. Extend HttpStatusException to contain ServiceError

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Improve fetching of random articles from reading lists.

2018-01-09 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403182 ) Change subject: Improve fetching of random articles from reading lists. .. Improve fetching of random articles from reading lists. This

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Privacy: Reset appInstallID when user opts out of event logg...

2018-01-09 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403170 ) Change subject: Privacy: Reset appInstallID when user opts out of event logging. .. Privacy: Reset appInstallID when user opts out of event

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix interception of WebView content with extended content-ty...

2018-01-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402600 ) Change subject: Fix interception of WebView content with extended content-type header. .. Fix interception of WebView content with extended

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode.

2018-01-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402601 ) Change subject: Bump versionCode. .. Bump versionCode. Change-Id: I9cb519cd40ba8e35989707a26efc47109efa387f --- M app/build.gradle 1 file

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Move logic for creating Default list to database upgrade hook.

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402104 ) Change subject: Move logic for creating Default list to database upgrade hook. .. Move logic for creating Default list to database upgrade

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Follow-ups to correctly center text inside TextViews.

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402092 ) Change subject: Follow-ups to correctly center text inside TextViews. .. Follow-ups to correctly center text inside TextViews. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Consolidate RtlAwareTextView style into theme, instead of in...

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402060 ) Change subject: Consolidate RtlAwareTextView style into theme, instead of individual views. .. Consolidate RtlAwareTextView style into

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix ok/cancel strings in custom date picker.

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402053 ) Change subject: Fix ok/cancel strings in custom date picker. .. Fix ok/cancel strings in custom date picker. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix RTL issue in Trending Articles card footer.

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402052 ) Change subject: Fix RTL issue in Trending Articles card footer. .. Fix RTL issue in Trending Articles card footer. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix RTL appearance of Continue Reading card.

2018-01-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402051 ) Change subject: Fix RTL appearance of Continue Reading card. .. Fix RTL appearance of Continue Reading card. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix behavior of Retry button in OfflineCard.

2018-01-02 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401518 ) Change subject: Fix behavior of Retry button in OfflineCard. .. Fix behavior of Retry button in OfflineCard. Bug: T183308 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update page-library to 4.7.11.

2017-12-18 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398856 ) Change subject: Update page-library to 4.7.11. .. Update page-library to 4.7.11. Change-Id: I7cd9b97c9ddf8148ea77746784577f7f4da0a217 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update whitelist for a few mobile app schemas.

2017-12-15 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398542 ) Change subject: Update whitelist for a few mobile app schemas. .. Update whitelist for a few mobile app schemas. This adds a few fields to

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode

2017-12-15 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398503 ) Change subject: Bump versionCode .. Bump versionCode Change-Id: I2c43dc884deca6edddff94a17bbb975072acda8c --- M app/build.gradle 1 file

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: lighten/correct color of usage data onboarding...

2017-12-14 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398382 ) Change subject: Design tweak: lighten/correct color of usage data onboarding switch. .. Design tweak: lighten/correct color of usage data

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix possible crash when receiving OnThisDay response.

2017-12-14 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398252 ) Change subject: Fix possible crash when receiving OnThisDay response. .. Fix possible crash when receiving OnThisDay response.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix possible crash in LicenseActivity.

2017-12-14 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398250 ) Change subject: Fix possible crash in LicenseActivity. .. Fix possible crash in LicenseActivity. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Remove old framework for synchronizing user options.

2017-12-13 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398065 ) Change subject: Remove old framework for synchronizing user options. .. Remove old framework for synchronizing user options. We do not

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [SUPER WIP] Reading list database layer: a reimagining.

2017-12-12 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397847 ) Change subject: [SUPER WIP] Reading list database layer: a reimagining. .. [SUPER WIP] Reading list database layer: a reimagining.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode

2017-12-08 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396434 ) Change subject: Bump versionCode .. Bump versionCode Change-Id: Ib507de4d92e607bef4f3d55d5390cd9eb4db62b1 --- M app/build.gradle 1 file

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix occasional bug in Randomizer.

2017-12-08 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396424 ) Change subject: Fix occasional bug in Randomizer. .. Fix occasional bug in Randomizer. One out of ten times, when first loading the

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Clean up some code in Developer Preferences.

2017-12-07 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396277 ) Change subject: Clean up some code in Developer Preferences. .. Clean up some code in Developer Preferences. Remove a lot of unnecessary

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode.

2017-12-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395816 ) Change subject: Bump versionCode. .. Bump versionCode. Actually bump it by a few numbers, to make room for possible updates for APKs that

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Use sans-serif-medium for bolded links in News and On This Day.

2017-12-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395792 ) Change subject: Use sans-serif-medium for bolded links in News and On This Day. .. Use sans-serif-medium for bolded links in News and On

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Don't log 404 errors when saving pages.

2017-12-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395774 ) Change subject: Don't log 404 errors when saving pages. .. Don't log 404 errors when saving pages. This has been causing an unnecessary

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Final (final) design tweaks.

2017-12-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395772 ) Change subject: Final (final) design tweaks. .. Final (final) design tweaks. - Tweak line spacing in on-this-day page items. - Slightly

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Remove default fade-in animation from Fresco drawees.

2017-12-06 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395770 ) Change subject: Remove default fade-in animation from Fresco drawees. .. Remove default fade-in animation from Fresco drawees. This makes

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode and minor version.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395670 ) Change subject: Bump versionCode and minor version. .. Bump versionCode and minor version. For great justice. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Final design tweaks for on-this-day.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395667 ) Change subject: Final design tweaks for on-this-day. .. Final design tweaks for on-this-day. Bug: T175995 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak to on-this-day page cards.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395659 ) Change subject: Design tweak to on-this-day page cards. .. Design tweak to on-this-day page cards. Bug: T175995 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On This Day endpoint follow-up.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395609 ) Change subject: On This Day endpoint follow-up. .. On This Day endpoint follow-up. Change-Id: If90c272c70001d192fdbe91b82676107254663be ---

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix boldening of on-this-day links.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395597 ) Change subject: Fix boldening of on-this-day links. .. Fix boldening of on-this-day links. The previous boldening algorithm was

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Element transition for On This Day.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395587 ) Change subject: Element transition for On This Day. .. Element transition for On This Day. Bug: T175995 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On This Day follow-up.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395580 ) Change subject: On This Day follow-up. .. On This Day follow-up. In which I do some light reworking of the layouts to be more performant

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix color of card footer icons.

2017-12-05 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395544 ) Change subject: Fix color of card footer icons. .. Fix color of card footer icons. Bug: T182099 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweaks of on-this-day header layout.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395145 ) Change subject: Design tweaks of on-this-day header layout. .. Design tweaks of on-this-day header layout. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix style of individual on-this-day items.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395119 ) Change subject: Fix style of individual on-this-day items. .. Fix style of individual on-this-day items. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix collapsed toolbar style in On This Day.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395117 ) Change subject: Fix collapsed toolbar style in On This Day. .. Fix collapsed toolbar style in On This Day. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Enable initial onboarding in production.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395075 ) Change subject: Enable initial onboarding in production. .. Enable initial onboarding in production. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix viewing of library licenses.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395049 ) Change subject: Fix viewing of library licenses. .. Fix viewing of library licenses. The LicenseActivity needs exported=true in the

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: One more tweak to black mode.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395032 ) Change subject: One more tweak to black mode. .. One more tweak to black mode. Bug: T173319 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Enable On This Day in production.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395010 ) Change subject: Enable On This Day in production. .. Enable On This Day in production. Change-Id: I9f2e9c53adaa9495dbee885bba11809dd44039f8

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak for black theme.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394989 ) Change subject: Design tweak for black theme. .. Design tweak for black theme. Bug: T173319 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix possible crash when swiping in Randomizer.

2017-12-04 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394988 ) Change subject: Fix possible crash when swiping in Randomizer. .. Fix possible crash when swiping in Randomizer. Bug: T181874 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make "Continue Reading" card load pages from existing tabs.

2017-12-01 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394595 ) Change subject: Make "Continue Reading" card load pages from existing tabs. .. Make "Continue Reading" card load pages from existing tabs.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make news text highlightable.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394453 ) Change subject: Make news text highlightable. .. Make news text highlightable. Change-Id: I75ef8ba4cbb5eddce73bb3ecee580c301e304c5e --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update text colors in About activity.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394454 ) Change subject: Update text colors in About activity. .. Update text colors in About activity. Bug: T181640 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update style of Trending card footer.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394403 ) Change subject: Update style of Trending card footer. .. Update style of Trending card footer. Bug: T170884 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Event logging for On This Day.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394363 ) Change subject: Event logging for On This Day. .. Event logging for On This Day. This implements the new schema developed at:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Event logging for Feed Configuration.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394354 ) Change subject: Event logging for Feed Configuration. .. Event logging for Feed Configuration. This implements the new schema developed at:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Event logging for Randomizer.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394344 ) Change subject: Event logging for Randomizer. .. Event logging for Randomizer. This implements the new schema developed at:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update default ordering of feed cards.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394335 ) Change subject: Update default ordering of feed cards. .. Update default ordering of feed cards. This changes the default order of feed

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix entering Randomizer activity from app shortcut.

2017-11-30 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394334 ) Change subject: Fix entering Randomizer activity from app shortcut. .. Fix entering Randomizer activity from app shortcut. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update wikimedia-page-library to 4.7.7.

2017-11-29 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394202 ) Change subject: Update wikimedia-page-library to 4.7.7. .. Update wikimedia-page-library to 4.7.7. Contains provisions for Black mode.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Don't show Offline Library setting in Beta or Prod.

2017-11-29 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394201 ) Change subject: Don't show Offline Library setting in Beta or Prod. .. Don't show Offline Library setting in Beta or Prod. Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Tweak design of static cards in Feed.

2017-11-29 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394079 ) Change subject: Tweak design of static cards in Feed. .. Tweak design of static cards in Feed. Bug: T158788 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update to Mapbox 5.2.0.

2017-11-28 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393840 ) Change subject: Update to Mapbox 5.2.0. .. Update to Mapbox 5.2.0. With much crossing of fingers, this might fix crashes we've seen on

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [SUPER WIP] Black theme.

2017-11-28 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393757 ) Change subject: [SUPER WIP] Black theme. .. [SUPER WIP] Black theme. Bug: T173319 Change-Id: Ie885e6b8ea6014a93d9cc2b9874fc3622831f8d5 ---

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design updates for Randomizer.

2017-11-27 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393632 ) Change subject: Design updates for Randomizer. .. Design updates for Randomizer. - The bookmark icon is now correctly filled-in when the

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix navigation to certain links from Reference popups.

2017-11-27 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393618 ) Change subject: Fix navigation to certain links from Reference popups. .. Fix navigation to certain links from Reference popups. Bug:

  1   2   3   4   5   6   7   8   9   10   >