[MediaWiki-commits] [Gerrit] Added %D and %T formatters (request time) - change (operations...varnishkafka)

2014-05-26 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/135441 Change subject: Added %D and %T formatters (request time) .. Added %D and %T formatters (request time) Change-Id: I8c3a04ac14f1b4ea83a4e74b9

[MediaWiki-commits] [Gerrit] Dont require whitespace-separated Hdr:fields - change (operations...varnishkafka)

2014-02-26 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/115868 Change subject: Dont require whitespace-separated Hdr:fields .. Dont require whitespace-separated Hdr:fields Change-Id: I9544add06642a894d1d

[MediaWiki-commits] [Gerrit] Explicitly link with zlib - change (operations...varnishkafka)

2014-02-26 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/115867 Change subject: Explicitly link with zlib .. Explicitly link with zlib Change-Id: Ib105d283dbabfb26e44530b3f0e7670a3fb40b56 --- M Makefile 1

[MediaWiki-commits] [Gerrit] File outputs were erroneously closed in outputs_check - change (analytics/kafkatee)

2014-02-10 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/112467 Change subject: File outputs were erroneously closed in outputs_check .. File outputs were erroneously closed in outputs_check Change-Id: I8

[MediaWiki-commits] [Gerrit] FIXME fixes: signals, stats output, proper rotates, default ... - change (analytics/kafkatee)

2014-01-30 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/110505 Change subject: FIXME fixes: signals, stats output, proper rotates, default paths .. FIXME fixes: signals, stats output, proper rotates, def

[MediaWiki-commits] [Gerrit] Fixes for Ottomata's gerrit review comments - change (analytics/kafkatee)

2014-01-28 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/110115 Change subject: Fixes for Ottomata's gerrit review comments .. Fixes for Ottomata's gerrit review comments Change-Id: I84fa273754374dd781826

[MediaWiki-commits] [Gerrit] OSX compilation fixes - change (analytics/kafkatee)

2014-01-27 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/109683 Change subject: OSX compilation fixes .. OSX compilation fixes Reported by Diederik Change-Id: I272bd1db99ff24b94cfc5b98527fcdbb8cef13e9 -

[MediaWiki-commits] [Gerrit] json: output NaN as null for '\!num' modifiers - change (operations...varnishkafka)

2014-01-03 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/105216 Change subject: json: output NaN as null for '\!num' modifiers .. json: output NaN as null for '\!num' modifiers Change-Id: Ib70c21b4540416

[MediaWiki-commits] [Gerrit] Add support for %{Varnish:xid}x (X-Varnish: ..) - change (operations...varnishkafka)

2014-01-02 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/105093 Change subject: Add support for %{Varnish:xid}x (X-Varnish: ..) .. Add support for %{Varnish:xid}x (X-Varnish: ..) Change-Id: I282210e4fdb5

[MediaWiki-commits] [Gerrit] Fixed librdkafka configuration reference URL - change (operations...varnishkafka)

2013-12-04 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/99252 Change subject: Fixed librdkafka configuration reference URL .. Fixed librdkafka configuration reference URL Change-Id: Iaa43cd1f808c6f785f2

[MediaWiki-commits] [Gerrit] escaper: Comment magical constant numbers - change (operations...varnishkafka)

2013-11-29 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/98156 Change subject: escaper: Comment magical constant numbers .. escaper: Comment magical constant numbers Change-Id: I57d98bbbfd43b57e097d968d1

[MediaWiki-commits] [Gerrit] Added %{VCL_Log:key}x support - change (operations...varnishkafka)

2013-11-28 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/98135 Change subject: Added %{VCL_Log:key}x support .. Added %{VCL_Log:key}x support Change-Id: I1af3bf3399e13340b8afde3fe21fdc4f43718ddf --- M va

[MediaWiki-commits] [Gerrit] Tag column reader was used incorrectly - change (operations...varnishkafka)

2013-11-28 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/98136 Change subject: Tag column reader was used incorrectly .. Tag column reader was used incorrectly Change-Id: I90e3b1cb9fe9cf1b24e3634de75dad9

[MediaWiki-commits] [Gerrit] Correctly calculate escape buffer size - change (operations...varnishkafka)

2013-11-28 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/98134 Change subject: Correctly calculate escape buffer size .. Correctly calculate escape buffer size Change-Id: I1d4ceb67bce73e90f88d3dee8ec8e4c

[MediaWiki-commits] [Gerrit] Configuration property namespace fixup - change (operations...varnishkafka)

2013-11-05 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/93858 Change subject: Configuration property namespace fixup .. Configuration property namespace fixup * Kafka properties are now prefixed with "k

[MediaWiki-commits] [Gerrit] Grow scratch pad by temporary buffers if necessary (issue #2) - change (operations...varnishkafka)

2013-10-21 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/91053 Change subject: Grow scratch pad by temporary buffers if necessary (issue #2) .. Grow scratch pad by temporary buffers if necessary (issue #2

[MediaWiki-commits] [Gerrit] Avoid unnecessary clearing of scratch pad on logline alloc. - change (operations...varnishkafka)

2013-10-21 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/91056 Change subject: Avoid unnecessary clearing of scratch pad on logline alloc. .. Avoid unnecessary clearing of scratch pad on logline alloc. C

[MediaWiki-commits] [Gerrit] Limit maximum tag size content - change (operations...varnishkafka)

2013-10-21 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/91054 Change subject: Limit maximum tag size content .. Limit maximum tag size content Configuration property: "tag.size.max" Change-Id: I8886a

[MediaWiki-commits] [Gerrit] Added statistics (both from varnishkafka and librdkafka) - change (operations...varnishkafka)

2013-10-21 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/91052 Change subject: Added statistics (both from varnishkafka and librdkafka) .. Added statistics (both from varnishkafka and librdkafka) Config

[MediaWiki-commits] [Gerrit] Increase string renderer output buffer to 8K - change (operations...varnishkafka)

2013-10-21 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/91055 Change subject: Increase string renderer output buffer to 8K .. Increase string renderer output buffer to 8K Change-Id: I10d661c88ce5534260b

[MediaWiki-commits] [Gerrit] Added rate-limiting to (most) error logs generated by varnis... - change (operations...varnishkafka)

2013-10-16 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/90184 Change subject: Added rate-limiting to (most) error logs generated by varnishkafka (issue #1) .. Added rate-limiting to (most) error logs ge

[MediaWiki-commits] [Gerrit] Provide some more detail when Kafka ..produce() fails. - change (operations...varnishkafka)

2013-10-15 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/90030 Change subject: Provide some more detail when Kafka ..produce() fails. .. Provide some more detail when Kafka ..produce() fails. Change-Id:

[MediaWiki-commits] [Gerrit] Log failed Kafka message deliveries (issue #1) - change (operations...varnishkafka)

2013-10-15 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/90029 Change subject: Log failed Kafka message deliveries (issue #1) .. Log failed Kafka message deliveries (issue #1) Controlled through "log.kaf

[MediaWiki-commits] [Gerrit] Make scratch buffer size configurable (issue #2) - change (operations...varnishkafka)

2013-10-15 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/90028 Change subject: Make scratch buffer size configurable (issue #2) .. Make scratch buffer size configurable (issue #2) Controlled through the

[MediaWiki-commits] [Gerrit] Use LRU hash for logline cache to avoid memory leak - change (operations...varnishkafka)

2013-10-07 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/88234 Change subject: Use LRU hash for logline cache to avoid memory leak .. Use LRU hash for logline cache to avoid memory leak The LRU cache is

[MediaWiki-commits] [Gerrit] Updated for new librdkafka API. - change (operations...varnishkafka)

2013-10-03 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/87472 Change subject: Updated for new librdkafka API. .. Updated for new librdkafka API. Change-Id: Ief5b28690c17a1b4087f7f9586182b05683f7c84 ---

[MediaWiki-commits] [Gerrit] Default explicitly configured numeric fields to 0 instead of -. - change (operations...varnishkafka)

2013-09-23 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/85710 Change subject: Default explicitly configured numeric fields to 0 instead of -. .. Default explicitly configured numeric fields to 0 instead

[MediaWiki-commits] [Gerrit] Fixed typo in README - change (operations...varnishkafka)

2013-09-23 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/85647 Change subject: Fixed typo in README .. Fixed typo in README Change-Id: I7e77f5bf125399ad2f1af8376467c50643d0e4c6 --- M README.md 1 file cha

[MediaWiki-commits] [Gerrit] Cleaned up the conf.example - change (operations...varnishkafka)

2013-09-23 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/85648 Change subject: Cleaned up the conf.example .. Cleaned up the conf.example Change-Id: I3f868c0841ebbeab9fb7be3f3c1ce64b22f380d5 --- M varnis

[MediaWiki-commits] [Gerrit] Added README.md markdown file - change (operations...varnishkafka)

2013-09-07 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/83347 Change subject: Added README.md markdown file .. Added README.md markdown file Change-Id: Ie4170698c6b241ac50ea33d41c7d405bee8100c2 --- A RE

[MediaWiki-commits] [Gerrit] Let log.data.copy default to true. - change (operations...varnishkafka)

2013-08-27 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/81388 Change subject: Let log.data.copy default to true. .. Let log.data.copy default to true. Change-Id: I96f66730dc73ccb6c072dd9a81b1253a5239c5c

[MediaWiki-commits] [Gerrit] Added optional secondary formatter: format.key - change (operations...varnishkafka)

2013-08-27 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/81390 Change subject: Added optional secondary formatter: format.key .. Added optional secondary formatter: format.key Config property: format.key

[MediaWiki-commits] [Gerrit] Added optional %{}t formatting to %t - change (operations...varnishkafka)

2013-08-27 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/81389 Change subject: Added optional %{}t formatting to %t .. Added optional %{}t formatting to %t Change-Id: I2a079741eea0d4e842eed8dbaa9f282c809

[MediaWiki-commits] [Gerrit] Added support for libyajl version 1.x - change (operations...varnishkafka)

2013-08-20 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/80127 Change subject: Added support for libyajl version 1.x .. Added support for libyajl version 1.x Change-Id: I26272bfcb263071ba412d8b9811247ee4

[MediaWiki-commits] [Gerrit] Added support for escaping troublesome characters in tag con... - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79745 Change subject: Added support for escaping troublesome characters in tag content. .. Added support for escaping troublesome characters in ta

[MediaWiki-commits] [Gerrit] Dont redeclare 'len' - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79751 Change subject: Dont redeclare 'len' .. Dont redeclare 'len' Change-Id: Ia802061e426d02c57f23c011a4515aad266828f5 --- M varnishkafka.c 1 fil

[MediaWiki-commits] [Gerrit] When reading offline VSL files (-r ..) make a copy of each m... - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79748 Change subject: When reading offline VSL files (-r ..) make a copy of each matched tags data since the data is volatile. .. When reading off

[MediaWiki-commits] [Gerrit] Handle "Var: Val" with empty " Val"s. - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79749 Change subject: Handle "Var: Val" with empty " Val"s. .. Handle "Var: Val" with empty " Val"s. Change-Id: I38980e81f6df32ee553695cf6998c80af

[MediaWiki-commits] [Gerrit] Added 'output = null' for testing purposes. - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79747 Change subject: Added 'output = null' for testing purposes. .. Added 'output = null' for testing purposes. Change-Id: If5f1e2fe89acf5caa60c2

[MediaWiki-commits] [Gerrit] Decrease default log.level to 6 (info) - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79752 Change subject: Decrease default log.level to 6 (info) .. Decrease default log.level to 6 (info) Change-Id: Ic4921a7db19512422ece92a3fd749b6

[MediaWiki-commits] [Gerrit] Indent fix and clarified comment. - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79750 Change subject: Indent fix and clarified comment. .. Indent fix and clarified comment. Change-Id: Ibbb3cd158f7cac518dd5dea3301130b595f49a3f

[MediaWiki-commits] [Gerrit] Added JSON formatter, field name identifers and type casting... - change (operations...varnishkafka)

2013-08-18 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/79746 Change subject: Added JSON formatter, field name identifers and type casting option. .. Added JSON formatter, field name identifers and type

[MediaWiki-commits] [Gerrit] Added JSON formatter, field name identifers and type casting... - change (operations...varnishkafka)

2013-08-07 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/78160 Change subject: Added JSON formatter, field name identifers and type casting option. .. Added JSON formatter, field name identifers and type

[MediaWiki-commits] [Gerrit] Link with -lrt - change (operations...varnishkafka)

2013-08-07 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/78161 Change subject: Link with -lrt .. Link with -lrt Change-Id: I50d6607968bf0f3512c7d65396f0f2e37b4fb64a --- M Makefile 1 file changed, 1 inser

[MediaWiki-commits] [Gerrit] Added support for escaping troublesome characters in tag con... - change (operations...varnishkafka)

2013-08-07 Thread Edenhill (Code Review)
Edenhill has uploaded a new change for review. https://gerrit.wikimedia.org/r/78157 Change subject: Added support for escaping troublesome characters in tag content. .. Added support for escaping troublesome characters in ta