[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add other countries to recruitment survey

2017-02-08 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336662 ) Change subject: Add other countries to recruitment survey .. Add other countries to recruitment survey Bug: T156419 Change-Id: I885b2faf1

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add new recruitment surveys for iOS and Android to announcem...

2017-02-06 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336358 ) Change subject: Add new recruitment surveys for iOS and Android to announcements endpoint .. Add new recruitment surveys for iOS and Andr

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Re-add p tags for iOS - needed for proper spacing

2016-12-15 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327517 ) Change subject: Re-add p tags for iOS - needed for proper spacing .. Re-add p tags for iOS - needed for proper spacing Bug: T152572 Chang

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add EN Donation Announcements

2016-12-14 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327224 ) Change subject: Add EN Donation Announcements .. Add EN Donation Announcements This adds an announcement for both the iOS and Android app

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Update start end times for surveys

2016-12-07 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/325805 Change subject: Update start end times for surveys .. Update start end times for surveys Bug: T145830 Change-Id: Id33cec18905ad9b570eca0b11

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Temporarily skip Wikivoyage geo unit test

2016-12-05 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Temporarily skip Wikivoyage geo unit test .. Temporarily skip Wikivoyage geo unit test A test was broken by an underlying content change (probably a templat

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add new survey link for android

2016-12-05 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/325335 Change subject: Add new survey link for android .. Add new survey link for android Update caption text Bug:T145830 Change-Id: I6dbb0367a94

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Extend survey through December

2016-11-30 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/324506 Change subject: Extend survey through December .. Extend survey through December Bug: T145830 Change-Id: I82f978c1568271b33f0537d79ea47ceac

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add announcements endpoint

2016-11-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/320712 Change subject: Add announcements endpoint .. Add announcements endpoint - Added new route to return static JSON - Added basic unit tests

[MediaWiki-commits] [Gerrit] Update site association file to support handoff and credenti... - change (operations/mediawiki-config)

2016-03-24 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/279394 Change subject: Update site association file to support handoff and credential sharing with the iOS app .. Update site association file to

[MediaWiki-commits] [Gerrit] Check respondsToSelector before calling method that is unava... - change (apps...wikipedia)

2015-07-24 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/226905 Change subject: Check respondsToSelector before calling method that is unavailable in early versions of iOS 7 .. Check respondsToSelector b

[MediaWiki-commits] [Gerrit] Check for NSNull before operating on language links - change (apps...wikipedia)

2015-07-24 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/226896 Change subject: Check for NSNull before operating on language links .. Check for NSNull before operating on language links T106853 Change-

[MediaWiki-commits] [Gerrit] Fix crash for nil title while saving page - change (apps...wikipedia)

2015-07-23 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/226625 Change subject: Fix crash for nil title while saving page .. Fix crash for nil title while saving page Bug: T106028 Bail out early in prod

[MediaWiki-commits] [Gerrit] Implement MobileWikiAppNavMenu logging - change (apps...wikipedia)

2015-07-23 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/226612 Change subject: Implement MobileWikiAppNavMenu logging .. Implement MobileWikiAppNavMenu logging Bug: T104622 Add new funnel Add logging i

[MediaWiki-commits] [Gerrit] Fix deletion animation - change (apps...wikipedia)

2015-07-21 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/226108 Change subject: Fix deletion animation .. Fix deletion animation bug: T105814 Migrated deletion logic to use snapshotting instead of actua

[MediaWiki-commits] [Gerrit] Implement Memory cache for articles - change (apps...wikipedia)

2015-07-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/225481 Change subject: Implement Memory cache for articles .. Implement Memory cache for articles T105819 Adding NSCache to the datastore, settin

[MediaWiki-commits] [Gerrit] Implement gifs in web view - change (apps...wikipedia)

2015-07-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/225329 Change subject: Implement gifs in web view .. Implement gifs in web view T104481 Added AnimatedGIFImageSerialization pod Updated all pods

[MediaWiki-commits] [Gerrit] Unifying list logic - change (apps...wikipedia)

2015-07-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/225230 Change subject: Unifying list logic .. Unifying list logic Follow on for T105019 Made a MWKList object. Using it to centralize list logic.

[MediaWiki-commits] [Gerrit] Prework for Lists - change (apps...wikipedia)

2015-07-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/225093 Change subject: Prework for Lists .. Prework for Lists Was getting compiler issues because of importing MediaWikiKit in global (Circular im

[MediaWiki-commits] [Gerrit] Adding Nearby to tab UI - change (apps...wikipedia)

2015-07-14 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/224745 Change subject: Adding Nearby to tab UI .. Adding Nearby to tab UI T105018 Add Nearby to tab controller in storyboard Remove nearby storyb

[MediaWiki-commits] [Gerrit] Add Recents to Tab UI - change (apps...wikipedia)

2015-07-14 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/224631 Change subject: Add Recents to Tab UI .. Add Recents to Tab UI T105019 Add new tab, updating story board Add recents data source Made Hist

[MediaWiki-commits] [Gerrit] Added Tab Bar to main UI - change (apps...wikipedia)

2015-07-13 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/224508 Change subject: Added Tab Bar to main UI .. Added Tab Bar to main UI T105018 Updated Storyboard to add tab bar Updated main UI to respond

[MediaWiki-commits] [Gerrit] Add search suggestions to 5.0 - change (apps...wikipedia)

2015-07-10 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/224110 Change subject: Add search suggestions to 5.0 .. Add search suggestions to 5.0 T105023 Added delegate call back to recent searches Added r

[MediaWiki-commits] [Gerrit] Fix various popup issues - change (apps...wikipedia)

2015-07-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/223985 Change subject: Fix various popup issues .. Fix various popup issues T105396 Fix images loading slowly (need to get the article from the d

[MediaWiki-commits] [Gerrit] Fixing unit tests for article fetcher and friends - change (apps...wikipedia)

2015-07-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/223954 Change subject: Fixing unit tests for article fetcher and friends .. Fixing unit tests for article fetcher and friends Change-Id: Icbf0a551

[MediaWiki-commits] [Gerrit] Update article fetcher to have multiple completion blocks. - change (apps...wikipedia)

2015-07-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/223834 Change subject: Update article fetcher to have multiple completion blocks. .. Update article fetcher to have multiple completion blocks. Up

[MediaWiki-commits] [Gerrit] Fix "gap" above UI in landscape - change (apps...wikipedia)

2015-07-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/223807 Change subject: Fix "gap" above UI in landscape .. Fix "gap" above UI in landscape Updated Masonry Used top layout guide for constraints to

[MediaWiki-commits] [Gerrit] Creating Fetcher to encapsulate async article fetching logic - change (apps...wikipedia)

2015-07-06 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/223194 Change subject: Creating Fetcher to encapsulate async article fetching logic .. Creating Fetcher to encapsulate async article fetching logic

[MediaWiki-commits] [Gerrit] Presenting popup preview for article VC from web view - change (apps...wikipedia)

2015-07-01 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/222197 Change subject: Presenting popup preview for article VC from web view .. Presenting popup preview for article VC from web view T101289 Add

[MediaWiki-commits] [Gerrit] Add save button to article card - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220964 Change subject: Add save button to article card .. Add save button to article card Bug T103088 Adding the capability for the article VC to

[MediaWiki-commits] [Gerrit] Adding KVO Controller pod - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220960 Change subject: Adding KVO Controller pod .. Adding KVO Controller pod Prework for bug: T103088 Need a fault tolerant way to use KVO in th

[MediaWiki-commits] [Gerrit] Prework for Save Button - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220961 Change subject: Prework for Save Button .. Prework for Save Button Bug 103888 Add ability for button type to be applied to button created i

[MediaWiki-commits] [Gerrit] More fixes for nil title - short circuit and never load a ba... - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220785 Change subject: More fixes for nil title - short circuit and never load a bad title .. More fixes for nil title - short circuit and never l

[MediaWiki-commits] [Gerrit] Fix unit tests for new assertions - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220774 Change subject: Fix unit tests for new assertions .. Fix unit tests for new assertions Change-Id: Icec88348be54514422938309de67f709190d186c

[MediaWiki-commits] [Gerrit] More preventions for nil title in history - change (apps...wikipedia)

2015-06-25 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220762 Change subject: More preventions for nil title in history .. More preventions for nil title in history Bug: T103737 more parameters assers

[MediaWiki-commits] [Gerrit] Fix crash bug due to nil title text. Bug: T103737 - change (apps...wikipedia)

2015-06-24 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220695 Change subject: Fix crash bug due to nil title text. Bug: T103737 .. Fix crash bug due to nil title text. Bug: T103737 Multiple safety nets

[MediaWiki-commits] [Gerrit] Update to languages glyph from design. - change (apps...wikipedia)

2015-06-22 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/220034 Change subject: Update to languages glyph from design. .. Update to languages glyph from design. For T97780. Change-Id: I8e664d482809f62cb

[MediaWiki-commits] [Gerrit] Implemented user data store and user list actions with Promi... - change (apps...wikipedia)

2015-06-22 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/219895 Change subject: Implemented user data store and user list actions with Promisekit .. Implemented user data store and user list actions with

[MediaWiki-commits] [Gerrit] Fix up bottom bar based on design comments - change (apps...wikipedia)

2015-06-22 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/219850 Change subject: Fix up bottom bar based on design comments .. Fix up bottom bar based on design comments Even spacing, reorder icons Bug:

[MediaWiki-commits] [Gerrit] Implemented user data store and user list actions with Promi... - change (apps...wikipedia)

2015-06-22 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/219840 Change subject: Implemented user data store and user list actions with Promisekit .. Implemented user data store and user list actions with

[MediaWiki-commits] [Gerrit] Make deceleration rates normal when scrolling in the app. - change (apps...wikipedia)

2015-06-18 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/219179 Change subject: Make deceleration rates normal when scrolling in the app. .. Make deceleration rates normal when scrolling in the app. Bug:

[MediaWiki-commits] [Gerrit] Implementing full text search. - change (apps...wikipedia)

2015-06-18 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/219176 Change subject: Implementing full text search. .. Implementing full text search. Follow on for Bug: T102362 Updated fetcher for full text

[MediaWiki-commits] [Gerrit] Fixing broken build - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218985 Change subject: Fixing broken build .. Fixing broken build Adding missing references to Global.h Adding missing reference to Legacy core da

[MediaWiki-commits] [Gerrit] Prework for implementing full text search - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218966 Change subject: Prework for implementing full text search .. Prework for implementing full text search Bug: T102362 Adding Mantle pod for

[MediaWiki-commits] [Gerrit] Update Podfile to iOS 7 - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218925 Change subject: Update Podfile to iOS 7 .. Update Podfile to iOS 7 Follow on patch for T102362 Change-Id: I398822335e02047e3ff3a2da078c58b

[MediaWiki-commits] [Gerrit] Reveal/Hide Search Animation Bug: T102362 - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218922 Change subject: Reveal/Hide Search Animation Bug: T102362 .. Reveal/Hide Search Animation Bug: T102362 Add delegate methods for responding

[MediaWiki-commits] [Gerrit] Pre-work for Bug: T102362 - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218921 Change subject: Pre-work for Bug: T102362 .. Pre-work for Bug: T102362 Refactor List view controller to work with data sources. Article is

[MediaWiki-commits] [Gerrit] Pre-work for Bug: T102362 - change (apps...wikipedia)

2015-06-17 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218919 Change subject: Pre-work for Bug: T102362 .. Pre-work for Bug: T102362 Refactor List view controller to work with data sources. Article is

[MediaWiki-commits] [Gerrit] Implement present and dismiss from list Bug: T101291 - change (apps...wikipedia)

2015-06-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218772 Change subject: Implement present and dismiss from list Bug: T101291 .. Implement present and dismiss from list Bug: T101291 Added a transi

[MediaWiki-commits] [Gerrit] Add saved pages list Bug: T97779 - change (apps...wikipedia)

2015-06-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218771 Change subject: Add saved pages list Bug: T97779 .. Add saved pages list Bug: T97779 Add collection view controller logic Load saved pages

[MediaWiki-commits] [Gerrit] Add new UI structure. Bug: T101282 - change (apps...wikipedia)

2015-06-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218710 Change subject: Add new UI structure. Bug: T101282 .. Add new UI structure. Bug: T101282 Moved all cruft out of app delegate. New story boa

[MediaWiki-commits] [Gerrit] Add new UI structure. Bug: T101282 - change (apps...wikipedia)

2015-06-16 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218708 Change subject: Add new UI structure. Bug: T101282 .. Add new UI structure. Bug: T101282 Moved all cruft out of app delegate. New story boa

[MediaWiki-commits] [Gerrit] Implement present and dismiss from list Bug: T101291 - change (apps...wikipedia)

2015-06-13 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/218100 Change subject: Implement present and dismiss from list Bug: T101291 .. Implement present and dismiss from list Bug: T101291 Added a transi

[MediaWiki-commits] [Gerrit] WIP Temp commit for web vc work - change (apps...wikipedia)

2015-06-12 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217958 Change subject: WIP Temp commit for web vc work .. WIP Temp commit for web vc work Change-Id: I4ef40b86899035791bb09c0a8a9d56fe65b5a410 ---

[MediaWiki-commits] [Gerrit] Add swipe to delete to saved pages Bug: T97779 - change (apps...wikipedia)

2015-06-12 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217956 Change subject: Add swipe to delete to saved pages Bug: T97779 .. Add swipe to delete to saved pages Bug: T97779 Follow on patch. Added ges

[MediaWiki-commits] [Gerrit] Fix search sampling Bug: T102163 - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217672 Change subject: Fix search sampling Bug: T102163 .. Fix search sampling Bug: T102163 It was sending all events instead of sampling to 0.1%

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217584 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: Idf

[MediaWiki-commits] [Gerrit] Fixed some footer xib constraint issues on iOS 7. - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217581 Change subject: Fixed some footer xib constraint issues on iOS 7. .. Fixed some footer xib constraint issues on iOS 7. Removed cruft gestur

[MediaWiki-commits] [Gerrit] fix visual & fnl lang picker regressions - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217579 Change subject: fix visual & fnl lang picker regressions .. fix visual & fnl lang picker regressions - Language filtering (filter both loca

[MediaWiki-commits] [Gerrit] Update fastlane metadata for app store including screenshots - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217578 Change subject: Update fastlane metadata for app store including screenshots .. Update fastlane metadata for app store including screenshots

[MediaWiki-commits] [Gerrit] Fixed some footer xib constraint issues on iOS 7. - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217572 Change subject: Fixed some footer xib constraint issues on iOS 7. .. Fixed some footer xib constraint issues on iOS 7. Removed cruft gestur

[MediaWiki-commits] [Gerrit] Fixed some footer xib constraint issues on iOS 7. - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217571 Change subject: Fixed some footer xib constraint issues on iOS 7. .. Fixed some footer xib constraint issues on iOS 7. Removed cruft gestur

[MediaWiki-commits] [Gerrit] Adding helpers for CGD Created while working on Bug: T97779 - change (apps...wikipedia)

2015-06-11 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217523 Change subject: Adding helpers for CGD Created while working on Bug: T97779 .. Adding helpers for CGD Created while working on Bug: T97779

[MediaWiki-commits] [Gerrit] Add saved pages list Bug: T97779 - change (apps...wikipedia)

2015-06-10 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217339 Change subject: Add saved pages list Bug: T97779 .. Add saved pages list Bug: T97779 Add collection view controller logic Load saved pages

[MediaWiki-commits] [Gerrit] Moving global functions and macros to a global header. This ... - change (apps...wikipedia)

2015-06-10 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217298 Change subject: Moving global functions and macros to a global header. This includes the MWLocalize macro. This is anticipation of the WikiAppUtils class going away. .

[MediaWiki-commits] [Gerrit] Update fastlane metadata for app store including screenshots - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217212 Change subject: Update fastlane metadata for app store including screenshots .. Update fastlane metadata for app store including screenshots

[MediaWiki-commits] [Gerrit] Fix for lead image not fading in. - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217211 Change subject: Fix for lead image not fading in. .. Fix for lead image not fading in. Fix for landscape article title tap causing image ga

[MediaWiki-commits] [Gerrit] Revert some changes from the swift patch that accidentally g... - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217210 Change subject: Revert some changes from the swift patch that accidentally got in. .. Revert some changes from the swift patch that acciden

[MediaWiki-commits] [Gerrit] version bump - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217111 Change subject: version bump .. version bump Change-Id: I9e833ddd7b1dee64b99e8afe4902fc154188bf15 --- M Wikipedia/Wikipedia-Info.plist 1 fi

[MediaWiki-commits] [Gerrit] Add new UI structure. Bug: T101282 - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217008 Change subject: Add new UI structure. Bug: T101282 .. Add new UI structure. Bug: T101282 Moved all cruft out of app delegate. New story boa

[MediaWiki-commits] [Gerrit] bump deployment target 7.0 & enable swift - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217002 Change subject: bump deployment target 7.0 & enable swift .. bump deployment target 7.0 & enable swift (Originally from Bgerstle) - Bump d

[MediaWiki-commits] [Gerrit] Add Blockskit UI subspec. (Now can use block based UI for al... - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/217001 Change subject: Add Blockskit UI subspec. (Now can use block based UI for alert views and buttons - yippee!) .. Add Blockskit UI subspec. (

[MediaWiki-commits] [Gerrit] Fix for lead image not fading in. - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216995 Change subject: Fix for lead image not fading in. .. Fix for lead image not fading in. Fix for landscape article title tap causing image ga

[MediaWiki-commits] [Gerrit] Moving user defaults registration from a static constructor ... - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216993 Change subject: Moving user defaults registration from a static constructor into the class load method. The requirement to register before applicationDidFinishLaunching does not require a C function.(Highest

[MediaWiki-commits] [Gerrit] Remove week warnings - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216992 Change subject: Remove week warnings .. Remove week warnings Change-Id: Id714ad9ff4b535592440a3850827533b4a6b3cdd --- M Wikipedia/Categorie

[MediaWiki-commits] [Gerrit] Fix Text Alignment warnings - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216991 Change subject: Fix Text Alignment warnings .. Fix Text Alignment warnings Change-Id: I4ac27689aeb3b80c57d66b5512e33960ddbd3040 --- M Wikip

[MediaWiki-commits] [Gerrit] Removing manual warnings. These should be copied into phabri... - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216990 Change subject: Removing manual warnings. These should be copied into phabricator for proper estimation and prioritization. .. Removing man

[MediaWiki-commits] [Gerrit] Remove warnings for deprecated prefixed text and friends - change (apps...wikipedia)

2015-06-09 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216989 Change subject: Remove warnings for deprecated prefixed text and friends .. Remove warnings for deprecated prefixed text and friends Change

[MediaWiki-commits] [Gerrit] Fix build (needed to cast object to the expected type) - change (apps...wikipedia)

2015-06-08 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216877 Change subject: Fix build (needed to cast object to the expected type) .. Fix build (needed to cast object to the expected type) Change-Id:

[MediaWiki-commits] [Gerrit] One more time fix fast file - change (apps...wikipedia)

2015-06-05 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/216117 Change subject: One more time fix fast file .. One more time fix fast file Change-Id: If782a1428e7bff644ff96fc68475f7fd1dcda2e7 --- M fastl

[MediaWiki-commits] [Gerrit] Tweak to lead image height and initial vertical offset. - change (apps...wikipedia)

2015-06-05 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Tweak to lead image height and initial vertical offset. .. Tweak to lead image height and initial vertical offset. Bug: T101464 Change-Id: I30a3916d5402b4ed

[MediaWiki-commits] [Gerrit] move hockeyapp & debug menu config to info.plist - change (apps...wikipedia)

2015-06-04 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: move hockeyapp & debug menu config to info.plist .. move hockeyapp & debug menu config to info.plist tested on: - [x] Debug: https://rink.hockeyapp.net/ma

[MediaWiki-commits] [Gerrit] Fetch site info to get main page - change (apps...wikipedia)

2015-06-04 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fetch site info to get main page .. Fetch site info to get main page Prevents a crash in the app when we don't know the main page for a given language code.

[MediaWiki-commits] [Gerrit] Fix for wonky spacing around text beneath widened images. - change (apps...wikipedia)

2015-06-04 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix for wonky spacing around text beneath widened images. .. Fix for wonky spacing around text beneath widened images. Bug: T101186 Change-Id: Ib476ecf4227

[MediaWiki-commits] [Gerrit] add tests for article fetcher - change (apps...wikipedia)

2015-06-03 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: add tests for article fetcher .. add tests for article fetcher Bug: T101078 Change-Id: I6cf93ba8578b958ef1b96f7b9dae411d432c8798 --- M MediaWikiKit/MediaWik

[MediaWiki-commits] [Gerrit] fix unit tests (again) & crash reporting - change (apps...wikipedia)

2015-06-03 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: fix unit tests (again) & crash reporting .. fix unit tests (again) & crash reporting Crash reporting is now expected to always be enabled. - Use bundle ide

[MediaWiki-commits] [Gerrit] Fix Bug: T99123 - was removing an object for a nil key, now ... - change (apps...wikipedia)

2015-06-03 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix Bug: T99123 - was removing an object for a nil key, now checking for nil. .. Fix Bug: T99123 - was removing an object for a nil key, now checking for ni

[MediaWiki-commits] [Gerrit] make sure to run block when commenting out version bump work - change (apps...wikipedia)

2015-06-03 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/215640 Change subject: make sure to run block when commenting out version bump work .. make sure to run block when commenting out version bump work

[MediaWiki-commits] [Gerrit] hygiene: hash & equality utils plus title & site cleanup - change (apps...wikipedia)

2015-06-03 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: hygiene: hash & equality utils plus title & site cleanup .. hygiene: hash & equality utils plus title & site cleanup This is a boyscout patch in preparation

[MediaWiki-commits] [Gerrit] Fix Bug: T99123 - was removing an object for a nil key, now ... - change (apps...wikipedia)

2015-06-02 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/215372 Change subject: Fix Bug: T99123 - was removing an object for a nil key, now checking for nil. .. Fix Bug: T99123 - was removing an object f

[MediaWiki-commits] [Gerrit] Fix Bug: T99121 - no longer trying to append a nil string - change (apps...wikipedia)

2015-06-02 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/215373 Change subject: Fix Bug: T99121 - no longer trying to append a nil string .. Fix Bug: T99121 - no longer trying to append a nil string Chan

[MediaWiki-commits] [Gerrit] Fix alpha builds - use jenkins number for build number until... - change (apps...wikipedia)

2015-06-02 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/215367 Change subject: Fix alpha builds - use jenkins number for build number until we have the ability to push changes to gerrit. .. Fix alpha bu

[MediaWiki-commits] [Gerrit] Fix for Bug: T99122 - exception on non-wmf image urls - change (apps...wikipedia)

2015-06-02 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review. https://gerrit.wikimedia.org/r/215357 Change subject: Fix for Bug: T99122 - exception on non-wmf image urls .. Fix for Bug: T99122 - exception on non-wmf image urls Once again t

[MediaWiki-commits] [Gerrit] fix unit tests & consolidate fixtures - change (apps...wikipedia)

2015-06-01 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: fix unit tests & consolidate fixtures .. fix unit tests & consolidate fixtures - Changes to MWK ownership semantics were causing some tests to break. - Move

[MediaWiki-commits] [Gerrit] Image assets file updates - change (apps...wikipedia)

2015-06-01 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Image assets file updates .. Image assets file updates These changes result from simply clicking the .xcassets file in Xcode 6.3. Not sure why, but figured

[MediaWiki-commits] [Gerrit] set UIFileSharingEnabled based on build config - change (apps...wikipedia)

2015-06-01 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: set UIFileSharingEnabled based on build config .. set UIFileSharingEnabled based on build config Writes to the app's Info.plist after build to enable iTunes

[MediaWiki-commits] [Gerrit] Fix for images sometimes not being routed to data store. - change (apps...wikipedia)

2015-06-01 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix for images sometimes not being routed to data store. .. Fix for images sometimes not being routed to data store. Change-Id: Ic936ac9eb886e0710b898ba328e

[MediaWiki-commits] [Gerrit] Fix for lead image title gradient not being hidden on landsc... - change (apps...wikipedia)

2015-05-20 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix for lead image title gradient not being hidden on landscape iOS 6. .. Fix for lead image title gradient not being hidden on landscape iOS 6. Bug: T9969

[MediaWiki-commits] [Gerrit] Fix for math symbols and other small images being incorrectl... - change (apps...wikipedia)

2015-05-20 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix for math symbols and other small images being incorrectly widened. .. Fix for math symbols and other small images being incorrectly widened. Bug: T9975

[MediaWiki-commits] [Gerrit] Fix for face detection in lead image on iOS 6. - change (apps...wikipedia)

2015-05-19 Thread Fjalapeno (Code Review)
Fjalapeno has submitted this change and it was merged. Change subject: Fix for face detection in lead image on iOS 6. .. Fix for face detection in lead image on iOS 6. Turns out css "calc" was used and is not supported in iOS 6

  1   2   3   >