[MediaWiki-commits] [Gerrit] mediawiki...GoogleSiteSearch[master]: Version 3.0

2016-08-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/305935 Change subject: Version 3.0 .. Version 3.0 Change-Id: Ie18df0930d183c8aeca2cecbc18e12ade611dd9c --- M extension.json 1 file changed, 1

[MediaWiki-commits] [Gerrit] mediawiki...GoogleSiteSearch[master]: Convert to CSE v2 API, make HTML customizable by GoogleSiteS...

2016-08-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/305934 Change subject: Convert to CSE v2 API, make HTML customizable by GoogleSiteSearchHTML hook .. Convert to CSE v2 API, make HTML customizable

[MediaWiki-commits] [Gerrit] mediawiki...GoogleSiteSearch[master]: Convert to 1.23+ extension.json

2016-08-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/305875 Change subject: Convert to 1.23+ extension.json .. Convert to 1.23+ extension.json Change-Id: Ic4044fee9cceef4a0daf8cef67344a2ee19445e8 --- A

[MediaWiki-commits] [Gerrit] mediawiki...SecureHTML[master]: Version 3.0

2016-07-28 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/301737 Change subject: Version 3.0 .. Version 3.0 Change-Id: I392cde120dc43a9acdcb66d3b517bd384d119c4d --- M extension.json 1 file changed, 1

[MediaWiki-commits] [Gerrit] Convert to 1.25+ extension.json - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Convert to 1.25+ extension.json .. Convert to 1.25+ extension.json Backwards compatible with 1.23. Change-Id: I15a312662917ddb9c9743fd129e3737f4973cfd6 --- M

[MediaWiki-commits] [Gerrit] Convert to 1.25+ extension.json - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300803 Change subject: Convert to 1.25+ extension.json .. Convert to 1.25+ extension.json Backwards compatible with 1.23. Change-Id:

[MediaWiki-commits] [Gerrit] Provide additional protection against key name leaks - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Provide additional protection against key name leaks .. Provide additional protection against key name leaks The existence of a key name could be discovered

[MediaWiki-commits] [Gerrit] Use === for comparisons - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Use === for comparisons .. Use === for comparisons "$testhash == $computedhash" may allow for increased collision probability, due to PHP's loose type

[MediaWiki-commits] [Gerrit] Provide additional protection against key name leaks - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300761 Change subject: Provide additional protection against key name leaks .. Provide additional protection against key name leaks The existence of

[MediaWiki-commits] [Gerrit] Use === for comparisons - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300760 Change subject: Use === for comparisons .. Use === for comparisons "$testhash == $computedhash" may allow for increased collision

[MediaWiki-commits] [Gerrit] Use Html::rawElement class=error for inline secureHTMLRender... - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Use Html::rawElement class=error for inline secureHTMLRender errors .. Use Html::rawElement class=error for inline secureHTMLRender errors Change-Id:

[MediaWiki-commits] [Gerrit] Use Html::rawElement class=error for inline secureHTMLRender... - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300743 Change subject: Use Html::rawElement class=error for inline secureHTMLRender errors .. Use Html::rawElement class=error for inline

[MediaWiki-commits] [Gerrit] Allow configurable per-key HMAC algorithm - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Allow configurable per-key HMAC algorithm .. Allow configurable per-key HMAC algorithm Change-Id: Ifba94953278ff3f8d26578c8c9084187b1cc20b5 --- M

[MediaWiki-commits] [Gerrit] Allow configurable per-key HMAC algorithm - change (mediawiki...SecureHTML)

2016-07-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300742 Change subject: Allow configurable per-key HMAC algorithm .. Allow configurable per-key HMAC algorithm Change-Id:

[MediaWiki-commits] [Gerrit] Remove legacy shtml_keys (MD5 concatenation) support - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300490 Change subject: Remove legacy shtml_keys (MD5 concatenation) support .. Remove legacy shtml_keys (MD5 concatenation) support Version 1 keys

[MediaWiki-commits] [Gerrit] Convert HTML form to HTMLForm - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Convert HTML form to HTMLForm .. Convert HTML form to HTMLForm Change-Id: Ie883ca4a42978e2fffc27d526bcef259ecf70c70 --- M SpecialSecureHTML.php 1 file

[MediaWiki-commits] [Gerrit] Document i18n securehtml-hashrequired - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Document i18n securehtml-hashrequired .. Document i18n securehtml-hashrequired Change-Id: Iabf9535ce94cc6f438886c54da77b8ab6f1a --- M i18n/qqq.json 1 file

[MediaWiki-commits] [Gerrit] Document i18n securehtml-hashrequired - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300489 Change subject: Document i18n securehtml-hashrequired .. Document i18n securehtml-hashrequired Change-Id:

[MediaWiki-commits] [Gerrit] Convert HTML form to HTMLForm - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/300488 Change subject: Convert HTML form to HTMLForm .. Convert HTML form to HTMLForm Change-Id: Ie883ca4a42978e2fffc27d526bcef259ecf70c70 --- M

[MediaWiki-commits] [Gerrit] Make the shtml tag configurable via wgSecureHTMLTag - change (mediawiki...SecureHTML)

2016-07-21 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Make the shtml tag configurable via wgSecureHTMLTag .. Make the shtml tag configurable via wgSecureHTMLTag Change-Id:

[MediaWiki-commits] [Gerrit] Fix key name check in deprecated shtml_keys - change (mediawiki...SecureHTML)

2016-07-19 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Fix key name check in deprecated shtml_keys .. Fix key name check in deprecated shtml_keys Change-Id: Ia25f1030e8b614612f985bffa2741d318a772917 --- M

[MediaWiki-commits] [Gerrit] Fix key name check in deprecated shtml_keys - change (mediawiki...SecureHTML)

2016-07-19 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/299871 Change subject: Fix key name check in deprecated shtml_keys .. Fix key name check in deprecated shtml_keys Change-Id:

[MediaWiki-commits] [Gerrit] Check for array indices before using them - change (mediawiki...SecureHTML)

2016-07-18 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Check for array indices before using them .. Check for array indices before using them Change-Id: I718ab3b0b804e37da003cc56db6beb89fe3f74a8 --- M

[MediaWiki-commits] [Gerrit] Check for array indices before using them - change (mediawiki...SecureHTML)

2016-07-18 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/299690 Change subject: Check for array indices before using them .. Check for array indices before using them Change-Id:

[MediaWiki-commits] [Gerrit] Replacing deprecated getLang function. - change (mediawiki...GoogleSiteSearch)

2014-07-15 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Replacing deprecated getLang function. .. Replacing deprecated getLang function. Replace the getLang() function on line 81 with the new getLanguage()

[MediaWiki-commits] [Gerrit] Version 2.4.1 - change (mediawiki...SecureHTML)

2014-04-14 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125693 Change subject: Version 2.4.1 .. Version 2.4.1 Change-Id: I886d60b0c339c3befcdff6520f61c7387c208077 --- M SecureHTML.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] Version 2.4.1 - change (mediawiki...SecureHTML)

2014-04-14 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Version 2.4.1 .. Version 2.4.1 Change-Id: I886d60b0c339c3befcdff6520f61c7387c208077 --- M SecureHTML.php 1 file changed, 1 insertion(+), 1 deletion(-)

[MediaWiki-commits] [Gerrit] Version 2.2 - change (mediawiki...GoogleSiteSearch)

2014-04-14 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125694 Change subject: Version 2.2 .. Version 2.2 Change-Id: I0a157d35e127d660ac85703f83f27fd40dc6b476 --- M GoogleSiteSearch.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] Version 2.2 - change (mediawiki...GoogleSiteSearch)

2014-04-14 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Version 2.2 .. Version 2.2 Change-Id: I0a157d35e127d660ac85703f83f27fd40dc6b476 --- M GoogleSiteSearch.php 1 file changed, 1 insertion(+), 1 deletion(-)

[MediaWiki-commits] [Gerrit] Use FormatJson::encode() for escaping template JS - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125583 Change subject: Use FormatJson::encode() for escaping template JS .. Use FormatJson::encode() for escaping template JS htmltentities() is not

[MediaWiki-commits] [Gerrit] Use FormatJson::encode() for escaping template JS - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Use FormatJson::encode() for escaping template JS .. Use FormatJson::encode() for escaping template JS htmltentities() is not appropriate for escaping the

[MediaWiki-commits] [Gerrit] Allow template use on HTTPS sites - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Allow template use on HTTPS sites .. Allow template use on HTTPS sites When the default template is served on an HTTPS site, the CSE block is not served due

[MediaWiki-commits] [Gerrit] Allow template use on HTTPS sites - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125584 Change subject: Allow template use on HTTPS sites .. Allow template use on HTTPS sites When the default template is served on an HTTPS site,

[MediaWiki-commits] [Gerrit] Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125585 Change subject: Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() .. Global $wgGoogleSiteSearchCharset in GoogleSiteSearch()

[MediaWiki-commits] [Gerrit] Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() - change (mediawiki...GoogleSiteSearch)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() .. Global $wgGoogleSiteSearchCharset in GoogleSiteSearch() $wgGoogleSiteSearchCharset was not being

[MediaWiki-commits] [Gerrit] Fix PHP Undefined notices - change (mediawiki...SecureHTML)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Fix PHP Undefined notices .. Fix PHP Undefined notices Fix several places where a PHP Undefined variable or Undefined index notice can be generated.

[MediaWiki-commits] [Gerrit] Fix PHP Undefined notices - change (mediawiki...SecureHTML)

2014-04-13 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/125676 Change subject: Fix PHP Undefined notices .. Fix PHP Undefined notices Fix several places where a PHP Undefined variable or Undefined index

[MediaWiki-commits] [Gerrit] Add SpecialSearchResultsPrepend/Append to release notes - change (mediawiki/core)

2013-04-17 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/59790 Change subject: Add SpecialSearchResultsPrepend/Append to release notes .. Add SpecialSearchResultsPrepend/Append to release notes Commit

[MediaWiki-commits] [Gerrit] Add SpecialSearchResultsPrepend/Append to release notes - change (mediawiki/core)

2013-03-21 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/55030 Change subject: Add SpecialSearchResultsPrepend/Append to release notes .. Add SpecialSearchResultsPrepend/Append to release notes Commit

[MediaWiki-commits] [Gerrit] Consistency tweaks in preparation for adding extension to tr... - change (mediawiki...SecureHTML)

2013-02-27 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Consistency tweaks in preparation for adding extension to translatewiki.net .. Consistency tweaks in preparation for adding extension to translatewiki.net *

[MediaWiki-commits] [Gerrit] Add $wgGoogleSiteSearchCharset for HTML templating - change (mediawiki...GoogleSiteSearch)

2013-02-26 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/51028 Change subject: Add $wgGoogleSiteSearchCharset for HTML templating .. Add $wgGoogleSiteSearchCharset for HTML templating Default 'UTF-8',

[MediaWiki-commits] [Gerrit] Add i18n message documentation - change (mediawiki...SecureHTML)

2013-02-25 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Add i18n message documentation .. Add i18n message documentation Per https://www.mediawiki.org/wiki/I18n#Message_documentation . Also, adjust URL to https for

[MediaWiki-commits] [Gerrit] Add i18n message documentation - change (mediawiki...GoogleSiteSearch)

2013-02-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/50704 Change subject: Add i18n message documentation .. Add i18n message documentation Per

[MediaWiki-commits] [Gerrit] Add i18n message documentation - change (mediawiki...GoogleSiteSearch)

2013-02-24 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Add i18n message documentation .. Add i18n message documentation Per https://www.mediawiki.org/wiki/I18n#Message_documentation Change-Id:

[MediaWiki-commits] [Gerrit] Add i18n message documentation - change (mediawiki...SecureHTML)

2013-02-24 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. https://gerrit.wikimedia.org/r/50723 Change subject: Add i18n message documentation .. Add i18n message documentation Per

[MediaWiki-commits] [Gerrit] Add .gitignore and .gitreview - change (mediawiki...GoogleSiteSearch[master])

2013-01-23 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. Change subject: Add .gitignore and .gitreview .. Add .gitignore and .gitreview Change-Id: I08d6f04b9596d03e56cf3278d56b5ac3a34d41f4 --- A .gitignore A .gitreview 2 files changed, 10

[MediaWiki-commits] [Gerrit] Add .gitignore and .gitreview - change (mediawiki...GoogleSiteSearch[master])

2013-01-23 Thread Fo0bar (Code Review)
Fo0bar has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview .. Add .gitignore and .gitreview Change-Id: I08d6f04b9596d03e56cf3278d56b5ac3a34d41f4 --- A .gitignore A .gitreview 2 files

[MediaWiki-commits] [Gerrit] Adding SpecialSearchResultsPrepend/Append hooks - change (mediawiki/core[master])

2013-01-17 Thread Fo0bar (Code Review)
Fo0bar has uploaded a new change for review. Change subject: Adding SpecialSearchResultsPrepend/Append hooks .. Adding SpecialSearchResultsPrepend/Append hooks These hooks allow you to prepend, append or replace the search