[MediaWiki-commits] [Gerrit] MediaViewer schema should be a dependency of mmv.bootstrap - change (mediawiki...MultimediaViewer)

2014-02-26 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115866 Change subject: MediaViewer schema should be a dependency of mmv.bootstrap .. MediaViewer schema should be a dependency of mmv.bootstrap For

[MediaWiki-commits] [Gerrit] Reduce Wikidata author vcard to creator part - change (mediawiki...CommonsMetadata)

2014-02-25 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115379 Change subject: Reduce Wikidata author vcard to creator part .. Reduce Wikidata author vcard to creator part Wikidata templates dump a vcard

[MediaWiki-commits] [Gerrit] Fixes hash self-reaction - change (mediawiki...MultimediaViewer)

2014-02-24 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115129 Change subject: Fixes hash self-reaction .. Fixes hash self-reaction * Fixes bug where the mmv would react to its own hash changes * Adds

[MediaWiki-commits] [Gerrit] Better way to detect CORS support - change (mediawiki...MultimediaViewer)

2014-02-24 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115166 Change subject: Better way to detect CORS support .. Better way to detect CORS support The old technique doesn't work in Firefox and doesn't

[MediaWiki-commits] [Gerrit] Wait for CSS to be truly loaded before opening the viewer - change (mediawiki...MultimediaViewer)

2014-02-24 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/115196 Change subject: Wait for CSS to be truly loaded before opening the viewer .. Wait for CSS to be truly loaded before opening the viewer This

[MediaWiki-commits] [Gerrit] Fix hash handling issues - change (mediawiki...MultimediaViewer)

2014-02-21 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/114728 Change subject: Fix hash handling issues .. Fix hash handling issues * Fixes the bug where the browser hash would get nuked on foreign anchor

[MediaWiki-commits] [Gerrit] Fix preloadFullscreenThumnail breakage - change (mediawiki...MultimediaViewer)

2014-02-20 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/114443 Change subject: Fix preloadFullscreenThumnail breakage .. Fix preloadFullscreenThumnail breakage Since there was no merge conflict and the

[MediaWiki-commits] [Gerrit] Missing dependency - change (mediawiki...MultimediaViewer)

2014-02-19 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/114149 Change subject: Missing dependency .. Missing dependency Change-Id: I8ce510883e13401d9b1464b1583ee11d01f40df6 --- M MultimediaViewer.php 1

[MediaWiki-commits] [Gerrit] GlobalUsage should use the right Api class - change (mediawiki...MultimediaViewer)

2014-02-19 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/114174 Change subject: GlobalUsage should use the right Api class .. GlobalUsage should use the right Api class Change-Id:

[MediaWiki-commits] [Gerrit] Hide mouse cursor when buttons are faded out in fullscreen - change (mediawiki...MultimediaViewer)

2014-02-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113921 Change subject: Hide mouse cursor when buttons are faded out in fullscreen .. Hide mouse cursor when buttons are faded out in fullscreen

[MediaWiki-commits] [Gerrit] Make metadata animation more subtle - change (mediawiki...MultimediaViewer)

2014-02-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113929 Change subject: Make metadata animation more subtle .. Make metadata animation more subtle And stop showing when the user has opened the

[MediaWiki-commits] [Gerrit] Reduce Wikidata author vcard to creator part - change (mediawiki...MultimediaViewer)

2014-02-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113937 Change subject: Reduce Wikidata author vcard to creator part .. Reduce Wikidata author vcard to creator part And let the credit area overflow

[MediaWiki-commits] [Gerrit] Blurred thumbnail preview + progress bar - change (mediawiki...MultimediaViewer)

2014-02-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113963 Change subject: Blurred thumbnail preview + progress bar .. Blurred thumbnail preview + progress bar Displays a blurred version of the

[MediaWiki-commits] [Gerrit] Make the image and navigation buttons unselectable - change (mediawiki...MultimediaViewer)

2014-02-18 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113970 Change subject: Make the image and navigation buttons unselectable .. Make the image and navigation buttons unselectable Change-Id:

[MediaWiki-commits] [Gerrit] Record detailed network performance of API calls - change (mediawiki...MultimediaViewer)

2014-02-14 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113344 Change subject: Record detailed network performance of API calls .. Record detailed network performance of API calls Also fixes some issues

[MediaWiki-commits] [Gerrit] Avoid double requests when measuring performance of image load - change (mediawiki...MultimediaViewer)

2014-02-13 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113130 Change subject: Avoid double requests when measuring performance of image load .. Avoid double requests when measuring performance of image

[MediaWiki-commits] [Gerrit] Fix missing dependency for mmv.performance - change (mediawiki...MultimediaViewer)

2014-02-13 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/113134 Change subject: Fix missing dependency for mmv.performance .. Fix missing dependency for mmv.performance Change-Id:

[MediaWiki-commits] [Gerrit] Get rid of lightboxHooks - change (mediawiki...MultimediaViewer)

2014-02-11 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112670 Change subject: Get rid of lightboxHooks .. Get rid of lightboxHooks Delete lightboxHooks, since most of them haven't proven to be useful.

[MediaWiki-commits] [Gerrit] Fix fullscreen and close icons - change (mediawiki...MultimediaViewer)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112426 Change subject: Fix fullscreen and close icons .. Fix fullscreen and close icons Some styles got mangled when 111372 landed Change-Id:

[MediaWiki-commits] [Gerrit] Fix defullscreen icon duplicate CSS - change (mediawiki...MultimediaViewer)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112428 Change subject: Fix defullscreen icon duplicate CSS .. Fix defullscreen icon duplicate CSS This one slipped through the cracks again

[MediaWiki-commits] [Gerrit] Start sampling detailed network performance for Multimedia V... - change (operations/mediawiki-config)

2014-02-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/112452 Change subject: Start sampling detailed network performance for Multimedia Viewer .. Start sampling detailed network performance for

[MediaWiki-commits] [Gerrit] Track detailed content loading network performance - change (mediawiki...MultimediaViewer)

2014-02-04 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/97 Change subject: Track detailed content loading network performance .. Track detailed content loading network performance Leverages the W3C

[MediaWiki-commits] [Gerrit] Fix the view all uses link when there are both local and g... - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110517 Change subject: Fix the view all uses link when there are both local and global results .. Fix the view all uses link when there are both

[MediaWiki-commits] [Gerrit] Make mmv handle urlencoded hashes - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110522 Change subject: Make mmv handle urlencoded hashes .. Make mmv handle urlencoded hashes Change-Id: Id05806be4586a3d6f04b92ace2c8195b8de016bc

[MediaWiki-commits] [Gerrit] Add the ability to know if fullscreen is available - change (mediawiki/core)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110523 Change subject: Add the ability to know if fullscreen is available .. Add the ability to know if fullscreen is available Not all browsers

[MediaWiki-commits] [Gerrit] Hide the fullscren button when fullscreen is unavailable - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110525 Change subject: Hide the fullscren button when fullscreen is unavailable .. Hide the fullscren button when fullscreen is unavailable

[MediaWiki-commits] [Gerrit] Place the metadata correctly before opening the lightbox - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110530 Change subject: Place the metadata correctly before opening the lightbox .. Place the metadata correctly before opening the lightbox The

[MediaWiki-commits] [Gerrit] Hide the controls after some time when in fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-31 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110579 Change subject: Hide the controls after some time when in fullscreen mode .. Hide the controls after some time when in fullscreen mode

[MediaWiki-commits] [Gerrit] Swap position of caption and description - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110341 Change subject: Swap position of caption and description .. Swap position of caption and description The design requested that the caption is

[MediaWiki-commits] [Gerrit] Replace $.fn.msg calls my mw.message - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110363 Change subject: Replace $.fn.msg calls my mw.message .. Replace $.fn.msg calls my mw.message $.fn.msg breaks on beta for an unknown reason

[MediaWiki-commits] [Gerrit] Revert Replace $.fn.msg calls by mw.message - change (mediawiki...MultimediaViewer)

2014-01-30 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/110364 Change subject: Revert Replace $.fn.msg calls by mw.message .. Revert Replace $.fn.msg calls by mw.message This reverts commit

[MediaWiki-commits] [Gerrit] Fix fatal in DataCollector.php - change (mediawiki...CommonsMetadata)

2014-01-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109857 Change subject: Fix fatal in DataCollector.php .. Fix fatal in DataCollector.php b6a5a1f17efb06a12be65fce3a708d50928cd7af introduced a fatal

[MediaWiki-commits] [Gerrit] Test metadata visibility in fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-28 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109866 Change subject: Test metadata visibility in fullscreen mode .. Test metadata visibility in fullscreen mode Add metadata visibility logic to

[MediaWiki-commits] [Gerrit] Simple test for enter/exiting fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-27 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109677 Change subject: Simple test for enter/exiting fullscreen mode .. Simple test for enter/exiting fullscreen mode While writing the test I

[MediaWiki-commits] [Gerrit] Fixes bug where next/prev would exit fullscreen mode - change (mediawiki...MultimediaViewer)

2014-01-27 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109682 Change subject: Fixes bug where next/prev would exit fullscreen mode .. Fixes bug where next/prev would exit fullscreen mode Next/prev

[MediaWiki-commits] [Gerrit] Chevron/metadata UI behavior improvements - change (mediawiki...MultimediaViewer)

2014-01-22 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/109023 Change subject: Chevron/metadata UI behavior improvements .. Chevron/metadata UI behavior improvements When the multimedia panel is closed,

[MediaWiki-commits] [Gerrit] Adding first pass at jsduck docs - change (mediawiki...MultimediaViewer)

2014-01-21 Thread Gilles (Code Review)
Gilles has submitted this change and it was merged. Change subject: Adding first pass at jsduck docs .. Adding first pass at jsduck docs Interface, data model, and image all documented. Change-Id:

[MediaWiki-commits] [Gerrit] Add main class to jsduck - change (mediawiki...MultimediaViewer)

2014-01-21 Thread Gilles (Code Review)
Gilles has submitted this change and it was merged. Change subject: Add main class to jsduck .. Add main class to jsduck Change-Id: I774303ce4f756637bea3821ae2b2ff724351b3bb --- M docs/external.js M docs/jsduck-config.json M

[MediaWiki-commits] [Gerrit] Propagate the favicon information to getInfo() - change (mediawiki/core)

2014-01-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107592 Change subject: Propagate the favicon information to getInfo() .. Propagate the favicon information to getInfo() This is needed by

[MediaWiki-commits] [Gerrit] Display the favicon of the foreign file repo when available - change (mediawiki...MultimediaViewer)

2014-01-15 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107594 Change subject: Display the favicon of the foreign file repo when available .. Display the favicon of the foreign file repo when available

[MediaWiki-commits] [Gerrit] Make sure that the close button is always visible - change (mediawiki...MultimediaViewer)

2014-01-14 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107379 Change subject: Make sure that the close button is always visible .. Make sure that the close button is always visible Change-Id:

[MediaWiki-commits] [Gerrit] Clicking on the chevron should open/close the details - change (mediawiki...MultimediaViewer)

2014-01-14 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/107384 Change subject: Clicking on the chevron should open/close the details .. Clicking on the chevron should open/close the details Change-Id:

[MediaWiki-commits] [Gerrit] Solves visibility issue on the progress bar - change (mediawiki...UploadWizard)

2014-01-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106704 Change subject: Solves visibility issue on the progress bar .. Solves visibility issue on the progress bar At first it seemed odd to me that

[MediaWiki-commits] [Gerrit] Fix the i18n source string for the chunked preference - change (mediawiki...UploadWizard)

2014-01-10 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106711 Change subject: Fix the i18n source string for the chunked preference .. Fix the i18n source string for the chunked preference Seemed like a

[MediaWiki-commits] [Gerrit] Only scroll to the top when opening the lightbox - change (mediawiki...MultimediaViewer)

2014-01-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106533 Change subject: Only scroll to the top when opening the lightbox .. Only scroll to the top when opening the lightbox Not when going

[MediaWiki-commits] [Gerrit] Improve the test coverage to also check prev/next scroll - change (mediawiki...MultimediaViewer)

2014-01-09 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106560 Change subject: Improve the test coverage to also check prev/next scroll .. Improve the test coverage to also check prev/next scroll This

[MediaWiki-commits] [Gerrit] Move the arrows and the close/fullscreen button - change (mediawiki...MultimediaViewer)

2014-01-08 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106224 Change subject: Move the arrows and the close/fullscreen button .. Move the arrows and the close/fullscreen button Looks drastic at first,

[MediaWiki-commits] [Gerrit] Make the behavior of the lightbox more consistent with scroll - change (mediawiki...MultimediaViewer)

2014-01-08 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/106263 Change subject: Make the behavior of the lightbox more consistent with scroll .. Make the behavior of the lightbox more consistent with

[MediaWiki-commits] [Gerrit] Solves visibility issue on the progress bar - change (mediawiki...UploadWizard)

2014-01-06 Thread Gilles (Code Review)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/105694 Change subject: Solves visibility issue on the progress bar .. Solves visibility issue on the progress bar At first it seemed odd to me that

<    6   7   8   9   10   11