[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Send sectionpreview parameter on TextExtract parse

2017-06-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361892 ) Change subject: Send sectionpreview parameter on TextExtract parse .. Send sectionpreview parameter on TextExtract parse This will

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable logging from MobileFormatter#moveFirstParagraphBefo...

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361789 ) Change subject: Disable logging from MobileFormatter#moveFirstParagraphBeforeInfobox .. Disable logging from

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Cleanup: Remove wgMFContentNamespace

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361788 ) Change subject: Cleanup: Remove wgMFContentNamespace .. Cleanup: Remove wgMFContentNamespace Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Drop use of oojs-ui-widgets

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361762 ) Change subject: Drop use of oojs-ui-widgets .. Drop use of oojs-ui-widgets Using ButtonGroupWidget and ButtonWidget have no impact on

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Check parents when parsing thumbnails

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361721 ) Change subject: Check parents when parsing thumbnails .. Check parents when parsing thumbnails This revisits the earlier decision. It is

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[wmf/1.30.0-wmf.6]: Hygiene: SamplingRate -> BucketSize

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361716 ) Change subject: Hygiene: SamplingRate -> BucketSize .. Hygiene: SamplingRate -> BucketSize In order to avoid further confusion, clarify

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[wmf/1.30.0-wmf.6]: i13n: Don't sample by pageview

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361715 ) Change subject: i13n: Don't sample by pageview .. i13n: Don't sample by pageview Currently, the mw.eventLog.Schema class samples per

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove Cards from release tools

2017-06-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361703 ) Change subject: Remove Cards from release tools .. Remove Cards from release tools Bug: T167452 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Placeholder to avoid failing browser tests

2017-06-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361188 ) Change subject: Placeholder to avoid failing browser tests .. Placeholder to avoid failing browser tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: SkinStyles should be arrays

2017-06-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361187 ) Change subject: Hygiene: SkinStyles should be arrays .. Hygiene: SkinStyles should be arrays This shouldn't work even though it does.

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove code relating to pointer overlays in main menu

2017-06-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361083 ) Change subject: Hygiene: Remove code relating to pointer overlays in main menu .. Hygiene: Remove code relating to pointer overlays in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Address padding/button width in pointer overlay UI regression

2017-06-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361014 ) Change subject: Address padding/button width in pointer overlay UI regression .. Address padding/button width in pointer overlay UI

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Increase navigation menu size for mobile devices.

2017-06-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361013 ) Change subject: Increase navigation menu size for mobile devices. .. Increase navigation menu size for mobile devices. Up to tablet

[MediaWiki-commits] [Gerrit] integration/config[master]: Setup browser test job for Minerva skin

2017-06-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361012 ) Change subject: Setup browser test job for Minerva skin .. Setup browser test job for Minerva skin There are no browser tests in the

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Reflect current state of collapsing when enabling

2017-06-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360997 ) Change subject: Reflect current state of collapsing when enabling .. Reflect current state of collapsing when enabling Table of contents

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Test for T167852

2017-06-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360984 ) Change subject: Test for T167852 .. Test for T167852 Change-Id: I70427eff09e92f9e502f2a824f056da28971cf39 --- M

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Test case for T168329

2017-06-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360783 ) Change subject: Test case for T168329 .. Test case for T168329 Change-Id: Icd2c5d76479c6334ec0a6cfc46bc7bda06837fbd --- M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: skinStyles can now be registered via ResourceModuleSkinStyles

2017-06-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360696 ) Change subject: skinStyles can now be registered via ResourceModuleSkinStyles .. skinStyles can now be registered via

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Load mediawiki.action.edit.styles on mobile

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360569 ) Change subject: Load mediawiki.action.edit.styles on mobile .. Load mediawiki.action.edit.styles on mobile Hopefully uncontroversial.

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Exclude noviewer and metadata images from media viewer

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360566 ) Change subject: Exclude noviewer and metadata images from media viewer .. Exclude noviewer and metadata images from media viewer Bug:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: More uploads cleanup

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360567 ) Change subject: Hygiene: More uploads cleanup .. Hygiene: More uploads cleanup it amazes me how a feature removed over 2 years ago still

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Image overlay icons are rotated versions of arrow icon

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360426 ) Change subject: Image overlay icons are rotated versions of arrow icon .. Image overlay icons are rotated versions of arrow icon

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Footer arrow should use Icon rotate classes

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360427 ) Change subject: Hygiene: Footer arrow should use Icon rotate classes .. Hygiene: Footer arrow should use Icon rotate classes Follow up

[MediaWiki-commits] [Gerrit] mediawiki...Cards[master]: Empty for real

2017-06-20 Thread Jdlrobson (Code Review)
Jdlrobson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359048 ) Change subject: Empty for real .. Empty for real Bug: T167452 Change-Id: I481b7099d9b7b0af15840ba7d158842fcc2cfc99 --- D

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: DONOTMERGE folow up

2017-06-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359629 ) Change subject: DONOTMERGE folow up .. DONOTMERGE folow up Change-Id: Ibd57843c6cc9c765d23aea330ee073461864f033 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: DONOTMERGE: Testing auto rebaser

2017-06-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359573 ) Change subject: DONOTMERGE: Testing auto rebaser .. DONOTMERGE: Testing auto rebaser Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Reduce column-width to 25em for Minerva skin

2017-06-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359493 ) Change subject: Reduce column-width to 25em for Minerva skin .. Reduce column-width to 25em for Minerva skin Current Minerva skin is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Variable tweaks

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359363 ) Change subject: Hygiene: Variable tweaks .. Hygiene: Variable tweaks * redColorBase is available in core. So use it. * The table of

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Migrate various Minerva specific styles to skinStyles

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359360 ) Change subject: Hygiene: Migrate various Minerva specific styles to skinStyles .. Hygiene: Migrate various Minerva specific styles to

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: Apply column-width in Minerva skin

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359354 ) Change subject: Apply column-width in Minerva skin .. Apply column-width in Minerva skin Current Minerva skin is purposely restricted to

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: wgImagesDisabled has no impact on client side code for mobile

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359230 ) Change subject: wgImagesDisabled has no impact on client side code for mobile .. wgImagesDisabled has no impact on client side code for

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop the disable images feature

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359229 ) Change subject: Drop the disable images feature .. Drop the disable images feature This removes the option from the

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: MobileFrontend is removing the disabled images feature

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359226 ) Change subject: MobileFrontend is removing the disabled images feature .. MobileFrontend is removing the disabled images feature Thus do

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: Zero should use mediawiki.storage

2017-06-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359223 ) Change subject: Zero should use mediawiki.storage .. Zero should use mediawiki.storage mobile.settings is being removed. Bug: T144423

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Tests for diffs

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359060 ) Change subject: Tests for diffs .. Tests for diffs Bug: T154227 Change-Id: I5de74baac742c01a53b492c1aa904943114a8a55 --- M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Only use what you need

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359059 ) Change subject: Hygiene: Only use what you need .. Hygiene: Only use what you need Don't import files unless they are used. Note, CI

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Introduce mobile.variables

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359058 ) Change subject: Hygiene: Introduce mobile.variables .. Hygiene: Introduce mobile.variables This will allow us to determine which

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: TEST

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359053 ) Change subject: TEST .. TEST Change-Id: I04f13928ef1c5f97970c5e03e15bc1f82defcdb6 --- M src/specials/SpecialElectronPdf.php 1 file

[MediaWiki-commits] [Gerrit] mediawiki...Cards[master]: Empty for real

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359048 ) Change subject: Empty for real .. Empty for real Bug: T167452 Change-Id: I481b7099d9b7b0af15840ba7d158842fcc2cfc99 --- D

[MediaWiki-commits] [Gerrit] translatewiki[master]: Remove Cards from translatewiki

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359046 ) Change subject: Remove Cards from translatewiki .. Remove Cards from translatewiki Bug: T167452 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove Cards from the cluster

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359045 ) Change subject: Remove Cards from the cluster .. Remove Cards from the cluster Bug: T167452 Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove Cards from CI

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359044 ) Change subject: Remove Cards from CI .. Remove Cards from CI Bug: T167452 Change-Id: I0bedebf1ba5f7b7b0142ebe5b70356dd637e85ce --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove dead config variables

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359043 ) Change subject: Remove dead config variables .. Remove dead config variables MinervaPrintStyles feature flag was temporary. Bug:

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Remove CardsGateway (unused)

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359031 ) Change subject: Remove CardsGateway (unused) .. Remove CardsGateway (unused) Bug: T167647 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Add Minerva role

2017-06-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359014 ) Change subject: Add Minerva role .. Add Minerva role In preparation for MobileFrontend/Minerva split (see T71366) Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: MinervaHooks does not exist yet..

2017-06-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358408 ) Change subject: MinervaHooks does not exist yet.. .. MinervaHooks does not exist yet.. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: DONOTMERGE TEST :

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358147 ) Change subject: DONOTMERGE TEST : .. DONOTMERGE TEST : Change-Id: I9a96b45bc3f04d19f2ad378a49afe6fe34c06831 --- M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix UI regression - normalize heading font size

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358142 ) Change subject: Fix UI regression - normalize heading font size .. Fix UI regression - normalize heading font size Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Minerva is its own skin

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358141 ) Change subject: Minerva is its own skin .. Minerva is its own skin Before running the script: * Make sure MobileFrontend

[MediaWiki-commits] [Gerrit] integration/config[master]: Drop Selenium jobs

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358092 ) Change subject: Drop Selenium jobs .. Drop Selenium jobs These do not work on skins (see T167543) Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Add a skin specific selenium job

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358088 ) Change subject: Add a skin specific selenium job .. Add a skin specific selenium job Bug: T167543 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: CI should pass

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358083 ) Change subject: CI should pass .. CI should pass Change-Id: I84ae3ea14191f672cabcd52020e80b0a40a72ce1 --- A .rubocop.yml A Gemfile A

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Event sampling is based on user bucket

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358069 ) Change subject: Event sampling is based on user bucket .. Event sampling is based on user bucket Ensure the event sampling is consistent

[MediaWiki-commits] [Gerrit] integration/config[master]: Setup CI for MinervaNeue skin

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358067 ) Change subject: Setup CI for MinervaNeue skin .. Setup CI for MinervaNeue skin * Reflect MobileFrontend two way dependency ** Note in

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: Allow sampling by user session token

2017-06-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358046 ) Change subject: Allow sampling by user session token .. Allow sampling by user session token In A/B tests it is important to sample

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Refactor mobile diff code

2017-06-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357941 ) Change subject: Hygiene: Refactor mobile diff code .. Hygiene: Refactor mobile diff code Implement InlineDifferenceEngine::showDiffPage

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Ensure mDiffEngine is available inside showDiff

2017-06-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357918 ) Change subject: Ensure mDiffEngine is available inside showDiff .. Ensure mDiffEngine is available inside showDiff To be defensive

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Undeploy Cards

2017-06-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357858 ) Change subject: Undeploy Cards .. Undeploy Cards It has been on cluster for a week in an inert form. It is now surplus to requirements.

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update logo and dimensions for SR wordmark

2017-06-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357848 ) Change subject: Update logo and dimensions for SR wordmark .. Update logo and dimensions for SR wordmark Bug: T165896 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.4]: Add styles to Special:MobileMenu

2017-06-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357846 ) Change subject: Add styles to Special:MobileMenu .. Add styles to Special:MobileMenu Without this change the special page won't be

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: Fallback for badly configured mobile skins

2017-06-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357701 ) Change subject: POC: Fallback for badly configured mobile skins .. POC: Fallback for badly configured mobile skins Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SkinFallbackTemplate methods protected not private

2017-06-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357700 ) Change subject: SkinFallbackTemplate methods protected not private .. SkinFallbackTemplate methods protected not private Allow reuse in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Introduce mobile.less and minerva.less mixins/variables

2017-06-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357671 ) Change subject: Introduce mobile.less and minerva.less mixins/variables .. Introduce mobile.less and minerva.less mixins/variables

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[wmf/1.30.0-wmf.4]: Session id should not change on every page view

2017-06-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357667 ) Change subject: Session id should not change on every page view .. Session id should not change on every page view Bug: T167236

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Relaunch related pages A/B test to 98% of users

2017-06-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357666 ) Change subject: Relaunch related pages A/B test to 98% of users .. Relaunch related pages A/B test to 98% of users Bug: T167310

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Migrate Cards code to RelatedArticles

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357520 ) Change subject: Migrate Cards code to RelatedArticles .. Migrate Cards code to RelatedArticles * Move across all files * Rename

[MediaWiki-commits] [Gerrit] mediawiki...Cards[master]: Empty the Cards extension

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357519 ) Change subject: Empty the Cards extension .. Empty the Cards extension This should be merged prior to merging

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Session id should not change on every page view

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357444 ) Change subject: Session id should not change on every page view .. Session id should not change on every page view Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove unused icon- prefixed classes

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357439 ) Change subject: Hygiene: Remove unused icon- prefixed classes .. Hygiene: Remove unused icon- prefixed classes Not referenced anywhere

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update ContentNamespaces for Commons Wiki

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357426 ) Change subject: Update ContentNamespaces for Commons Wiki .. Update ContentNamespaces for Commons Wiki Bug: T167077 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable page previews on wikispecies

2017-06-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357425 ) Change subject: Disable page previews on wikispecies .. Disable page previews on wikispecies Bug: T166894 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't checkHash for reference links

2017-06-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357333 ) Change subject: Don't checkHash for reference links .. Don't checkHash for reference links If a link points to a hash fragment but is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Docs: Separate Minerva and MobileFrontend config options in ...

2017-06-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357316 ) Change subject: Docs: Separate Minerva and MobileFrontend config options in README .. Docs: Separate Minerva and MobileFrontend config

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Error the official mediawiki way

2017-06-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356878 ) Change subject: Error the official mediawiki way .. Error the official mediawiki way Don't confuse users by showing a non-styled 404

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Minerva should use mediawiki.hlist

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356775 ) Change subject: Minerva should use mediawiki.hlist .. Minerva should use mediawiki.hlist Override provided styles Bug: T42062

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow skins to control style of mediawiki.hlist

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356773 ) Change subject: Allow skins to control style of mediawiki.hlist .. Allow skins to control style of mediawiki.hlist Bug: T42062

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add styles specific for hlist inside warning/error/success b...

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356771 ) Change subject: Add styles specific for hlist inside warning/error/success boxes .. Add styles specific for hlist inside

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove abandoned swipe experiment

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356768 ) Change subject: Remove abandoned swipe experiment .. Remove abandoned swipe experiment Changes: * Remove mobile.swipe module * Remove

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove unused/discouraged mobile.context methods

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356769 ) Change subject: Hygiene: Remove unused/discouraged mobile.context methods .. Hygiene: Remove unused/discouraged mobile.context methods

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP: Remove all the deprecated config variables

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356770 ) Change subject: WIP: Remove all the deprecated config variables .. WIP: Remove all the deprecated config variables Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Feature flag expand all sections

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356763 ) Change subject: Feature flag expand all sections .. Feature flag expand all sections Bug: T153975 Change-Id:

[MediaWiki-commits] [Gerrit] translatewiki[master]: Enable translations for MinervaNeue

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356634 ) Change subject: Enable translations for MinervaNeue .. Enable translations for MinervaNeue Bug: T166743 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add migration script

2017-06-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356633 ) Change subject: Add migration script .. Add migration script Bug: T166744 Change-Id: I6466a72bc32916a7e3092b24e61961f8d422ed88 --- A

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: MFContentNamespace may not exist

2017-05-31 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356507 ) Change subject: Hygiene: MFContentNamespace may not exist .. Hygiene: MFContentNamespace may not exist Since the config variable is not

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove dead uploads code

2017-05-31 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356500 ) Change subject: Hygiene: Remove dead uploads code .. Hygiene: Remove dead uploads code Photo uploading was removed a long time ago and

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: When page properties are not available do not throw exceptions

2017-05-31 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356481 ) Change subject: When page properties are not available do not throw exceptions .. When page properties are not available do not throw

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use currentTarget rather than target in ref link click handler

2017-05-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356301 ) Change subject: Use currentTarget rather than target in ref link click handler .. Use currentTarget rather than target in ref link click

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Page images can come outside the lead for all projects excep...

2017-05-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356225 ) Change subject: Page images can come outside the lead for all projects except Wikipedia .. Page images can come outside the lead for all

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Docs: Don't register methods as globals in documentation

2017-05-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355808 ) Change subject: Docs: Don't register methods as globals in documentation .. Docs: Don't register methods as globals in documentation

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Run doc generation on `npm test`

2017-05-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355807 ) Change subject: Run doc generation on `npm test` .. Run doc generation on `npm test` The benefit of this is if there are any problems

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: Switch from jsduck to jsdoc in MobileFrontend extension

2017-05-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355720 ) Change subject: POC: Switch from jsduck to jsdoc in MobileFrontend extension .. POC: Switch from jsduck to jsdoc in MobileFrontend

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Breaking change: Remove Sidebar code from RelatedArticles

2017-05-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355637 ) Change subject: Breaking change: Remove Sidebar code from RelatedArticles .. Breaking change: Remove Sidebar code from RelatedArticles

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Make number of RelatedArticles configurable

2017-05-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355636 ) Change subject: Make number of RelatedArticles configurable .. Make number of RelatedArticles configurable Wikivoyage pages have more

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Add browser test for editor default view of watchlist

2017-05-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355484 ) Change subject: Add browser test for editor default view of watchlist .. Add browser test for editor default view of watchlist Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikivoyage should allow page images outside the lead

2017-05-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355479 ) Change subject: Wikivoyage should allow page images outside the lead .. Wikivoyage should allow page images outside the lead Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Hygiene: Remove no longer supported config flags

2017-05-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355477 ) Change subject: Hygiene: Remove no longer supported config flags .. Hygiene: Remove no longer supported config flags

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable print styles in Minerva

2017-05-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355478 ) Change subject: Enable print styles in Minerva .. Enable print styles in Minerva Bug: T163287 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: Use geosearch for nearby results

2017-05-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354943 ) Change subject: POC: Use geosearch for nearby results .. POC: Use geosearch for nearby results This demonstrates how Nearby results

[MediaWiki-commits] [Gerrit] integration/config[master]: Make mwext-MobileFrontend-npm-run-lint-modules job stable/no...

2017-05-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354911 ) Change subject: Make mwext-MobileFrontend-npm-run-lint-modules job stable/non-voting .. Make mwext-MobileFrontend-npm-run-lint-modules

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: MFEnableManifest should add manifest to all mobile skins

2017-05-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354716 ) Change subject: MFEnableManifest should add manifest to all mobile skins .. MFEnableManifest should add manifest to all mobile skins

<    1   2   3   4   5   6   7   8   9   10   >