[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.21.4

2017-05-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354057 ) Change subject: Tag v0.21.4 .. Tag v0.21.4 Change-Id: I7919a7e30539af968cf904d6aefc453f066fcfcb --- M History.md M package.json 2 files

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Upgrade eslint-config-wikimedia from 0.3.0 to 0.4.0 a...

2017-05-16 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354008 ) Change subject: build: Upgrade eslint-config-wikimedia from 0.3.0 to 0.4.0 and make pass .. build: Upgrade eslint-config-wikimedia from

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (45aa796b3)

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353899 ) Change subject: Update VE core submodule to master (45aa796b3) .. Update VE core submodule to master (45aa796b3) New changes: e7e9e0ba3

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.30.0-wmf.1]: Always prefer wikitext for action=edit on non-SET wikis

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353863 ) Change subject: Always prefer wikitext for action=edit on non-SET wikis .. Always prefer wikitext for action=edit on non-SET wikis Ideal

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.30.0-wmf.1]: Fix action=edit links for NWE

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353861 ) Change subject: Fix action=edit links for NWE .. Fix action=edit links for NWE We added support loading NWE from action=edit in I35208cc

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Revert "Synchronise VE availability checks in frontend and b...

2017-05-15 Thread Jforrester (Code Review)
Hello Esanders, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/353850 to review the following change. Change subject: Revert "Synchronise VE availability checks in frontend and backend" ..

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Enable edit tab setup on appropriate Special pages

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353849 ) Change subject: Enable edit tab setup on appropriate Special pages .. Enable edit tab setup on appropriate Special pages Using the forth

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Introduce wgRelevantPageIsProbablyEditable

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353848 ) Change subject: Introduce wgRelevantPageIsProbablyEditable .. Introduce wgRelevantPageIsProbablyEditable Change-Id: I6c6ca1cfd93e7be9179

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (8e29310db)

2017-05-15 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353838 ) Change subject: Update VE core submodule to master (8e29310db) .. Update VE core submodule to master (8e29310db) New changes: e7e9e0ba3

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable OOUI for EditPage on MW.org

2017-05-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353480 ) Change subject: Enable OOUI for EditPage on MW.org .. Enable OOUI for EditPage on MW.org Change-Id: I688e9355c1eab2220fc724cbcad592b6e83

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.1]: mw.Upload.Dialog: Define .static.name

2017-05-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353475 ) Change subject: mw.Upload.Dialog: Define .static.name .. mw.Upload.Dialog: Define .static.name Bug: T164999 Change-Id: I0e5d11bdeac1ea60

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (347765f82)

2017-05-11 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353367 ) Change subject: Update VE core submodule to master (347765f82) .. Update VE core submodule to master (347765f82) New changes: 8155f98fd

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[wmf/1.29.0-wmf.21]: i18n: Tell users they can use ISBNs

2017-05-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353177 ) Change subject: i18n: Tell users they can use ISBNs .. i18n: Tell users they can use ISBNs Bug: T145462 Change-Id: I9c73dfbfc3a99b26d0f5

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[wmf/1.30.0-wmf.1]: i18n: Tell users they can use ISBNs

2017-05-10 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353176 ) Change subject: i18n: Tell users they can use ISBNs .. i18n: Tell users they can use ISBNs Bug: T145462 Change-Id: I9c73dfbfc3a99b26d0f5

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up fa2efb9e5 part II: Don't try to call a private fun...

2017-05-08 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352727 ) Change subject: Follow-up fa2efb9e5 part II: Don't try to call a private function .. Follow-up fa2efb9e5 part II: Don't try to call a pr

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (fbeb0db2c)

2017-05-08 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352713 ) Change subject: Update VE core submodule to master (fbeb0db2c) .. Update VE core submodule to master (fbeb0db2c) New changes: d61440346

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Add role for 'CodeMirror' extension

2017-05-08 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352650 ) Change subject: Add role for 'CodeMirror' extension .. Add role for 'CodeMirror' extension Change-Id: Id2141297d7226a345132419d743d63132

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Special:Preferences: Use OOjs UI

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352071 ) Change subject: [WIP] Special:Preferences: Use OOjs UI .. [WIP] Special:Preferences: Use OOjs UI This amazingly sort-of works. Things t

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComm...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352059 ) Change subject: build: Enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment .. build: Enable MediaWiki.WhiteSpace.Spa

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Enable MediaWiki.Commenting.FunctionComment.MissingPa...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352061 ) Change subject: build: Enable MediaWiki.Commenting.FunctionComment.MissingParamTag .. build: Enable MediaWiki.Commenting.FunctionComment

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Enable MediaWiki.NamingConventions.LowerCamelFunction...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352058 ) Change subject: build: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName .. build: Enable MediaWiki.NamingConventi

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Enable MediaWiki.Commenting.FunctionComment.ParamName...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352056 ) Change subject: build: Enable MediaWiki.Commenting.FunctionComment.ParamNameNoMatch .. build: Enable MediaWiki.Commenting.FunctionCommen

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Enable MediaWiki.Commenting.FunctionComment.MissingPa...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352062 ) Change subject: build: Enable MediaWiki.Commenting.FunctionComment.MissingParamComment .. build: Enable MediaWiki.Commenting.FunctionCom

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Bump mediawiki-codesniffer to 0.8.0 and make pass

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352055 ) Change subject: build: Bump mediawiki-codesniffer to 0.8.0 and make pass .. build: Bump mediawiki-codesniffer to 0.8.0 and make pass Cha

[MediaWiki-commits] [Gerrit] mediawiki...Pickle[master]: Move ignore for phpcs to phpcs.xml

2017-05-04 Thread Jforrester (Code Review)
Jforrester has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350975 ) Change subject: Move ignore for phpcs to phpcs.xml .. Move ignore for phpcs to phpcs.xml This allows the phpcbf command to profi

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [FAILING TEST CASE] TableAction: Inserting a mixed th/td row...

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351918 ) Change subject: [FAILING TEST CASE] TableAction: Inserting a mixed th/td row should do so .. [FAILING TEST CASE] TableAction: Inserting

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.21]: Export publish-short message for mobile

2017-05-04 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351893 ) Change subject: Export publish-short message for mobile .. Export publish-short message for mobile Bug: T164472 Change-Id: I143bc119583d

[MediaWiki-commits] [Gerrit] oojs/ui[master]: icons: Provide 'clip', 'unClip', and 'pushPin' in moderation

2017-05-03 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351733 ) Change subject: icons: Provide 'clip', 'unClip', and 'pushPin' in moderation .. icons: Provide 'clip', 'unClip', and 'pushPin' in moderat

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: eslint: Simplify globals with module everywhere, ve only in ...

2017-05-03 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351690 ) Change subject: eslint: Simplify globals with module everywhere, ve only in VE code .. eslint: Simplify globals with module everywhere,

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] icons: Merge 'caret' into regular movem...

2017-05-03 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351660 ) Change subject: [DEPRECATING CHANGE] icons: Merge 'caret' into regular movement icons .. [DEPRECATING CHANGE] icons: Merge 'caret' into

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] icons: Remove 'caret' icons, deprecated in...

2017-05-03 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351661 ) Change subject: [BREAKING CHANGE] icons: Remove 'caret' icons, deprecated in v0.21.3 .. [BREAKING CHANGE] icons: Remove 'caret' icons, d

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.21]: Follow-up 57a06a6: Use the same attribute name on read and o...

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351527 ) Change subject: Follow-up 57a06a6: Use the same attribute name on read and on write .. Follow-up 57a06a6: Use the same attribute name on

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Move default user preference setting to appropriate hook

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351526 ) Change subject: Move default user preference setting to appropriate hook .. Move default user preference setting to appropriate hook Bug

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up 57a06a6: Use the same attribute name on read and o...

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351521 ) Change subject: Follow-up 57a06a6: Use the same attribute name on read and on write .. Follow-up 57a06a6: Use the same attribute name on

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ApiVisualEditor: Move RESTbase initiation from construct() t...

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351352 ) Change subject: ApiVisualEditor: Move RESTbase initiation from construct() to execute() .. ApiVisualEditor: Move RESTbase initiation fro

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.21]: Follow-up I488fd7e74: Adjust saveFail calls for new function...

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351329 ) Change subject: Follow-up I488fd7e74: Adjust saveFail calls for new function signature .. Follow-up I488fd7e74: Adjust saveFail calls fo

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up 91a75e3fe: Respect the new signature for saveFail(...

2017-05-02 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351324 ) Change subject: Follow-up 91a75e3fe: Respect the new signature for saveFail() everywhere .. Follow-up 91a75e3fe: Respect the new signatu

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: lib: Update README files for OOjs and OOjs UI

2017-05-01 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351213 ) Change subject: lib: Update README files for OOjs and OOjs UI .. lib: Update README files for OOjs and OOjs UI Change-Id: I1413136830ce6

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: extension.json: Drop no-op dependency on deprecated es5-shim...

2017-05-01 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351199 ) Change subject: extension.json: Drop no-op dependency on deprecated es5-shim module .. extension.json: Drop no-op dependency on deprecat

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Resources.php: Drop no-op dependency on deprecated es5-shim ...

2017-05-01 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351198 ) Change subject: Resources.php: Drop no-op dependency on deprecated es5-shim module .. Resources.php: Drop no-op dependency on deprecated

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: extension.json: Drop no-op dependency on deprecated es5-shim...

2017-05-01 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351197 ) Change subject: extension.json: Drop no-op dependency on deprecated es5-shim module .. extension.json: Drop no-op dependency on deprecat

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: extension.json: Drop no-op dependency on deprecated es5-shim...

2017-05-01 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351196 ) Change subject: extension.json: Drop no-op dependency on deprecated es5-shim module .. extension.json: Drop no-op dependency on deprecat

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [WIP] Allow document subscribers to be informed to changes t...

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350965 ) Change subject: [WIP] Allow document subscribers to be informed to changes to nodes .. [WIP] Allow document subscribers to be informed t

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Transaction#isNoOp: Simple code is simple

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350964 ) Change subject: Transaction#isNoOp: Simple code is simple .. Transaction#isNoOp: Simple code is simple Change-Id: I61664bc58793262d1f1f5

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: build: Drop second eslint-config-wikimedia reference

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350913 ) Change subject: build: Drop second eslint-config-wikimedia reference .. build: Drop second eslint-config-wikimedia reference Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFrom...

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350890 ) Change subject: ve.dm.ElementLinearData.test: Cover getAnnotationIndexesFromOffset .. ve.dm.ElementLinearData.test: Cover getAnnotationI

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [WIP] ElementLinearData: Don't use IVStores, rely on annotat...

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350891 ) Change subject: [WIP] ElementLinearData: Don't use IVStores, rely on annotation hashes .. [WIP] ElementLinearData: Don't use IVStores, r

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (a5deb2b73)

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350859 ) Change subject: Update VE core submodule to master (a5deb2b73) .. Update VE core submodule to master (a5deb2b73) New changes: c61044a89

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Re-sync tests from VE-core into ext.visualEditor.test

2017-04-28 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350860 ) Change subject: Re-sync tests from VE-core into ext.visualEditor.test .. Re-sync tests from VE-core into ext.visualEditor.test Whoops. O

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: WIP: Migrate in all the MwEmbedSupport extension

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350758 ) Change subject: WIP: Migrate in all the MwEmbedSupport extension .. WIP: Migrate in all the MwEmbedSupport extension Bug: T164037 Change

[MediaWiki-commits] [Gerrit] mediawiki...MwEmbedSupport[master]: Hollow-out repository

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350755 ) Change subject: Hollow-out repository .. Hollow-out repository Code being moved to its consumer, TimedMediaHandler. Bug: T164037 Change

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move RELEASE-NOTES-1.29 to HISTORY

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350745 ) Change subject: Move RELEASE-NOTES-1.29 to HISTORY .. Move RELEASE-NOTES-1.29 to HISTORY Changes to master that are going to be immediat

[MediaWiki-commits] [Gerrit] mediawiki/vendor[REL1_29]: Revert "Update OOjs UI to v0.21.2"

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350661 ) Change subject: Revert "Update OOjs UI to v0.21.2" .. Revert "Update OOjs UI to v0.21.2" This is for MediaWiki 1.30 onwards; REL1_29 nee

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up 14cffee7: Correct deprecation version comment

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350650 ) Change subject: Follow-up 14cffee7: Correct deprecation version comment .. Follow-up 14cffee7: Correct deprecation version comment We me

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: mediawiki.toolbar: Emit deprecation warnings

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350644 ) Change subject: mediawiki.toolbar: Emit deprecation warnings .. mediawiki.toolbar: Emit deprecation warnings Callers to the EditPageBefo

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Cover tags

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350579 ) Change subject: tests: Cover tags .. tests: Cover tags Change-Id: Ie282bf3c4855b63789d52005e885708b8f37287c --- M tests/dm/ve.dm.examp

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Cover LinkAnnotation#getFragment()

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350578 ) Change subject: tests: Cover LinkAnnotation#getFragment() .. tests: Cover LinkAnnotation#getFragment() Change-Id: Ie66fa4ce8c57afeba04e8

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Test rich annotations' describeChange()

2017-04-27 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350580 ) Change subject: tests: Test rich annotations' describeChange() .. tests: Test rich annotations' describeChange() Change-Id: I1d362819ad2

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Decom legacy citoid service hostname

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350505 ) Change subject: Decom legacy citoid service hostname .. Decom legacy citoid service hostname Announced on 8 March with a 1 May deadline.

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Hooks#EditPageBeforeEditToolbar: Return false so that other ...

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350498 ) Change subject: Hooks#EditPageBeforeEditToolbar: Return false so that other toolbars aren't loaded .. Hooks#EditPageBeforeEditToolbar: R

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Prepare for 1.30 branch

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350463 ) Change subject: Prepare for 1.30 branch .. Prepare for 1.30 branch Change-Id: If9842b19ec995d03f93f96bfad4d61ca96c37f3c --- A RELEASE-NO

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (15d5124ee)

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350457 ) Change subject: Update VE core submodule to master (15d5124ee) .. Update VE core submodule to master (15d5124ee) New changes: 15d5124ee

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: TransactionBuilder.test: Don't use `static` as the variable ...

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350454 ) Change subject: TransactionBuilder.test: Don't use `static` as the variable name .. TransactionBuilder.test: Don't use `static` as the va

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (5936b9521)

2017-04-26 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350450 ) Change subject: Update VE core submodule to master (5936b9521) .. Update VE core submodule to master (5936b9521) New changes: f1d1ddda4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: maintenance/resources/update-oojs-ui: Copy across map files ...

2017-04-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350352 ) Change subject: maintenance/resources/update-oojs-ui: Copy across map files for debug mode .. maintenance/resources/update-oojs-ui: Copy

[MediaWiki-commits] [Gerrit] mediawiki...BounceHandler[master]: Explicitly specify 'section' => 'alert' for unsubscribe noti...

2017-04-25 Thread Jforrester (Code Review)
Jforrester has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/293770 ) Change subject: Explicitly specify 'section' => 'alert' for unsubscribe notification .. Explicitly specify 'section' => 'alert'

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Bump grunt-stylelint, bring in stylelint explicitly

2017-04-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350324 ) Change subject: build: Bump grunt-stylelint, bring in stylelint explicitly .. build: Bump grunt-stylelint, bring in stylelint explicitly

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Un-blacklist the lintid parameter

2017-04-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350313 ) Change subject: Un-blacklist the lintid parameter .. Un-blacklist the lintid parameter Depends-On: I59a7e0a3e8be32e4689cbf41c4904970902c

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Revert "Don't deprecate immediately, let Wikimedia extension...

2017-04-24 Thread Jforrester (Code Review)
Hello Bartosz DziewoƄski, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/350082 to review the following change. Change subject: Revert "Don't deprecate immediately, let Wikimedia extensions/services convert first" ..

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Don't deprecate immediately, let Wikimedia extensions/servic...

2017-04-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350068 ) Change subject: Don't deprecate immediately, let Wikimedia extensions/services convert first .. Don't deprecate immediately, let Wikimed

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: WikitextSerializer: Handle new TemplateData API option

2017-04-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350065 ) Change subject: WikitextSerializer: Handle new TemplateData API option .. WikitextSerializer: Handle new TemplateData API option Change-

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (00f0a0bf8)

2017-04-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350003 ) Change subject: Update VE core submodule to master (00f0a0bf8) .. Update VE core submodule to master (00f0a0bf8) New changes: 04c3aa3aa

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (7b494035e)

2017-04-24 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350001 ) Change subject: Update VE core submodule to master (7b494035e) .. Update VE core submodule to master (7b494035e) New changes: 705f9df8d

[MediaWiki-commits] [Gerrit] mediawiki...BounceHandler[master]: build: add grunt-contrib-jshint

2017-04-21 Thread Jforrester (Code Review)
Jforrester has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/349466 ) Change subject: build: add grunt-contrib-jshint .. build: add grunt-contrib-jshint See T119973 Change-Id: Ia69fbe9bae4c76b5ba5c

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTemplatePage: Show a different message if the template doe...

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349370 ) Change subject: MWTemplatePage: Show a different message if the template doesn't exist .. MWTemplatePage: Show a different message if th

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTransclusionModel: Update for change in TemplateData

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349369 ) Change subject: MWTransclusionModel: Update for change in TemplateData .. MWTransclusionModel: Update for change in TemplateData Change-

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: API: Identify missing and no-TemplateData pages in the response

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349368 ) Change subject: API: Identify missing and no-TemplateData pages in the response .. API: Identify missing and no-TemplateData pages in the

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: build: Explicitly depend on eslint-config-wikimedia, don't j...

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349363 ) Change subject: build: Explicitly depend on eslint-config-wikimedia, don't just hope it's there .. build: Explicitly depend on eslint-co

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: build: Bump grunt-banana-checker devDependency to latest

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349362 ) Change subject: build: Bump grunt-banana-checker devDependency to latest .. build: Bump grunt-banana-checker devDependency to latest Cha

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: build: Bump various devDependencies to latest

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349359 ) Change subject: build: Bump various devDependencies to latest .. build: Bump various devDependencies to latest grunt 0

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: build: Replace jshint and jscs with eslint

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349360 ) Change subject: build: Replace jshint and jscs with eslint .. build: Replace jshint and jscs with eslint Bug: T118941 Change-Id: Ibb5464

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: build: Bump various devDependencies to latest

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349356 ) Change subject: build: Bump various devDependencies to latest .. build: Bump various devDependencies to latest grunt-banana-checker 0.

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: build: Replace jshint and jscs with eslint

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349355 ) Change subject: build: Replace jshint and jscs with eslint .. build: Replace jshint and jscs with eslint Bug: T118941 Change-Id: I4b73fb

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTarget: Load anew if RESTbase has forgotten it was de...

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349337 ) Change subject: ArticleTarget: Load anew if RESTbase has forgotten it was deleted .. ArticleTarget: Load anew if RESTbase has forgotten

[MediaWiki-commits] [Gerrit] oojs/ui[master]: tests: Drop unnecessary hints to qunit about the number of t...

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349279 ) Change subject: tests: Drop unnecessary hints to qunit about the number of tests .. tests: Drop unnecessary hints to qunit about the numb

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable mobile non-JavaScript editing on all MobileFrontend w...

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349274 ) Change subject: Enable mobile non-JavaScript editing on all MobileFrontend wikis .. Enable mobile non-JavaScript editing on all MobileFro

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: doc: Bump copyright year notice, 'team' name

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349244 ) Change subject: doc: Bump copyright year notice, 'team' name .. doc: Bump copyright year notice, 'team' name Change-Id: Ia090c417a1aa716

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: VisualEditor: Move Cite-specific wikitext handler tests here

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349245 ) Change subject: VisualEditor: Move Cite-specific wikitext handler tests here .. VisualEditor: Move Cite-specific wikitext handler tests h

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWWikitextStringTransferHandler: Move Cite ones there

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349243 ) Change subject: MWWikitextStringTransferHandler: Move Cite ones there .. MWWikitextStringTransferHandler: Move Cite ones there Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (bfb35aaef)

2017-04-20 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349242 ) Change subject: Update VE core submodule to master (bfb35aaef) .. Update VE core submodule to master (bfb35aaef) New changes: 57f8064b6

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Show a different label for the current mode in the editor mo...

2017-04-19 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348984 ) Change subject: Show a different label for the current mode in the editor mode selector .. Show a different label for the current mode i

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: HACK: Temporarily patch OOjs UI locally to work around upstr...

2017-04-19 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348978 ) Change subject: HACK: Temporarily patch OOjs UI locally to work around upstream problem .. HACK: Temporarily patch OOjs UI locally to wo

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Follow-up d22d23311: Don't reference OO.ui.ToolGroup blindly

2017-04-19 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348977 ) Change subject: Follow-up d22d23311: Don't reference OO.ui.ToolGroup blindly .. Follow-up d22d23311: Don't reference OO.ui.ToolGroup blin

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Fix the easy rule violations with `composer fix`

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348899 ) Change subject: phpcs: Fix the easy rule violations with `composer fix` .. phpcs: Fix the easy rule violations with `composer fix` * Gen

[MediaWiki-commits] [Gerrit] integration/config[master]: [FlaggedRevs] Add composer-test template

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348896 ) Change subject: [FlaggedRevs] Add composer-test template .. [FlaggedRevs] Add composer-test template Bug: T163301 Change-Id: I9d39660344

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Disallow long array syntax

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348895 ) Change subject: phpcs: Disallow long array syntax .. phpcs: Disallow long array syntax Change-Id: I616813063477425fa8ef2afb1ef90af5e4cf6

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: build: Use composer to lint PHP and assert code style

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348894 ) Change subject: build: Use composer to lint PHP and assert code style .. build: Use composer to lint PHP and assert code style Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Revert "Temporary workaround for OOjs UI missing border bug"

2017-04-18 Thread Jforrester (Code Review)
Hello Addshore, Tobias Gritschacher, WMDE-Fisch, jenkins-bot, Andrew-WMDE, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/348891 to review the following change. Change subject: Revert "Temporary workaround for OOjs UI missing border bug"

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Use source maps in coverage report

2017-04-18 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348890 ) Change subject: build: Use source maps in coverage report .. build: Use source maps in coverage report Shamelessly stolen from I0939c217

[MediaWiki-commits] [Gerrit] analytics/limn-ee-data[master]: Add frwiki, hewiki, etwiki to list of RCFilters wikis

2017-04-18 Thread Jforrester (Code Review)
Jforrester has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/348028 ) Change subject: Add frwiki, hewiki, etwiki to list of RCFilters wikis .. Add frwiki, hewiki, etwiki to list of RCFilters wikis C

<    1   2   3   4   5   6   7   8   9   10   >