[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Implement suggested changes code-review

2017-06-27 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361635 ) Change subject: Implement suggested changes code-review .. Implement suggested changes code-review 1) changed some syntax that only works

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Merge branch 'formprinter-cleanup' into append-autoedit

2017-06-23 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361042 ) Change subject: Merge branch 'formprinter-cleanup' into append-autoedit .. Merge branch 'formprinter-cleanup' into append-autoedit Change

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Merge branch 'formprinter-cleanup' into append-autoedit

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360834 ) Change subject: Merge branch 'formprinter-cleanup' into append-autoedit .. Merge branch 'formprinter-cleanup' into append-autoedit Change

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Few minor fixes that caused major issues

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360829 ) Change subject: Few minor fixes that caused major issues .. Few minor fixes that caused major issues Fixed the definition of globals and

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Merge branch 'formprinter-cleanup' into append-autoedit

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360830 ) Change subject: Merge branch 'formprinter-cleanup' into append-autoedit .. Merge branch 'formprinter-cleanup' into append-autoedit Change

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Working += and -= functionality.

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360811 ) Change subject: Working += and -= functionality. .. Working += and -= functionality. This allows you to add and remove items from a comma

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Working += and -= functionality.

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360805 ) Change subject: Working += and -= functionality. .. Working += and -= functionality. This allows you to add and remove items from a comma

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Working += and -= functionality.

2017-06-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360803 ) Change subject: Working += and -= functionality. .. Working += and -= functionality. This allows you to add and remove items from a comma

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Step four: Move the entire definition-processing function out

2017-06-20 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360341 ) Change subject: Step four: Move the entire definition-processing function out .. Step four: Move the entire definition-processing function

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fixed missing variable; removed some comments

2017-06-20 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360340 ) Change subject: Fixed missing variable; removed some comments .. Fixed missing variable; removed some comments Removed now-unnecessary co

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Step three: split out several processing functions

2017-06-20 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360339 ) Change subject: Step three: split out several processing functions .. Step three: split out several processing functions split out all ta

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Step one: Split up some variables to support OOP

2017-06-20 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360337 ) Change subject: Step one: Split up some variables to support OOP .. Step one: Split up some variables to support OOP Made as many variabl

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Step two: Reduce comments to fewer lines

2017-06-20 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360338 ) Change subject: Step two: Reduce comments to fewer lines .. Step two: Reduce comments to fewer lines I'm all for limiting code to a certa

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fix a few of the same error

2017-06-13 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358574 ) Change subject: Fix a few of the same error .. Fix a few of the same error Apologies for splitting up these commits; I noticed these erro

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Add more Object-oriented class properties/variables

2017-06-13 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358572 ) Change subject: Add more Object-oriented class properties/variables .. Add more Object-oriented class properties/variables Moved a couple

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Major revamp of core function formHTML

2017-06-13 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358555 ) Change subject: Major revamp of core function formHTML .. Major revamp of core function formHTML Mainly split up this gigantic function (

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Fix problem with the prop not already existing

2017-05-16 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353961 ) Change subject: Fix problem with the prop not already existing .. Fix problem with the prop not already existing When adding a new proper

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Add code I accidentally removed

2017-05-09 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352838 ) Change subject: Add code I accidentally removed .. Add code I accidentally removed Change-Id: I2529dd9f37b365133727d1bf6bf352ecaf1887fd -

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Add AutoEditToggle parser function

2017-05-09 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352771 ) Change subject: Add AutoEditToggle parser function .. Add AutoEditToggle parser function Make it possible to toggle a value using AutoEdi

[MediaWiki-commits] [Gerrit] Add feature: parameter indexing; expand README - change (mediawiki...Tabs)

2015-01-12 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184426 Change subject: Add feature: parameter indexing; expand README .. Add feature: parameter indexing; expand README - Added a feature that mak

[MediaWiki-commits] [Gerrit] Fix scrolling in Chrome, add scroll documentation - change (mediawiki...Tabs)

2015-01-10 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184202 Change subject: Fix scrolling in Chrome, add scroll documentation .. Fix scrolling in Chrome, add scroll documentation Scrolling/hotlinking

[MediaWiki-commits] [Gerrit] Add nested="" attribute to tab tag - change (mediawiki...Tabs)

2015-01-10 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184188 Change subject: Add nested="" attribute to tab tag .. Add nested="" attribute to tab tag now it is possible to make nested toggle boxes or

[MediaWiki-commits] [Gerrit] Fix jslint errors. - change (mediawiki...Tabs)

2015-01-10 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184138 Change subject: Fix jslint errors. .. Fix jslint errors. On the previous commit, jslint didn't mention these errors until jenkins-bot decid

[MediaWiki-commits] [Gerrit] Add feature: s that show up in every tab - change (mediawiki...Tabs)

2015-01-10 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184126 Change subject: Add feature: s that show up in every tab .. Add feature: s that show up in every tab Using index="*" for a tag will now ma

[MediaWiki-commits] [Gerrit] Change documentation in README file - change (mediawiki...Tabs)

2015-01-09 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184086 Change subject: Change documentation in README file .. Change documentation in README file Change-Id: I95ebe567d803ace0308023d5ad49ba377969

[MediaWiki-commits] [Gerrit] Clean up code, with slight functionality change - change (mediawiki...Tabs)

2015-01-09 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/184081 Change subject: Clean up code, with slight functionality change .. Clean up code, with slight functionality change - Made the code a bit mo

[MediaWiki-commits] [Gerrit] Problem fix: url() no longer allowed in style attr - change (mediawiki...Tabs)

2015-01-09 Thread Joeytje50 (Code Review)
Joeytje50 has submitted this change and it was merged. Change subject: Problem fix: url() no longer allowed in style attr .. Problem fix: url() no longer allowed in style attr - Style attributes allowed any CSS input; now any

[MediaWiki-commits] [Gerrit] Patch problem that allows loading images from any url; updat... - change (mediawiki...Tabs)

2015-01-09 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/183978 Change subject: Patch problem that allows loading images from any url; update README Style attributes allowed any CSS input; now any url() is filtered out. Added extra info to $wgExtennsion credits Added/fix

[MediaWiki-commits] [Gerrit] Cleanup: fix i18n files, clean up whitespace. Removed traili... - change (mediawiki...Tabs)

2014-08-01 Thread Joeytje50 (Code Review)
Joeytje50 has submitted this change and it was merged. Change subject: Cleanup: fix i18n files, clean up whitespace. Removed trailing whitespace from several files, corrected mentioning of a tag in i18n files which isn't used by the extension anymore, which was removed even before version 1.0.

[MediaWiki-commits] [Gerrit] Cleanup: fix i18n files, clean up whitespace. Removed traili... - change (mediawiki...Tabs)

2014-08-01 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/151239 Change subject: Cleanup: fix i18n files, clean up whitespace. Removed trailing whitespace from several files, corrected mentioning of a tag in i18n files which isn't used by the extension anymore, which was

[MediaWiki-commits] [Gerrit] Version 1.1: Add Android Browser support - change (mediawiki...Tabs)

2014-08-01 Thread Joeytje50 (Code Review)
Joeytje50 has submitted this change and it was merged. Change subject: Version 1.1: Add Android Browser support .. Version 1.1: Add Android Browser support Now includes a togglebox fallback for Android Browser (and Dolphin Brow

[MediaWiki-commits] [Gerrit] Removed trailing whitespace. - change (mediawiki...Tabs)

2014-07-11 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/145563 Change subject: Removed trailing whitespace. .. Removed trailing whitespace. Change-Id: I026b5ea57c633ed5505ac49c07673354a38022b3 --- A .gi

[MediaWiki-commits] [Gerrit] Minor changes - change (mediawiki...Tabs)

2014-01-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/109010 Change subject: Minor changes .. Minor changes Change-Id: Ib080bba6af94edcd80362a8113b15cfa54fcdfdc --- M Tabs.body.php M Tabs.i18n.php M

[MediaWiki-commits] [Gerrit] Version 1.0 - change (mediawiki...Tabs)

2014-01-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/109000 Change subject: Version 1.0 .. Version 1.0 Change-Id: Ib835878b4e4b7f04bfc22e4606e35519b7b4c9ed --- M Tabs.body.php M Tabs.i18n.php M Tabs

[MediaWiki-commits] [Gerrit] Version 1.0 - change (mediawiki...Tabs)

2014-01-22 Thread Joeytje50 (Code Review)
Joeytje50 has uploaded a new change for review. https://gerrit.wikimedia.org/r/108993 Change subject: Version 1.0 .. Version 1.0 Change-Id: Id6a61ea60225dddb382671242df2b4c122b5603c --- D README.md 1 file changed, 0 insertio