[MediaWiki-commits] [Gerrit] Set a default value for $wgBookManagerv2JsonEditor - change (mediawiki...BookManagerv2)

2013-12-05 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Set a default value for $wgBookManagerv2JsonEditor .. Set a default value for $wgBookManagerv2JsonEditor Change-Id: I8aa2c0196b4521ad68f630be6fa2d68a48e256

[MediaWiki-commits] [Gerrit] Notice: Undefined variable: jsonPageTitle in BookManagerv2.h... - change (mediawiki...BookManagerv2)

2013-12-05 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Notice: Undefined variable: jsonPageTitle in BookManagerv2.hooks.php on line 527 .. Notice: Undefined variable: jsonPageTitle in BookManagerv2.hooks.php on

[MediaWiki-commits] [Gerrit] WebRequest::getCheck is never null - change (mediawiki...BookManagerv2)

2013-12-05 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: WebRequest::getCheck is never null .. WebRequest::getCheck is never null It returns a boolean, which is never null. Change-Id: Ife1579b6778bdf6a1b045b4646

[MediaWiki-commits] [Gerrit] Update to new version of schema - change (mediawiki...BookManagerv2)

2013-09-18 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Update to new version of schema .. Update to new version of schema This uses "*-field" in the i18n fields. Change-Id: I6a3980f83740a2f80d5ea56be7ceef4db0a

[MediaWiki-commits] [Gerrit] Update to new version of schema - change (mediawiki...BookManagerv2)

2013-09-18 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/84921 Change subject: Update to new version of schema .. Update to new version of schema This uses "*-field" in the i18n fields. Change-Id: I6a

[MediaWiki-commits] [Gerrit] Bug 52331: Prevent navbars from appearing in diff view. - change (mediawiki...BookManagerv2)

2013-09-15 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/84293 Change subject: Bug 52331: Prevent navbars from appearing in diff view. .. Bug 52331: Prevent navbars from appearing in diff view. This ch

[MediaWiki-commits] [Gerrit] Fix some bugs with the indentation patch. - change (mediawiki...BookManagerv2)

2013-09-12 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/84093 Change subject: Fix some bugs with the indentation patch. .. Fix some bugs with the indentation patch. i18n fields were having 'field' app

[MediaWiki-commits] [Gerrit] Give grep a chance to find the usages - change (mediawiki...BookManagerv2)

2013-08-29 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Give grep a chance to find the usages .. Give grep a chance to find the usages Change-Id: Id07abac133e9216bea2b259ef5b76f96fd28b9d7 --- M BookManagerv2.hoo

[MediaWiki-commits] [Gerrit] Bug 50959: Pull the JSON schema from the Meta page. - change (mediawiki...BookManagerv2)

2013-08-28 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/81560 Change subject: Bug 50959: Pull the JSON schema from the Meta page. .. Bug 50959: Pull the JSON schema from the Meta page. This allows the

[MediaWiki-commits] [Gerrit] Bug 53431: Adjust so clicking "remove" on new sections remov... - change (mediawiki...BookManagerv2)

2013-08-27 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/81411 Change subject: Bug 53431: Adjust so clicking "remove" on new sections removes them. .. Bug 53431: Adjust so clicking "remove" on new sect

[MediaWiki-commits] [Gerrit] Bug 52350: Allow sections to be indented and outdented - change (mediawiki...BookManagerv2)

2013-08-27 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/81379 Change subject: Bug 52350: Allow sections to be indented and outdented .. Bug 52350: Allow sections to be indented and outdented This upda

[MediaWiki-commits] [Gerrit] Fix the message "bookmanagerv2-prev-title" - change (mediawiki...BookManagerv2)

2013-08-26 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Fix the message "bookmanagerv2-prev-title" .. Fix the message "bookmanagerv2-prev-title" * "bookmanagerv2-prev-title" takes one parameter Change-Id: Ic43c

[MediaWiki-commits] [Gerrit] Add documentation comments to the JSON editor - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Add documentation comments to the JSON editor .. Add documentation comments to the JSON editor Change-Id: I49a3bb1179fcbf1951d907cb4602784b312e8612 --- M J

[MediaWiki-commits] [Gerrit] Add documentation comments to the JSON editor - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80694 Change subject: Add documentation comments to the JSON editor .. Add documentation comments to the JSON editor Change-Id: I49a3bb1179fcbf1

[MediaWiki-commits] [Gerrit] Bug 53290: Add descriptive titles for edit/rename buttons in... - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80693 Change subject: Bug 53290: Add descriptive titles for edit/rename buttons in editor. .. Bug 53290: Add descriptive titles for edit/rename

[MediaWiki-commits] [Gerrit] Bug 53289: Use more descriptive titles for prev/next links i... - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80692 Change subject: Bug 53289: Use more descriptive titles for prev/next links in navbar. .. Bug 53289: Use more descriptive titles for prev/n

[MediaWiki-commits] [Gerrit] Bug 53288: Use more descriptive link titles for read/edit in... - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80691 Change subject: Bug 53288: Use more descriptive link titles for read/edit in dropdowns .. Bug 53288: Use more descriptive link titles for

[MediaWiki-commits] [Gerrit] Bug 53105: Make the extension function independently from th... - change (mediawiki...BookManagerv2)

2013-08-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80677 Change subject: Bug 53105: Make the extension function independently from the schema. .. Bug 53105: Make the extension function independen

[MediaWiki-commits] [Gerrit] Escape wfMessages in links - change (mediawiki...BookManagerv2)

2013-08-22 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Escape wfMessages in links .. Escape wfMessages in links Per Nikerabbit's comments at https://gerrit.wikimedia.org/r/#/c/80090/3/BookManagerv2.hooks.php C

[MediaWiki-commits] [Gerrit] Escape wfMessages in links - change (mediawiki...BookManagerv2)

2013-08-22 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80383 Change subject: Escape wfMessages in links .. Escape wfMessages in links Per Nikerabbit's comments at https://gerrit.wikimedia.org/r/#/c/8

[MediaWiki-commits] [Gerrit] Bug 52310: Disallow empty JSON blocks (don't merge) - change (mediawiki...BookManagerv2)

2013-08-21 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80326 Change subject: Bug 52310: Disallow empty JSON blocks (don't merge) .. Bug 52310: Disallow empty JSON blocks (don't merge) This patch prev

[MediaWiki-commits] [Gerrit] Bug 51062: Update schema so additional properties aren't all... - change (mediawiki...BookManagerv2)

2013-08-21 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 51062: Update schema so additional properties aren't allowed. .. Bug 51062: Update schema so additional properties aren't allowed. The schema was allo

[MediaWiki-commits] [Gerrit] Bug 51062: Update schema so additional properties aren't all... - change (mediawiki...BookManagerv2)

2013-08-21 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80308 Change subject: Bug 51062: Update schema so additional properties aren't allowed. .. Bug 51062: Update schema so additional properties are

[MediaWiki-commits] [Gerrit] Bug 53164: Add variable to enable/disable navigtion bars. - change (mediawiki...BookManagerv2)

2013-08-21 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80237 Change subject: Bug 53164: Add variable to enable/disable navigtion bars. .. Bug 53164: Add variable to enable/disable navigtion bars. Thi

[MediaWiki-commits] [Gerrit] Bug 52821: Provide link to the JSON page from navbar dropdowns. - change (mediawiki...BookManagerv2)

2013-08-20 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/80090 Change subject: Bug 52821: Provide link to the JSON page from navbar dropdowns. .. Bug 52821: Provide link to the JSON page from navbar dro

[MediaWiki-commits] [Gerrit] Change the default value of $wgBookManagerv2NavigationNamesp... - change (mediawiki...BookManagerv2)

2013-08-13 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/79015 Change subject: Change the default value of $wgBookManagerv2NavigationNamespaces .. Change the default value of $wgBookManagerv2NavigationN

[MediaWiki-commits] [Gerrit] Bug 50672: JavaScript fallback for navbar - change (mediawiki...BookManagerv2)

2013-08-12 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/78932 Change subject: Bug 50672: JavaScript fallback for navbar .. Bug 50672: JavaScript fallback for navbar Add links to the Book: page, which

[MediaWiki-commits] [Gerrit] Bugfix: Forgotten exclamation point - change (mediawiki...BookManagerv2)

2013-08-09 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bugfix: Forgotten exclamation point .. Bugfix: Forgotten exclamation point This was causing seven PHPunit failures, not to mention unwanted behavior. Chan

[MediaWiki-commits] [Gerrit] Bugfix: Forgotten exclamation point - change (mediawiki...BookManagerv2)

2013-08-09 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/78482 Change subject: Bugfix: Forgotten exclamation point .. Bugfix: Forgotten exclamation point This was causing seven PHPunit failures, not to

[MediaWiki-commits] [Gerrit] Bug 51239: Draft JSON editor (do not commit) - change (mediawiki...BookManagerv2)

2013-08-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/78264 Change subject: Bug 51239: Draft JSON editor (do not commit) .. Bug 51239: Draft JSON editor (do not commit) This patch adds a custon edit

[MediaWiki-commits] [Gerrit] Use inNamespaces instead of comparing getNamespaces. - change (mediawiki...BookManagerv2)

2013-08-02 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/77360 Change subject: Use inNamespaces instead of comparing getNamespaces. .. Use inNamespaces instead of comparing getNamespaces. This is the p

[MediaWiki-commits] [Gerrit] Add month-only date format. - change (mediawiki/core)

2013-07-31 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/77059 Change subject: Add month-only date format. .. Add month-only date format. The BookManagerv2 extension needs support for dates that consis

[MediaWiki-commits] [Gerrit] Bug 50989: Add view frontend to the JSON page. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76883 Change subject: Bug 50989: Add view frontend to the JSON page. .. Bug 50989: Add view frontend to the JSON page. Instead of showing the ra

[MediaWiki-commits] [Gerrit] Minor capitalization issue. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76880 Change subject: Minor capitalization issue. .. Minor capitalization issue. Change-Id: I41a4eb98a7874553d893c0eef4be860af8d9a4bd --- M Book

[MediaWiki-commits] [Gerrit] Minor capitalization issue. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Minor capitalization issue. .. Minor capitalization issue. Change-Id: I41a4eb98a7874553d893c0eef4be860af8d9a4bd --- M BookManagerv2.hooks.php 1 file change

[MediaWiki-commits] [Gerrit] Add globals that were removed in rebase. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Add globals that were removed in rebase. .. Add globals that were removed in rebase. Change-Id: Ibd908f99b38cd717a2f0b4930aaf5bba86d61fcf --- M BookManager

[MediaWiki-commits] [Gerrit] Add globals that were removed in rebase. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76879 Change subject: Add globals that were removed in rebase. .. Add globals that were removed in rebase. Change-Id: Ibd908f99b38cd717a2f0b4930

[MediaWiki-commits] [Gerrit] Bug 50762: Add variables to show/hide items in the navbar. - change (mediawiki...BookManagerv2)

2013-07-30 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50762: Add variables to show/hide items in the navbar. .. Bug 50762: Add variables to show/hide items in the navbar. This allows people to hide the met

[MediaWiki-commits] [Gerrit] Bug 52052: Add namespace configuration variable for navbar - change (mediawiki...BookManagerv2)

2013-07-29 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76644 Change subject: Bug 52052: Add namespace configuration variable for navbar .. Bug 52052: Add namespace configuration variable for navbar B

[MediaWiki-commits] [Gerrit] Register namespace in hook handler; add docs re: customization - change (mediawiki...BookManagerv2)

2013-07-29 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Register namespace in hook handler; add docs re: customization .. Register namespace in hook handler; add docs re: customization Change-Id: I660368c52d0639

[MediaWiki-commits] [Gerrit] Bug 50762: Add variables to show/hide items in the navbar. - change (mediawiki...BookManagerv2)

2013-07-28 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76463 Change subject: Bug 50762: Add variables to show/hide items in the navbar. .. Bug 50762: Add variables to show/hide items in the navbar. T

[MediaWiki-commits] [Gerrit] Bug 51194: Localize the publication date in the metadata. - change (mediawiki...BookManagerv2)

2013-07-28 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76454 Change subject: Bug 51194: Localize the publication date in the metadata. .. Bug 51194: Localize the publication date in the metadata. Thi

[MediaWiki-commits] [Gerrit] Change back to using dot concatenation. - change (mediawiki...BookManagerv2)

2013-07-28 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76451 Change subject: Change back to using dot concatenation. .. Change back to using dot concatenation. mwalker has informed me that dot concat

[MediaWiki-commits] [Gerrit] Remove "pages" property from the JSON schema. - change (mediawiki...BookManagerv2)

2013-07-28 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Remove "pages" property from the JSON schema. .. Remove "pages" property from the JSON schema. Because the ProofreadPage extension will be attempting to se

[MediaWiki-commits] [Gerrit] Remove "pages" property from the JSON schema. - change (mediawiki...BookManagerv2)

2013-07-28 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76353 Change subject: Remove "pages" property from the JSON schema. .. Remove "pages" property from the JSON schema. Because the ProofreadPage e

[MediaWiki-commits] [Gerrit] Add tags - change (mediawiki...BookManagerv2)

2013-07-27 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Add tags .. Add tags Spotted by Siebrand http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Bookmanagerv2-example-nav/en Change-Id: I85ed34b94

[MediaWiki-commits] [Gerrit] Remove extraneous CSS - change (mediawiki...BookManagerv2)

2013-07-25 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/76014 Change subject: Remove extraneous CSS .. Remove extraneous CSS List-related CSS in the primary CSS file is being overridden in the JavaScr

[MediaWiki-commits] [Gerrit] Fix bug where cache values were being stored incorrectly. - change (mediawiki...BookManagerv2)

2013-07-24 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Fix bug where cache values were being stored incorrectly. .. Fix bug where cache values were being stored incorrectly. When the cache value was set when th

[MediaWiki-commits] [Gerrit] Fix bug where cache values were being stored incorrectly. - change (mediawiki...BookManagerv2)

2013-07-24 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/75806 Change subject: Fix bug where cache values were being stored incorrectly. .. Fix bug where cache values were being stored incorrectly. Whe

[MediaWiki-commits] [Gerrit] Bug 51196: Fix the appearance of wrapped text in navbar - change (mediawiki...BookManagerv2)

2013-07-24 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/75801 Change subject: Bug 51196: Fix the appearance of wrapped text in navbar .. Bug 51196: Fix the appearance of wrapped text in navbar Now, wh

[MediaWiki-commits] [Gerrit] Bug 51258: Add title and alt attributes for icons. - change (mediawiki...BookManagerv2)

2013-07-23 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/75524 Change subject: Bug 51258: Add title and alt attributes for icons. .. Bug 51258: Add title and alt attributes for icons. Add descriptions

[MediaWiki-commits] [Gerrit] Bug 51257: Improve chapter dropdown for books with many chap... - change (mediawiki...BookManagerv2)

2013-07-22 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 51257: Improve chapter dropdown for books with many chapters. .. Bug 51257: Improve chapter dropdown for books with many chapters. Add scrollbar, limi

[MediaWiki-commits] [Gerrit] Create contents page when JSON block is saved - change (mediawiki...BookManagerv2)

2013-07-22 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/75152 Change subject: Create contents page when JSON block is saved .. Create contents page when JSON block is saved When the Book: page for a b

[MediaWiki-commits] [Gerrit] Cache the JSON blocks using memcached - change (mediawiki...BookManagerv2)

2013-07-19 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74803 Change subject: Cache the JSON blocks using memcached .. Cache the JSON blocks using memcached JSON blocks are now saved to the cache when

[MediaWiki-commits] [Gerrit] Bug 51257: Improve chapter dropdown for books with many chap... - change (mediawiki...BookManagerv2)

2013-07-19 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74658 Change subject: Bug 51257: Improve chapter dropdown for books with many chapters. .. Bug 51257: Improve chapter dropdown for books with ma

[MediaWiki-commits] [Gerrit] Change NS_MAIN to $wgContentNamespaces. - change (mediawiki...BookManagerv2)

2013-07-18 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Change NS_MAIN to $wgContentNamespaces. .. Change NS_MAIN to $wgContentNamespaces. Per suggestion from helder.wiki, check that the navigation bars are bein

[MediaWiki-commits] [Gerrit] Change NS_MAIN to $wgContentNamespaces. - change (mediawiki...BookManagerv2)

2013-07-18 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74518 Change subject: Change NS_MAIN to $wgContentNamespaces. .. Change NS_MAIN to $wgContentNamespaces. Per suggestion from helder.wiki, check

[MediaWiki-commits] [Gerrit] Re-add minor CSS change that got lost in a rebase. - change (mediawiki...BookManagerv2)

2013-07-18 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Re-add minor CSS change that got lost in a rebase. .. Re-add minor CSS change that got lost in a rebase. I accidentally removed the ordered and unordered l

[MediaWiki-commits] [Gerrit] Re-add minor CSS change that got lost in a rebase. - change (mediawiki...BookManagerv2)

2013-07-18 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74510 Change subject: Re-add minor CSS change that got lost in a rebase. .. Re-add minor CSS change that got lost in a rebase. I accidentally re

[MediaWiki-commits] [Gerrit] Bug 51591: NS_MAIN pages break on JSON edge cases. - change (mediawiki...BookManagerv2)

2013-07-18 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74490 Change subject: Bug 51591: NS_MAIN pages break on JSON edge cases. .. Bug 51591: NS_MAIN pages break on JSON edge cases. When the JSON sec

[MediaWiki-commits] [Gerrit] Fix PHPunit failure - change (mediawiki...BookManagerv2)

2013-07-17 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Fix PHPunit failure .. Fix PHPunit failure AutoloaderTest::testAutoLoadConfig was failing because of classes that existed in the JsonSchema file, but weren

[MediaWiki-commits] [Gerrit] Fix PHPunit failure - change (mediawiki...BookManagerv2)

2013-07-17 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74304 Change subject: Fix PHPunit failure .. Fix PHPunit failure AutoloaderTest::testAutoLoadConfig was failing because of classes that existed

[MediaWiki-commits] [Gerrit] Bug 50674: Allow display of example navbars. - change (mediawiki...BookManagerv2)

2013-07-17 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74289 Change subject: Bug 50674: Allow display of example navbars. .. Bug 50674: Allow display of example navbars. If a user sets $wgBookManager

[MediaWiki-commits] [Gerrit] Bug 51256: Load primary CSS separately from JavaScript. - change (mediawiki...BookManagerv2)

2013-07-17 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 51256: Load primary CSS separately from JavaScript. .. Bug 51256: Load primary CSS separately from JavaScript. The CSS was all loading with the JavaScr

[MediaWiki-commits] [Gerrit] Whitespace cleanup, changing lists to use ordered list. - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Whitespace cleanup, changing lists to use ordered list. .. Whitespace cleanup, changing lists to use ordered list. Removing trailing whitespace and whitesp

[MediaWiki-commits] [Gerrit] Add .jshintrc file for this extension. - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Add .jshintrc file for this extension. .. Add .jshintrc file for this extension. Jenkins was panicking over whitespace in JavaScript; hopefully this will h

[MediaWiki-commits] [Gerrit] Add .jshintrc file for this extension. - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74090 Change subject: Add .jshintrc file for this extension. .. Add .jshintrc file for this extension. Jenkins was panicking over whitespace in

[MediaWiki-commits] [Gerrit] Bug 50957: Populate navbar from JSON block. - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50957: Populate navbar from JSON block. .. Bug 50957: Populate navbar from JSON block. The chapterlist, metadata, and previous/next links are now popul

[MediaWiki-commits] [Gerrit] Code cleanup - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Code cleanup .. Code cleanup Fixing whitespace, spelling error. Ran PHPUnit tests, as well as stylize.php and checkSyntax.php Change-Id: I3644f37b550310d3

[MediaWiki-commits] [Gerrit] Code cleanup - change (mediawiki...BookManagerv2)

2013-07-16 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/74076 Change subject: Code cleanup .. Code cleanup Fixing whitespace, spelling error. Ran PHPUnit tests, as well as stylize.php and checkSyntax.

[MediaWiki-commits] [Gerrit] Bug 51256: Load primary CSS separately from JavaScript. - change (mediawiki...BookManagerv2)

2013-07-15 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/73784 Change subject: Bug 51256: Load primary CSS separately from JavaScript. .. Bug 51256: Load primary CSS separately from JavaScript. The CSS

[MediaWiki-commits] [Gerrit] Page numbers should not be required - change (mediawiki...BookManagerv2)

2013-07-12 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Page numbers should not be required .. Page numbers should not be required Books that don't have scans won't have page numbers, so this property should not

[MediaWiki-commits] [Gerrit] Page numbers should not be required - change (mediawiki...BookManagerv2)

2013-07-12 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/73417 Change subject: Page numbers should not be required .. Page numbers should not be required Books that don't have scans won't have page num

[MediaWiki-commits] [Gerrit] Bug 50957: Populate navbar from JSON block. - change (mediawiki...BookManagerv2)

2013-07-11 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/73150 Change subject: Bug 50957: Populate navbar from JSON block. .. Bug 50957: Populate navbar from JSON block. The chapterlist, metadata, and

[MediaWiki-commits] [Gerrit] Adding a "link" property to each section entry. - change (mediawiki...BookManagerv2)

2013-07-11 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Adding a "link" property to each section entry. .. Adding a "link" property to each section entry. This allows for a section to have a name that's differen

[MediaWiki-commits] [Gerrit] Adding a "link" property to each section entry. - change (mediawiki...BookManagerv2)

2013-07-11 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/73143 Change subject: Adding a "link" property to each section entry. .. Adding a "link" property to each section entry. This allows for a secti

[MediaWiki-commits] [Gerrit] Bug 50759: Use local image files instead of URLs. - change (mediawiki...BookManagerv2)

2013-07-10 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50759: Use local image files instead of URLs. .. Bug 50759: Use local image files instead of URLs. Use local image files for the icons in the navigatio

[MediaWiki-commits] [Gerrit] Bug 50759: Use local image files instead of URLs. - change (mediawiki...BookManagerv2)

2013-07-10 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/73117 Change subject: Bug 50759: Use local image files instead of URLs. .. Bug 50759: Use local image files instead of URLs. Use local image fil

[MediaWiki-commits] [Gerrit] Bug 50988: Add i18n for the JSON error messages - change (mediawiki...BookManagerv2)

2013-07-09 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50988: Add i18n for the JSON error messages .. Bug 50988: Add i18n for the JSON error messages Now the JSON errors will actually display useful message

[MediaWiki-commits] [Gerrit] Bug 50988: Add i18n for the JSON error messages - change (mediawiki...BookManagerv2)

2013-07-09 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72774 Change subject: Bug 50988: Add i18n for the JSON error messages .. Bug 50988: Add i18n for the JSON error messages Now the JSON errors wil

[MediaWiki-commits] [Gerrit] Use __DIR__ directly, instead of storing it in a variable. - change (mediawiki...BookManagerv2)

2013-07-09 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Use __DIR__ directly, instead of storing it in a variable. .. Use __DIR__ directly, instead of storing it in a variable. I had switched to using $dir = __D

[MediaWiki-commits] [Gerrit] Use __DIR__ directly, instead of storing it in a variable. - change (mediawiki...BookManagerv2)

2013-07-09 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72745 Change subject: Use __DIR__ directly, instead of storing it in a variable. .. Use __DIR__ directly, instead of storing it in a variable. I

[MediaWiki-commits] [Gerrit] Whitespace cleanup, changing lists to use ordered list. - change (mediawiki...BookManagerv2)

2013-07-09 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72742 Change subject: Whitespace cleanup, changing lists to use ordered list. .. Whitespace cleanup, changing lists to use ordered list. Removin

[MediaWiki-commits] [Gerrit] Fixing scoping issue. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Fixing scoping issue. .. Fixing scoping issue. Accidentally used $dir inside a function, which caused an error. Change-Id: Ic84ed69cab0abd889ff08a122f292d

[MediaWiki-commits] [Gerrit] Fixing scoping issue. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72665 Change subject: Fixing scoping issue. .. Fixing scoping issue. Accidentally used $dir inside a function, which caused an error. Change-Id

[MediaWiki-commits] [Gerrit] Bug 50987: Use a directory variable instead of calling repea... - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50987: Use a directory variable instead of calling repeatedly. .. Bug 50987: Use a directory variable instead of calling repeatedly. Storing $dir = __

[MediaWiki-commits] [Gerrit] Bug 50987: Use a directory variable instead of calling repea... - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72660 Change subject: Bug 50987: Use a directory variable instead of calling repeatedly. .. Bug 50987: Use a directory variable instead of calli

[MediaWiki-commits] [Gerrit] Disallow properties that aren't in the JSON schema. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Disallow properties that aren't in the JSON schema. .. Disallow properties that aren't in the JSON schema. Prevent save and return an error if the block co

[MediaWiki-commits] [Gerrit] Disallow properties that aren't in the JSON schema. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72658 Change subject: Disallow properties that aren't in the JSON schema. .. Disallow properties that aren't in the JSON schema. Prevent save an

[MediaWiki-commits] [Gerrit] Use the wiki DB for the BookManagerv2DBname. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Use the wiki DB for the BookManagerv2DBname. .. Use the wiki DB for the BookManagerv2DBname. Previously the DB name was hardcoded in, but this required any

[MediaWiki-commits] [Gerrit] Use wgDBname for the BookManagerv2DBname - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72638 Change subject: Use wgDBname for the BookManagerv2DBname .. Use wgDBname for the BookManagerv2DBname Previously the DB name was hardcoded

[MediaWiki-commits] [Gerrit] Bug 50674: Adding an example JSON book structure. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Bug 50674: Adding an example JSON book structure. .. Bug 50674: Adding an example JSON book structure. This patch adds an example of a valid JSON block tha

[MediaWiki-commits] [Gerrit] Bug 50674: Adding an example JSON book structure. - change (mediawiki...BookManagerv2)

2013-07-08 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/72559 Change subject: Bug 50674: Adding an example JSON book structure. .. Bug 50674: Adding an example JSON book structure. This patch adds an

[MediaWiki-commits] [Gerrit] Initializing repository with BookManagerv2 files. Files take... - change (mediawiki...BookManagerv2)

2013-07-02 Thread Mollywhite (Code Review)
Mollywhite has submitted this change and it was merged. Change subject: Initializing repository with BookManagerv2 files. Files taken from https://github.com/mollywhite/BookTest .. Initializing repository with BookManagerv2 fil

[MediaWiki-commits] [Gerrit] Initializing repository with BookManagerv2 files. Files take... - change (mediawiki...BookManagerv2)

2013-07-02 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/71655 Change subject: Initializing repository with BookManagerv2 files. Files taken from https://github.com/mollywhite/BookTest .. Initializing

[MediaWiki-commits] [Gerrit] (bug 42731) Fix bullet point overlap in "See also" section. ... - change (wikimedia...modifications)

2013-06-22 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/69983 Change subject: (bug 42731) Fix bullet point overlap in "See also" section. Remove a bullet point image that's added by vector.css Bug: 42731 .

[MediaWiki-commits] [Gerrit] (bug 47509) Move left/right key navigation to bookmanager.js - change (mediawiki...BookManager)

2013-04-22 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/60367 Change subject: (bug 47509) Move left/right key navigation to bookmanager.js .. (bug 47509) Move left/right key navigation to bookmanager.j

[MediaWiki-commits] [Gerrit] (bug 30994) Use wgContentNamespaces instead of NS_MAIN for w... - change (mediawiki...BookManager)

2013-04-15 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/59367 Change subject: (bug 30994) Use wgContentNamespaces instead of NS_MAIN for wgBookManagerNamespaces. .. (bug 30994) Use wgContentNamespaces

[MediaWiki-commits] [Gerrit] (bug 44507) Change "permissions errors" message to "permissi... - change (mediawiki/core)

2013-04-13 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/59060 Change subject: (bug 44507) Change "permissions errors" message to "permission error" .. (bug 44507) Change "permissions errors" message t

[MediaWiki-commits] [Gerrit] Patch to support (bug 42122) - change (mediawiki...Parsoid)

2013-03-27 Thread Mollywhite (Code Review)
Mollywhite has uploaded a new change for review. https://gerrit.wikimedia.org/r/56352 Change subject: Patch to support (bug 42122) .. Patch to support (bug 42122) Change-Id: I02986880eae5fbdfc78a11f29fd255c30c3d4fde --- M

  1   2   >