Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172467
Change subject: ApiResponse: return success or die with error if logging fails
..
ApiResponse: return success or die with error if logging fai
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172463
Change subject: Allow for null answer in response api.
..
Allow for null answer in response api.
As isset on null is false
Change-Id: Ib1793
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172424
Change subject: Add max height and scroll to reference drawer
..
Add max height and scroll to reference drawer
Change-Id: I92f846fb14aa01ca20
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171994
Change subject: Only assume sections are collapsible if they are wrapped in a
div
..
Only assume sections are collapsible if they are wrapped
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171717
Change subject: Validate claims in ApiResponse
..
Validate claims in ApiResponse
- Verifies 'correct' param is null or boolean
- Checks that
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171633
Change subject: Fix WikiGrokDialogB answer recording
..
Fix WikiGrokDialogB answer recording
No claims were being submitted due to button sel
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171303
Change subject: Set user language in api request so notifications are localized
..
Set user language in api request so notifications are local
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171023
Change subject: Validate claims in WikiGrokResponseApi
..
Validate claims in WikiGrokResponseApi
Change-Id: I455d383a76e6e7bf0f17dd6d7c4c6527
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170994
Change subject: hygiene: Change source to task_type for consistency
..
hygiene: Change source to task_type for consistency
Dependent on WikiG
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170992
Change subject: hygiene: Change source to task_type for consistency with
MobileFrontend
..
hygiene: Change source to task_type for consistenc
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170877
Change subject: Add alma_mater (schools) to WikiGrok Dialog b
..
Add alma_mater (schools) to WikiGrok Dialog b
Change-Id: Idcb9fd23fa8850b421
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170838
Change subject: Add mobile mode getter
..
Add mobile mode getter
Change-Id: I32fd10f8af3fa8c39e8bb3acc1ea7225a076f8eb
---
M javascripts/loggi
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169776
Change subject: Change wikigrok tags to buttons and adjust spacing
..
Change wikigrok tags to buttons and adjust spacing
Change-Id: Ic5acf4e5
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169599
Change subject: Add missing WikiGrok documentation
..
Add missing WikiGrok documentation
Change-Id: I9ef081a0519075aa0cd15c1c058d2cfdd163e773
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169592
Change subject: Update and add missing documentation
..
Update and add missing documentation
Updated documentation for Icon.js
Change-Id: I9
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169583
Change subject: Add missing documentation
..
Add missing documentation
Add missing documentation for:
Section.js
ContentOverlay.js
settings.j
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169578
Change subject: Add missing documentation
..
Add missing documentation
Add missing documentation for:
Overlay.js
Page.js
PageApi.js
Panel.js
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169567
Change subject: Fix MF documentation part 1
..
Fix MF documentation part 1
Bug: 72341
Change-Id: I20caef5b48b2dc1c023580252f5ae563b4039717
--
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169552
Change subject: Document incomplete methods and classes.
..
Document incomplete methods and classes.
Change-Id: Ie1e360aa1979d8dc85ce8264b043
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169548
Change subject: Gruntfile cleanup
..
Gruntfile cleanup
Change-Id: I43604998687200f046e2a74bfa205df77c164371
---
R .jscsrc
M Gruntfile.js
M Ma
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168656
Change subject: Setup Gruntfile to run jshint and jscs
..
Setup Gruntfile to run jshint and jscs
Setup default task and test for jenkins
run
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168400
Change subject: hygiene: coding style spacing
..
hygiene: coding style spacing
Change-Id: I312e9758f4d588d7883d7dc0aef3928ed2e64448
---
M jav
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168336
Change subject: Mobile mode getter and implement in schemas and
WikiGrokResponseApi
..
Mobile mode getter and implement in schemas and WikiGr
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/168018
Change subject: WIP: New WikiGrok response API
..
WIP: New WikiGrok response API
Change-Id: Ifb56ccfae9d2eb5e06d0427881ff60d0aa372f55
depende
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167974
Change subject: Move wgMFThumbnailSizes to js hooks as its used outside Minerva
..
Move wgMFThumbnailSizes to js hooks as its used outside Min
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167893
Change subject: Square up dimensions of WikiGrok spinner for even padding around
..
Square up dimensions of WikiGrok spinner for even padding
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167719
Change subject: Give spinner same margins as search result text
..
Give spinner same margins as search result text
Bug: 72272
Change-Id: I4de
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166892
Change subject: hygiene: WikiGrok api documentation typo
..
hygiene: WikiGrok api documentation typo
Change-Id: I461fe59971b8d0f89007673a9fd7
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166885
Change subject: Feature flag to permit wikiGrok on all devices
..
Feature flag to permit wikiGrok on all devices
Useful for testing on deskto
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165941
Change subject: Add alpha feature to provide zero like image quality reduction
..
Add alpha feature to provide zero like image quality reducti
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165858
Change subject: Split out text specific less
..
Split out text specific less
Change-Id: I71cda6b3d94c7a59e098d56de6a4ff45a965649c
---
M inclu
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165857
Change subject: Split out table specific less
..
Split out table specific less
Removed unused tableHeadBackgroundColor
Change-Id: I851c50f30
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165856
Change subject: Split out list specific less
..
Split out list specific less
Change-Id: Id94b7022e883e7b4df1671e900799d4b42ffa8ff
---
M inclu
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165855
Change subject: Split out blockquote specific less
..
Split out blockquote specific less
Change-Id: Iceeb91b8de4315c334e66c9d0ddbafe81af6a9c1
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165854
Change subject: Split out heading specific less
..
Split out heading specific less
Change-Id: Ieb82dbb49b508571f79ceba0a091dd5ecc0215ed
---
M
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165853
Change subject: Split out link specific less
..
Split out link specific less
Change-Id: I8759ef594f908be059709c16ca7dd16c9d582dbc
---
M inclu
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165852
Change subject: Split out gallery specific less
..
Split out gallery specific less
Change-Id: I1fd76e407931868fcc0ca11143a7da5a6cc72994
---
M
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165851
Change subject: Split out full image specific less
..
Split out full image specific less
Change-Id: I95409c6b57e54772a063990cc4a2e6221388920a
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165850
Change subject: Split out thumbnail content less
..
Split out thumbnail content less
Change-Id: I641523251bf02f738dc0cc8bd0936dbfe0ead552
---
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165421
Change subject: Split out content less into features
..
Split out content less into features
Rules that were in .content block remain
Removed
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165315
Change subject: Remove apple web app capable mode from skin
..
Remove apple web app capable mode from skin
Homescreen bookmarks then get crea
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165135
Change subject: Standardize on jQuery.each vs forEach
..
Standardize on jQuery.each vs forEach
Bug: 63454
Change-Id: I500125701cf4d7f1245786d
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165029
Change subject: Longer timeout for history update on search click
..
Longer timeout for history update on search click
Tested on chrome in: w
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163108
Change subject: Make onPostLoginRedirect behave the same as
onCentralAuthPostLoginRedirect
..
Make onPostLoginRedirect behave the same as onC
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163049
Change subject: Rewrite GS tasktoolbar VE tour with new api
..
Rewrite GS tasktoolbar VE tour with new api
Save step is currently broken in m
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/162791
Change subject: WIP: Rewrite GS tasktoolbar tour with new api
..
WIP: Rewrite GS tasktoolbar tour with new api
Currently stuck: I cannot get
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161028
Change subject: Revert "mw-ui-button: Revamp the LESS to be simpler, and
improve cross-browser support"
..
Revert "mw-ui-button: Revamp the L
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/160079
Change subject: Use CSS to hide and show flyout states
..
Use CSS to hide and show flyout states
Fix error state padding issue below button
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159935
Change subject: Vertically align suggestions for less than 3 on a page
..
Vertically align suggestions for less than 3 on a page
Change-Id: I
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159932
Change subject: Ellipsis page title in flyout
..
Ellipsis page title in flyout
Change-Id: I18057d02a71a582a984f5c7464f080ad48ba3fd7
---
M res
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159927
Change subject: Wrap suggestion text
..
Wrap suggestion text
Change-Id: I40556fa6011aef860bced4fe3d9cdc2d5ac61501
---
M resources/lightbulb/l
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159828
Change subject: Fire TaskRecommendationImpression when flyout is reopened
..
Fire TaskRecommendationImpression when flyout is reopened
Bug: 7
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159393
Change subject: WIP: Animate suggestions
..
WIP: Animate suggestions
todo:
- struture suggestion container in a wrapper with overflow hidden
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159077
Change subject: Add loading state to flyout.
..
Add loading state to flyout.
Change-Id: Idf091a98e108e577cbc57563c8f8540964b2bfef
TODO: Need
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/158233
Change subject: WIP: Begin version 2 of error states. Setup and optimized icons
..
WIP: Begin version 2 of error states. Setup and optimized
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/158037
Change subject: Fix lightbulb position and size
..
Fix lightbulb position and size
Change-Id: I7208903316c3509645f45055ef32038ab48e6425
---
M
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/157990
Change subject: Make profile icon gender neutral and remove from login link in
Vector
..
Make profile icon gender neutral and remove from log
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/157001
Change subject: WIP: Add error states to flyout
..
WIP: Add error states to flyout
Change-Id: I2e2be6c30b10db569a6f12fa7b116f4cf78f360a
---
M
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156962
Change subject: Fix dependency for lastedited message
..
Fix dependency for lastedited message
Change-Id: Ie47938deb5258b66b3fe1afe90a790db4d
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155837
Change subject: Position flyout on window resize
..
Position flyout on window resize
Change-Id: I53248ffaac405e794b99ab7f720143847a78410c
---
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155447
Change subject: Hide recommendations in personal tools if js is disabled
..
Hide recommendations in personal tools if js is disabled
Bug: 698
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155441
Change subject: Add postEdit recommendation only when editing in mainspace
..
Add postEdit recommendation only when editing in mainspace
Bug:
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155431
Change subject: Prevent multiple api requests from firing
..
Prevent multiple api requests from firing
Bug: 69719
Change-Id: Ic8c2fe52aa2a0c1
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155154
Change subject: Update default button color per design consensus
..
Update default button color per design consensus
Change-Id: Ie8acb28f4562
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155100
Change subject: Use personal-urls hook to render lightbulb
..
Use personal-urls hook to render lightbulb
Change-Id: I6333b7af637ee6660e8b9446
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154950
Change subject: Update cta header color for consistency
..
Update cta header color for consistency
Change-Id: I4e635a699ddecdaf7e11a542079a67
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154949
Change subject: Update guider header color for consistency
..
Update guider header color for consistency
Change-Id: I361207d4c802bef5b2f4c373
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154945
Change subject: Instrument TaskRecommendationImpression schema for flyout
..
Instrument TaskRecommendationImpression schema for flyout
Change
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150965
Change subject: Instrument task recommendation schemas
..
Instrument task recommendation schemas
Change-Id: Idf2ec7f3c53e795b04c295bea33b8e3f
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150062
Change subject: Bump memory for redis to prevent various job runner internal
errors
..
Bump memory for redis to prevent various job runner in
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150027
Change subject: Bump memory for cirrussearch to avoid internal errors
..
Bump memory for cirrussearch to avoid internal errors
Change-Id: Icd
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148278
Change subject: Removed deprecated and unused guider members and methods
..
Removed deprecated and unused guider members and methods
Removed
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148268
Change subject: Consolidate guider css and images and remove unused
..
Consolidate guider css and images and remove unused
Change-Id: I753770
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/147528
Change subject: Remove anonymous experiement v2 module loading from hooks
..
Remove anonymous experiement v2 module loading from hooks
Change
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/146979
Change subject: Make profile icon gender neutral. Remove from Login link
..
Make profile icon gender neutral. Remove from Login link
Bug: 4
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/146519
Change subject: Preserve some space around the close button
..
Preserve some space around the close button
Addresses issue where heading is w
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/146249
Change subject: Update first edit tour buttons per latest guidedtour api changes
..
Update first edit tour buttons per latest guidedtour api c
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/146182
Change subject: Show either a next or or okay button in
gettingstartedtasktoolbar edit step.
..
Show either a next or or okay button in getti
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/146291
Change subject: WIP: lightbulb
..
WIP: lightbulb
Change-Id: I9bd86d6207455c2cb27164bdf18323b01b77f494
---
M GettingStarted.php
M Hooks.php
2
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145993
Change subject: fix setupAnimations doc typo
..
fix setupAnimations doc typo
Change-Id: I7ed0e2bf15d4a205dd4dfc31be99739a2f955a3e
---
M modul
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145992
Change subject: In transition look up tour by name, instead of undefined
property
..
In transition look up tour by name, instead of undefined
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145991
Change subject: Allow multiple button types. Fix getButton tests.
..
Allow multiple button types. Fix getButton tests.
When defining a butt
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145464
Change subject: End tour if saving before preview
..
End tour if saving before preview
Bug: 66743
Change-Id: I3aea99e5ff1bf8a4f85df36f2614465
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145396
Change subject: Per team discussion, change flagType property name to type
..
Per team discussion, change flagType property name to type
Remo
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143577
Change subject: Update default and quiet button color per design consensus
..
Update default and quiet button color per design consensus
Upda
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143189
Change subject: Add mw-ui-progressive button class to link type buttons.
..
Add mw-ui-progressive button class to link type buttons.
Change-I
Robmoen has submitted this change and it was merged.
Change subject: Stop the pokey container covering the element
..
Stop the pokey container covering the element
* Make the pokey container (.guider_arrow) a rectangle of 42px
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143176
Change subject: Add back buttons to relevant steps on first edit tours
..
Add back buttons to relevant steps on first edit tours
Change-Id: I
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143170
Change subject: Add automatic next button step specification.
..
Add automatic next button step specification.
* Fixes first edit tours where
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142437
Change subject: Add back buttons to relevant steps on first edit tours
..
Add back buttons to relevant steps on first edit tours
Change-Id: I
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142434
Change subject: Fix issue with automatic next button when there is an okay
button.
..
Fix issue with automatic next button when there is an o
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142426
Change subject: Remove text shadow from default mediawiki.ui buttons
..
Remove text shadow from default mediawiki.ui buttons
Place text-shado
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140619
Change subject: Remove page from redis categories on page delete
..
Remove page from redis categories on page delete
Bug: 56044
Change-Id: I0
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140573
Change subject: Put a tabindex on buttons and focus progressive button when
step is shown
..
Put a tabindex on buttons and focus progressive
Robmoen has submitted this change and it was merged.
Change subject: Draw the pokey using HTML and CSS
..
Draw the pokey using HTML and CSS
* Replace the pokey PNG with a rotated div with a box shadow, which can
be scaled (or
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137837
Change subject: WIP: Add back button functionality.
..
WIP: Add back button functionality.
Change-Id: I8446bade1def3967d101f34d5b2f711c81c944
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137157
Change subject: WIP: Icon buttons for next and complete steps
..
WIP: Icon buttons for next and complete steps
TODO: resolve i18n flipping is
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/136915
Change subject: TEST - Optionally depend on CentralAuth's redirect hook
..
TEST - Optionally depend on CentralAuth's redirect hook
Dependent
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/136454
Change subject: Move images into subfolders in anticipation of icon buttons
..
Move images into subfolders in anticipation of icon buttons
Ch
Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135888
Change subject: Optionally depend on CentralAuth's redirect hook
..
Optionally depend on CentralAuth's redirect hook
Dependent on core hook P
201 - 300 of 497 matches
Mail list logo
