[MediaWiki-commits] [Gerrit] Updated site link table fixation for IE - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Updated site link table fixation for IE .. Updated site link table fixation for IE Correctly aligning the site link table's edit buttons in IE. C

[MediaWiki-commits] [Gerrit] (bug 43006) Replace toolbar with message while saving/removi... - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43006) Replace toolbar with message while saving/removing .. (bug 43006) Replace toolbar with message while saving/removing - patch set 2: Co

[MediaWiki-commits] [Gerrit] (hotfix) fixing entitieswithoutlabel-test in chrome - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (hotfix) fixing entitieswithoutlabel-test in chrome .. (hotfix) fixing entitieswithoutlabel-test in chrome Change-Id: Id05af10033f9925930e43de0546

[MediaWiki-commits] [Gerrit] (hotfix) fixing entitieswithoutlabel-test in chrome - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) fixing entitieswithoutlabel-test in chrome .. (hotfix) fixing entitieswithoutlabel-test in chrome Change-Id: Id05af10033f9925930e43de054620710064

[MediaWiki-commits] [Gerrit] (testing) selenium tests for label/description/aliases lengt... - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (testing) selenium tests for label/description/aliases length constraints .. (testing) selenium tests for label/description/aliases length constraints Ch

[MediaWiki-commits] [Gerrit] Moving baseclasses and preparing for reuse - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Moving baseclasses and preparing for reuse .. Moving baseclasses and preparing for reuse Patchset 2: Removed a couple of accidential included file

[MediaWiki-commits] [Gerrit] (hotfix) wrong order of parameters in messages - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) wrong order of parameters in messages .. (hotfix) wrong order of parameters in messages Change-Id: I4a4fd85fffd0a012aed7058cc5edf3e8e58bce11 ---

[MediaWiki-commits] [Gerrit] Checking on initial snak when drawing property - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Checking on initial snak when drawing property .. Checking on initial snak when drawing property Check prevents property input element from being

[MediaWiki-commits] [Gerrit] (minor) selenium: only run client qunit tests on client - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) selenium: only run client qunit tests on client .. (minor) selenium: only run client qunit tests on client - making filter more specific to not ex

[MediaWiki-commits] [Gerrit] (minor) selenium: only run client qunit tests on client - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) selenium: only run client qunit tests on client .. (minor) selenium: only run client qunit tests on client - making filter more specific t

[MediaWiki-commits] [Gerrit] (hotfix) fix to selenium protected page object - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (hotfix) fix to selenium protected page object .. (hotfix) fix to selenium protected page object - select list content has changed Change-Id: I9d

[MediaWiki-commits] [Gerrit] (hotfix) fix to selenium protected page object - change (mediawiki...Wikibase[master])

2013-01-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) fix to selenium protected page object .. (hotfix) fix to selenium protected page object - select list content has changed Change-Id: I9d7e75d6c5

[MediaWiki-commits] [Gerrit] (testing) method to exclude certain browsers in selenium tes... - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (testing) method to exclude certain browsers in selenium tests .. (testing) method to exclude certain browsers in selenium tests - this adds the possibili

[MediaWiki-commits] [Gerrit] (bug 41007) added selenium tests for localizing numbers - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 41007) added selenium tests for localizing numbers .. (bug 41007) added selenium tests for localizing numbers Change-Id: I7883aeb849836a7f2b6c59d2483

[MediaWiki-commits] [Gerrit] (testing) removing workarounds for bug 43200 in selenium tes... - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (testing) removing workarounds for bug 43200 in selenium tests .. (testing) removing workarounds for bug 43200 in selenium tests - bug 43200 is fixed, so

[MediaWiki-commits] [Gerrit] Added TODO in diff visualizer to prevent notices when visual... - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Added TODO in diff visualizer to prevent notices when visualizing diffs containing claims .. Added TODO in diff visualizer to prevent notices when

[MediaWiki-commits] [Gerrit] fix error detection in createclaim api - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: fix error detection in createclaim api .. fix error detection in createclaim api clean patching results in a warning being added that a patch was

[MediaWiki-commits] [Gerrit] Added claims to entity patching - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Added claims to entity patching .. Added claims to entity patching Change-Id: Ifbdbfcc689779230ee383a02df23eedb8c64e2c1 --- M lib/includes/entity/

[MediaWiki-commits] [Gerrit] Added claims diffing and added this to entitydiff - change (mediawiki...Wikibase[master])

2013-01-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Added claims diffing and added this to entitydiff .. Added claims diffing and added this to entitydiff Change-Id: I2b8fe753ff7ca00f1e1362b08ebfd00

[MediaWiki-commits] [Gerrit] (hotfix) selenium sitelinks tests fix - change (mediawiki...Wikibase[master])

2013-01-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) selenium sitelinks tests fix .. (hotfix) selenium sitelinks tests fix - entity selector has changed its logic, selenium tests have to be adjusted

[MediaWiki-commits] [Gerrit] (bug 42995) selenium tests for statements UI errorhandling - change (mediawiki...Wikibase[master])

2013-01-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 42995) selenium tests for statements UI errorhandling .. (bug 42995) selenium tests for statements UI errorhandling Change-Id: I215961337a4b46430dd10

[MediaWiki-commits] [Gerrit] (testing) snaktype selector seleneium tests (DNM) - change (mediawiki...Wikibase[master])

2013-01-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (testing) snaktype selector seleneium tests (DNM) .. (testing) snaktype selector seleneium tests (DNM) - for some weird reason this is not working in Fire

[MediaWiki-commits] [Gerrit] (bug 44051) Adding mediawiki.user dependency to entityViewIn... - change (mediawiki...Wikibase[mw1.21-wmf8])

2013-01-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 44051) Adding mediawiki.user dependency to entityViewInit .. (bug 44051) Adding mediawiki.user dependency to entityViewInit In addition, checking if

[MediaWiki-commits] [Gerrit] (bug 44051) Adding mediawiki.user dependency to entityViewIn... - change (mediawiki...Wikibase[master])

2013-01-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 44051) Adding mediawiki.user dependency to entityViewInit .. (bug 44051) Adding mediawiki.user dependency to entityViewInit In addition, chec

[MediaWiki-commits] [Gerrit] ResourceLoader modules dependency clean-up - change (mediawiki...Wikibase[master])

2013-01-16 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: ResourceLoader modules dependency clean-up .. ResourceLoader modules dependency clean-up Proper eachchange and wikibase.templates dependencies alo

[MediaWiki-commits] [Gerrit] Adding eachchange dependency to dataTypes valueview module - change (mediawiki...DataValues[master])

2013-01-16 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Adding eachchange dependency to dataTypes valueview module .. Adding eachchange dependency to dataTypes valueview module eachchange jquery plugin

[MediaWiki-commits] [Gerrit] (bug 43585) testing 0 as value for label/description/aliases - change (mediawiki...Wikibase[master])

2013-01-16 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 43585) testing 0 as value for label/description/aliases .. (bug 43585) testing 0 as value for label/description/aliases - this adds selenium tests C

[MediaWiki-commits] [Gerrit] (minor) workaround for failing qunit tests in firefox - change (mediawiki...Wikibase[master])

2013-01-15 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) workaround for failing qunit tests in firefox .. (minor) workaround for failing qunit tests in firefox - in firefox focus-qunit tests are failing

[MediaWiki-commits] [Gerrit] make changes line hook more backwards compatible - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: make changes line hook more backwards compatible .. make changes line hook more backwards compatible - although we intend to backport patch to cor

[MediaWiki-commits] [Gerrit] adjust watchlist query to use rc_this_oldid=page_latest - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: adjust watchlist query to use rc_this_oldid=page_latest .. adjust watchlist query to use rc_this_oldid=page_latest - LIST_OR doesn't work perfectl

[MediaWiki-commits] [Gerrit] (bug 43873) enable continuation in ApiSearchEntities again - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43873) enable continuation in ApiSearchEntities again .. (bug 43873) enable continuation in ApiSearchEntities again The continuation in ApiSe

[MediaWiki-commits] [Gerrit] (bug 43958) fix autocomment for connecting an item with a cl... - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43958) fix autocomment for connecting an item with a client page .. (bug 43958) fix autocomment for connecting an item with a client page -

[MediaWiki-commits] [Gerrit] (minor) function for checking whether value would be most su... - change (mediawiki...DataValues[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) function for checking whether value would be most suitable for view .. (minor) function for checking whether value would be most suitable

[MediaWiki-commits] [Gerrit] (minor) function for checking whether value would be suitabl... - change (mediawiki...DataValues[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) function for checking whether value would be suitable for valueview .. (minor) function for checking whether value would be suitable for v

[MediaWiki-commits] [Gerrit] (bug 42995) Basic error handling for claim/snak UI - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 42995) Basic error handling for claim/snak UI .. (bug 42995) Basic error handling for claim/snak UI When saving/removing a claim/snak fails (

[MediaWiki-commits] [Gerrit] Enabling object to be passed to Tooltip extension's setToolt... - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Enabling object to be passed to Tooltip extension's setTooltip .. Enabling object to be passed to Tooltip extension's setTooltip Passing an object

[MediaWiki-commits] [Gerrit] Tooltips for claim view widget - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Tooltips for claim view widget .. Tooltips for claim view widget - patch set 2: Updated messages Change-Id: I841861bab4b84c8579250bff633862a1

[MediaWiki-commits] [Gerrit] (bug 43124) add toggle for wikibase edits in watchlist - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43124) add toggle for wikibase edits in watchlist .. (bug 43124) add toggle for wikibase edits in watchlist this is not the ideal solution, b

[MediaWiki-commits] [Gerrit] Update commonsMedia widget value on suggester's close event - change (mediawiki...DataValues[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Update commonsMedia widget value on suggester's close event .. Update commonsMedia widget value on suggester's close event When selecting a sugges

[MediaWiki-commits] [Gerrit] Correct parameter order in AutocompleteInterface - change (mediawiki...Wikibase[master])

2013-01-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Correct parameter order in AutocompleteInterface .. Correct parameter order in AutocompleteInterface Change-Id: Ia0716c7f0d27d66a016fa34b298835c7c

[MediaWiki-commits] [Gerrit] (minor) add wb.Snak.prototype.toMap() and wb.Snak.newFromMap... - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) add wb.Snak.prototype.toMap() and wb.Snak.newFromMap() .. (minor) add wb.Snak.prototype.toMap() and wb.Snak.newFromMap() Adds those two fu

[MediaWiki-commits] [Gerrit] (minor) add wb.Snak.equal() - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) add wb.Snak.equal() .. (minor) add wb.Snak.equal() Allows to check whether one Snak is equal to another. Compares the Snak's type and pro

[MediaWiki-commits] [Gerrit] (minor) simpler way to maximize browser during selenium test... - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) simpler way to maximize browser during selenium tests .. (minor) simpler way to maximize browser during selenium tests Change-Id: Ibe53b24

[MediaWiki-commits] [Gerrit] (minor) simpler way to maximize browser during selenium test... - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) simpler way to maximize browser during selenium tests .. (minor) simpler way to maximize browser during selenium tests Change-Id: Ibe53b247d9e7594

[MediaWiki-commits] [Gerrit] (43828) marking specific selenium tests as experimental - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (43828) marking specific selenium tests as experimental .. (43828) marking specific selenium tests as experimental - selenium tests testing experimental f

[MediaWiki-commits] [Gerrit] (hotfix) fix calls to getEntityNamespaces - change (mediawiki...Wikibase[master])

2013-01-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) fix calls to getEntityNamespaces .. (hotfix) fix calls to getEntityNamespaces - getEntityNamespaces was moved from lib to repo in I4acc406d but s

[MediaWiki-commits] [Gerrit] (minor) small change to statements rake tasks in selenium - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) small change to statements rake tasks in selenium .. (minor) small change to statements rake tasks in selenium Change-Id: I45770d43dc1967ddc6a38f9

[MediaWiki-commits] [Gerrit] (43828) possibility to filter experimentals in selenium test... - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (43828) possibility to filter experimentals in selenium tests .. (43828) possibility to filter experimentals in selenium tests - this adds the possibility

[MediaWiki-commits] [Gerrit] (minor) always start selenium tests in fullscreen - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) always start selenium tests in fullscreen .. (minor) always start selenium tests in fullscreen - otherwise it could happen that some elements (e.g

[MediaWiki-commits] [Gerrit] (42954) selenium tests for ip warning message - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (42954) selenium tests for ip warning message .. (42954) selenium tests for ip warning message Change-Id: I4db44d1d7fc90d21b0245d95ec7b4e642ffa4fa2 --- A

[MediaWiki-commits] [Gerrit] (hotfix) removed unnecessary parameter - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) removed unnecessary parameter .. (hotfix) removed unnecessary parameter Change-Id: I9c28cb12594ffbb13579e1eb1a8599abc2b4007a --- M repo/includes/

[MediaWiki-commits] [Gerrit] (bug 43814) link to Special:SetLabel from EntityView - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 43814) link to Special:SetLabel from EntityView .. (bug 43814) link to Special:SetLabel from EntityView - the label-edit-button should link to the Se

[MediaWiki-commits] [Gerrit] (hotfix) $prefs should be passed by reference - change (mediawiki...Wikibase[master])

2013-01-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (hotfix) $prefs should be passed by reference .. (hotfix) $prefs should be passed by reference - $prefs should be passed by reference in the onGetPreferen

[MediaWiki-commits] [Gerrit] (minor) increase waitingtime in clientrepo seleniumtest when... - change (mediawiki...Wikibase[master])

2013-01-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) increase waitingtime in clientrepo seleniumtest when un/deleting item .. (minor) increase waitingtime in clientrepo seleniumtest when un/deleting

[MediaWiki-commits] [Gerrit] (minor) keep window focus during running qunit with selenium - change (mediawiki...Wikibase[master])

2013-01-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) keep window focus during running qunit with selenium .. (minor) keep window focus during running qunit with selenium Change-Id: I6dafd367dec4dc33d

[MediaWiki-commits] [Gerrit] (minor) removed todo from selenium statements tests - change (mediawiki...Wikibase[master])

2013-01-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) removed todo from selenium statements tests .. (minor) removed todo from selenium statements tests - one bug got removed some time ago but there w

[MediaWiki-commits] [Gerrit] (43301) add Selenium to check error-reporting - change (mediawiki...Wikibase[master])

2013-01-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (43301) add Selenium to check error-reporting .. (43301) add Selenium to check error-reporting - tests check the correct error reporting when changing lab

[MediaWiki-commits] [Gerrit] (bug 43304) Added snakview variation definition for handling... - change (mediawiki...Wikibase[master])

2013-01-08 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43304) Added snakview variation definition for handling of SomeValueSnaks .. (bug 43304) Added snakview variation definition for handling of

[MediaWiki-commits] [Gerrit] (bug 43304) Added snakview variation definition for handling... - change (mediawiki...Wikibase[master])

2013-01-08 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43304) Added snakview variation definition for handling of NoValueSnaks .. (bug 43304) Added snakview variation definition for handling of No

[MediaWiki-commits] [Gerrit] (bug 43304) Refactoring of Snakview variations registration - change (mediawiki...Wikibase[master])

2013-01-08 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43304) Refactoring of Snakview variations registration .. (bug 43304) Refactoring of Snakview variations registration Makes the variation sys

[MediaWiki-commits] [Gerrit] (bug 43304) Mechanism for supporting different Snak types in... - change (mediawiki...Wikibase[master])

2013-01-08 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43304) Mechanism for supporting different Snak types in the user interface .. (bug 43304) Mechanism for supporting different Snak types in th

[MediaWiki-commits] [Gerrit] Simplified xpath declarations in alias Selenium module - change (mediawiki...Wikibase[master])

2013-01-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Simplified xpath declarations in alias Selenium module .. Simplified xpath declarations in alias Selenium module Change-Id: Id6be6cade770d5447870c

[MediaWiki-commits] [Gerrit] (minor) adjust selenium tests for new snak type selectr DOM - change (mediawiki...Wikibase[master])

2013-01-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) adjust selenium tests for new snak type selectr DOM .. (minor) adjust selenium tests for new snak type selectr DOM Change-Id: I7943972baf4

[MediaWiki-commits] [Gerrit] (Bug 43304) Changed DOM for snak type selector - change (mediawiki...Wikibase[master])

2013-01-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (Bug 43304) Changed DOM for snak type selector .. (Bug 43304) Changed DOM for snak type selector Adjusted 'wb-snak' Template to have a node for th

[MediaWiki-commits] [Gerrit] (minor) adjust selenium tests for new snak type selectr DOM - change (mediawiki...Wikibase[master])

2013-01-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) adjust selenium tests for new snak type selectr DOM .. (minor) adjust selenium tests for new snak type selectr DOM Change-Id: I7943972baf4ce8b15d7

[MediaWiki-commits] [Gerrit] Moved data type selector ui code into own class to facilitat... - change (mediawiki...Wikibase[master])

2013-01-03 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Moved data type selector ui code into own class to facilitate testing and reuse and make special newproperty simpler .. Moved data type selector u

[MediaWiki-commits] [Gerrit] (bug 43606) more selenium tests for statements UI - change (mediawiki...Wikibase[master])

2013-01-03 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 43606) more selenium tests for statements UI .. (bug 43606) more selenium tests for statements UI - multiple statements - multiple claims for same st

[MediaWiki-commits] [Gerrit] (bug 43363) Entity selector: Setting input value when settin... - change (mediawiki...Wikibase[master])

2013-01-03 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43363) Entity selector: Setting input value when setting entity .. (bug 43363) Entity selector: Setting input value when setting entity When

[MediaWiki-commits] [Gerrit] (minor) removed test for item label/description uniqueness - change (mediawiki...Wikibase[master])

2012-12-20 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) removed test for item label/description uniqueness .. (minor) removed test for item label/description uniqueness - since this restriction

[MediaWiki-commits] [Gerrit] (minor) removed test for item label/description uniqueness - change (mediawiki...Wikibase[master])

2012-12-20 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) removed test for item label/description uniqueness .. (minor) removed test for item label/description uniqueness - since this restriction got remo

[MediaWiki-commits] [Gerrit] (minor) Adding property input placeholder message to resourc... - change (mediawiki...Wikibase[master])

2012-12-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) Adding property input placeholder message to resource module .. (minor) Adding property input placeholder message to resource module Chan

[MediaWiki-commits] [Gerrit] (bug 42998) Placeholder and loading spinner when adding a sn... - change (mediawiki...Wikibase[master])

2012-12-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 42998) Placeholder and loading spinner when adding a snak .. (bug 42998) Placeholder and loading spinner when adding a snak When adding a sna

[MediaWiki-commits] [Gerrit] (minor) fix edgecase in aliases UI when edited by multiple u... - change (mediawiki...Wikibase[master])

2012-12-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) fix edgecase in aliases UI when edited by multiple users .. (minor) fix edgecase in aliases UI when edited by multiple users - this fixes a very s

[MediaWiki-commits] [Gerrit] (minor) make sure arrays have equal size before doing multis... - change (mediawiki...Wikibase[master])

2012-12-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) make sure arrays have equal size before doing multisort .. (minor) make sure arrays have equal size before doing multisort - a PHP warning was giv

[MediaWiki-commits] [Gerrit] Added EntityLoader test and fixed a bug - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Added EntityLoader test and fixed a bug .. Added EntityLoader test and fixed a bug Change-Id: Iadd24d36cd9d02eb0aa9ea2ccec736f0c894751c --- M lib/

[MediaWiki-commits] [Gerrit] Added ReferencedEntitiesFinder - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Added ReferencedEntitiesFinder .. Added ReferencedEntitiesFinder Change-Id: I0007a986504215705e8989161a511c098995df10 --- M client/WikibaseClient.

[MediaWiki-commits] [Gerrit] Match changes in Diff extension - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Match changes in Diff extension .. Match changes in Diff extension Change-Id: Ic46422c37a05fa19c3b5c5b17faf7a66130a7632 --- M lib/includes/entity/

[MediaWiki-commits] [Gerrit] Work on splitting the patching code to its own dedicated cla... - change (mediawiki...Diff[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Work on splitting the patching code to its own dedicated class .. Work on splitting the patching code to its own dedicated class Change-Id: Ibfbc0

[MediaWiki-commits] [Gerrit] (Bug 43206) makes Claim properties links to their related wi... - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (Bug 43206) makes Claim properties links to their related wiki pages .. (Bug 43206) makes Claim properties links to their related wiki pages Also

[MediaWiki-commits] [Gerrit] (Bug 43001) Link to items in statements ui - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (Bug 43001) Link to items in statements ui .. (Bug 43001) Link to items in statements ui When adding a Claim with a PVSnak using a property of typ

[MediaWiki-commits] [Gerrit] (minor) Adjusted entity selector QUnit test to new API behav... - change (mediawiki...Wikibase[master])

2012-12-18 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) Adjusted entity selector QUnit test to new API behaviour .. (minor) Adjusted entity selector QUnit test to new API behaviour Corresponds t

[MediaWiki-commits] [Gerrit] Improved HTML building of datatype selector and added sort - change (mediawiki...Wikibase[master])

2012-12-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Improved HTML building of datatype selector and added sort .. Improved HTML building of datatype selector and added sort Change-Id: Ieda9f1e98335b

[MediaWiki-commits] [Gerrit] (minor) Update to wikibase-api-edit-conflict - change (mediawiki...Wikibase[master])

2012-12-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) Update to wikibase-api-edit-conflict .. (minor) Update to wikibase-api-edit-conflict Change-Id: Ie9cb26253011e05a875459135a58d01eadfa2f40

[MediaWiki-commits] [Gerrit] (bug 42999) Entity selector: Display alias when entity has n... - change (mediawiki...Wikibase[master])

2012-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 42999) Entity selector: Display alias when entity has no label .. (bug 42999) Entity selector: Display alias when entity has no label - patc

[MediaWiki-commits] [Gerrit] (bug 43005) Attaching keyboard events to snakview widget - change (mediawiki...Wikibase[master])

2012-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43005) Attaching keyboard events to snakview widget .. (bug 43005) Attaching keyboard events to snakview widget - patch set 2: rebase Change

[MediaWiki-commits] [Gerrit] (minor) refactored wbsearchentities - change (mediawiki...Wikibase[master])

2012-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) refactored wbsearchentities .. (minor) refactored wbsearchentities - split off some logic from sortByScore into seperate method - removed reportin

[MediaWiki-commits] [Gerrit] (bug 43074) Setting focus when starting snakview edit mode - change (mediawiki...Wikibase[master])

2012-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43074) Setting focus when starting snakview edit mode .. (bug 43074) Setting focus when starting snakview edit mode Depends on change Iaa4e1e

[MediaWiki-commits] [Gerrit] (bug 43074) Focus/blur methods for valueview widget - change (mediawiki...DataValues[master])

2012-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43074) Focus/blur methods for valueview widget .. (bug 43074) Focus/blur methods for valueview widget Change-Id: Iaa4e1e04ddffb4107a7b3e9666e

[MediaWiki-commits] [Gerrit] (bug 43003) wbsearchentities should report link to item - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 43003) wbsearchentities should report link to item .. (bug 43003) wbsearchentities should report link to item Change-Id: I1d9411e14e53c5d70ceb9f6e0cd

[MediaWiki-commits] [Gerrit] (minor) fix reporting of aliases in wbsearchentities (again!... - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) fix reporting of aliases in wbsearchentities (again!) .. (minor) fix reporting of aliases in wbsearchentities (again!) - fix from Iea5e866a someho

[MediaWiki-commits] [Gerrit] (Bug 42950) Add an autocomment for Special:SetLabel - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (Bug 42950) Add an autocomment for Special:SetLabel .. (Bug 42950) Add an autocomment for Special:SetLabel This adds an autocomment, but without f

[MediaWiki-commits] [Gerrit] (bug 43068) Display proper label for PVSnaks using wikibase-... - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43068) Display proper label for PVSnaks using wikibase-item properties .. (bug 43068) Display proper label for PVSnaks using wikibase-item pr

[MediaWiki-commits] [Gerrit] (Bug 43068) Allow LinkedSingleInputWidget views to display a... - change (mediawiki...DataValues[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (Bug 43068) Allow LinkedSingleInputWidget views to display additional DOM within link .. (Bug 43068) Allow LinkedSingleInputWidget views to displa

[MediaWiki-commits] [Gerrit] (bug 43062) send proper baserevid with claims API requests - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. Change subject: (bug 43062) send proper baserevid with claims API requests .. (bug 43062) send proper baserevid with claims API requests Change-Id: I6a194a884a41d6a486b20

[MediaWiki-commits] [Gerrit] (no bug) removed todo in statements selenium test - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (no bug) removed todo in statements selenium test .. (no bug) removed todo in statements selenium test - removed todo & commented out stuff, cause

[MediaWiki-commits] [Gerrit] (no bug) fixed ULS fallback in selenium tests - change (mediawiki...Wikibase[master])

2012-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (no bug) fixed ULS fallback in selenium tests .. (no bug) fixed ULS fallback in selenium tests - some selenium tests were broken when ULS not acti

[MediaWiki-commits] [Gerrit] Dropdown for commonsmedia view for choosing Commons Media fi... - change (mediawiki...DataValues[master])

2012-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Dropdown for commonsmedia view for choosing Commons Media file .. Dropdown for commonsmedia view for choosing Commons Media file Uses $.suggester

[MediaWiki-commits] [Gerrit] Special handling of IE in template QUnit tests - change (mediawiki...Wikibase[master])

2012-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Special handling of IE in template QUnit tests .. Special handling of IE in template QUnit tests - patch set 2: rebase Change-Id: Ia03c7f2d5579e4

[MediaWiki-commits] [Gerrit] (bug 43000) Only select entity if it actually has changed - change (mediawiki...Wikibase[master])

2012-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43000) Only select entity if it actually has changed .. (bug 43000) Only select entity if it actually has changed Change-Id: Id71ec98c1eb834e

[MediaWiki-commits] [Gerrit] (bug 40955) Adding claims in existing section - change (mediawiki...Wikibase[master])

2012-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 40955) Adding claims in existing section .. (bug 40955) Adding claims in existing section This allows adding a claim which has a Main Snak us

<    5   6   7   8   9   10   11   12   13   14   >