Krinkle has submitted this change and it was merged. Change subject: (bug 40339) Out of bounds errors ......................................................................
(bug 40339) Out of bounds errors Detecting contextChange events was making assumptions about the previous state, and causing a mess of problems. Solution: detect contextChange events in a smarter way. We also now emit contextChange event when moving to a different node. This helps fix other issues because it's possible for the selection to be the same, but the node at that range to change, and that's a context change for sure. Example would be changing the heading level. Change-Id: I99d6fa94fae76aa940077abc9b5beacd38eb7b0b --- M modules/ve/dm/ve.dm.Surface.js 1 file changed, 22 insertions(+), 13 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/36597 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d6fa94fae76aa940077abc9b5beacd38eb7b0b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
