Henning Snater has submitted this change and it was merged. Change subject: (bug 43304) Moved snak type selector for snakview widget into its own widget ......................................................................
(bug 43304) Moved snak type selector for snakview widget into its own widget There is a jquery.wikibase.snakview.TypeSelector widget now. This one is only used by the snakview widget internally since it is not really a widget displaying all possible Snak types but rather those, which can be chosen by the snakview widget. Snak types unsupported by the snakview are not displayed in the selector. This makes the widget rather useless for the outside world and therefore there is no jQuery.widget.bridge used to make the widget available to the outside. * Also brings some minor changes to the type selectors architecture and handling. * Less event registrations are required now since there is only one listener for click events on the menu now. * using 'active' instead of 'disabled' ui state for chosen elements (even though it looks kind of stupid, styling might be in order) * when resizing the window, the menu will vanish now - this might be changed again but it seems less tricky in some edge cases for now - patch set 2: Renamed to SnakTypeSelector, updated some naming - patch set 3: Renamed setMenuPosition() to repositionMenu() - patch set 4: Updated destroy() method Change-Id: I49a21e615a047a40721bbfe36abfbe35c1e66631 --- M lib/resources/Resources.php A lib/resources/jquery.wikibase/jquery.wikibase.snakview.SnakTypeSelector.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js 3 files changed, 188 insertions(+), 96 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49a21e615a047a40721bbfe36abfbe35c1e66631 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
