Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/142901

Change subject: (bug 67276) do not pass exceptions silently
......................................................................

(bug 67276) do not pass exceptions silently

re-raise the exception coming from Site.editpage() method and don't
raise different exceptions with the same PageNotSaved exception.

Change-Id: Iff0daf5b13ed698a732c55ccb851575cb906beff
---
M pywikibot/page.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/01/142901/1

diff --git a/pywikibot/page.py b/pywikibot/page.py
index fb55dfb..be4e2f4 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -908,7 +908,7 @@
             pywikibot.log(u"Error saving page %s (%s)\n" % (link, err),
                           exc_info=True)
             if not callback and not async:
-                raise pywikibot.PageNotSaved("%s: %s" % (link, err))
+                raise  # re-raise the exception from site.py
         if callback:
             callback(self, err)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/142901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff0daf5b13ed698a732c55ccb851575cb906beff
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to