Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/124369
Change subject: [Gingerbread] Attempting to get edit summary memory working ...................................................................... [Gingerbread] Attempting to get edit summary memory working There's some null pointer failure in AbsListView.setSelector that I haven't tracked down yet. Change-Id: Id7b0f624660bd0e534c8b0dba3aeabf792853fdb --- A wikipedia/res/layout-v17/simple_list_item_1.xml A wikipedia/res/layout/simple_list_item_1.xml M wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryHandler.java 3 files changed, 53 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/69/124369/1 diff --git a/wikipedia/res/layout-v17/simple_list_item_1.xml b/wikipedia/res/layout-v17/simple_list_item_1.xml new file mode 100644 index 0000000..533b695 --- /dev/null +++ b/wikipedia/res/layout-v17/simple_list_item_1.xml @@ -0,0 +1,26 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- Copyright (C) 2006 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<TextView xmlns:android="http://schemas.android.com/apk/res/android"; + android:id="@android:id/text1" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:textAppearance="?android:attr/textAppearanceListItemSmall" + android:gravity="center_vertical" + android:paddingStart="?android:attr/listPreferredItemPaddingStart" + android:paddingEnd="?android:attr/listPreferredItemPaddingEnd" + android:minHeight="?android:attr/listPreferredItemHeightSmall" + /> diff --git a/wikipedia/res/layout/simple_list_item_1.xml b/wikipedia/res/layout/simple_list_item_1.xml new file mode 100644 index 0000000..f25b86c --- /dev/null +++ b/wikipedia/res/layout/simple_list_item_1.xml @@ -0,0 +1,26 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- Copyright (C) 2006 The Android Open Source Project + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<TextView xmlns:android="http://schemas.android.com/apk/res/android"; + android:id="@android:id/text1" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:textAppearance="?android:attr/textAppearanceMedium" + android:gravity="center_vertical" + android:paddingStart="6dip" + android:paddingEnd="6dip" + android:minHeight="?android:attr/listPreferredItemHeight" + /> diff --git a/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryHandler.java b/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryHandler.java index 6a2fc35..462a008 100644 --- a/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryHandler.java +++ b/wikipedia/src/main/java/org/wikipedia/editing/summaries/EditSummaryHandler.java @@ -87,7 +87,7 @@ @Override public View newView(Context context, Cursor cursor, ViewGroup parent) { - return activity.getLayoutInflater().inflate(android.R.layout.simple_list_item_1, parent, false); + return activity.getLayoutInflater().inflate(R.layout.simple_list_item_1, parent, false); } @Override -- To view, visit https://gerrit.wikimedia.org/r/124369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7b0f624660bd0e534c8b0dba3aeabf792853fdb Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <br...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
