Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273510
Change subject: [PULL THROUGH] Use new VisualEditorSupportCheck pattern
......................................................................
[PULL THROUGH] Use new VisualEditorSupportCheck pattern
Pull-through for Id53bdfe1c in VisualEditor.
Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
---
M .jsduck/categories.json
M .jshintrc
M jsduck.json
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
4 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/10/273510/1
diff --git a/.jsduck/categories.json b/.jsduck/categories.json
index 925e5e1..48f1d6d 100644
--- a/.jsduck/categories.json
+++ b/.jsduck/categories.json
@@ -68,7 +68,7 @@
"ve.init",
"ve.init.Platform",
"ve.init.Target",
- "window.VisualEditorSupportCheck",
+ "global",
"ve.init.sa*"
]
},
diff --git a/.jshintrc b/.jshintrc
index 30cc13d..fa174f6 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -23,6 +23,7 @@
"OO": false,
"QUnit": false,
"unicodeJS": false,
- "ve": false
+ "ve": false,
+ "VisualEditorSupportCheck": false
}
}
diff --git a/jsduck.json b/jsduck.json
index 005c600..3de6801 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -8,7 +8,7 @@
"--warnings-exit-nonzero": true,
"--builtin-classes": true,
"--external":
"HTMLDocument,Window,Node,Text,Set,Range,Selection,ClientRect,File,Blob,DataTransfer,DataTransferItem,KeyboardEvent,MouseEvent",
- "--warnings": ["-nodoc(class,public)"],
+ "--warnings": ["-nodoc(class,public)", "-global"],
"--": [
".jsduck/external.js",
"lib/ve/.jsduck/external.js",
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index bdd6e38..3d4504c 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -622,7 +622,7 @@
// Whether VisualEditor should be available for the current user, page,
wiki, mediawiki skin,
// browser etc.
init.isAvailable = (
- window.VisualEditorSupportCheck() &&
+ VisualEditorSupportCheck() &&
( ( 'vewhitelist' in uri.query ) || !$.client.test(
init.blacklist, null, true ) ) &&
--
To view, visit https://gerrit.wikimedia.org/r/273510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
