Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73014
Change subject: Add "(No differences)" on a empty diff
......................................................................
Add "(No differences)" on a empty diff
This makes it easier to see the fact, because without a hint, the user
can mean, that there is something missing, but here the missing is okay
and for that, the message is helpful.
Change-Id: I458fb688b0001fb674ece65b3fdabf56fc658a29
---
M includes/diff/DifferenceEngine.php
M languages/messages/MessagesEn.php
M maintenance/language/messages.inc
3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/14/73014/1
diff --git a/includes/diff/DifferenceEngine.php
b/includes/diff/DifferenceEngine.php
index 4c2de4e..c426b03 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -610,6 +610,13 @@
return false;
} else {
$multi = $this->getMultiNotice();
+ // give a notice, when there is a empty diff
+ if ( $body === '' ) {
+ if ( $multi !== '' ) {
+ $multi .= '<br />';
+ }
+ $multi .= $this->msg( 'diff-empty' )->parse();
+ }
return $this->addHeader( $body, $otitle, $ntitle,
$multi, $notice );
}
}
diff --git a/languages/messages/MessagesEn.php
b/languages/messages/MessagesEn.php
index a60a28c..489f306 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1779,6 +1779,7 @@
'compareselectedversions' => 'Compare selected revisions',
'showhideselectedversions' => 'Show/hide selected revisions',
'editundo' => 'undo',
+'diff-empty' => '(No difference)',
'diff-multi' => '({{PLURAL:$1|One intermediate revision|$1
intermediate revisions}} by {{PLURAL:$2|one user|$2 users}} not shown)',
'diff-multi-manyusers' => '({{PLURAL:$1|One intermediate revision|$1
intermediate revisions}} by more than $2 {{PLURAL:$2|user|users}} not shown)',
'difference-missing-revision' => '{{PLURAL:$2|One revision|$2 revisions}} of
this difference ($1) {{PLURAL:$2|was|were}} not found.
diff --git a/maintenance/language/messages.inc
b/maintenance/language/messages.inc
index 49ed880..36abe66 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -930,6 +930,7 @@
'compareselectedversions',
'showhideselectedversions',
'editundo',
+ 'diff-empty',
'diff-multi',
'diff-multi-manyusers',
'difference-missing-revision',
--
To view, visit https://gerrit.wikimedia.org/r/73014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I458fb688b0001fb674ece65b3fdabf56fc658a29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
