Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150391
Change subject: Add JS hook to allow extensions to prevent double click from
changing to action=edit
......................................................................
Add JS hook to allow extensions to prevent double click from changing to
action=edit
There's a preference which makes the browser go to action=edit when double
clicking
on the content. In VE we want to disable this while the editor is open. With
this
hook in place, we could do something like:
mw.hook( 'dblclickedit' ).add( function ( hookStatus ) {
if ( target.active ) {
hookStatus.edit = false;
}
} );
Bug: 53058
Change-Id: I0f6225b25ad279755548361f82b855727758da2b
---
M resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/91/150391/1
diff --git
a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
index 2ded40c..92c8429 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
@@ -4,9 +4,13 @@
( function ( mw, $ ) {
$( function () {
mw.util.$content.dblclick( function ( e ) {
- e.preventDefault();
- // Trigger native HTMLElement click instead of opening
URL (bug 43052)
- $( '#ca-edit a' ).get( 0 ).click();
+ var hookStatus = { edit: true };
+ mw.hook( 'dblclickedit' ).fire( hookStatus );
+ if ( hookStatus.edit ) {
+ e.preventDefault();
+ // Trigger native HTMLElement click instead of
opening URL (bug 43052)
+ $( '#ca-edit a' ).get( 0 ).click();
+ }
} );
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/150391
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f6225b25ad279755548361f82b855727758da2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
