Jarry1250 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65464
Change subject: Add loading spinner and tweak display time.
......................................................................
Add loading spinner and tweak display time.
Uses jquery.spinner methods.
Change-Id: I3e63f6cf3e0cdc2ececdbf5fec8558d69eef71fc
---
M TranslateSvg.php
M resources/ext.translatesvg.core.js
2 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg
refs/changes/64/65464/1
diff --git a/TranslateSvg.php b/TranslateSvg.php
index 6926573..f714961 100644
--- a/TranslateSvg.php
+++ b/TranslateSvg.php
@@ -45,6 +45,7 @@
'jquery.autoresize',
'jquery.colorpicker',
'jquery.json',
+ 'jquery.spinner',
'ext.translate.hooks',
'ext.translate.editor'
),
diff --git a/resources/ext.translatesvg.core.js
b/resources/ext.translatesvg.core.js
index 1a40cfb..91b9372 100644
--- a/resources/ext.translatesvg.core.js
+++ b/resources/ext.translatesvg.core.js
@@ -122,7 +122,7 @@
// than 5 times a second
window.clearTimeout( tsvgLoader.updateThumbnailTimer );
tsvgLoader.updateThumbnailTimer = window.setTimeout(
- function () { tsvgLoader.updateThumbnail($form)
}, 200
+ function () { tsvgLoader.updateThumbnail( $form
) }, 300
);
},
updateThumbnail: function ( $form ) {
@@ -140,6 +140,11 @@
return;
}
var identifiers = name.split( '/' );
+
+ // Inform the user we are working
+ $thumbnail.find( 'div.center' ).first().hide();
+ $thumbnail.append( $.createSpinner( { 'id':
'translatesvg-' + identifiers[2], 'size': 'large' } ) );
+ $( '.mw-spinner' ).css( 'margin', 'auto' ).css(
'display', 'block' );
// Create and set overrides[identifier][langcode]
var overrideValue = $textarea.val() +
tsvgLoader.propertiesToString( $form );
@@ -164,8 +169,17 @@
var newSrc =
data.query.messagegroups[0].thumbnail.message;
$thumbnail.find('img').attr(
'src', newSrc );
}
+ window.setTimeout(
+ function () {
tsvgLoader.hideSpinner( $thumbnail, identifiers[2] ) }, 500
+ );
}
} );
+ },
+ hideSpinner: function ( $thumbnail, id ) {
+ // Hide a spinner after a delay to ensure that the
system has redrawn the SVG
+ // before it gets shown.
+ $thumbnail.find( 'div.center' ).first().show();
+ $.removeSpinner( 'translatesvg-' + id );
}
};
$( document ).ready( function () {
--
To view, visit https://gerrit.wikimedia.org/r/65464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e63f6cf3e0cdc2ececdbf5fec8558d69eef71fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslateSvg
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 <jarry1...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
